Re: [PATCH v6 4/5] tty: serial: handle HAS_IOPORT dependencies

2024-10-14 Thread Maciej W. Rozycki
On Tue, 8 Oct 2024, Niklas Schnelle wrote: > > > +static __always_inline bool is_upf_fourport(struct uart_port *port) > > > +{ > > > + if (!IS_ENABLED(CONFIG_HAS_IOPORT)) > > > + return false; > > > + > > > + return port->flags & UPF_FOURPORT; > > > +} > > > > Can we perhaps avoid adding

Re: [PATCH v6 4/5] tty: serial: handle HAS_IOPORT dependencies

2024-10-09 Thread Niklas Schnelle
On Tue, 2024-10-08 at 10:16 +0200, Niklas Schnelle wrote: > On Mon, 2024-10-07 at 22:09 +0100, Maciej W. Rozycki wrote: > > On Mon, 7 Oct 2024, Niklas Schnelle wrote: > > > > > diff --git a/drivers/tty/serial/8250/8250_pci.c > > > b/drivers/tty/serial/8250/8250_pci.c > > > index > > > 6709b6a5f3

Re: [PATCH v6 4/5] tty: serial: handle HAS_IOPORT dependencies

2024-10-08 Thread Niklas Schnelle
On Mon, 2024-10-07 at 22:09 +0100, Maciej W. Rozycki wrote: > On Mon, 7 Oct 2024, Niklas Schnelle wrote: > > > diff --git a/drivers/tty/serial/8250/8250_pci.c > > b/drivers/tty/serial/8250/8250_pci.c > > index > > 6709b6a5f3011db38acc58dc7223158fe4fcf72e..6a638feb44e443a1998980dd037748f227ec1bc8

Re: [PATCH v6 4/5] tty: serial: handle HAS_IOPORT dependencies

2024-10-07 Thread Maciej W. Rozycki
On Mon, 7 Oct 2024, Niklas Schnelle wrote: > diff --git a/drivers/tty/serial/8250/8250_pci.c > b/drivers/tty/serial/8250/8250_pci.c > index > 6709b6a5f3011db38acc58dc7223158fe4fcf72e..6a638feb44e443a1998980dd037748f227ec1bc8 > 100644 > --- a/drivers/tty/serial/8250/8250_pci.c > +++ b/drivers/tt

[PATCH v6 4/5] tty: serial: handle HAS_IOPORT dependencies

2024-10-07 Thread Niklas Schnelle
In a future patch HAS_IOPORT=n will disable inb()/outb() and friends at compile time. We thus need to add HAS_IOPORT as dependency for those drivers using them unconditionally. Some 8250 serial drivers support MMIO only use, so fence only the parts requiring I/O ports and print an error message if