Re: [PATCH v5] drm/virtio: Add drm_panic support

2025-02-02 Thread Dmitry Osipenko
On 12/2/24 20:19, Jocelyn Falempe wrote: >>> >>> I've now noticed that drm_gem_shmem_vmap() expects BO reservation lock >>> to be held and we can't take lock it at a panic time. >>> >>> https://elixir.bootlin.com/linux/v6.12.1/source/drivers/gpu/drm/ >>> drm_gem_shmem_helper.c#L330 >>> >>> This res

Re: [PATCH v5] drm/virtio: Add drm_panic support

2024-12-10 Thread Ryosuke Yasuoka
On Mon, Dec 2, 2024 at 11:30 PM Dmitry Osipenko wrote: > > On 11/29/24 15:24, Ryosuke Yasuoka wrote: > > > + } else { > > + iosys_map_set_vaddr(&sb->map[0], bo->base.vaddr); > > + } > > + > > + sb->format = plane->state->fb->format; > > + sb->height = plane->state-

Re: [PATCH v5] drm/virtio: Add drm_panic support

2024-12-02 Thread Dmitry Osipenko
On 12/2/24 17:29, Dmitry Osipenko wrote: > On 11/29/24 15:24, Ryosuke Yasuoka wrote: > >> +static int virtio_drm_get_scanout_buffer(struct drm_plane *plane, >> + struct drm_scanout_buffer *sb) >> +{ >> +struct virtio_gpu_object *bo; >> + >> +if (!pla

Re: [PATCH v5] drm/virtio: Add drm_panic support

2024-12-02 Thread Dmitry Osipenko
On 11/29/24 15:24, Ryosuke Yasuoka wrote: > +static int virtio_drm_get_scanout_buffer(struct drm_plane *plane, > + struct drm_scanout_buffer *sb) > +{ > + struct virtio_gpu_object *bo; > + > + if (!plane->state || !plane->state->fb || !plane->state-

Re: [PATCH v5] drm/virtio: Add drm_panic support

2024-12-02 Thread Jocelyn Falempe
On 02/12/2024 17:19, Dmitry Osipenko wrote: On 12/2/24 17:29, Dmitry Osipenko wrote: On 11/29/24 15:24, Ryosuke Yasuoka wrote: +static int virtio_drm_get_scanout_buffer(struct drm_plane *plane, +struct drm_scanout_buffer *sb) +{ + struct virtio

[PATCH v5] drm/virtio: Add drm_panic support

2024-11-30 Thread Ryosuke Yasuoka
From: Jocelyn Falempe Virtio gpu supports the drm_panic module, which displays a message to the screen when a kernel panic occurs. Signed-off-by: Ryosuke Yasuoka Signed-off-by: Jocelyn Falempe --- v5: Based on Dmitry's comment, fix the followings - Rename virtio_panic_buffer to panic_vbuf - Re