[Spice-devel] [PATCH v3 4/6] spice: remove the single monitor config logic

From: Marc-André Lureau Introduced in commit 9c956e646178fee8c14ce7dfae5a9d7cb901876c ("spice: prepare for upcoming spice-server change"), the new logic never materialized in the spice server source tree. Let's remove it for now, until it actually changes in Spice. Signed-off-by: Marc-André Lure

[Spice-devel] [PATCH v3 2/6] edid: use physical dimensions if available

From: Marc-André Lureau Replace dpi with width_mm/height_mm in qemu_edid_info. Use it when set (non-zero) to compute the DPI and generate the EDID. Signed-off-by: Marc-André Lureau --- hw/display/edid-generate.c | 36 +--- include/hw/display/edid.h | 5 -

[Spice-devel] [PATCH v3 6/6] virtio-gpu: set physical dimensions for EDID

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- hw/display/virtio-gpu-base.c | 2 ++ hw/display/virtio-gpu.c| 2 ++ include/hw/virtio/virtio-gpu.h | 1 + 3 files changed, 5 insertions(+) diff --git a/hw/display/virtio-gpu-base.c b/hw/display/virtio-gpu-base.c index aeb87

[Spice-devel] [PATCH v3 5/6] spice: get monitors physical dimension

From: Marc-André Lureau With upcoming Spice server version 0.14.4, the monitor configuration can contain additional fields for the monitor physical dimensions. Signed-off-by: Marc-André Lureau --- include/ui/console.h | 3 +++ ui/spice-display.c | 7 +++ 2 files changed, 10 insertions(+)

[Spice-devel] [PATCH v3 0/6] Add physical display dimensions to spice/virtio-gpu

From: Marc-André Lureau Hi, This series improves the support for HiDPI displays with Spice. The related spice series have already been merged. v3: - simplify the handling of Spice monitor configuration (Frediano) v2: - add a patch to "spice: remove the single monitor config logic" (Gerd) Mar

[Spice-devel] [PATCH v3 3/6] ui: add getter for UIInfo

From: Marc-André Lureau The following patch is going to introduce extra fields / details to UIInfo. Add a getter and keep the current values, instead of memset(0) Signed-off-by: Marc-André Lureau --- include/ui/console.h | 1 + ui/console.c | 7 +++ ui/spice-display.c | 2 +- 3 f

[Spice-devel] [PATCH v3 1/6] edid: fix physical display size computation

From: Marc-André Lureau Divide the resolution by the DPI, and multiply to mm. Note the computation done for edid[21/22] is correct (in cm). Signed-off-by: Marc-André Lureau --- hw/display/edid-generate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/display/edid-g

[Spice-devel] [PATCH v2 1/6] edid: fix physical display size computation

From: Marc-André Lureau Divide the resolution by the DPI, and multiply to mm. Note the computation done for edid[21/22] is correct (in cm). Signed-off-by: Marc-André Lureau --- hw/display/edid-generate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/display/edid-g

[Spice-devel] [PATCH v2 6/6] virtio-gpu: set physical dimensions for EDID

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- hw/display/virtio-gpu-base.c | 2 ++ hw/display/virtio-gpu.c| 2 ++ include/hw/virtio/virtio-gpu.h | 1 + 3 files changed, 5 insertions(+) diff --git a/hw/display/virtio-gpu-base.c b/hw/display/virtio-gpu-base.c index aeb87

[Spice-devel] [PATCH v2 4/6] spice: remove the single monitor config logic

From: Marc-André Lureau Introduced in commit 9c956e646178fee8c14ce7dfae5a9d7cb901876c ("spice: prepare for upcoming spice-server change"), the new logic never materialized in the spice server source tree. Let's remove it for now, until it actually changes in Spice. Signed-off-by: Marc-André Lure

[Spice-devel] [PATCH v2 5/6] spice: get monitors physical dimension

From: Marc-André Lureau Note that for consistency, we use the same logic as MonitorsConfig to figure out the associated monitor. However, I can't find traces of the discussion/patches about the "new spice-server" behaviour: it still uses the multiple-configurations path in git master. Signed-off

[Spice-devel] [PATCH v2 3/6] ui: add getter for UIInfo

From: Marc-André Lureau The following patch is going to introduce extra fields / details to UIInfo. Add a getter and keep the current values, instead of memset(0) Signed-off-by: Marc-André Lureau --- include/ui/console.h | 1 + ui/console.c | 7 +++ ui/spice-display.c | 2 +- 3 f

[Spice-devel] [PATCH v2 2/6] edid: use physical dimensions if available

From: Marc-André Lureau Replace dpi with width_mm/height_mm in qemu_edid_info. Use it when set (non-zero) to compute the DPI and generate the EDID. Signed-off-by: Marc-André Lureau --- hw/display/edid-generate.c | 36 +--- include/hw/display/edid.h | 5 -

[Spice-devel] [PATCH v2 0/6] Add physical display dimensions to spice/virtio-gpu

From: Marc-André Lureau Hi, This series improves the support for HiDPI displays with Spice. The related spice series have already been merged. v2: - add patch to "spice: remove the single monitor config logic" (Gerd) Marc-André Lureau (6): edid: fix physical display size computation edid:

[Spice-devel] [PATCH spice-gtk] build-aux: remove unused file

From: Marc-André Lureau Left from previous commit. Signed-off-by: Marc-André Lureau --- build-aux/gitlog-to-changelog | 191 -- 1 file changed, 191 deletions(-) delete mode 100755 build-aux/gitlog-to-changelog diff --git a/build-aux/gitlog-to-changelog b/build

[Spice-devel] [PATCH linux/vd-agent 09/11] clipboard: filter out only our own events

From: Marc-André Lureau Do not rely on internal state when receiving clipboard events, as this may race with external events. Use gtk_clipboard_set_with_owner() Signed-off-by: Marc-André Lureau --- src/vdagent/clipboard.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff -

[Spice-devel] [PATCH linux/vd-agent 07/11] vdagent: use G_OPTION_FLAG_NONE

From: Marc-André Lureau Improve readability a bit, reindent slightly. Signed-off-by: Marc-André Lureau --- src/vdagent/vdagent.c | 37 ++--- 1 file changed, 22 insertions(+), 15 deletions(-) diff --git a/src/vdagent/vdagent.c b/src/vdagent/vdagent.c index 13ef2

[Spice-devel] [PATCH linux/vd-agent 11/11] clipboard: implement CAP_CLIPBOARD_GRAB_SERIAL

From: Marc-André Lureau Implement the behaviour described in protocol "vdagent: introduce VD_AGENT_CAP_CLIPBOARD_GRAB_SERIAL". Signed-off-by: Marc-André Lureau --- src/vdagentd/vdagentd.c | 40 +++- 1 file changed, 39 insertions(+), 1 deletion(-) diff --git

[Spice-devel] [PATCH linux/vd-agent 10/11] clipboard: only send release when no immediate grab

From: Marc-André Lureau Do not send a release event between two grabs, this helps with window manager interaction issues on peer side. Advertise this behaviour via a capability introduced in spice-protocol 0.12.16, so the client doesn't need to do some time-based filtering. (the capability shou

[Spice-devel] [PATCH linux/vd-agent 08/11] clipboard: gobject-ify VDAgentClipboards

From: Marc-André Lureau This will allow easier lifecycle management, and usage of gtk_clipboard_set_with_owner() Signed-off-by: Marc-André Lureau --- src/vdagent/clipboard.c | 67 +++-- src/vdagent/clipboard.h | 12 +--- src/vdagent/vdagent.c | 7 +++-

[Spice-devel] [PATCH linux/vd-agent 06/11] configure: bump gobject >= 2.50

From: Marc-André Lureau This is required for using the new GObject macros. According to commit 61fc548fe1a323dd2344c8ae267e3ce05e86da7d ("Bump GLib version to 2.34"), RHEL6 is no longer supported. GLib version across some distributions, from repology: - Debian Stable (9): 2.50.3 - CentOS 7: 2.5

[Spice-devel] [PATCH linux/vd-agent 05/11] configure: depend on gobject

From: Marc-André Lureau The following patches are going to introduce GObject. It's not a big change, since usually glib comes installed with gobject on most systems. Signed-off-by: Marc-André Lureau --- Makefile.am | 12 ++-- configure.ac | 2 +- 2 files changed, 7 insertions(+), 7

[Spice-devel] [PATCH linux/vd-agent 04/11] clipboard: remove vdagent-selection-id usage

From: Marc-André Lureau Modernize a bit the code, using gtk_clipboard_get_selection(). Signed-off-by: Marc-André Lureau --- src/vdagent/clipboard.c | 29 - 1 file changed, 20 insertions(+), 9 deletions(-) diff --git a/src/vdagent/clipboard.c b/src/vdagent/clipboard

[Spice-devel] [PATCH linux/vd-agent 01/11] Add a .gitpublish

From: Marc-André Lureau Set a default profile for git-publish. (https://github.com/stefanha/git-publish) Signed-off-by: Marc-André Lureau --- .gitpublish | 4 1 file changed, 4 insertions(+) create mode 100644 .gitpublish diff --git a/.gitpublish b/.gitpublish new file mode 100644 index

[Spice-devel] [PATCH linux/vd-agent 00/11] Clipboard improvements

From: Marc-André Lureau Hi, This series implements 2 protocol capabilities for solving some clipboard race issues, and other minor improvements. For a description of the changes, see related patches and protocol changes: - [PATCH spice-protocol] vdagent: introduce VD_AGENT_CAP_CLIPBOARD_NO_REL

[Spice-devel] [PATCH linux/vd-agent 03/11] configure: bump gtk+ >= 3.22

From: Marc-André Lureau According to repology, - Debian Stable (9): 3.22.11 - CentOS 7: 3.22.30 - Fedora 26: 3.22.21 (fwiw, Fedora 30: 3.24.7) Signed-off-by: Marc-André Lureau --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index

[Spice-devel] [PATCH linux/vd-agent 02/11] session: free active session

From: Marc-André Lureau According to sd_seat_get_active(2), you must free() the pointer. Signed-off-by: Marc-André Lureau --- src/vdagentd/systemd-login.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/vdagentd/systemd-login.c b/src/vdagentd/systemd-login.c index a11b66d..0b2dd0a 1006

[Spice-devel] [PATCH spice-gtk 3/3] clipboard: implement CAP_CLIPBOARD_GRAB_SERIAL

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- src/channel-main.c | 32 +++- src/spice-gtk-session.c | 1 - 2 files changed, 31 insertions(+), 2 deletions(-) diff --git a/src/channel-main.c b/src/channel-main.c index e359e8d..ced037e 100644 --- a

[Spice-devel] [PATCH spice-gtk 1/3] clipboard: do not delay release if agent has "no release on regrab"

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- configure.ac| 2 +- meson.build | 2 +- src/channel-main.c | 2 ++ src/spice-gtk-session.c | 9 - 4 files changed, 12 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index d

[Spice-devel] [PATCH spice-gtk 0/3] Clipboard improvements

From: Marc-André Lureau Hi, This series implements 2 protocol capabilities for solving some clipboard race issues. For a description of the changes, see related patches and protocol changes: - [PATCH spice-protocol] vdagent: introduce VD_AGENT_CAP_CLIPBOARD_NO_RELEASE_ON_REGRAB - [PATCH spice-

[Spice-devel] [PATCH spice-gtk 2/3] clipboard: pre-condition on selection value < 256

From: Marc-André Lureau The protocol uses a u8 for the selection value. Make sure the given argument value fits there, or throw a critical. The other places seem to use u8 variables already. Signed-off-by: Marc-André Lureau --- src/channel-main.c | 1 + 1 file changed, 1 insertion(+) diff --

[Spice-devel] [PATCH spice-protocol 2/3] vdagent: introduce VD_AGENT_CAP_CLIPBOARD_NO_RELEASE_ON_REGRAB

From: Marc-André Lureau This capability means the peer will not send a release event between two subsequent grabs. This helps with interaction issues with clipboard managers which can be worked around by time-based filters at this point. With this capability, there is no need for such filter. Si

[Spice-devel] [PATCH spice-protocol 3/3] vdagent: introduce VD_AGENT_CAP_CLIPBOARD_GRAB_SERIAL

From: Marc-André Lureau When this capability is negoticated by both the client & the agent, the clipboard grab messages have an associated serial counter. The serial is reset to 0 upon client connection. The counter is increment by 1 on each grab message, by both sides. The sender of the messa

[Spice-devel] [PATCH spice-protocol 1/3] Add a .gitpublish

From: Marc-André Lureau Set a default profile for git-publish. (https://github.com/stefanha/git-publish) Signed-off-by: Marc-André Lureau --- .gitpublish | 4 1 file changed, 4 insertions(+) create mode 100644 .gitpublish diff --git a/.gitpublish b/.gitpublish new file mode 100644 index

[Spice-devel] [PATCH spice-gtk 2/2] clipboard: do not release between remote grabs

From: Marc-André Lureau Delay the release events for 0.5 sec. If no further grab comes in, then release the grab. Otherwise, let's skip the release. This avoids some races with clipboard managers. Related to: https://gitlab.freedesktop.org/spice/spice-gtk/issues/82 Signed-off-by: Marc-André Lur

[Spice-devel] [PATCH spice-gtk 0/2] clipboard: skip release between grabs

From: Marc-André Lureau Hi, There has been several reports of clipboard issues that seem related to clipboard managers interactions. Although it's not crystal clear what are the problems, we realized the spice protocol does't handle well conflicting grabs coming simultaneously from client and re

[Spice-devel] [PATCH spice-gtk 1/2] clipboard: do not release between client grabs

From: Marc-André Lureau On the client side, whenever the grab owner changes (and the clipboard was previously grabbed), spice-gtk sends a clipboard release followed immediately by a new grab. But some clipboard managers on the remote side react to clipboard release events by taking a clipboard gr

[Spice-devel] [PATCH] build-sys: remove meson/check-spice-common

From: Marc-André Lureau This is not necessary, as meson already checks out the git submodules. Signed-off-by: Marc-André Lureau --- build-aux/meson/check-spice-common | 5 - meson.build| 3 --- 2 files changed, 8 deletions(-) delete mode 100755 build-aux/meson/chec

[Spice-devel] [PATCH spice-gtk 12/12] gtk-doc: fix api-index warnings

From: Marc-André Lureau Fix gtk-doc warnings such as: html/SpiceChannel.html:538: warning: no link for: "api-index-0.20" -> (0.20). Unfortunately, the generated file is still missing. Signed-off-by: Marc-André Lureau --- doc/reference/spice-gtk-docs.xml | 102 +--

[Spice-devel] [PATCH spice-gtk 10/12] meson: use gtk-doc --rebuild-types

From: Marc-André Lureau Since gtk-doc 1.8, no need to maintain a types file! Signed-off-by: Marc-André Lureau --- doc/reference/meson.build | 2 +- doc/reference/spice-gtk.types | 49 --- 2 files changed, 1 insertion(+), 50 deletions(-) delete mode 100644

[Spice-devel] [PATCH spice-gtk 08/12] meson: remove our own submodule update

From: Marc-André Lureau Our own handling was limited, since it checked only spice-common. This is handled by meson since v0.40 for subprojects. Signed-off-by: Marc-André Lureau --- build-aux/meson/check-spice-common | 5 - meson.build| 3 --- 2 files changed, 8 del

[Spice-devel] [PATCH spice-gtk 06/12] Move src/keycodemapdb -> subprojects/keycodemapdb

From: Marc-André Lureau Follow meson build system conventions. This will allow meson to handle it as a subproject. Signed-off-by: Marc-André Lureau --- .gitmodules | 4 ++-- meson.build | 6 +- src/meson.build | 2 -- {src => s

[Spice-devel] [PATCH spice-gtk 07/12] keycodemapdb: update submodule

From: Marc-André Lureau Daniel P. Berrange (24): Add named constants for QKeyCode values Add ability to generate enums Build tests with warnings enabled Add Sun/Sparc keyboard keycodes Add some missing mappings for USB HID Add line for QKeyCode asterisk A

[Spice-devel] [PATCH spice-gtk 11/12] gtk-doc: fix a few warnings, improve output

From: Marc-André Lureau Escape special characters with \, fixes: html/SpiceUsbDeviceManager.html:741: warning: no link for: "1" -> (1). html/SpiceUsbDeviceManager.html:742: warning: no link for: "2" -> (2). html/SpiceUsbDeviceManager.html:743: warning: no link for: "3" -> (3). html/SpiceUsbDevice

[Spice-devel] [PATCH spice-gtk 05/12] meson: add vcs_tag to session init debug log

From: Marc-André Lureau Use the trick recommended here to generate a vcs_tag.h at build-time: https://github.com/mesonbuild/meson/issues/3903 Hopefully, meson will learn to generate project version from git: https://github.com/mesonbuild/meson/issues/688 Signed-off-by: Marc-André Lureau --- s

[Spice-devel] [PATCH spice-gtk 09/12] doc: fix a few links

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- src/channel-display.c | 2 +- src/channel-main.h| 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/channel-display.c b/src/channel-display.c index ae949eb..fd072a9 100644 --- a/src/channel-display.c +++ b

[Spice-devel] [PATCH spice-gtk 01/12] meson: improve gtk-doc build

From: Marc-André Lureau - Fix the following warnings: ./spice-gtk-sections.txt:467: warning: No declaration found for SPICE_GTK_CHECK_VERSION. ./spice-gtk-sections.txt:468: warning: No declaration found for SPICE_GTK_MAJOR_VERSION. ./spice-gtk-sections.txt:469: warning: No declaration found for

[Spice-devel] [PATCH spice-gtk 04/12] Drop autotools

From: Marc-André Lureau Maintaining 1 build system is hard. Maintaining 2 is even harder. It seems the meson build system is now in good shape to replace autotools. Like many desktop projects, let's move entirely to meson and drop autotools support. Known changes: - no git version: a following

[Spice-devel] [PATCH spice-gtk 02/12] meson: fix ninja dist, and building from tarball

From: Marc-André Lureau meson doesn't handle git-version-gen correctly yet (see meson#688). Let's set the version manually for now. And a tag version vX.X will also fail to build, version_info[2] is out of array bounds. Signed-off-by: Marc-André Lureau --- meson.build | 2 +- src/meson.bu

[Spice-devel] [PATCH spice-gtk 00/12] Various build-sys patches post-v0.36

From: Marc-André Lureau Hi, Meson build system seems complete enough to drop autotools upstream! Various other improvements to meson, gtk-doc, etc... (the first 2 patches were already sent for review on the ML, but are included here for completeness and have received minor fixes) Thanks Marc-

[Spice-devel] [PATCH spice-gtk 03/12] meson: fix po generation

From: Marc-André Lureau Use glib preset (from meson v0.37) to catch all our translatable strings and use good default settings. While at it, remove the needless directory argument. Signed-off-by: Marc-André Lureau --- po/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Spice-devel] [PATCH spice-gtk v2] spice-common: update submodule

From: Marc-André Lureau Get the fix for meson build and big endian machines, like s390x. Frediano Ziglio (4): marshaller: Provide spice_marshaller_fill_iovec for Windows test: Add a test for subject_to_x509_name function lz: Avoid buffer reading overflow checking for image type

[Spice-devel] [PATCH spice-gtk] spice-common: update submodule

From: Marc-André Lureau $ git diff --submodule=log Submodule subprojects/spice-common 924f47a..0a753b9: > meson: fix building for big-endian host > quic: fix sign-compare warning > build-sys: improve asciidoc rules to allow multiple targets > Add a .gitpublish > lz: More checks on image

[Spice-devel] [PATCH spice-common] quic: fix sign-compare warning

From: Marc-André Lureau ../subprojects/spice-common/common/quic.c: In function 'fill_model_structures': ../subprojects/spice-common/common/quic.c:695:55: error: comparison of integer expressions of different signedness: 'int' and 'unsigned int' [-Werror=sign-compare] spice_assert(free_coun

[Spice-devel] [PATCH spice-gtk v2] spicy-screenshot: use G_BIG_ENDIAN

From: Marc-André Lureau WORDS_BIGENDIAN is defined by autofoo macro. meson doesn't define it. Let's use the GLib defines instead. Signed-off-by: Marc-André Lureau --- tools/spicy-screenshot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/spicy-screenshot.c b/tools/s

[Spice-devel] [PATCH spice-common] meson: fix building for big-endian host

From: Marc-André Lureau autofoo build-sys defines WORDS_BIGENDIAN, and spice-common code uses it. Later, I think it would make sense to switch to G_BIG_ENDIAN instead. Fixes: https://gitlab.freedesktop.org/spice/spice-common/issues/2 Signed-off-by: Marc-André Lureau --- meson.build | 3 +++

[Spice-devel] [PATCH spice-gtk] spicy-screenshot: use G_BIG_ENDIAN

From: Marc-André Lureau WORDS_BIGENDIAN is defined by autofoo macro. meson doesn't define it. Let's use the GLib define instead. Signed-off-by: Marc-André Lureau --- tools/spicy-screenshot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/spicy-screenshot.c b/tools/sp

[Spice-devel] [PATCH spice-gtk] meson: improve gtk-doc build

From: Marc-André Lureau - Fix the following warnings: ./spice-gtk-sections.txt:467: warning: No declaration found for SPICE_GTK_CHECK_VERSION. ./spice-gtk-sections.txt:468: warning: No declaration found for SPICE_GTK_MAJOR_VERSION. ./spice-gtk-sections.txt:469: warning: No declaration found for

[Spice-devel] [PATCH spice-gtk v2] NEWS: prepare v0.36 release

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- NEWS | 25 + 1 file changed, 25 insertions(+) diff --git a/NEWS b/NEWS index 3f54f77..1693621 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,28 @@ +v0.36 += + +- Add meson build: autotools will be removed in a fu

[Spice-devel] [PATCH spice-gtk] NEWS: prepare v0.36 release

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- NEWS | 26 ++ 1 file changed, 26 insertions(+) This is a preliminary patch for the v0.36 release notes, which should happen after the spice-gtk patch queue on the ML is flushed. diff --git a/NEWS b/NEWS index

[Spice-devel] [PATCH spice-common 3/3] docs: add spice URI scheme

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- docs/Makefile.am | 1 + docs/meson.build | 2 +- docs/spice_uri_scheme.txt | 131 ++ 3 files changed, 133 insertions(+), 1 deletion(-) create mode 100644 docs/spice_uri_scheme

[Spice-devel] [PATCH spice-common 2/3] build-sys: improve asciidoc rules to allow multiple targets

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- docs/Makefile.am | 22 +++--- docs/meson.build | 12 +++- 2 files changed, 22 insertions(+), 12 deletions(-) diff --git a/docs/Makefile.am b/docs/Makefile.am index 421e5f9..e7e126b 100644 --- a/docs/Makefile.a

[Spice-devel] [PATCH spice-common 1/3] Add a .gitpublish

From: Marc-André Lureau That makes it easier to send patch series for spice-common. Signed-off-by: Marc-André Lureau --- .gitpublish | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 .gitpublish diff --git a/.gitpublish b/.gitpublish new file mode 100644 index 000..97e6dba ---

[Spice-devel] [PATCH spice-common 0/3] Add a "spice" URI scheme document

From: Marc-André Lureau Hi, A recent discussion about Spice URI scheme on the QEMU mailing list with Gerd prompted me to make an effort to standardize the Spice URIs usage. So far, it is mostly used and described in spice-gtk (see URI in man/spice-client.pod). However, it would be good to standa

[Spice-devel] [PATCH spice-common 0/3] Add a "spice" URI scheme document

From: Marc-André Lureau Hi, A recent discussion about Spice URI scheme on the QEMU mailing list with Gerd prompted me to make an effort to standardize the Spice URIs usage. So far, it is mostly used and described in spice-gtk (see URI in man/spice-client.pod). However, it would be good to standa

[Spice-devel] [PATCH spice-protocol] NEWS: prepare for 0.12.15 release

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- NEWS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/NEWS b/NEWS index d17acba..c78a58b 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,9 @@ +Major changes in 0.12.15 + +* Add support for h265 video codec +*

[Spice-devel] [PATCH spice-gtk v3 2/2] desktop: compile out GNOME support if host is Windows or MAC

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- src/desktop-integration.c | 37 +++-- 1 file changed, 19 insertions(+), 18 deletions(-) diff --git a/src/desktop-integration.c b/src/desktop-integration.c index 2b936f4..a0d5b00 100644 --- a/src/deskto

[Spice-devel] [PATCH spice-gtk v3 1/2] desktop: Do not try org.gnome.SessionManager on Windows or Mac

From: Marc-André Lureau DBus support is available on those systems, yet it doesn't make sense to attempt to connect to GNOME session manager. Mark gnome_integration_init() as unused. The following patch is compiling out the GNOME support instead. It is not squashed here, because it makes reviewi

[Spice-devel] [PATCH spice-gtk v3] gst: check pulsesrc version >= 1.14.5

From: Marc-André Lureau There is a racy bug in pulsesrc that we can't easily workaround: https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/merge_requests/69 It is fixed with 1.15, and will be backported to upcoming 1.14.5. PulseAudio may not be picked by autoaudiosrc, but looking up the

[Spice-devel] [PATCH spice-gtk] gtk: don't request clipboard targets when there is no owner

From: Marc-André Lureau After a clipboard-clear, the owner-changed signal is triggered, with no owner. Let's avoid requesting for targets, that would lead to a failure. Fixes: (lt-spicy:23226): GSpice-DEBUG: 13:36:38.741: spice-gtk-session.c:797 clipboard_clear (lt-spicy:23226): GSpice-DEBUG: 1

[Spice-devel] [PATCH spice-gtk v2 02/15] build-sys: deprecate the pulseaudio backend

From: Marc-André Lureau The PulseAudio audio backend is still the default. However, it will be deprecated in favour of the GStreamer backend in a future release. Then PulseAudio will be disabled by default, and later on removed. Signed-off-by: Marc-André Lureau --- configure.ac | 3 +++ meson

[Spice-devel] [PATCH spice-gtk v2 01/15] build-sys: drop gstaudio option, make GStreamer a requirement

From: Marc-André Lureau GStreamer is being increasingly used by spice-gtk. Let's make it a core requirement. Signed-off-by: Marc-André Lureau --- .gitlab-ci.yml| 2 -- configure.ac | 32 ++-- meson.build | 18 -- meson_options.txt |

[Spice-devel] [PATCH spice-gtk v2 00/15] Various build-sys & fixes for v0.36

From: Marc-André Lureau Hi, This series is the remaining of "[PATCH spice-gtk 00/34] Various build-related improvements" and other changes after review & merge: - make GStreamer a build requirement - deprecate the pulse backend, for now this is just a build warning - add a check for pulsesrc ve

[Spice-devel] [PATCH spice-gtk v2 01/15] build-sys: drop gstaudio option, make GStreamer a requirement

From: Marc-André Lureau GStreamer is being increasingly used by spice-gtk. Let's make it a core requirement. Signed-off-by: Marc-André Lureau --- .gitlab-ci.yml| 2 -- configure.ac | 32 ++-- meson.build | 18 -- meson_options.txt |

[Spice-devel] [PATCH spice-gtk v2 00/15] Various build-sys & fixes for v0.36

From: Marc-André Lureau Hi, This series is the remaining of "[PATCH spice-gtk 00/34] Various build-related improvements" and other changes after review & merge: - make GStreamer a build requirement - deprecate the pulse backend, for now this is just a build warning - add a check for pulsesrc ve

[Spice-devel] [PATCH spice-gtk] build-sys: drop support for libcacard < 2.5.1

From: Marc-André Lureau v2.5.1 was released the 2015-11-24. According to repology, from the distro we care about, CentOS 6, openSUSE Leap 42.3 have too old version (0.1.2). SPICE_CHECK_SMARTCARD is updated with spice-common. Signed-off-by: Marc-André Lureau --- meson.build | 18

[Spice-devel] [PATCH spice-common] Bump libcacard requirement to 2.5.1

From: Marc-André Lureau v2.5.1 was released the 2015-11-24. According to repology, from the distro we care about, CentOS 6, openSUSE Leap 42.3 have too old version (0.1.2). spice-gtk & spice-server will have to be updated to drop USE_SMARTCARD_012. Signed-off-by: Marc-André Lureau --- m4/spi

[Spice-devel] [PATCH spice-gtk 33/34] audio: use gstreamer by default

From: Marc-André Lureau The pulse backend is getting deprecated. Signed-off-by: Marc-André Lureau --- src/spice-audio.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/spice-audio.c b/src/spice-audio.c index daf62df..a03c80b 100644 --- a/src/spice-audio.c +++ b/sr

[Spice-devel] [PATCH spice-gtk 34/34] build-sys: deprecate the pulseaudio backend

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- configure.ac | 3 +++ meson.build | 1 + 2 files changed, 4 insertions(+) diff --git a/configure.ac b/configure.ac index a23f861..fdfdd5a 100644 --- a/configure.ac +++ b/configure.ac @@ -549,3 +549,6 @@ AC_MSG_NOTICE([ ]) SPICE_

[Spice-devel] [PATCH spice-gtk 30/34] gstaudio: set state to NULL before unref

From: Marc-André Lureau (lt-spicy:13097): GStreamer-CRITICAL **: 18:01:13.698: Trying to dispose element pipeline1, but it is in READY instead of the NULL state. You need to explicitly set elements to the NULL state before dropping the final reference, to allow them to clean up. Signed-off-by:

[Spice-devel] [PATCH spice-gtk 28/34] meson: switch vapi to auto feature

From: Marc-André Lureau Removed unused vapigen/vapidir variables as well. Signed-off-by: Marc-André Lureau --- meson.build | 9 + meson_options.txt | 3 +-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/meson.build b/meson.build index 9896151..7e0c68d 100644 ---

[Spice-devel] [PATCH spice-gtk 31/34] spicy: use SpiceSession::disconnected signal

From: Marc-André Lureau Let's not track channels ourself, but rely on the disconnected signal instead. This solves spicy hanging, when gstaudio is recording and the main loop is gone, so record channel is not finalized, and GStreamer locks. Signed-off-by: Marc-André Lureau --- tools/spicy.c |

[Spice-devel] [PATCH spice-gtk 32/34] gst: check pulseaudio plugin version >= 1.15

From: Marc-André Lureau There is a racy bug in pulsesrc that we can't easily workaround: https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/merge_requests/69 It will hopefully be fixed with 1.15. In theory, pulseaudio may not be picked by autoaudiosink, but looking up the actual sink or

[Spice-devel] [PATCH spice-gtk 29/34] gstaudio: remove spice_gstaudio_finalize

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- src/spice-gstaudio.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/src/spice-gstaudio.c b/src/spice-gstaudio.c index dcd0591..aff69d2 100644 --- a/src/spice-gstaudio.c +++ b/src/spice-gstaudio.c @@ -59,11 +59,6 @@ static vo

[Spice-devel] [PATCH spice-gtk 27/34] meson: choose a better default coroutine

From: Marc-André Lureau Let's have a new 'auto' default value, and use winfibers on Windows. Signed-off-by: Marc-André Lureau --- meson.build | 23 --- meson_options.txt | 3 ++- 2 files changed, 18 insertions(+), 8 deletions(-) diff --git a/meson.build b/meson.buil

[Spice-devel] [PATCH spice-gtk 25/34] meson: add gtk_doc option

From: Marc-André Lureau This is based on similar meson code in GStreamer. (one of the core meson developer, Nirbheek, is also doing the GStreamer meson build support) This allows me to install a meson-mingw64 build, with -Dgtk_doc=disabled, as it fails to build currently for other reasons which

[Spice-devel] [PATCH spice-gtk 24/34] meson: remove some meson-spice-gtk-doc warnings

From: Marc-André Lureau ../src/./spice-audio.h:22:2: warning: #warning "Only can be included directly" [-Wcpp] #warning "Only can be included directly" ^~~ ... Signed-off-by: Marc-André Lureau --- doc/reference/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/refer

[Spice-devel] [PATCH spice-gtk 26/34] meson: don't alias meson host_machine.system()

From: Marc-André Lureau It makes it non-obvious what that variable actually is. Signed-off-by: Marc-André Lureau --- meson.build | 9 - src/meson.build | 2 +- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/meson.build b/meson.build index b596a0f..bbfd8d0 100644 ---

[Spice-devel] [PATCH spice-gtk 23/34] build-sys: remove dbus option

From: Marc-André Lureau The desktop-integration code works by attempting to connect to GNOME Session Manager. If it is absent, it will print a "Warning no automount-inhibiting implementation available" message. Tested on win32 as well. Signed-off-by: Marc-André Lureau --- .gitlab-ci.yml

[Spice-devel] [PATCH spice-gtk 19/34] meson: switch introspection option to auto feature

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- meson.build | 5 +++-- meson_options.txt | 3 +-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/meson.build b/meson.build index 07e8227..4c9c05c 100644 --- a/meson.build +++ b/meson.build @@ -263,8 +263,9 @@ end

[Spice-devel] [PATCH spice-gtk 22/34] build-sys: switch smartcard option to auto feature

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- .gitlab-ci.yml| 1 - meson.build | 5 +++-- meson_options.txt | 3 +-- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index a3cb6ad..750e801 100644 --- a/.gitlab-ci.yml +++ b/.

[Spice-devel] [PATCH spice-gtk 21/34] meson: switch sasl option to auto feature

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- .gitlab-ci.yml| 1 - meson.build | 5 +++-- meson_options.txt | 3 +-- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 692374a..a3cb6ad 100644 --- a/.gitlab-ci.yml +++ b/.

[Spice-devel] [PATCH spice-gtk 20/34] meson: switch lz4 option to auto feature

From: Marc-André Lureau Contrary to spice server dependency, spice-gtk doesn't have a known minimum version requirement. Signed-off-by: Marc-André Lureau --- .gitlab-ci.yml| 1 - meson.build | 10 +++--- meson_options.txt | 3 +-- 3 files changed, 4 insertions(+), 10 deletions(

[Spice-devel] [PATCH spice-gtk 16/34] meson: switch pulse option to auto feature

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- .gitlab-ci.yml| 1 - meson.build | 8 +++- meson_options.txt | 3 +-- 3 files changed, 4 insertions(+), 8 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index e913da4..fabe29e 100644 --- a/.gitlab-ci.yml +++

[Spice-devel] [PATCH spice-gtk 18/34] meson: switch polkit option to auto feature

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- meson.build | 32 +++- meson_options.txt | 3 +-- 2 files changed, 16 insertions(+), 19 deletions(-) diff --git a/meson.build b/meson.build index 18e330f..07e8227 100644 --- a/meson.build +++ b/meso

[Spice-devel] [PATCH spice-gtk 17/34] meson: switch usbredir option to auto feature

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- .gitlab-ci.yml| 1 - meson.build | 15 +-- meson_options.txt | 3 +-- 3 files changed, 6 insertions(+), 13 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index fabe29e..125dbd7 100644 --- a/.gitlab-

[Spice-devel] [PATCH spice-gtk 15/34] meson: switch webdav option to auto feature

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- .gitlab-ci.yml| 1 - meson.build | 14 +- meson_options.txt | 3 +-- 3 files changed, 10 insertions(+), 8 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 5d4da85..e913da4 100644 --- a/.gitlab-c

[Spice-devel] [PATCH spice-gtk 14/34] meson: switch gtk option to auto feature

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- meson.build | 6 -- meson_options.txt | 3 +-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/meson.build b/meson.build index 91d0742..ebc846e 100644 --- a/meson.build +++ b/meson.build @@ -128,8 +128,10 @@ e

[Spice-devel] [PATCH spice-gtk 13/34] .gitlab-ci: disable meson auto-features in makecheck_simple-meson

From: Marc-André Lureau Let's turn explicit true/false option into features which can be autodetected and turned all enabled/disabled at once. Signed-off-by: Marc-André Lureau --- .gitlab-ci.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.y

[Spice-devel] [PATCH spice-gtk 12/34] meson: fix mingw build

From: Marc-André Lureau Remove rt/x11/m dependencies from Windows build. Signed-off-by: Marc-André Lureau --- meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 42c18f0..91d0742 100644 --- a/meson.build +++ b/meson.build @@ -103,

  1   2   3   >