he code but I tested this and it makes
usb-redirection working again in Boxes.
--
Regards,
Zeeshan Ali (Khattak)
Befriend GNOME: http://www.gnome.org/friends/
___
Spice-devel mailing list
Spice-devel@lists.freedeskto
Make it clear that users of this function must provide additional
sockets for individual channels.
---
gtk/spice-session.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/gtk/spice-session.c b/gtk/spice-session.c
index 88bcacd..59f45bc 100644
--- a/gtk/spice-session.c
Make it clear that users of this function must provide additional
sockets for individual channels.
---
gtk/spice-session.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/gtk/spice-session.c b/gtk/spice-session.c
index 88bcacd..cfc70bf 100644
--- a/gtk/spice-session.c
t; https://bugzilla.gnome.org/show_bug.cgi?id=698430
> Any suggestion to have a shorter short-log is welcome :-)
After all that practice with this in Boxes, I'm pretty sure you can do
much better if you just try a bit.
--
Regards,
Zeeshan Ali (Khattak)
On Mon, Sep 15, 2014 at 8:56 AM, Christophe Fergeau wrote:
> On Fri, Sep 12, 2014 at 06:52:07PM +0100, Zeeshan Ali (Khattak) wrote:
>> Anyone up for review? It would be nice to get this in and (if
>> possible) even released before GNOME's code freeze break on Wednesday.
>&g
On Fri, Sep 12, 2014 at 7:20 PM, Fabiano Fidêncio wrote:
>
>
> On Fri, Sep 12, 2014 at 7:52 PM, Zeeshan Ali (Khattak)
> wrote:
>>
>> On Wed, Sep 10, 2014 at 3:52 PM, Zeeshan Ali (Khattak)
>> wrote:
>> > On Wed, Sep 10, 2014 at 3:35 PM, Christophe
On Wed, Sep 10, 2014 at 3:52 PM, Zeeshan Ali (Khattak)
wrote:
> On Wed, Sep 10, 2014 at 3:35 PM, Christophe Fergeau
> wrote:
>> Since commit 9cf9ca434, spice_channel_iterate() will report a
>> SPICE_CHANNEL_ERROR_IO error to library users when
>> SpiceChannel::has_err
on_check() test, but only when
> SpiceChannel::has_error is set.
>
> This fixes https://bugs.freedesktop.org/show_bug.cgi?id=83692
> ---
Just wanted to say that I tested this patch and it fixes the bug above.
--
Regards,
Zeeshan Ali (Khattak)
Be
Ack! Assuming you tested it locally.
--
Regards,
Zeeshan Ali (Khattak)
FSF member#5124
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
On Wed, Aug 17, 2011 at 7:35 PM, Christophe Fergeau wrote:
> Hey,
Yo,
> These fixes duplicate fixes that already went into master :-/ See commits
> d7d0a3a98e and 0d4bd5504.
Darn! Looks like you did a better job even. :)
--
Regards,
Zeeshan Ali (Khattak)
FSF me
From: "Zeeshan Ali (Khattak)"
---
client/red_channel.cpp|1 +
client/x11/red_window.cpp |1 +
2 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/client/red_channel.cpp b/client/red_channel.cpp
index f4cdf52..ace4a03 100644
--- a/client/red_channel.cpp
++
On Wed, May 25, 2011 at 12:39 PM, Alon Levy wrote:
> On Wed, May 25, 2011 at 12:08:47AM +0300, Zeeshan Ali (Khattak) wrote:
>> This should be squashed into commit 27df918.
>
> If you are talking about a public git tree (i.e. gitorious) then squashing
> is a bad idea, it changes
Now (commit 27df918) that we already gather connection information when
user (single)-clicks a recent connection item, we can safely use the
selected recent connection when user activates (double-clicks) it.
---
gtk/spicy.c |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --g
This should be squashed into commit 27df918.
---
gtk/spicy.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/gtk/spicy.c b/gtk/spicy.c
index cc30d54..7b51216 100644
--- a/gtk/spicy.c
+++ b/gtk/spicy.c
@@ -152,7 +152,7 @@ static struct {
};
#ifndef WIN32
-static void
Don't use mix of tabs and spaces.
---
gtk/spicy.c | 242 +-
1 files changed, 121 insertions(+), 121 deletions(-)
diff --git a/gtk/spicy.c b/gtk/spicy.c
index bfa8189..cc30d54 100644
--- a/gtk/spicy.c
+++ b/gtk/spicy.c
@@ -104,12 +104,12 @@
---
gtk/spicy.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/gtk/spicy.c b/gtk/spicy.c
index 262d465..bfa8189 100644
--- a/gtk/spicy.c
+++ b/gtk/spicy.c
@@ -184,7 +184,7 @@ static void
recent_item_activated_dialog_cb(GtkRecentChooser *chooser, gpointer
}
#endif
Fill-in the connection dialog fields as soon user selects a recent
connection.
---
gtk/spicy.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/gtk/spicy.c b/gtk/spicy.c
index 0120692..262d465 100644
--- a/gtk/spicy.c
+++ b/gtk/spicy.c
@@ -160,6 +160,8 @@ static void
re
Prefer 'if/else' over 'switch' when dealing with only 2 possibilities.
---
gtk/spicy.c |8 ++--
1 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/gtk/spicy.c b/gtk/spicy.c
index 82d8de2..0120692 100644
--- a/gtk/spicy.c
+++ b/gtk/spicy.c
@@ -239,18 +239,14 @@ static int connec
On Wed, May 18, 2011 at 11:38 PM, Zeeshan Ali (Khattak)
wrote:
> When only 1 element needs to be allocated, calloc() only makes the code
> *slightly* less readable.
Please ignore this patch. I forgot that calloc also zero's out the memory.
--
Regards,
Zeeshan Ali (Khattak)
FSF
When only 1 element needs to be allocated, calloc() only makes the code
*slightly* less readable.
---
src/console-kit.c |2 +-
src/udscs.c |6 +++---
src/vdagent-virtio-port.c |2 +-
src/vdagent-x11.c |2 +-
src/vdagentd-uinput.c |2 +-
src/vda
dled in GDP the same way
> - for MacOS, I suppose we could also write a simple QuickTime component doing
> the same conversion
Cool, with all these advantages in mind, maybe we should just focus
on the practicalities of this approach and only come back to the other
option
/
Hmm.. do we really want to depend on non-free plugins? :)
--
Regards,
Zeeshan Ali (Khattak)
FSF member#5124
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
SHOULD be more easily portable.
Issues/challenges here are:
a. Same as issue 1.a above.
b. GDP is unidirectional so we'll need to figure a way to serialize
upstream events from the client. Shouldn't be difficult though once we
know how to solve the previous issue.
c. Same a
No need to keep the code that it disabled since it harms readability.
Also remove the '#if 1' for same rationale.
---
gtk/channel-display.c|3 +-
gtk/channel-main.c |6
gtk/coroutine_gthread.c |4 ---
gtk/coroutine_ucontext.c |5 ---
gtk/decode-glz.c |4
---
0 files changed, 0 insertions(+), 0 deletions(-)
mode change 100755 => 100644 server/red_tunnel_worker.h
diff --git a/server/red_tunnel_worker.h b/server/red_tunnel_worker.h
old mode 100755
new mode 100644
--
1.7.5
___
Spice-devel mailing list
Sp
From: Zeeshan Ali (Khattak)
---
modulesets/spice.xml |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/modulesets/spice.xml b/modulesets/spice.xml
index 9603438..a640afd 100644
--- a/modulesets/spice.xml
+++ b/modulesets/spice.xml
@@ -23,6 +23,8 @@
http
26 matches
Mail list logo
