> On October 12, 2015 at 6:19 PM Christophe Fergeau wrote:
> Hey,
>
> So we have both spice_uri_parse() and spice_parse_uri(), the former used
> for parsing proxy URIs, the latter for parsing spice:// URIs.
> spice_parse_uri() supports [] notation, but also knows how to unescape
> URI components
> On October 12, 2015 at 6:16 PM Christophe Fergeau wrote:
>
> Looks good, though detecting the presence of ":" feels a bit magic :)
Surely it's a future proof strategy because who uses colons for anything
meaningful anyway? ;-)
At least s->host is supposed to only contain the host and no other
Hi
> On October 12, 2015 at 6:08 PM Christophe Fergeau wrote:
> On Mon, Oct 05, 2015 at 04:16:43PM +0200, Wolfgang Bumiller wrote:
> >
> > diff --git a/tests/session.c b/tests/session.c
> > (...)
>
> Was this test working fine for you ? most of the tests in tests/
Signed-off-by: Wolfgang Bumiller
---
src/spice-uri.c | 36 +---
1 file changed, 29 insertions(+), 7 deletions(-)
diff --git a/src/spice-uri.c b/src/spice-uri.c
index 82aefdb..c0d2d9c 100644
--- a/src/spice-uri.c
+++ b/src/spice-uri.c
@@ -114,11 +114,24
Signed-off-by: Wolfgang Bumiller
---
src/spice-session.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/src/spice-session.c b/src/spice-session.c
index e1d9997..86c339f 100644
--- a/src/spice-session.c
+++ b/src/spice-session.c
@@ -399,8 +399,15 @@ static gchar
ver
set it, so it was always 'localhost', which made testing the ipv6
address a little hard ;-).
Changed one 'localhost' to '127.0.0.1' for completeness' sake.
Also added proxy URI tests to it.
Wolfgang Bumiller (3):
proxy: support ipv6 addresses in b
Signed-off-by: Wolfgang Bumiller
---
tests/session.c | 45 +++--
1 file changed, 39 insertions(+), 6 deletions(-)
diff --git a/tests/session.c b/tests/session.c
index feee3db..c9f6bca 100644
--- a/tests/session.c
+++ b/tests/session.c
@@ -8,24 +8,28
> On October 5, 2015 at 2:53 PM Victor Toso wrote:
> Could you please also add some tests in tests/session.c ?
> We are lacking tests and this seems a good oportunity ;)
Sure, apparently spice_uri_create in spice-session.c fails to add brackets when
needed, and I didn't see spice_uri_to_string
Signed-off-by: Wolfgang Bumiller
---
src/spice-uri.c | 19 ---
1 file changed, 16 insertions(+), 3 deletions(-)
diff --git a/src/spice-uri.c b/src/spice-uri.c
index 82aefdb..2415857 100644
--- a/src/spice-uri.c
+++ b/src/spice-uri.c
@@ -114,11 +114,24 @@ gboolean spice_uri_parse
