On 1/25/20 2:58 PM, ole-kru...@yandex.ru wrote:
Hello dear devs,
our host has libspice-server1 0.14.2, qemu-kvm 4.1, libvirt 5.0.0 with "ramfb"
option for mediated devices enabled, NVIDIA GRID GPU. We'd like to stream
GPU-accelerated video from Linux guests. spice-streaming-agent+gst-plugin
Its functionally is equivalent to connecting to the deep-element-added
signal, but a bit more convenient
Signed-off-by: Snir Sheriber
---
src/channel-display-gst.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/src/channel-display-gst.c b/src/channel-display-gst.c
Signed-off-by: Snir Sheriber
---
This helps to debug plugins load related issues
---
src/channel-display-gst.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/channel-display-gst.c b/src/channel-display-gst.c
index 437328b..16bfa37 100644
--- a/src/channel-display-gst.c
+++ b/src
When XLIB_CAPTURE is set to 0 and framerate is set to anything
other than 25 streaming-agent crashes
This is a regrerssion caused by e0cf764baff9d678a6e75916457300d1ff39b169
Fixing it is done by adding the framerate value to convertion caps
Signed-off-by: Snir Sheriber
---
src/gst-plugin.cpp
On 8/28/19 5:48 PM, Frediano Ziglio wrote:
---
src/Makefile.am| 4
src/mjpeg-fallback.cpp | 38 +-
2 files changed, 17 insertions(+), 25 deletions(-)
diff --git a/src/Makefile.am b/src/Makefile.am
index 0133bf5..31b8af1 100644
--- a/src/Make
Hi,
Sorry for the late replay
On 8/28/19 5:44 PM, Frediano Ziglio wrote:
The Xlib capture helper provides a wrapping class for XImage, Display
information and other capturing related functionalities which allows
to use unified and simple API for screen capturing using X.
This also utilize the
Hi,
On 9/9/19 6:54 PM, Frediano Ziglio wrote:
deploy is done by triggering copr's webhook so copr will
get the artifacts and generate a build.
---
This is another suggestion to integrate deployment to copr
The flow is as follow:
- Successful gitlab-ci build will generate tarball and spec file
---
meson.build | 11 +++
spice-gtk.spec.in | 190 ++
2 files changed, 201 insertions(+)
create mode 100644 spice-gtk.spec.in
diff --git a/meson.build b/meson.build
index 171a3f6..7ececd7 100644
--- a/meson.build
+++ b/meson.build
@@ -407,3 +407
deploy is done by triggering copr's webhook so copr will
get the artifacts and generate a build.
---
This is another suggestion to integrate deployment to copr
The flow is as follow:
- Successful gitlab-ci build will generate tarball and spec file
as accessible artifacts
- once the linux build c
Hi,
On 9/9/19 12:01 PM, Victor Toso wrote:
Hi,
On Sun, Sep 08, 2019 at 04:25:32PM +0300, Snir Sheriber wrote:
Hi,
On 9/2/19 7:04 PM, Victor Toso wrote:
From: Victor Toso
This means we can drop gstvideo_init() function and replace its calls
with gst_is_initialized().
Signed-off-by
HI,
On 9/2/19 7:04 PM, Victor Toso wrote:
From: Victor Toso
Does not work properly just because gst_is_initialized() checks if
gst_init() or gst_check_init() was ever called but it does not
consider if gst_deinit() was called too. I'm sending this RFC to check
if should be added or wait till f
Hi,
On 9/2/19 7:04 PM, Victor Toso wrote:
From: Victor Toso
Let's gst_deinit() if we initialize it for the same rationale pointed out
in 0381e62 "spicy: Add call of gst_deinit at program exit" in
2017-10-20 by Christophe de Dinechin
Signed-off-by: Victor Toso
---
src/spice-session.c | 8 +
Hi,
On 9/2/19 7:04 PM, Victor Toso wrote:
From: Victor Toso
This means we can drop gstvideo_init() function and replace its calls
with gst_is_initialized().
Signed-off-by: Victor Toso
---
src/channel-display-gst.c | 23 +--
1 file changed, 5 insertions(+), 18 deletion
Hi,
On 9/2/19 6:50 PM, Kevin Pouget wrote:
This patch allows the MJPEG encoder to inform the spice-widget that
its video drawing area (draw-area) should be made visible on screen.
This is required to switch from GST video decoding to native MJPEG
decoding, otherwise the gst-area remained on top
Hi,
On 8/29/19 7:17 PM, Frediano Ziglio wrote:
This patch allows the MJPEG encoder to inform the spice-widget that
its video drawing area (draw-area) should be made visible on screen.
This is required to switch from GST video decoding to native MJPEG
decoding, otherwise the gst-area remained on
This will drop the following warning:
"Project specifies a minimum meson_version '>= 0.49' but uses
features which were added in newer versions"
Signed-off-by: Snir Sheriber
---
meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meson.bu
Hi,
On 8/28/19 1:36 PM, Frediano Ziglio wrote:
Hi,
On 8/27/19 10:49 PM, Marc-André Lureau wrote:
Hi
On Tue, Aug 27, 2019 at 6:27 PM Snir Sheriber wrote:
This will let copr to generate srpm using the .copr/Makefile script
Do we really want to maintain that kind of distro things upstream
Hi,
On 8/27/19 10:49 PM, Marc-André Lureau wrote:
Hi
On Tue, Aug 27, 2019 at 6:27 PM Snir Sheriber wrote:
This will let copr to generate srpm using the .copr/Makefile script
Do we really want to maintain that kind of distro things upstream? Do
we need it?
What does it bring that gitlab CI
the other hand if it's preferred to be the official upstream spec i can
add the changelog and move necessary copr changes to the Makefile
script.
Signed-off-by: Snir Sheriber
---
Test build:
https://copr.fedorainfracloud.org/coprs/snir/spice-project/build/1021943/
---
meson.build
This will let copr to generate srpm using the .copr/Makefile script
Signed-off-by: Snir Sheriber
---
.copr/Makefile | 29 +
1 file changed, 29 insertions(+)
create mode 100644 .copr/Makefile
diff --git a/.copr/Makefile b/.copr/Makefile
new file mode 100644
index
Signed-off-by: Snir Sheriber
---
Test build:
https://copr.fedorainfracloud.org/coprs/snir/spice-project/build/1021943/
---
meson.build | 11 +++
spice-gtk.spec.in | 190 ++
2 files changed, 201 insertions(+)
create mode 100644 spice
---
src/Makefile.am| 2 ++
src/gst-plugin.cpp | 43 +++
2 files changed, 21 insertions(+), 24 deletions(-)
diff --git a/src/Makefile.am b/src/Makefile.am
index 31b8af1..1de8f9a 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -98,6 +98,8 @@ gst_pl
The Xlib capture helper provides a wrapping class for XImage, Display
information and other capturing related functionalities which allows
to use unified and simple API for screen capturing using X.
This also utilize the X MIT-SHM extension which improves capturing
speed, hence, xext is required.
-
---
src/Makefile.am| 4
src/mjpeg-fallback.cpp | 38 +-
2 files changed, 17 insertions(+), 25 deletions(-)
diff --git a/src/Makefile.am b/src/Makefile.am
index 0133bf5..31b8af1 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -21,6 +21,7 @@ A
Acked-by: Snir Sheriber
On 8/12/19 9:55 AM, Frediano Ziglio wrote:
On LLP64 platforms (like Windows) a virtual address cannot be
represented by a "unsigned long" type, so use uintptr_t which is
defined as an integral type large like a pointer.
"address_delta" and "add
Acked-by: Snir Sheriber
On 8/12/19 9:56 AM, Frediano Ziglio wrote:
Signed-off-by: Frediano Ziglio
---
docs/spice_style.txt | 9 +
1 file changed, 9 insertions(+)
diff --git a/docs/spice_style.txt b/docs/spice_style.txt
index e4d7fc6d1..89a550fb8 100644
--- a/docs/spice_style.txt
The typeUPtr templates are very similar except for the unref-function.
This patch is replacing the templates with a macro which also accepts
an unref-function and is using this macro to define all typeUPtr types.
Signed-off-by: Snir Sheriber
---
-Update commit message
-Conform with spice style
On 8/11/19 7:41 PM, Frediano Ziglio wrote:
On 8/11/19 3:12 PM, Frediano Ziglio wrote:
Hi
On 7/23/19 11:22 AM, Frediano Ziglio wrote:
When to Say "a" or "an" | Pronunciation |
EnglishClub
https://www.
On 8/11/19 3:12 PM, Frediano Ziglio wrote:
Hi
On 7/23/19 11:22 AM, Frediano Ziglio wrote:
When to Say "a" or "an" | Pronunciation | EnglishClub
https://www.englishclub.com/pronunciation/a-an.htm
On LLP64 platforms (like Windows) a virtual address canno
Hi,
On 8/6/19 6:34 PM, Kevin Pouget wrote:
With this patch, spice-streaming-agent exits the frame-sending loop
when START/STOP requests are received. This allows the recomputation
of the most suitable capture/encoding plugin, that may have been
updated with START/STOP message.
Signed-off-by: K
On 8/6/19 6:34 PM, Kevin Pouget wrote:
This patch gives more priority to the requested video codecs when
selecting the FrameCapture plugin, instead of its hard-coded rank.
We may want to mention this priority also in the header file.
Snir.
The client_codecs storage structure is changed fro
Hi,
Tested, seems to work well! switching is smooth, if codec fails
it falls back to mjpeg (not very loudly), no default gstreamer
codec currently. As mentioned i find this feature useful :)
another comment below
On 8/6/19 6:34 PM, Kevin Pouget wrote:
With this patch, spice-streaming-agent
On 8/11/19 2:56 PM, Snir Sheriber wrote:
Hi
On 7/23/19 11:22 AM, Frediano Ziglio wrote:
When to Say "a" or "an" | Pronunciation | EnglishClub
https://www.englishclub.com/pronunciation/a-an.htm
Oops, wrong pasting, please ignore :P
On LLP64 platforms (lik
Hi
On 7/23/19 11:22 AM, Frediano Ziglio wrote:
When to Say "a" or "an" | Pronunciation | EnglishClub
https://www.englishclub.com/pronunciation/a-an.htm
On LLP64 platforms (like Windows) a virtual address cannot
be represented by a "unsigned long" type, so use uintptr_t
which is define
Oh, just noticed, if this pushed, we may want to change the spice
style doc as well
Snir.
On 8/11/19 12:01 PM, Snir Sheriber wrote:
Hi,
It could be an issue with duplicated name headers but
seems we do not have such headers.
Ack
On 7/29/19 5:23 PM, Frediano Ziglio wrote:
Guards currently
Hi,
Acked-by: Snir Sheriber
nice catch
Snir.
On 7/23/19 11:22 AM, Frediano Ziglio wrote:
On 32 systems pointers are 32 bit while QXLPHYSICAL is always
64 bit.
Using pointer -> intptr_t -> QXLPHYSICAL conversion cause pointers
to have higher 32 bit set to 1 if the address is >= 0
Acked-by: Snir Sheriber
On 7/23/19 11:22 AM, Frediano Ziglio wrote:
Signed-off-by: Frediano Ziglio
---
server/tests/replay.c | 18 ++
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/server/tests/replay.c b/server/tests/replay.c
index e3ef7bf15..992f26d63
Hi,
It could be an issue with duplicated name headers but
seems we do not have such headers.
Ack
On 7/29/19 5:23 PM, Frediano Ziglio wrote:
Guards currently are quite different in format.
Unify updating to "#pragma once" syntax. This syntax is used
by GTK tools too.
To avoid possible regressio
Signed-off-by: Snir Sheriber
---
Another suggestion to shoten the templates + changing subject
---
src/gst-plugin.cpp | 64 +++---
1 file changed, 20 insertions(+), 44 deletions(-)
diff --git a/src/gst-plugin.cpp b/src/gst-plugin.cpp
index 4d17dbc
This also fixes a memory leak of GstBuffer
Signed-off-by: Snir Sheriber
---
Changes from v1:
-commit message
-Style
--
src/gst-plugin.cpp | 36 +++-
1 file changed, 23 insertions(+), 13 deletions(-)
diff --git a/src/gst-plugin.cpp b/src/gst-plugin.cpp
index
Hi,
On 8/8/19 1:09 PM, Kevin Pouget wrote:
Hello,
On Thu, Aug 8, 2019 at 11:23 AM Snir Sheriber wrote:
Hi,
On 8/7/19 6:49 PM, Kevin Pouget wrote:
This patch allows the MJPEG encoder to inform the spice-widget that
its video drawing area (draw-area) should be made visible on screen.
So
Hi,
On 8/7/19 6:49 PM, Kevin Pouget wrote:
This patch allows the MJPEG encoder to inform the spice-widget that
its video drawing area (draw-area) should be made visible on screen.
So the first one does not work?
BTW i think the consensus is to mention the patch version in all
of the subjects
rks is you configure gitlab (in gitlab project
settings->integration)
to trigger the copr repo webhook link with every push (this will trigger
a build
in copr, this build is based on srpm created by the .copr/Makefile script)
Snir.
Frediano
ping
On 2/25/19 4:56 PM, Snir Sh
ping
On 2/27/19 1:26 PM, Snir Sheriber wrote:
This Makefile script is invoked by copr to build source rpm
See: https://docs.pagure.org/copr.copr/user_documentation.html#make-srpm
---
Changes from v1 are script improvements and description
---
.copr/Makefile | 21 +
1
ping
On 2/25/19 4:56 PM, Snir Sheriber wrote:
---
.copr/Makefile | 21 +
1 file changed, 21 insertions(+)
create mode 100644 .copr/Makefile
diff --git a/.copr/Makefile b/.copr/Makefile
new file mode 100644
index 000..53b1b1b
--- /dev/null
+++ b/.copr/Makefile
HI,
On 8/1/19 6:27 PM, Kevin Pouget wrote:
Hello Snir,
On Thu, Aug 1, 2019 at 5:02 PM Snir Sheriber wrote:
Hi,
On 8/1/19 3:43 PM, Kevin Pouget wrote:
On Wed, Jul 31, 2019 at 12:09 PM Kevin Pouget wrote:
On Wed, Jul 31, 2019 at 11:50 AM Frediano Ziglio wrote:
With this patch, spice
On 8/1/19 7:17 PM, Frediano Ziglio wrote:
---
This patch is not really necessary, just a suggestion, it's a bit hacky
but would save some code.
Other options would be to use explicit template specialization or to
leave it as is.
Sure, what I don't like is that is surely not type safe, you can
On 8/1/19 6:30 PM, Frediano Ziglio wrote:
Looks fine.
But what are the difference? For instance what additional memory types we
want to feed to the pipeline?
For example VASurface for vaapi based plugins
Snir
---
src/gst-plugin.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Hi,
On 8/1/19 6:39 PM, Frediano Ziglio wrote:
---
src/gst-plugin.cpp | 31 ---
1 file changed, 20 insertions(+), 11 deletions(-)
diff --git a/src/gst-plugin.cpp b/src/gst-plugin.cpp
index 0a1d041..c7412c5 100644
--- a/src/gst-plugin.cpp
+++ b/src/gst-plugin.cpp
@
Acked-by: Snir Sheriber
On 8/1/19 4:04 PM, Frediano Ziglio wrote:
Signed-off-by: Frediano Ziglio
---
src/usb-device-manager.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/usb-device-manager.c b/src/usb-device-manager.c
index 0a04b119..426a0cd7 100644
--- a
Hi,
On 8/1/19 3:43 PM, Kevin Pouget wrote:
On Wed, Jul 31, 2019 at 12:09 PM Kevin Pouget wrote:
On Wed, Jul 31, 2019 at 11:50 AM Frediano Ziglio wrote:
With this patch, spice-streaming-agent can be launched with multiple
Gstreamer video codecs enabled:
spice-streaming-agent -c gst.codec=v
---
src/gst-plugin.cpp | 31 ---
1 file changed, 20 insertions(+), 11 deletions(-)
diff --git a/src/gst-plugin.cpp b/src/gst-plugin.cpp
index 0a1d041..c7412c5 100644
--- a/src/gst-plugin.cpp
+++ b/src/gst-plugin.cpp
@@ -67,6 +67,15 @@ struct GstSampleDeleter {
using
---
This patch is not really necessary, just a suggestion, it's a bit hacky
but would save some code.
Other options would be to use explicit template specialization or to
leave it as is.
---
src/gst-plugin.cpp | 44 ++--
1 file changed, 14 insertions(+), 3
Set GST_DEBUG_DUMP_DOT_DIR to specify where to place the generated
.dot file
---
src/gst-plugin.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gst-plugin.cpp b/src/gst-plugin.cpp
index e9d9364..0a1d041 100644
--- a/src/gst-plugin.cpp
+++ b/src/gst-plugin.cpp
@@ -261,7
---
src/gst-plugin.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gst-plugin.cpp b/src/gst-plugin.cpp
index 6415ac0..e9d9364 100644
--- a/src/gst-plugin.cpp
+++ b/src/gst-plugin.cpp
@@ -252,7 +252,7 @@ void GstreamerFrameCapture::pipeline_init(const
GstreamerEncoderSe
ack
On 7/26/19 1:04 PM, Frediano Ziglio wrote:
spice_usb_device_new is already returning a SpiceUsbDevice pointer.
Signed-off-by: Frediano Ziglio
---
src/usb-device-manager.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/usb-device-manager.c b/src/usb-device-manage
Acked-by: Snir Sheriber
On 7/22/19 2:25 PM, Frediano Ziglio wrote:
Signed-off-by: Frediano Ziglio
---
src/spice-widget-egl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/spice-widget-egl.c b/src/spice-widget-egl.c
index 7bae4e58..7db66082 100644
--- a/src/spice
Hi,
Here we can also remove some of the packing
Otherwise, ack for the series
On 7/22/19 2:08 PM, Frediano Ziglio wrote:
All other code use these headers.
Signed-off-by: Frediano Ziglio
---
server/migration-protocol.h | 32 ++--
server/reds.c |
operties may ignored silently.
Signed-off-by: Snir Sheriber
---
Changes from v2:
-Mainly c++ style and other minor changes
---
src/gst-plugin.cpp | 25 -
1 file changed, 20 insertions(+), 5 deletions(-)
diff --git a/src/gst-plugin.cpp b/src/gst-plugin.cpp
index 4e802f1..a60a
Acked-by: Snir Sheriber
Oh, got it, makes sense!
Thanks
On 7/18/19 6:50 PM, Frediano Ziglio wrote:
Signed-off-by: Frediano Ziglio
---
spice/start-packed.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/spice/start-packed.h b/spice/start-packed.h
index de0c595
On 7/18/19 6:37 PM, Frediano Ziglio wrote:
On 7/18/19 5:51 PM, Frediano Ziglio wrote:
Hi,
IIRC this was related to some compiler warning, no?
Yes, recent compilers are reporting it, see below.
If it is I'd mentioning it , otherwise, ack.
Just this patch or the entire series?
No, actua
On 7/18/19 5:51 PM, Frediano Ziglio wrote:
Hi,
IIRC this was related to some compiler warning, no?
Yes, recent compilers are reporting it, see below.
If it is I'd mentioning it , otherwise, ack.
Just this patch or the entire series?
No, actually i started looking at the second one and
Hi,
IIRC this was related to some compiler warning, no?
If it is I'd mentioning it , otherwise, ack.
Snir.
On 7/4/19 4:56 PM, Frediano Ziglio wrote:
Do not declare the structure as aligned.
The start/end-packed.h headers affects structures without
specification only using MingW or Microsoft
in, wrong properties may ignored silently.
Signed-off-by: Snir Sheriber
---
Difference from v1:
-Variables naming
-Using vector of pairs
-Add warnings for wrong input
-Set propeties after log msg
-Fix commit msg
*There is only basic input validation, assuming the user is
accurate with th
Hi,
On 7/16/19 2:35 PM, Frediano Ziglio wrote:
This allows to set plugin key=value properties on run time.
To add encoder plugin property use the following syntax:
-gst.prop="key=value"
Make sure syntax is accurate and that the property is supported by
the chosen plugin, wrong/invalid propertie
This allows to set plugin key=value properties on run time.
To add encoder plugin property use the following syntax:
-gst.prop="key=value"
Make sure syntax is accurate and that the property is supported by
the chosen plugin, wrong/invalid properties will be ignored silently.
Specific encoder availa
Acked-by: Snir Sheriber
On 7/7/19 7:35 PM, Frediano Ziglio wrote:
Do not expose multiple functions to fetch different parts of
internal structure.
Signed-off-by: Frediano Ziglio
---
server/red-qxl.c | 34 +-
server/red-qxl.h | 4 +---
server/reds.c
Acked-by: Snir Sheriber
The 0 result means success however the function (correctly) could
report a failure if the string is incorrect.
This fixes the test after commit b4150de3cd0e56d4ce43a99ef5c3c5f5cbdfc4a3
("spice_server_set_video_codecs: fail when no codec can be installed").
Sig
Hi,
On 7/5/19 4:09 PM, Frediano Ziglio wrote:
The 0 result means success however the function (correctly) could
report a failure if the string is incorrect.
This fixes the test after commit b4150de3cd0e56d4ce43a99ef5c3c5f5cbdfc4a3
("spice_server_set_video_codecs: fail when no codec can be instal
Hi,
On 7/5/19 6:47 PM, Frediano Ziglio wrote:
Do not expose multiple function to fetch different part of
internal structures.
shouldn't be "Do not expose multiple functions to fetch different parts of
internal structure." ?
Signed-off-by: Frediano Ziglio
---
server/red-qxl.c | 36 ++
ack
Acked-by: Snir Sheriber
On 6/2/19 8:53 PM, Frediano Ziglio wrote:
Signed-off-by: Frediano Ziglio
---
server/smartcard-channel-client.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/server/smartcard-channel-client.c
b/server/smartcard-channel-client.c
index
Hi,
On 6/2/19 8:53 PM, Frediano Ziglio wrote:
The attributes in this case are not used to apply the mask.
Doing so avoid sending garbage from the guest which usually
don't initialise the memory in case the mask is missing.
Guest should have cleared these bytes by its own however doing so
on the
Reported here:
https://gitlab.freedesktop.org/spice/spice-space-pages/issues/1
---
Following to this fix website manual will be automatically generated
---
docs/manual/manual.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/manual/manual.txt b/docs/manual/manual.txt
ind
Instead of manipulating a string and convert it to caps just
use dedicated functions instead
Signed-off-by: Snir Sheriber
---
Changes from v2:
-use g_free as a deleter
(exactly 100 characters width)
---
src/gst-plugin.cpp | 34 ++
1 file changed, 18 insertions
Ack for both
On 6/28/19 10:46 AM, Frediano Ziglio wrote:
ping
This follows up commit 887aedff41bdb89845e7cb349454a8dcbb515db4
"The video latency is in fact a margin".
Signed-off-by: Frediano Ziglio
---
src/channel-display-priv.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
d
Hi,
On 6/27/19 5:12 PM, Frediano Ziglio wrote:
Instead of manipulating a string and convert it to caps just
use dedicated functions instead
Signed-off-by: Snir Sheriber
---
Changes:
-commit log
-Suggesting uniqptr for caps_str
--
src/gst-plugin.cpp | 34
Instead of manipulating a string and convert it to caps just
use dedicated functions instead
Signed-off-by: Snir Sheriber
---
Changes:
-commit log
-Suggesting uniqptr for caps_str
--
src/gst-plugin.cpp | 34 ++
1 file changed, 18 insertions(+), 16 deletions
c due to its high rank).
Signed-off-by: Snir Sheriber
Acked-by: Frediano Ziglio
---
Basically Acked, for the record I'm sending it again with the minor changes
---
src/gst-plugin.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/gst-plugin.cpp b/src/gst-plugin
Hi,
On 6/26/19 6:24 PM, Frediano Ziglio wrote:
Signed-off-by: Snir Sheriber
Can you explain why this is better? It's not clear from the code.
Actually it is not much better, it just seems more reasonable to me
to set this properties using a dedicated function than manipulating
a s
g. in the
vaapi case it would select vaapipostproc due to its high rank).
Signed-off-by: Snir Sheriber
Really minor: vaapi -> VAAPI ?
Sure
Acked-by: Frediano Ziglio
---
At first i had a patch to choose vaapipostproc manually but then i remembered
this element
which suppose
c due to its high rank).
Signed-off-by: Snir Sheriber
---
At first i had a patch to choose vaapipostproc manually but then i remembered
this element
which suppose to do it automatically (it seems vaapipostproc has high enough
rank). I think
it's preferred although it's in gst-plugins-b
Signed-off-by: Snir Sheriber
---
src/gst-plugin.cpp | 33 +
1 file changed, 17 insertions(+), 16 deletions(-)
diff --git a/src/gst-plugin.cpp b/src/gst-plugin.cpp
index 9858beb..cf660eb 100644
--- a/src/gst-plugin.cpp
+++ b/src/gst-plugin.cpp
@@ -8,7 +8,6
Seems fine to me.
Ack
On 6/17/19 7:13 PM, Frediano Ziglio wrote:
This fixes https://bugzilla.redhat.com/show_bug.cgi?id=1582137.
Signed-off-by: Frediano Ziglio
---
server/display-channel.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/server/display-channel.c b/s
Hi,
On 6/17/19 8:33 PM, Francois Gouget wrote:
The client is in a better position than the server to pick the minimum
lag needed to compensate for frame arrival time jitter and ensure
smooth video playback.
To do so:
- It ignores the lag specified by the server through the mmtime clock
adjust
Hi,
Fine with me.
On 6/12/19 3:06 PM, Frediano Ziglio wrote:
We started disabling Celt support making the option required.
After 2 releases start making it disabled unless explicitly
enabled.
Signed-off-by: Frediano Ziglio
---
m4/spice-deps.m4 | 14 ++
meson_options.txt | 1 +
It seems this was pushed already some time ago
On 6/12/19 2:53 PM, Frediano Ziglio wrote:
This brings in the following changes:
Frediano Ziglio (4):
gitignore: Ignore auto generated generated_messages.h file
Do not check for HAVE_CONFIG_H
build: Remove unused git-version-ge
Assuming it passed the CI, Ack.
Acked-by: Snir Sheriber
On 6/12/19 6:13 PM, Frediano Ziglio wrote:
Signed-off-by: Frediano Ziglio
---
.gitlab-ci.yml | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 91ee47edc
Hi,
On 6/11/19 9:42 PM, Francois Gouget wrote:
schedule_frame() only pulls frames out of GStreamer's pipeline once all
previous decoded frames have been displayed. Thus when the video delay
IIRC we used to pull when samples arrived but it was changed to this so
pending frames will be queued
On 6/10/19 3:45 PM, Victor Toso wrote:
Hi,
On Mon, Jun 10, 2019 at 12:15:27PM +, Victor Toso wrote:
From: Snir Sheriber
When GDK_SCALE is != 1 and egl is used, the image presented does not
fit to the window (scale of 2 is often used with hidpi monitors).
Usually this is not a problem
Hi,
On 6/10/19 11:49 AM, Francois Gouget wrote:
The mm_time is an unsigned 32 bit int but spice_mmtime_diff() returns a
signed 32 bit int. That's reasonable because we normally substract
s/substract/subtract
Ack, I'll do this fix and push
frame times which should be at most seconds apart
Hi,
On 5/27/19 8:29 PM, Marc-André Lureau wrote:
Hi
On Mon, May 27, 2019 at 10:04 AM Snir Sheriber wrote:
When GDK_SCALE is != 1 and egl is used, the image presented does not
fit to the window (scale of 2 is often used with hidpi monitors).
Usually this is not a problem since all components
ack
On 6/1/19 3:14 PM, Frediano Ziglio wrote:
Signed-off-by: Frediano Ziglio
---
server/spicevmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/spicevmc.c b/server/spicevmc.c
index 460edb04f..84bbb73c2 100644
--- a/server/spicevmc.c
+++ b/server/spicevmc.c
@@ -7
Acked-by: Snir Sheriber
On 5/31/19 7:52 AM, Frediano Ziglio wrote:
Some function names where changed.
Signed-off-by: Frediano Ziglio
---
server/char-device.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/server/char-device.h b/server/char-device.h
index
When GDK_SCALE is != 1 and egl is used, the image presented does not
fit to the window (scale of 2 is often used with hidpi monitors).
Usually this is not a problem since all components are adjusted by
gdk/gtk but with egl, pixel-based data is not being scaled. In this
case window's scale value can
Hi,
On 5/23/19 2:00 PM, Victor Toso wrote:
Hi,
On Thu, May 23, 2019 at 01:01:12PM +0300, Snir Sheriber wrote:
Hi,
On 5/22/19 6:02 PM, Marc-André Lureau wrote:
Hi
On Sun, Mar 17, 2019 at 4:28 PM Snir Sheriber wrote:
When GDK_SCALE is != 1 and egl is used, the image presented does not
fit
Hi,
On 5/22/19 6:02 PM, Marc-André Lureau wrote:
Hi
On Sun, Mar 17, 2019 at 4:28 PM Snir Sheriber wrote:
When GDK_SCALE is != 1 and egl is used, the image presented does not
fit to the window (scale of 2 is often used with hidpi monitors).
Usually this is not a problem since all components
n 96ed6b7a and missed.
So i guess same subject would work "pygtk: remove bindings leftover"
Snir.
Acked-by: Snir Sheriber
On 5/17/19 1:41 PM, Frediano Ziglio wrote:
Signed-off-by: Frediano Ziglio
---
src/spice-client-gtk-module.c | 45 ---
Hi,
ack
(looks safe to remove but i didn't push yet (if someone want to object
by tomorrow ))
On 5/18/19 10:55 AM, Frediano Ziglio wrote:
This header was removed in 2014 (3c6b4e415) as deprecated and added again
in 2015 (2e88eb705) as causing some issue with former Qemu versions.
After 4 y
Hi,
Maybe worth mentioning it's leftover from pygtk/python bindings
not really critical, anyway, fine with me.
Acked-by: Snir Sheriber
On 5/17/19 1:41 PM, Frediano Ziglio wrote:
Signed-off-by: Frediano Ziglio
---
src/spice-client-gtk-module.c | 45 --
Signed-off-by: Snir Sheriber
---
m4/manywarnings.m4 | 1 -
1 file changed, 1 deletion(-)
diff --git a/m4/manywarnings.m4 b/m4/manywarnings.m4
index 4f701f4..3864100 100644
--- a/m4/manywarnings.m4
+++ b/m4/manywarnings.m4
@@ -116,7 +116,6 @@ AC_DEFUN([gl_MANYWARN_ALL_GCC],
-Wbuiltin-macro
1 - 100 of 446 matches
Mail list logo
