[Spice-devel] libcacard: src/link_test.c in the git tree

Hi. I noticed an extra file in the git tree in libcacard source directory, src/link_test.c, which is not present in the source tarball. Is it really needed there? Thanks, /mjt ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists

Re: [Spice-devel] [PATCH 2/2] do not link spice with libcacard

09.10.2015 16:36, Christophe Fergeau wrote: >> --- a/spice-common/m4/spice-deps.m4 >> +++ b/spice-common/m4/spice-deps.m4 >> @@ -58,7 +58,8 @@ AC_DEFUN([SPICE_CHECK_SMARTCARD], [ >>fi >> fi >> AS_VAR_APPEND([$1_CFLAGS], [' $(SMARTCARD_CFLAGS)']) >> -AS_VAR_APPEND([$1_LIBS], ['

[Spice-devel] libcacard: linking with too many libs

Hello. I tried to package libcacard, and come across a small thing. The library is uselessly linked with too many libs from the nss family, namely, the following libs are not needed: libplds4.so libplc4.so libssl3.so libsmime3.so libnssutil3.so (only libnss3.so is actually needed, it seems, may

[Spice-devel] [PATCH 1/2] use variables foo_LIBS and foo_CFLAGS in deps, not their values

variables during make time. So instead of AC_VAR_APPEND([$1_CFLAGS], [" $foo_CFLAGS"]) which adds _contents_ of $foo_CFLAGS, use AC_VAR_APPEND([$1_CFLAGS], [' $(foo_CFLAGS)']) which adds reference to foo_CFLAGS variable instead. Signed-off-by: Michael Tokarev --- spice-com

[Spice-devel] [PATCH 2/2] do not link spice with libcacard

None of the libcacard symbols are actually used by the library, only the header files, so there's no need to link with libcacard. Signed-off-by: Michael Tokarev --- spice-common/m4/spice-deps.m4 | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/spice-common/m4/spice-de

Re: [Spice-devel] [PATCH (v2)] Small cleanups to address compiler warnings

11.02.2013 18:49, Serge Hallyn wrote: > Changelog: Feb 11: Address feedback by Marc-André: > > Signed-off-by: Serge Hallyn Signed-off-By: Michael Tokarev (Or you can use Reviewed-by, whatever). > server/tests/basic_event_loop.c | 4 ++-- > server/tests/test_display_base.c |

Re: [Spice-devel] Disappearing mouse cursor in Autocad 2006 drawing window in WinXP VM with Spice+QXL video driver

10.02.2013 22:50, Giuseppe Bilotta wrote: Hello Michael, On Sun, Feb 10, 2013 at 9:48 AM, Michael Tokarev wrote: 10.02.2013 11:51, Giuseppe Bilotta wrote: libvirt 0.9.12-6 qemu-kvm 1.1.2+dfsg-5 libspice-server1 0.11.0-1 That's debian wheezy. Can you check whenever the latest releas

Re: [Spice-devel] Disappearing mouse cursor in Autocad 2006 drawing window in WinXP VM with Spice+QXL video driver

10.02.2013 11:51, Giuseppe Bilotta wrote: Hello all, I've been addressed to this mailing list after reporting the issue mentioned in the topic on #spice. Here are the details of the issue I'm seeing. This machine has a Virtual Machine with Windows XP installed to be able to run AutoCAD 2006. Th

Re: [Spice-devel] [PATCH] spice-common: remove version construction

07.02.2013 21:02, Marc-André Lureau wrote: - Mensaje original - Version string isn't used anywhere in spice-common, and there's no version for spice-common module per se, either. Hoever, configure.ac has this: AC_INIT([spice-common], [m4_esyscmd(build-aux/git-version-gen .t

[Spice-devel] [PATCH] Fix numerous compiler warnings due to wrong types and remove useless typecasts

This is a cleanup/fix patch that addresses numerous small defects all around the code. Author: Serge Hallyn Signed-off-By: Serge Hallyn Signed-off-By: Michael Tokarev --- a/server/tests/basic_event_loop.c +++ b/server/tests/basic_event_loop.c @@ -115,7 +115,7 @@ static void watch_remove

[Spice-devel] Address a compilation warning due to missing typecast

Author: Serge Hallyn This is a trivial typecast fix, -- all surrounding lines cast lines_end to PIXEL* but one is apparently forgotten. This fixes a compiler warning about incompatible types in assignment. --- a/spice-common/common/lz_compress_tmpl.c +++ b/spice-common/common/lz_compress_tmpl.c

[Spice-devel] [PATCH] spice-common: remove version construction

ld-aux/git-version-gen from AC_INIT and replaces it with a string "noversion", to stop these scary messages from being produced. Signed-off-by: Michael Tokarev --- spice-common/configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spice-common/configu

Re: [Spice-devel] Bug with qxl vga memory settings

25.01.2013 18:51, Michael Tokarev wrote: >> I saw also that qemu 1.3 debian package use vgabios from vgabios 0.7 package >> instead of seabios 1.7.2 package. >> Can be a problem with qxl? This is wrong. qemu-1.3, and current qemu git tree, uses vgabios 0.7a from http://www.

Re: [Spice-devel] Bug with qxl vga memory settings

[Adding spice-devel@ back - I don't think we should drop this list, even if it will be a repost there.] I've just a small comment below, -- I haven't gotten to testing it myself yet, was too busy today to do anything useful. 25.01.2013 18:37, Fabio Fantoni wrote: > Debugging qxl problem with xen

Re: [Spice-devel] [spice] configure: fix c&p from network to smartcard

22.01.2013 16:13, Christophe Fergeau wrote: Hey Fidencio, On Sat, Jan 12, 2013 at 07:03:46PM -0200, Fabiano Fidêncio wrote: --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index fc0216f..cfa0cbf 100644 --- a/configure.ac ++

Re: [Spice-devel] [PATCH] link libspice server with libm libpthread

, Michael Tokarev wrote: server/Makefile apparently forgot to link libspice-server with -lm -lpthread, but it uses symbols from these libraries directly. These libs are detected by configure and stored in $(SPICE_NONPKGCONFIG_LIBS) make variable, but this variable is never referenced at link time

Re: [Spice-devel] multi-clients issue

On 19.12.2012 09:05, Rozen Lin wrote: > Hi,All, > Currently I'm trying the multi-client feature of spice, the server > side is spice-server-0.10 and qemu-kvm-1.1, if I use only from Linux I guess it is debian wheezy, right? > machine the spicec-0.10 or spice-gtk-0.10 as clients, the multi-clien

Re: [Spice-devel] change the Monitor refresh rate of VM

On 16.08.2012 11:51, flooding Controlled wrote: > I just want to make sure that is could be changed or not. And, I think 100HZ > is too high, normally 75~85HZ is OK for PC, and 60HZ for laptop. Too high for what? The refresh rate is how often a (physical) video card sends information to a (physi

Re: [Spice-devel] change the Monitor refresh rate of VM

> 2012/8/15 flooding Controlled > > > Hi all: > > I am now using spice now, but stucked by some problems. > My vm is XP, and I can the monitor refresh rate! It is always 100HZ, and > it it too high, How can I decrease it ? What problem are you

Re: [Spice-devel] [PATCH] make celt to be optional

14.06.2012 18:23, David Mansfield wrote: [] > As a user, being given the information and the option to disable is the best > case. A message saying "No compressed audio codec is available. Continuing > with audio enabled may degrade performance. Disable audio for this sesison?" I wonder which

Re: [Spice-devel] [PATCH] make celt to be optional

On 13.06.2012 04:57, Brian Vetter wrote: > As an outside observer with nothing really at stake here, it would seem that > rather than Debian providing a hobbled version of the spice client that uses > raw audio (disables Celt), they offer up a patch for both the server and the > client that impl

Re: [Spice-devel] [PATCH] make celt to be optional

On 12.06.2012 15:35, Alexander Larsson wrote: > On Tue, 2012-06-12 at 14:31 +0400, Michael Tokarev wrote: >> On 12.06.2012 13:15, Alexander Larsson wrote: >> [] >>> Its not incompatible, like I i said in my "(Well, .." part above. But >>> what it means i

Re: [Spice-devel] [PATCH] make celt to be optional

On 12.06.2012 14:27, Marc-André Lureau wrote: > On Mon, Jun 4, 2012 at 11:33 AM, Christophe Fergeau > wrote: >> Makes sense to me though I've only looked quickly through it. Since it >> works for you, I'm in favour of committing it if noone disagrees. > > I also don't like these changes to end u

Re: [Spice-devel] [PATCH] make celt to be optional

On 12.06.2012 13:15, Alexander Larsson wrote: [] > Its not incompatible, like I i said in my "(Well, .." part above. But > what it means is that it will send audio as PCM instead of compressing > it. This is much larger, and will cause anyone using the debian spice > client to connect to a spice se

Re: [Spice-devel] [PATCH] make celt to be optional

On 12.06.2012 12:48, Alexander Larsson wrote: > On Sat, 2012-06-02 at 15:46 +0400, Michael Tokarev wrote: > >> I plan to use this patch in the upcoming Debian >> release, codename wheezy, to get rid of celt >> codec library there, since we decided celt051 is >> not g

Re: [Spice-devel] [PATCH] make celt to be optional

On 04.06.2012 16:28, Alon Levy wrote: > On Mon, Jun 04, 2012 at 11:33:22AM +0200, Christophe Fergeau wrote: >> Makes sense to me though I've only looked quickly through it. Since it >> works for you, I'm in favour of committing it if noone disagrees. > > I agree. Would you do a review and ack? Pl

[Spice-devel] [PATCH] link libspice server with libm libpthread

/Makefile.am, to libspice_server_la_LIBADD variable. Signed-off-By: Michael Tokarev --- server/Makefile.am |1 + 1 file changed, 1 insertion(+) diff --git a/server/Makefile.am b/server/Makefile.am index 97e7dfe..14e5694 100644 --- a/server/Makefile.am +++ b/server/Makefile.am @@ -38,6 +38,7

[Spice-devel] Next (stable) release of spice?

Are there any plans to make new release of spice? It's been quite some time since previous 0.10 release, and the amount of bugfixes and changes in current git master is huge. For one, I still can't use stable spice on my main development workstation because it is running 32bit userspace and spice

[Spice-devel] [PATCH] make celt to be optional

to patched server. I didn't check old clients and servers, however. In all cases, raw audio stream is being choosen and used. But since I don't really know how spice works internally, maybe I didn't perform correct testing. Please consider applying. Signed-off-By: Michael Tokarev C

[Spice-devel] [PATCH] fix error-path return in snd_set_record_peer()

The error_{1,2} labels in this functions are backwards. Signed-off-by: Michael Tokarev --- server/snd_worker.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/snd_worker.c b/server/snd_worker.c index 7bdd399..caffe67 100644 --- a/server/snd_worker.c +++ b