in wrote:
> > > On Fri, Jul 03, 2020 at 02:45:15PM +0900, Alexandre Courbot wrote:
> > > > Hi Dmitry,
> > > >
> > > > On Thu, Jul 2, 2020 at 10:47 PM Dmitry Sepp
wrote:
> > > > > Hi Keiichi,
> > > > >
> > > &g
x27;t happen until we issue the
next ATTACH call. Also, as we discussed before, it might be not possible to
free individual buffers, but the whole queue only.
Best regards,
Dmitry.
On Donnerstag, 2. Juli 2020 14:50:58 CEST Keiichi Watanabe wrote:
> Hi Dmitry,
>
> On Thu, Jul 2, 2020 at
Hi Keiichi,
Thank you very much for the hard work to update the spec and to summarize all
of the recent proposals!
I want to again raise a topic that was discussed earlier and unfortunately the
latest proposal cannot resolve the problem. I hope together with upstream
people we'll be able to fi
Hi Keiichi,
On Montag, 18. Mai 2020 07:17:53 CEST Keiichi Watanabe wrote:
> > +struct virtio_video_stream_create {
> > +struct virtio_video_cmd_hdr hdr;
> > +le32 in_mem_type; /* One of VIRTIO_VIDEO_MEM_TYPE_* types */
> > +le32 out_mem_type; /* One of VIRTIO_VIDEO_MEM_TYPE
Hi Keiichi,
Thanks for the update.
> > Thanks for providing this detailed overview. But again, we have already
> > discussed this in a similar way and it does not answer the questions. Ok,
> > suppose we set bitrate to 0x as I assumed above. Then the decoder
> > code should ideally wait u
gards,
Dmity.
On Freitag, 24. April 2020 13:45:38 CEST Keiichi Watanabe wrote:
> Hi Dmitry,
>
> On Thu, Apr 9, 2020 at 10:23 PM Dmitry Sepp
wrote:
> > Hi Keiichi,
> >
> > On Donnerstag, 9. April 2020 12:46:56 CEST Keiichi Watanabe wrote:
> > > Hi,
> >
Hi Keiichi,
On Montag, 20. April 2020 11:57:52 CEST Keiichi Watanabe wrote:
> Hi Dmitry,
>
> On Fri, Apr 17, 2020 at 5:09 PM Dmitry Sepp
wrote:
> > Hi,
> >
> > On Donnerstag, 9. April 2020 12:46:27 CEST Keiichi Watanabe wrote:
> > > Currently, we have three
Hi,
On Donnerstag, 9. April 2020 12:46:27 CEST Keiichi Watanabe wrote:
> Currently, we have three options of the design of per-stream properties:
>
> 1. Have two structs for image format and bitstream format.
> Pros:
> Well structured. Easy to support uni-directional stream.
> Cons:
> Not all pro
Hi Keiichi,
On Donnerstag, 9. April 2020 12:46:56 CEST Keiichi Watanabe wrote:
> Hi,
>
> On Tue, Apr 7, 2020 at 11:49 PM Dmitry Sepp
wrote:
> > Hi,
> >
> > > +\item[VIRTIO_VIDEO_CMD_STREAM_DESTROY] Destroy a video stream
> > > + (context) within the d
Hi Alexandre, Keiichi,
Thanks for the updates,
On Montag, 6. April 2020 13:46:33 CEST Keiichi Watanabe wrote:
>
> It seems that you're suggesting a big struct where bitstream params,
> image params and all controls are merged into, right?
> After rethinking, it makes sense to me.
> Originally, w
Hi,
> +\item[VIRTIO_VIDEO_CMD_STREAM_DESTROY] Destroy a video stream
> + (context) within the device.
> +
> +\begin{lstlisting}
> +struct virtio_video_stream_destroy {
> +struct virtio_video_cmd_hdr hdr;
> +};
> +\end{lstlisting}
Let's add more strict description to stream_destroy, like
Hi Keiichi,
On Freitag, 27. März 2020 04:35:13 CEST Keiichi Watanabe wrote:
> Hi Dmitry,
>
> On Wed, Mar 25, 2020 at 6:47 PM Dmitry Sepp
wrote:
> > Hi Keiichi,
> >
> > On Montag, 23. März 2020 16:48:14 CET Keiichi Watanabe wrote:
> > > Hi,
> > >
Hi Keiichi,
On Montag, 23. März 2020 16:48:14 CET Keiichi Watanabe wrote:
> Hi,
>
> On Mon, Mar 23, 2020 at 10:28 PM Dmitry Sepp
>
> wrote:
> > Hi Keiichi,
> >
> > On Montag, 23. März 2020 13:07:54 CET Keiichi Watanabe wrote:
> > > Hi everyone,
>
Hi Keiichi,
On Montag, 23. März 2020 13:07:54 CET Keiichi Watanabe wrote:
> Hi everyone,
>
> I have implemented a virtio-video device following my v3 spec in
> crosvm, which worked well together with Dmitry's driver [1]. I've
> started preparing v4 proposal to address problems found while
> imple
Hi Keiichi,
On Dienstag, 17. März 2020 07:53:26 CET Keiichi Watanabe wrote:
> > > diff --git a/include/uapi/linux/virtio_video.h
> > > b/include/uapi/linux/virtio_video.h new file mode 100644
> > > index ..0dd98a2237c6
> > > --- /dev/null
> > > +++ b/include/uapi/linux/virtio_video.h
>
Hi Tomasz,
On Freitag, 13. März 2020 12:11:51 CET Tomasz Figa wrote:
> On Fri, Mar 13, 2020 at 11:27 AM Dmitry Sepp
>
> wrote:
> > Hi Tomasz,
> >
> > On Freitag, 13. März 2020 11:05:35 CET Tomasz Figa wrote:
> > > On Thu, Mar 12, 2020 at 12:48 PM Dmitry
Hi Nicolas, Keiichi,
On Freitag, 13. März 2020 08:54:13 CET Keiichi Watanabe wrote:
> Hi Nicolas,
>
> On Fri, Mar 13, 2020 at 11:29 AM Nicolas Dufresne
wrote:
> > Hi Dimitry,
> >
> > Le jeudi 12 mars 2020 à 11:29 +0100, Dmitry Sepp a écrit :
> > > Hi H
Hi Tomasz,
On Freitag, 13. März 2020 11:05:35 CET Tomasz Figa wrote:
> On Thu, Mar 12, 2020 at 12:48 PM Dmitry Sepp
>
> wrote:
> > Hi Hans,
> >
> > One more thing:
> > > GFP_DMA? That's unusual. I'd expect GFP_DMA32. All V4L2 drivers use
> >
Hi Nicolas,
On Freitag, 13. März 2020 03:29:44 CET Nicolas Dufresne wrote:
> Hi Dimitry,
>
> Le jeudi 12 mars 2020 à 11:29 +0100, Dmitry Sepp a écrit :
> > Hi Hans,
> >
> > I'm not sure about crosvm, for us it is probably still feasible to
> > i
Hi Hans,
One more thing:
> GFP_DMA? That's unusual. I'd expect GFP_DMA32. All V4L2 drivers use that.
GFP_DMA32 had no effect for me on arm64. Probably I need to recheck.
Best regards,
Dmitry.
On Donnerstag, 12. März 2020 11:18:26 CET Hans Verkuil wrote:
> On 3/12/20 11:15
0 at 10:26 PM Hans Verkuil wrote:
> >> Hi Dmitry,
> >>
> >> On 2/18/20 9:27 PM, Dmitry Sepp wrote:
> >>> Hi all,
> >>>
> >>> This is a v4l2 virtio video driver for the virtio-video device
> >>> specification v3 [1]
Hi Hans,
Thanks for reviewing.
Sure, we understand the driver must pass v4l2-compliance. But the spec is not
finalized yet, so it was a bit out of the scope.
Best regards,
Dmitry.
On Mittwoch, 11. März 2020 14:26:46 CET Hans Verkuil wrote:
> Hi Dmitry,
>
> On 2/18/20 9:27 PM, Dm
Hi all,
This is a v4l2 virtio video driver for the virtio-video device
specification v3 [1].
The first version of the driver was introduced here [2].
Changes v1 -> v2:
* support the v3 spec (mostly)
* add a module parameter to ask for pages from ZONE_DMA
What is not implemented:
* Plane layout
Hi Keiichi,
thank you for the update.
On Dienstag, 14. Januar 2020 08:18:50 CET Keiichi Watanabe wrote:
> Hi,
>
> On Thu, Jan 9, 2020 at 11:21 PM Tomasz Figa wrote:
> > On Wed, Jan 8, 2020 at 10:52 PM Keiichi Watanabe
wrote:
> > > Hi Gerd,
> > >
> > > On Thu, Dec 19, 2019 at 10:12 PM Gerd Ho
Hi Gerd,
Thanks for reviewing!
On Montag, 13. Januar 2020 10:56:36 CET Gerd Hoffmann wrote:
> Hi,
>
> > This also means that we cannot have unspec for planes layout. Device
> > either
> > expects planes in separate buffers or in one buffer with some offsets,
> > there cannot be mixed cases.
>
Hi Tomasz,
On Samstag, 11. Januar 2020 17:06:46 CET Tomasz Figa wrote:
> On Sat, Jan 11, 2020 at 12:12 AM Dmitry Sepp
>
> wrote:
> > Hi Keiichi,
> >
> > On Freitag, 10. Januar 2020 14:53:01 CET Keiichi Watanabe wrote:
> > > Hi,
> > >
>
Hi Keiichi,
thanks for the updates, please see my comments below.
On Dienstag, 7. Januar 2020 14:24:31 CET Keiichi Watanabe wrote:
> Hi Dmitry,
>
> On Mon, Jan 6, 2020 at 11:59 PM Dmitry Sepp
wrote:
> > Hi,
> >
> > a couple of new comments:
> >
> >
Hi Keiichi,
On Mittwoch, 8. Januar 2020 07:59:22 CET Keiichi Watanabe wrote:
> Hi Dmitry,
>
> On Wed, Jan 8, 2020 at 1:50 AM Dmitry Sepp
wrote:
> > Hi Keiichi,
> >
> > thanks for the updates, please see my comments below.
> >
> > On Dienstag, 7. Ja
Hi,
On Donnerstag, 9. Januar 2020 15:56:08 CET Dmitry Sepp wrote:
> Hi,
>
> On Dienstag, 7. Januar 2020 11:25:56 CET Keiichi Watanabe wrote:
> > Hi Dmitry,
> >
> > On Mon, Jan 6, 2020 at 8:28 PM Dmitry Sepp
>
> wrote:
> > > Hi,
> > >
&
Hi Tomasz, Keiichi,
On Mittwoch, 8. Januar 2020 13:46:25 CET Tomasz Figa wrote:
> On Wed, Jan 8, 2020 at 9:15 PM Keiichi Watanabe
wrote:
> > Hi Dmitry,
> >
> > On Wed, Jan 8, 2020 at 7:00 PM Dmitry Sepp
wrote:
> > > Hi Keiichi,
> > >
> > >
Hi Keiichi,
On Freitag, 10. Januar 2020 14:53:01 CET Keiichi Watanabe wrote:
> Hi,
>
> On Fri, Jan 10, 2020 at 7:16 PM Dmitry Sepp
wrote:
> > Hi,
> >
> > On Donnerstag, 9. Januar 2020 15:56:08 CET Dmitry Sepp wrote:
> > > Hi,
> > >
> >
Hi,
On Dienstag, 7. Januar 2020 11:25:56 CET Keiichi Watanabe wrote:
> Hi Dmitry,
>
> On Mon, Jan 6, 2020 at 8:28 PM Dmitry Sepp
wrote:
> > Hi,
> >
> > On Montag, 6. Januar 2020 11:30:22 CET Keiichi Watanabe wrote:
> > > Hi Dmitry, Tomasz,
> > >
Hi,
a couple of new comments:
On Mittwoch, 18. Dezember 2019 14:02:14 CET Keiichi Watanabe wrote:
> From: Dmitry Sepp
>
> The virtio video encoder device and decoder device provide functionalities
> to encode and decode video stream respectively.
> Though video encoder and decod
Hi,
On Montag, 6. Januar 2020 11:30:22 CET Keiichi Watanabe wrote:
> Hi Dmitry, Tomasz,
>
> On Fri, Jan 3, 2020 at 10:05 PM Dmitry Sepp
wrote:
> > Hi Tomasz, Keiichi,
> >
> > On Samstag, 21. Dezember 2019 07:19:23 CET Tomasz Figa wrote:
> > > On Sat, Dec 21
Hi,
On Montag, 6. Januar 2020 09:33:35 CET Gerd Hoffmann wrote:
> Hi,
>
> > > We also see the need to add a max_streams value to this structure so as
> > > to
> > > explicitly provide a limit on the number of streams the guest can
> > > create.
> >
> > What would be the advantage over just try
Hi Tomasz, Keiichi,
On Samstag, 21. Dezember 2019 07:19:23 CET Tomasz Figa wrote:
> On Sat, Dec 21, 2019 at 3:18 PM Tomasz Figa wrote:
> > On Sat, Dec 21, 2019 at 1:36 PM Keiichi Watanabe
wrote:
> > > Hi Dmitry,
> > >
> > > On Sat, Dec 21, 2019 at 12:5
Hi Keiichi,
On Mittwoch, 18. Dezember 2019 14:02:14 CET Keiichi Watanabe wrote:
> From: Dmitry Sepp
>
> The virtio video encoder device and decoder device provide functionalities
> to encode and decode video stream respectively.
> Though video encoder and decoder are provid
On Donnerstag, 19. Dezember 2019 14:28:23 CET Dmitry Sepp wrote:
> Hi Keiichi,
>
> Thank you for the update. Please see some comments below.
>
> Also, we need to bring the virtio_video_control back as it is in fact used
> by the driver to enumerate supported encoder controls.
Hi Keiichi,
On Freitag, 20. Dezember 2019 16:26:50 CET Keiichi Watanabe wrote:
> Hi Dmitry,
> Thanks for the feedback.
>
> On Thu, Dec 19, 2019 at 10:28 PM Dmitry Sepp
>
> wrote:
> > Hi Keiichi,
> >
> > Thank you for the update. Please see some comments be
en?
Best regards,
Dmitry.
> * Renamed virtio_video_pin to virtio_video_buf_type.
> - It's similar to V4L2_BUF_TYPE_VIDEO_{OUTPUT, CAPTURE}.
> * Added an error event.
> * Reordered some subsections.
> * Changed styles to make it consistent with other devices.
>
> Dmitry Sepp (1)
Hi Keiichi,
On Freitag, 20. Dezember 2019 15:05:02 CET Keiichi Watanabe wrote:
> Hi Frediano,
> Thanks for reviewing!
>
> On Thu, Dec 19, 2019 at 2:29 AM Frediano Ziglio wrote:
> > > From: Dmitry Sepp
> > >
> > > The virtio video encoder device and decod
02:14 CET Keiichi Watanabe wrote:
> From: Dmitry Sepp
>
> The virtio video encoder device and decoder device provide functionalities
> to encode and decode video stream respectively.
> Though video encoder and decoder are provided as different devices, they use
> a same proto
Hi Tomasz,
On Donnerstag, 19. Dezember 2019 10:59:02 CET Tomasz Figa wrote:
> On Thu, Dec 19, 2019 at 6:48 PM Dmitry Sepp
wrote:
> > Hi,
> >
> > On Donnerstag, 19. Dezember 2019 08:46:39 CET Gerd Hoffmann wrote:
> > > On Wed, Dec 18, 2019 at 11:08:37PM +0900, Tom
Hi,
On Donnerstag, 19. Dezember 2019 08:46:39 CET Gerd Hoffmann wrote:
> On Wed, Dec 18, 2019 at 11:08:37PM +0900, Tomasz Figa wrote:
> > On Wed, Dec 18, 2019 at 10:40 PM Gerd Hoffmann wrote:
> > > Hi,
> > >
> > > > +The device MUST mark the last buffer with the
> > > > +VIRTIO_VIDEO_BUFFER_
Hi Gerd,
On Mittwoch, 18. Dezember 2019 14:40:37 CET Gerd Hoffmann wrote:
> Hi,
>
> > +The device MUST mark the last buffer with the
> > +VIRTIO_VIDEO_BUFFER_F_EOS flag to denote completion of the drain
> > +sequence.
>
> No, that would build a race condition into the protocol. The device
> c
45 matches
Mail list logo
