Re: [PATCH v2 0/5] drm/connector: make mode_valid() callback accept const mode pointer

2025-01-21 Thread Dmitry Baryshkov
On Tue, 21 Jan 2025 at 11:13, Geert Uytterhoeven wrote: > > Hi Dmitry, > > On Tue, Jan 7, 2025 at 12:31 PM Dmitry Baryshkov > wrote: > > On Sat, 14 Dec 2024 15:37:04 +0200, Dmitry Baryshkov wrote: > > > While working on the generic mode_valid() implementatio

Re: [PATCH v2 0/5] drm/connector: make mode_valid() callback accept const mode pointer

2025-01-21 Thread Dmitry Baryshkov
On Tue, Jan 21, 2025 at 12:10:25PM +0100, Geert Uytterhoeven wrote: > Hi Dmitry, > > CC sfr > > On Tue, Jan 21, 2025 at 11:44 AM Dmitry Baryshkov > wrote: > > On Tue, 21 Jan 2025 at 11:13, Geert Uytterhoeven > > wrote: > > > On Tue, Jan 7, 2025 at

Re: [PATCH v2 25/25] drm/xlnx: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-01-17 Thread Dmitry Baryshkov
On Thu, Jan 16, 2025 at 11:17:50AM +0100, Geert Uytterhoeven wrote: > On Thu, Jan 16, 2025 at 11:03 AM Tomi Valkeinen > wrote: > > On 16/01/2025 10:09, Thomas Zimmermann wrote: > > > Am 15.01.25 um 15:20 schrieb Tomi Valkeinen: > > > [...] > > >> > > >> My point is that we have the current UAPI, a

Re: [PATCH v2 13/25] drm/msm: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-01-17 Thread Dmitry Baryshkov
; color mode and align the pitch accordingly. - scanline, not scnaline - the statement about 32-pixel alignment needs an explanation that it is being currently handled by align_pitch(). With that in mind: Reviewed-by: Dmitry Baryshkov > Signed-off-by: Thomas Zimmermann > Cc: Rob Clark &

Re: [PATCH v2 0/5] drm/connector: make mode_valid() callback accept const mode pointer

2025-01-07 Thread Dmitry Baryshkov
On Sat, 14 Dec 2024 15:37:04 +0200, Dmitry Baryshkov wrote: > While working on the generic mode_valid() implementation for the HDMI > Connector framework I noticed that unlike other DRM objects > drm_connector accepts non-const pointer to struct drm_display_mode, > while obviousl

Re: [PATCH v2 0/5] drm/connector: make mode_valid() callback accept const mode pointer

2025-01-07 Thread Dmitry Baryshkov
On Mon, 6 Jan 2025 at 10:55, Maxime Ripard wrote: > > On Mon, Jan 06, 2025 at 12:47:07AM +0200, Dmitry Baryshkov wrote: > > On Sat, Dec 14, 2024 at 03:37:04PM +0200, Dmitry Baryshkov wrote: > > > While working on the generic mode_valid() implementation for the HDMI > &

Re: [PATCH v2 0/5] drm/connector: make mode_valid() callback accept const mode pointer

2025-01-06 Thread Dmitry Baryshkov
On Sat, Dec 14, 2024 at 03:37:04PM +0200, Dmitry Baryshkov wrote: > While working on the generic mode_valid() implementation for the HDMI > Connector framework I noticed that unlike other DRM objects > drm_connector accepts non-const pointer to struct drm_display_mode, > while obviousl

[PATCH v2 2/5] drm/amdgpu: don't change mode in amdgpu_dm_connector_mode_valid()

2024-12-15 Thread Dmitry Baryshkov
Make amdgpu_dm_connector_mode_valid() duplicate the mode during the test rather than modifying the passed mode. This is a preparation to converting the mode_valid() callback of drm_connector to take a const struct drm_display_mode argument. Reviewed-by: Laurent Pinchart Signed-off-by: Dmitry

[PATCH v2 0/5] drm/connector: make mode_valid() callback accept const mode pointer

2024-12-15 Thread Dmitry Baryshkov
grate drivers into using it one by one. Signed-off-by: Dmitry Baryshkov --- Changes in v2: - Rebased on top of linux-next - Replaced 'accept const argument' with 'take a const arugment' (Laurent) - Link to v1: https://lore.kernel.org/r/20241115-drm-connector-mode-v

[PATCH v2 3/5] drm/sti: hda: pass const struct drm_display_mode* to hda_get_mode_idx()

2024-12-15 Thread Dmitry Baryshkov
Pinchart Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/sti/sti_hda.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/sti/sti_hda.c b/drivers/gpu/drm/sti/sti_hda.c index b12863bea95559c4f874eb94cea8938609d435d4

[PATCH v2 1/5] drm/encoder_slave: make mode_valid accept const struct drm_display_mode

2024-12-15 Thread Dmitry Baryshkov
The mode_valid() callbacks of drm_encoder, drm_crtc and drm_bridge accept const struct drm_display_mode argument. Change the mode_valid callback of drm_encoder_slave to also accept const argument. Reviewed-by: Laurent Pinchart Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/i2c

[PATCH v2 5/5] drm/connector: make mode_valid take a const struct drm_display_mode

2024-12-15 Thread Dmitry Baryshkov
Pinchart Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 8 drivers/gpu/drm/amd/amdgpu/atombios_dp.c | 2 +- drivers/gpu/drm/amd/amdgpu/atombios_dp.h | 2 +- drivers/gpu/drm/amd/display/amdgpu_dm

[PATCH v2 4/5] drm/connector: make mode_valid_ctx take a const struct drm_display_mode

2024-12-15 Thread Dmitry Baryshkov
The mode_valid() callbacks of drm_encoder, drm_crtc and drm_bridge take a const struct drm_display_mode argument. Change the mode_valid_ctx callback of drm_connector to also take a const argument. Acked-by: Jani Nikula Reviewed-by: Laurent Pinchart Signed-off-by: Dmitry Baryshkov --- drivers

Re: [PATCH 1/5] drm/encoder_slave: make mode_valid accept const struct drm_display_mode

2024-11-21 Thread Dmitry Baryshkov
On Mon, Nov 18, 2024 at 11:26:03AM +0200, Jani Nikula wrote: > On Mon, 18 Nov 2024, Dmitry Baryshkov wrote: > > On Mon, 18 Nov 2024 at 01:33, Laurent Pinchart > > wrote: > >> > >> On Mon, Nov 18, 2024 at 01:22:12AM +0200, Dmitry Baryshkov wrote: > >&g

Re: [PATCH 5/5] drm/connector: make mode_valid accept const struct drm_display_mode

2024-11-21 Thread Dmitry Baryshkov
On Sun, 17 Nov 2024 at 23:24, Laurent Pinchart wrote: > > Hi Dmitry, > > Thank you for the patch. > > On Fri, Nov 15, 2024 at 11:09:30PM +0200, Dmitry Baryshkov wrote: > > The mode_valid() callbacks of drm_encoder, drm_crtc and drm_bridge > > accept const struct drm

Re: [PATCH 1/5] drm/encoder_slave: make mode_valid accept const struct drm_display_mode

2024-11-21 Thread Dmitry Baryshkov
On Sun, 17 Nov 2024 at 22:54, Laurent Pinchart wrote: > > Hi Dmitry, > > Thank you for the patch. > > On Fri, Nov 15, 2024 at 11:09:26PM +0200, Dmitry Baryshkov wrote: > > The mode_valid() callbacks of drm_encoder, drm_crtc and drm_bridge > > accept const struct drm

Re: [PATCH 1/5] drm/encoder_slave: make mode_valid accept const struct drm_display_mode

2024-11-21 Thread Dmitry Baryshkov
On Mon, 18 Nov 2024 at 01:33, Laurent Pinchart wrote: > > On Mon, Nov 18, 2024 at 01:22:12AM +0200, Dmitry Baryshkov wrote: > > On Sun, 17 Nov 2024 at 22:54, Laurent Pinchart wrote: > > > On Fri, Nov 15, 2024 at 11:09:26PM +0200, Dmitry Baryshkov wrote: > > > &

[PATCH 1/5] drm/encoder_slave: make mode_valid accept const struct drm_display_mode

2024-11-17 Thread Dmitry Baryshkov
The mode_valid() callbacks of drm_encoder, drm_crtc and drm_bridge accept const struct drm_display_mode argument. Change the mode_valid callback of drm_encoder_slave to also accept const argument. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/i2c/ch7006_drv.c | 2 +- drivers/gpu

[PATCH 5/5] drm/connector: make mode_valid accept const struct drm_display_mode

2024-11-17 Thread Dmitry Baryshkov
The mode_valid() callbacks of drm_encoder, drm_crtc and drm_bridge accept const struct drm_display_mode argument. Change the mode_valid callback of drm_connector to also accept const argument. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 8

[PATCH 3/5] drm/sti: hda: pass const struct drm_display_mode* to hda_get_mode_idx()

2024-11-17 Thread Dmitry Baryshkov
Make hda_get_mode_idx() accept const struct drm_display_mode pointer instead of just raw struct drm_display_mode. This is a preparation to converting the mode_valid() callback of drm_connector to accept const struct drm_display_mode argument. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm

[PATCH 0/5] drm/connector: make mode_valid() callback accept const mode pointer

2024-11-17 Thread Dmitry Baryshkov
ework code to pass const argument to that callback. Note: yes, I understand that this change might be hard to review and merge. The only viable option that I foresee is to add new callback, having the const argument and migrate drivers into using it one by one. Signed-off-by: Dmitry Baryshkov --- D

[PATCH 4/5] drm/connector: make mode_valid_ctx accept const struct drm_display_mode

2024-11-17 Thread Dmitry Baryshkov
The mode_valid() callbacks of drm_encoder, drm_crtc and drm_bridge accept const struct drm_display_mode argument. Change the mode_valid_ctx callback of drm_connector to also accept const argument. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/i915/display/intel_dp_mst.c | 2 +- include

[PATCH 2/5] drm/amdgpu: don't change mode in amdgpu_dm_connector_mode_valid()

2024-11-17 Thread Dmitry Baryshkov
Make amdgpu_dm_connector_mode_valid() duplicate the mode during the test rather than modifying the passed mode. This is a preparation to converting the mode_valid() callback of drm_connector to accept const struct drm_display_mode argument. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm

Re: [PATCH 0/2] drm: Treewide plane/crtc legacy state sweeping

2024-10-27 Thread Dmitry Baryshkov
On Fri, 25 Oct 2024 at 10:46, Ville Syrjälä wrote: > > On Wed, Oct 02, 2024 at 09:21:58PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > An attempt to hide the drm_plane/crtc legacy state better. > > > > This also highlights the fact that a lot of supposedly > > atomic drivers are po

Re: [Spice-devel] [PATCH] drm/aperture: Pass DRM driver structure instead of driver name

2021-08-06 Thread Dmitry Baryshkov
Zimmermann --- [...] drivers/gpu/drm/msm/msm_fbdev.c | 2 +- Reviewed-by: Dmitry Baryshkov drivers/gpu/drm/nouveau/nouveau_drm.c | 2 +- drivers/gpu/drm/qxl/qxl_drv.c | 2 +- drivers/gpu/drm/radeon/radeon_drv.c | 2 +- drivers/gpu/drm