Re: [PATCH v2 02/25] drm/dumb-buffers: Provide helper to set pitch and size

2025-01-12 Thread Thomas Zimmermann
Hi Am 13.01.25 um 04:53 schrieb Andy Yan: [...] Thanks for taking a look. That NV-related code at [0] is a 'somewhat non-idiomatic use' of the UAPI. The dumb-buffer interface really just supports a single plane. The fix would be a new ioctl that takes a DRM 4cc constant and returns a buffer han

Re: [PATCH v2 19/25] drm/rockchip: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-01-12 Thread Heiko Stübner
Am Donnerstag, 9. Januar 2025, 15:57:13 CET schrieb Thomas Zimmermann: > Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and > buffer size. Align the pitch to a multiple of 64. > > Signed-off-by: Thomas Zimmermann > Cc: Sandy Huang > Cc: "Heiko Stübner" > Cc: Andy Yan I've loo

Re: [PATCH v2 10/25] drm/imx/ipuv3: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-01-12 Thread Philipp Zabel
On Do, 2025-01-09 at 15:57 +0100, Thomas Zimmermann wrote: > Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and > buffer size. The hardware requires the framebuffer width to be a > multiple of 8. The scanline pitch has be large enough to support > this. Therefore compute the byte s

Re: [PATCH v2 23/25] drm/xe: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-01-12 Thread Matthew Auld
On 09/01/2025 14:57, Thomas Zimmermann wrote: Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and buffer size. Align the pitch to a multiple of 8. Align the buffer size according to hardware requirements. Signed-off-by: Thomas Zimmermann Cc: Lucas De Marchi Cc: "Thomas Hellströ

Re: [PATCH v2 23/25] drm/xe: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-01-12 Thread Matthew Auld
On 09/01/2025 16:26, Thomas Zimmermann wrote: Hi Am 09.01.25 um 17:05 schrieb Matthew Auld: On 09/01/2025 14:57, Thomas Zimmermann wrote: Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and buffer size. Align the pitch to a multiple of 8. Align the buffer size according to har

Re:[PATCH v2 02/25] drm/dumb-buffers: Provide helper to set pitch and size

2025-01-12 Thread Andy Yan
Hi Thomas, At 2025-01-09 22:56:56, "Thomas Zimmermann" wrote: >Add drm_modes_size_dumb(), a helper to calculate the dumb-buffer >scanline pitch and allocation size. Implementations of struct >drm_driver.dumb_create can call the new helper for their size >computations. There's currently quite a b

Re: [PATCH v2 22/25] drm/vmwgfx: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-01-12 Thread Zack Rusin
On Thu, Jan 9, 2025 at 10:03 AM Thomas Zimmermann wrote: > > Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch > and buffer size. No alignment required. > > Signed-off-by: Thomas Zimmermann > Cc: Zack Rusin > Cc: Broadcom internal kernel review list > > --- > drivers/gpu/drm/vmw