Re: [Spice-devel] [PATCH] drm/qxl: Fix build errors

2020-08-17 Thread Gerd Hoffmann
Hi, > I guess things are never quite so easy :-). It looks like Daniel's > patch is in drm-misc-fixes and Sidong's patch is in drm-misc-next. On > their own they're fine, but once they are merged in drm-tip the build > error shows up. Ah, ok. I've already wondered how that got past my build te

Re: [Spice-devel] [PATCH] drm/qxl: Fix build errors

2020-08-17 Thread Sam Ravnborg
Hi Sean. On Mon, Aug 17, 2020 at 03:58:38PM -0400, Sean Paul wrote: > From: Sean Paul > > Introduced in the patch below, the END macro was missing 'dev' and BEGIN > macro needs drm_drv_uses_atomic_modeset() from drm_drv.h > > Fixes: bbaac1354cc9 ("drm/qxl: Replace deprecated function in qxl_dis

Re: [Spice-devel] [PATCH] drm/qxl: Replace deprecated function in qxl_display

2020-08-17 Thread Gerd Hoffmann
On Sun, May 24, 2020 at 11:26:23AM +0900, Sidong Yang wrote: > Hi, Dave. > > This is resended e-mail for your advice. > > I'm a newbie interested in linux kernel and qxl module. > Please check this patch and give me advice for me. > Also I'll be glad if there is any task that you bothered. > Than