Re: [Spice-devel] [PATCH v3 1/2] virtio-video: Add virtio video device specification

2020-04-07 Thread Dmitry Sepp
Hi Alexandre, Keiichi, Thanks for the updates, On Montag, 6. April 2020 13:46:33 CEST Keiichi Watanabe wrote: > > It seems that you're suggesting a big struct where bitstream params, > image params and all controls are merged into, right? > After rethinking, it makes sense to me. > Originally, w

Re: [Spice-devel] [PATCH v3 1/2] virtio-video: Add virtio video device specification

2020-04-07 Thread Dmitry Sepp
Hi, > +\item[VIRTIO_VIDEO_CMD_STREAM_DESTROY] Destroy a video stream > + (context) within the device. > + > +\begin{lstlisting} > +struct virtio_video_stream_destroy { > +struct virtio_video_cmd_hdr hdr; > +}; > +\end{lstlisting} Let's add more strict description to stream_destroy, like

Re: [Spice-devel] [PATCH 30/44] drm/qxl: Use devm_drm_dev_alloc

2020-04-07 Thread Daniel Vetter
On Mon, Apr 6, 2020 at 7:29 PM Thomas Zimmermann wrote: > > > > Am 03.04.20 um 15:58 schrieb Daniel Vetter: > > Also need to remove the drm_dev_put from the remove hook. > > > > Signed-off-by: Daniel Vetter > > Cc: Dave Airlie > > Cc: Gerd Hoffmann > > Cc: virtualizat...@lists.linux-foundation.