Re: [Spice-devel] [virtio-dev] Re: [PATCH v2 0/1] VirtIO video device specification

2020-01-21 Thread Keiichi Watanabe
Hi, On Tue, Jan 21, 2020 at 3:44 PM Gerd Hoffmann wrote: > > > > > Can't this problem be solved by adding "offset" field in > > > > virtio_video_mem_entry? > > > > > > > > struct virtio_video_mem_entry { > > > > le64 addr; > > > > le32 length; > > > > le32 offset; > > > > u8 padding[4];

Re: [Spice-devel] [virtio-dev] Re: [PATCH v2 0/1] VirtIO video device specification

2020-01-21 Thread Gerd Hoffmann
Hi, > > Hmm, using (ii) the API, then check whenever your three plane buffers > > happen to have the correct layout for (1) hardware looks somewhat > > backwards to me. > > Can't this problem be solved by adding "offset" field in > virtio_video_mem_entry? > > struct virtio_video_mem_entry { >

Re: [Spice-devel] [virtio-dev] Re: [PATCH v2 0/1] VirtIO video device specification

2020-01-21 Thread Keiichi Watanabe
Hi, On Mon, Jan 20, 2020 at 7:48 PM Gerd Hoffmann wrote: > > Hi, > > > > Hmm, using (ii) the API, then check whenever your three plane buffers > > > happen to have the correct layout for (1) hardware looks somewhat > > > backwards to me. > > > > Can't this problem be solved by adding "offset" f

Re: [Spice-devel] [virtio-dev] Re: [PATCH v2 0/1] VirtIO video device specification

2020-01-21 Thread Keiichi Watanabe
Hi, On Wed, Jan 15, 2020 at 8:26 PM Gerd Hoffmann wrote: > > Hi, > > > > If you have (1) hardware you simply can't import buffers with arbitrary > > > plane offsets, so I'd expect software would prefer the single buffer > > > layout (i) over (ii), even when using another driver + dmabuf > > > e

Re: [Spice-devel] [virtio-dev] Re: [PATCH v2 0/1] VirtIO video device specification

2020-01-21 Thread Gerd Hoffmann
> > > Can't this problem be solved by adding "offset" field in > > > virtio_video_mem_entry? > > > > > > struct virtio_video_mem_entry { > > > le64 addr; > > > le32 length; > > > le32 offset; > > > u8 padding[4]; > > > }; > > > > > > Here, "addr" must be the same in every mem_entry for (1)