[Spice-devel] [PATCH spice-common] quic: Use G_UNLIKELY in some hot paths

2019-10-18 Thread Frediano Ziglio
The buffers provided should be big enough to avoid to ask for more space much often. Signed-off-by: Frediano Ziglio --- common/quic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/common/quic.c b/common/quic.c index e1c439f..d24a0f6 100644 --- a/common/quic.c +++ b/comm

Re: [Spice-devel] [PATCH spice-common v3 1/3] agent-interface: introduce the core of the Agent Interface

2019-10-18 Thread Frediano Ziglio
> > When initialized (recorder_initialization), the Agent Interface launch > a GThread (handle_communications) that opens a TCP server socket and > waits for Smart Local Agent connections. When a Local Agent connects > to the sockets, the communication is initialized > (agent_initialize_communica

Re: [Spice-devel] [PATCH spice-common v2 3/3] build: Introduce 'agent' as an alternative instrumentation library

2019-10-18 Thread Kevin Pouget
On Fri, Oct 18, 2019 at 1:37 PM Kevin Pouget wrote: > > The 'agent' interface is an experimental instrumentation library for > capturing and sharing Spice performance indicators with an external > agent. > > --enable-instrumentation=[c3d-rec/agent/no] > Enable instrumentation [def

[Spice-devel] [PATCH spice-common v3 3/3] build: Introduce the agent-interface as an alternative instrumentation library

2019-10-18 Thread Kevin Pouget
The agent-interface is an experimental instrumentation library for capturing and sharing Spice performance indicators with an external agent. --enable-instrumentation=[recorder/agent/no] Enable instrumentation [default=no] The former configuration option '--enable-recorder' is tr

[Spice-devel] [PATCH spice-common v3 2/3] agent-interface: add configuration functions

2019-10-18 Thread Kevin Pouget
agent_interface_start: this function allows launching the agent interface (ie, its listening socket) on a given port. agent_interface_set_on_connect_cb: this function allows passing a callback function that will be triggered when a client (a Local Agent) connects to the Agent Interface socket. ag

[Spice-devel] [PATCH spice-common v3 1/3] agent-interface: introduce the core of the Agent Interface

2019-10-18 Thread Kevin Pouget
When initialized (recorder_initialization), the Agent Interface launch a GThread (handle_communications) that opens a TCP server socket and waits for Smart Local Agent connections. When a Local Agent connects to the sockets, the communication is initialized (agent_initialize_communication), the com

[Spice-devel] [PATCH spice-common] codegen: Ignore path generating include guards

2019-10-18 Thread Frediano Ziglio
Make sure that guard do no change building out-of-tree or with Meson. Signed-off-by: Frediano Ziglio --- python_modules/marshal.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/python_modules/marshal.py b/python_modules/marshal.py index a09b614..e9130f3 100644 --- a/pytho

[Spice-devel] [PATCH spice-common] codegen: Check unsafe values alone

2019-10-18 Thread Frediano Ziglio
This rule remove possible integer overflows. Current code generated is not affected by these integer overflows as the computations are done using 64 bit but better safe then sorry. Signed-off-by: Frediano Ziglio --- python_modules/demarshal.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletio

Re: [Spice-devel] [PATCH 0/3] Make WIX script to be useful in Windows build

2019-10-18 Thread Frediano Ziglio
> > This series contains updates of WIX(L) script and related changes: > Make it compatible with WIX (currently WIX raises error on x64 build) > Customize several properties during build of MSI > Enable prevention of x86 install on x64 system > > Available at > https://gitlab.freedesktop.org/yuri

[Spice-devel] [PATCH 3/3] win32/vd_agent: Optionally disable installation of x86 MSI on x64 system

2019-10-18 Thread Yuri Benditovich
Currently the MSI built for x86 system can be easily installed on x64 system. When the script is processed by WIX this can be prevented by passing '-dNoWOW=yes' to the WIX-candle. Signed-off-by: Yuri Benditovich --- spice-vdagent.wxs.in | 5 + 1 file changed, 5 insertions(+) diff --git a/sp

[Spice-devel] [PATCH 0/3] Make WIX script to be useful in Windows build

2019-10-18 Thread Yuri Benditovich
This series contains updates of WIX(L) script and related changes: Make it compatible with WIX (currently WIX raises error on x64 build) Customize several properties during build of MSI Enable prevention of x86 install on x64 system Available at https://gitlab.freedesktop.org/yuri_benditovich/vd_a

[Spice-devel] [PATCH 2/3] win32/vd_agent: Customize MSI product name and install location

2019-10-18 Thread Yuri Benditovich
Customize these properties of WIX script during build under WIXL or Windows. Signed-off-by: Yuri Benditovich --- Makefile.am | 5 - spice-vdagent.wxs.in | 8 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/Makefile.am b/Makefile.am index 3020824..80e82c6 1006

[Spice-devel] [PATCH 1/3] win32/vd_agent: Fix WIX error on .wxs script

2019-10-18 Thread Yuri Benditovich
Allows the same WIXL script to be used for WIX on Windows. WIX raises error if Win64 property is not set for x64 MSI. Signed-off-by: Yuri Benditovich --- spice-vdagent.wxs.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/spice-vdagent.wxs.in b/spice-vdagent.wxs.in index

[Spice-devel] [PATCH spice-common v2 3/3] build: Introduce 'agent' as an alternative instrumentation library

2019-10-18 Thread Kevin Pouget
The 'agent' interface is an experimental instrumentation library for capturing and sharing Spice performance indicators with an external agent. --enable-instrumentation=[c3d-rec/agent/no] Enable instrumentation [default=no] Former configuration option '--enable-recorder=c3d' is t

[Spice-devel] [PATCH spice-common v2 1/3] agent-interface: introduce the core of the Agent Interface

2019-10-18 Thread Kevin Pouget
When initialized (recorder_initialization), the Agent Interface launch a GThread (handle_communications) that opens a TCP server socket and waits for Smart Local Agent connections. When a Local Agent connects to the sockets, the communication is initialized (agent_initialize_communication), the com

[Spice-devel] [PATCH spice-common v2 2/3] agent-interface: add configuration functions

2019-10-18 Thread Kevin Pouget
agent_interface_start: this function allows launching the agent interface (ie, its listening socket) on a given port. agent_interface_set_on_connect_cb: this function allows passing a callback function that will be triggered when a client (a Local Agent) connects to the Agent Interface socket. ag

Re: [Spice-devel] [PATCH spice-common 3/3] build: Introduce 'agent' as an alternative instrumentation library

2019-10-18 Thread Kevin Pouget
On Fri, Oct 18, 2019 at 11:22 AM Frediano Ziglio wrote: > > > > > The 'agent' interface is an experimental instrumentation library for > > capturing and sharing Spice performance indicators with an external > > agent. > > > > --enable-instrumentation=[c3d-rec/agent/no] > > Enable

Re: [Spice-devel] [PATCH spice-common 3/3] build: Introduce 'agent' as an alternative instrumentation library

2019-10-18 Thread Frediano Ziglio
> > The 'agent' interface is an experimental instrumentation library for > capturing and sharing Spice performance indicators with an external > agent. > > --enable-instrumentation=[c3d-rec/agent/no] > Enable instrumentation [default=no] > > Former configuration option '--enable

Re: [Spice-devel] [PATCH spice-common 3/3] build: Introduce 'agent' as an alternative instrumentation library

2019-10-18 Thread Kevin Pouget
On Thu, Oct 17, 2019 at 3:30 PM Kevin Pouget wrote: > > The 'agent' interface is an experimental instrumentation library for > capturing and sharing Spice performance indicators with an external > agent. > > --enable-instrumentation=[c3d-rec/agent/no] > Enable instrumentation [def