Re: [Spice-devel] [spice-gtk v1 1/2] channel-main: add debug related to migration

2019-09-27 Thread Frediano Ziglio
> > From: Victor Toso > > Migration can start with different messages and the code could take > different paths. By having a debug on which message started can help > pinpoint issues faster. > > Signed-off-by: Victor Toso Acked-by: Frediano Ziglio Frediano > --- > src/channel-main.c | 15

Re: [Spice-devel] [PATCH 1/2] drm/qxl: stop abusing TTM to call driver internal functions

2019-09-27 Thread Frediano Ziglio
> > The ttm_mem_io_* functions are actually internal to TTM and shouldn't be > used in a driver. > As far as I can see by your second patch QXL is just using exported (that is not internal) functions. Not that the idea of making them internal is bad but this comment is a wrong statement. > Inst

[Spice-devel] [PATCH 2/2] drm/ttm: stop exporting ttm_mem_io_* functions

2019-09-27 Thread Christian König
Those are not supposed to be used by drivers. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo_util.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo_util.c b/drivers/gpu/drm/ttm/ttm_bo_util.c index 086ba2c2f60b..2eca752c39e9 100644 --- a/drivers/g

[Spice-devel] [PATCH 1/2] drm/qxl: stop abusing TTM to call driver internal functions

2019-09-27 Thread Christian König
The ttm_mem_io_* functions are actually internal to TTM and shouldn't be used in a driver. Instead call the qxl_ttm_io_mem_reserve() function directly. Signed-off-by: Christian König --- drivers/gpu/drm/qxl/qxl_drv.h| 2 ++ drivers/gpu/drm/qxl/qxl_object.c | 11 +-- drivers/gpu/drm

[Spice-devel] regression from 0.14.0 -> 0.14.2 in screen resizing

2019-09-27 Thread Jason A. Donenfeld
Hi, My distro upgraded spice from 0.14.0 to 0.14.2. This has caused screen resizing geometry problems for my Windows guest. In spicy, I experience a massive black border around the screen, as though it's getting the internal coordinates and external coordinates out of sync. This seems to go away

Re: [Spice-devel] [PATCH v8 19/20] test-cd-emu: Make sure we can call spice_usb_backend_channel_flush_writes

2019-09-27 Thread Victor Toso
Hi, Sorry if I wasn't clear before but I'm completely fine with the tests patches as well. I take that only one patch (the command line option one) isn't going to be merged as some work on the design is pending, correct? Cheers, On Thu, Sep 19, 2019 at 04:11:32PM +0200, Victor Toso wrote: > From

Re: [Spice-devel] [spice-streaming-agent PATCH 4/4] Prepare for v0.3 release

2019-09-27 Thread Frediano Ziglio
> > 1. update NEWS > 2. update configure.ac > 3. update spec file > > Signed-off-by: Uri Lublin > --- > NEWS | 17 + > configure.ac | 2 +- > spice-streaming-agent.spec.in | 3 +++ > 3 files changed, 21 insertions(+), 1 deletion(-) >

Re: [Spice-devel] [spice-streaming-agent PATCH 3/4] Add a man page

2019-09-27 Thread Frediano Ziglio
> > --- > Makefile.am | 2 + > spice-streaming-agent.1 | 78 +++ > spice-streaming-agent.spec.in | 1 + > 3 files changed, 81 insertions(+) > create mode 100644 spice-streaming-agent.1 > > diff --git a/Makefile.am b/Makefile.am > index 9

Re: [Spice-devel] [EXTERNAL] Re: Dependency failed for Activation socket for spice guest agent daemon

2019-09-27 Thread Priya, Nupur
I am not using spice-vdagent, in my ISO, even though getting below dependency error during installation itself. On Thu, Sep 26, 2019 at 11:24:45AM +, Priya, Nupur wrote: > Hi All, > > The fix provided at link https://bugzilla.redhat.com/show_bug.cgi?id=1545212, > does not work on boot mess