Re: [Spice-devel] [PATCH spice-server v2 1/2] char-device: Don't use RedClient API

2019-08-30 Thread Frediano Ziglio
ping > > ping > > > > > ping > > > > > > > > ping > > > > > > > > > > > ping > > > > > > > > > > > > > > ping > > > > > > > > > > > ping > > > > > > > > > > > > > > > > > > > > ping the series > > > > > > > > > > > > > > > > > > > > > > > RedClient was an opaque structure for RedChar

Re: [Spice-devel] [PATCH spice-server v2 1/4] spicevmc: Do not use RedCharDevice pipe items handling

2019-08-30 Thread Frediano Ziglio
ping > > ping > > > > > ping > > > > > > > > ping > > > > > > > > > > > ping > > > > > > > > > > > > > > ping the series > > > > > > > > > > > > > > > > > As we don't use any token there's no reason to not queue directly > > > > > > instead > > > > > > of passing through RedCharDevice.

Re: [Spice-devel] [PATCH spice-server 1/2] event-loop: Move adapter interface from reds.c

2019-08-30 Thread Frediano Ziglio
ping > > ping the series > > > > > Put more event loop code in event-loop.c. > > This is a preparation patch for the next one. > > > > Signed-off-by: Frediano Ziglio > > --- > > server/event-loop.c | 58 + > > server/red-common.h | 1 + > > server

Re: [Spice-devel] [PATCH spice-gtk 1/3] usb-backend: Cache isochronous value

2019-08-30 Thread Frediano Ziglio
ping > > ping > > > > > ping the series > > > > > > > > Allows to remove _SpiceUsbDevice structure. > > > _SpiceUsbDevice is only caching this value from SpiceUsbBackendDevice. > > > > > > Signed-off-by: Frediano Ziglio > > > --- > > > src/usb-backend.c | 9 + > > > 1 file changed,

Re: [Spice-devel] [PATCH spice-gtk v4 24/29] usb-backend: Rewrite USB emulation support

2019-08-30 Thread Frediano Ziglio
> > Frediano Ziglio writes: > > >> > >> It's slightly better, but I was more thinking about adding (later) a > >> comment to spice_usbredir_write_callback, in order to indicate that it > >> does NOT deal with the HELLO packet, i.e. that the data processing logic > >> is split between the two laye

Re: [Spice-devel] [PATCH spice-server] meson: Fix compatibility with Meson 0.48

2019-08-30 Thread Eduardo Lima (Etrunko)
On 8/29/19 1:10 PM, Frediano Ziglio wrote: > The "install" argument for configure_file is available since 0.50. > However this is already "false" if "install_dir" is not provided. > > This will drop the following warning: > "Project targetting '>= 0.48' but tried to use feature introduced > in '0.

Re: [Spice-devel] [PATCH spice-gtk v4 24/29] usb-backend: Rewrite USB emulation support

2019-08-30 Thread Christophe de Dinechin
Frediano Ziglio writes: >> >> It's slightly better, but I was more thinking about adding (later) a >> comment to spice_usbredir_write_callback, in order to indicate that it >> does NOT deal with the HELLO packet, i.e. that the data processing logic >> is split between the two layers. >> > > Oh...