>
> Upon failure, write a warning message and continue
>
> Found-by: covscan
>
> Signed-off-by: Uri Lublin
> ---
>
> v1->v2: added a check for fopen too.
>
> ---
> src/vdagentd/vdagentd.c | 7 ++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/src/vdagentd/vdagentd.c
>
> A comment and curly brackets for style were added.
>
> Signed-off-by: Uri Lublin
Acked-by: Frediano Ziglio
> ---
>
> v1->v2: use shorter version (alternative of v1)
> add curly brackets to if blocks
>
> ---
> src/vdagentd/virtio-port.c | 10 +-
> 1 file changed, 5 inser
Upon failure, write a warning message and continue
Found-by: covscan
Signed-off-by: Uri Lublin
---
v1->v2: added a check for fopen too.
---
src/vdagentd/vdagentd.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/vdagentd/vdagentd.c b/src/vdagentd/vdagentd.c
inde
A comment and curly brackets for style were added.
Signed-off-by: Uri Lublin
---
v1->v2: use shorter version (alternative of v1)
add curly brackets to if blocks
---
src/vdagentd/virtio-port.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/vdagentd/vi
>
> This patch allows the MJPEG encoder to inform the spice-widget that
> its video drawing area (draw-area) should be made visible on screen.
>
> This is required to switch from GST video decoding to native MJPEG
> decoding, otherwise the gst-area remained on top and the MJPEG video
> stream was
> Frediano Ziglio writes:
>
> > Do not use G_GUINT32_FORMAT.
> > We support a minimum of 32 bit architectures.
>
> What was wrong with the old code?
>
Shorter and easier to read. I mean '%u' and '%" G_GUINT32_FORMAT "',
if you have an issue is harder to get it.
For instance it was hard to spot
The "install" argument for configure_file is available since 0.50.
However this is already "false" if "install_dir" is not provided.
This will drop the following warning:
"Project targetting '>= 0.48' but tried to use feature introduced
in '0.50.0': install arg in configure_file"
Signed-off-by: F
>
> On 8/29/19 1:26 AM, Frediano Ziglio wrote:
> > This will drop the following warning:
> > "Project targetting '>= 0.48.0' but tried to use feature introduced
> > in '0.50.0': install arg in configure_file"
> >
> > This brings in the following changes:
> >
> > Frediano Ziglio (5):
> > co
Frediano Ziglio writes:
> Do not use G_GUINT32_FORMAT.
> We support a minimum of 32 bit architectures.
What was wrong with the old code?
If you want to get rid of G_ macro dependencies, why not use PRIu32?
> ---
> src/cd-usb-bulk-msd.c | 53 +--
> 1 fil
On 8/29/19 1:04 AM, Frediano Ziglio wrote:
> The "install" argument for configure_file is available since 0.50.
> However this is already "false" if "install_dir" is not provided.
>
> Update also spice-common submodule to import a similar fix for
> spice-common module. This brings in the following
On 8/29/19 1:26 AM, Frediano Ziglio wrote:
> This will drop the following warning:
> "Project targetting '>= 0.48.0' but tried to use feature introduced
> in '0.50.0': install arg in configure_file"
>
> This brings in the following changes:
>
> Frediano Ziglio (5):
> codegen: Use has_end_at
This patch allows the MJPEG encoder to inform the spice-widget that
its video drawing area (draw-area) should be made visible on screen.
This is required to switch from GST video decoding to native MJPEG
decoding, otherwise the gst-area remained on top and the MJPEG video
stream was never shown.
>
> Preamble: Apologies for screwing up the formatting so badly in my last
> reply. Trying to repair a little manually here.
>
> Frediano Ziglio writes:
>
> > On 28 Aug 2019, at 12:16, Frediano Ziglio wrote:
> > > > I have the feeling I didn't get what you wanted to say.
> >
> > > I meant: what
Preamble: Apologies for screwing up the formatting so badly in my last
reply. Trying to repair a little manually here.
Frediano Ziglio writes:
> On 28 Aug 2019, at 12:16, Frediano Ziglio wrote:
> > > I have the feeling I didn't get what you wanted to say.
>
> > I meant: what is the separation of
>
> This patch allows the MJPEG encoder to inform the spice-widget that
> its video drawing area (draw-area) should be made visible on screen.
>
> This is required to switch from GST video decoding to native MJPEG
> decoding, otherwise the gst-area remained on top and the MJPEG video
> stream wa
This patch allows the MJPEG encoder to inform the spice-widget that
its video drawing area (draw-area) should be made visible on screen.
This is required to switch from GST video decoding to native MJPEG
decoding, otherwise the gst-area remained on top and the MJPEG video
stream was never shown.
Hello,
On Wed, Aug 14, 2019 at 3:08 PM Frediano Ziglio wrote:
>
> >
> > This patch enables the SPICE_DISPLAY_CAP_PREF_VIDEO_CODEC_TYPE
> > capability for the stream-channel.
> >
> > video_stream_parse_preferred_codecs: new function for parsing the
> > SPICE protocol message. This code used to be
17 matches
Mail list logo
