Re: [Spice-devel] [PATCH] drm/qxl: fix a memory leak bug

2019-08-19 Thread Gerd Hoffmann
On Mon, Aug 19, 2019 at 01:08:18PM -0500, Wenwen Wang wrote: > In qxl_bo_create(), the temporary 'bo' is allocated through kzalloc(). > However, it is not deallocated in the following execution if ttm_bo_init() > fails, leading to a memory leak bug. To fix this issue, free 'bo' before > returning t

[Spice-devel] [PATCH x11spice v4 2/3] Create separate shm_segment_t struct for SHM segments

2019-08-19 Thread Brendan Shanks
Signed-off-by: Brendan Shanks --- doc/spice_indent | 1 + src/display.c| 30 +++--- src/display.h| 8 ++-- src/scan.c | 2 +- src/session.c| 2 +- src/spice.c | 2 +- 6 files changed, 25 insertions(+), 20 deletions(-) diff --git a/doc/spice

[Spice-devel] [PATCH x11spice v4 1/3] Use unsigned int/size_t for display width/height/buffer size

2019-08-19 Thread Brendan Shanks
Signed-off-by: Brendan Shanks --- src/display.c | 8 src/display.h | 14 +++--- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/display.c b/src/display.c index 77b4d4e..3294f83 100644 --- a/src/display.c +++ b/src/display.c @@ -59,7 +59,7 @@ static xcb_scree

[Spice-devel] [PATCH x11spice v4 3/3] Add cache for SHM segments

2019-08-19 Thread Brendan Shanks
Add a cache to allow the reuse of SHM segments. Shared memory segments are added to the cache instead of being deallocated, and the cache is searched instead of/before allocating a new segment. Both the SHM segments and their attachment with the X server are cached. The cache currently has a fixe

[Spice-devel] [PATCH x11spice v4 0/3] Add cache for SHM segments

2019-08-19 Thread Brendan Shanks
Add a cache to x11spice for SHM segments. v4 simplifies the 'if' clauses in shm_cache_get/add, as suggested by Frediano. Brendan Shanks (3): Use unsigned int/size_t for display width/height/buffer size Create separate shm_segment_t struct for SHM segments Add cache for SHM segments doc/sp

[Spice-devel] [PATCH] drm/qxl: fix a memory leak bug

2019-08-19 Thread Wenwen Wang
In qxl_bo_create(), the temporary 'bo' is allocated through kzalloc(). However, it is not deallocated in the following execution if ttm_bo_init() fails, leading to a memory leak bug. To fix this issue, free 'bo' before returning the error. Signed-off-by: Wenwen Wang --- drivers/gpu/drm/qxl/qxl_o

Re: [Spice-devel] USB redirection: "LIBUSB_ERROR_NOT_SUPPORTED"

2019-08-19 Thread Yuri Benditovich
Hi Brian, Which backend you use on your Spice Client machine, UsbDk or WinUsb? What is the version of remote-viewer and the version of libusb-1.0.dll (it should be in the same directory when remote-viewer.exe) I'd also suggest to make a debug log (usually "remote-viewer ... --spice-debug > log.txt

[Spice-devel] USB redirection: "LIBUSB_ERROR_NOT_SUPPORTED"

2019-08-19 Thread Brian Wengel
Hi Spice-devs I'm trying to get some USB headsets to work on a VM (Win10 x64) using spice USB redirection, but I get the error "*LIBUSB_ERROR_NOT_SUPPORTED*". Is it a misconfiguration or is the device really not supported? I've added a ich9 USB controller on the VM: On my VM: [imag