[Spice-devel] [PATCH spice-common] codegen: Add 'chunk' to the output attributes

2019-08-14 Thread Frediano Ziglio
Output attributes are the attributes that specify how to store that field in the C structure. There can be only one output type specified. Signed-off-by: Frediano Ziglio --- python_modules/ptypes.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python_modules/ptypes.py b/py

[Spice-devel] [PATCH spice-common v2] codegen: Check validity of array members

2019-08-14 Thread Frediano Ziglio
Check that combination of fields for an array does not lead to unsafe code. check_valid method came from generate_c_declaration with some more check and it's use in demarshaller to validate the array if the structure is not generated. Signed-off-by: Frediano Ziglio --- python_modules/demarshal.p

Re: [Spice-devel] [PATCH spice-common 4/4] codegen: Check validity of array members

2019-08-14 Thread Frediano Ziglio
> > On 8/13/19 7:56 PM, Frediano Ziglio wrote: > > Check that combination of fields for an array does not > > lead to unsafe code. > > check_valid method came from generate_c_declaration with > > some more check and it's use in demarshaller to validate > > the array if the structure is not generat

Re: [Spice-devel] [PATCH spice-common 4/4] codegen: Check validity of array members

2019-08-14 Thread Uri Lublin
On 8/13/19 7:56 PM, Frediano Ziglio wrote: Check that combination of fields for an array does not lead to unsafe code. check_valid method came from generate_c_declaration with some more check and it's use in demarshaller to validate the array if the structure is not generated. Signed-off-by: Fre

Re: [Spice-devel] [PATCH spice-common 2/4] codegen: Add a check for C structure fields

2019-08-14 Thread Uri Lublin
On 8/13/19 7:56 PM, Frediano Ziglio wrote: This check make sure that output fields for member with @end (arrays) are declared as empty arrays in output C structure. This avoids output fields to be declared as pointer or other invalid types. The check is a compile time check so no code in object f

Re: [Spice-devel] [RFC spice-server 1/3] stream-channel: Add preferred video codec capability

2019-08-14 Thread Frediano Ziglio
> > This patch enables the SPICE_DISPLAY_CAP_PREF_VIDEO_CODEC_TYPE > capability for the stream-channel. > > video_stream_parse_preferred_codecs: new function for parsing the > SPICE protocol message. This code used to be inside > dcc_handle_preferred_video_codec_type. > > struct StreamChannelCli

Re: [Spice-devel] [Intel-gfx] [PATCH v6 08/17] drm/ttm: use gem vma_node

2019-08-14 Thread Thierry Reding
On Wed, Aug 14, 2019 at 07:58:27AM +0200, Gerd Hoffmann wrote: > > Hi Gerd, > > > > I've been seeing a regression on Nouveau with recent linux-next releases > > and git bisect points at this commit as the first bad one. If I revert > > it (there's a tiny conflict with a patch that was merged subse

Re: [Spice-devel] [RFC spice-streaming-agent 4/4] concrete-agent: prioritize requested codec for plugin selection

2019-08-14 Thread Frediano Ziglio
> > On Mon, Aug 12, 2019 at 9:43 AM Frediano Ziglio wrote: > > > > > > > > This patch gives more priority to the requested video codecs when > > > selecting the FrameCapture plugin, instead of its hard-coded rank. > > > > > > The client_codecs storage structure is changed from 'set' to 'vector',

Re: [Spice-devel] [Intel-gfx] [PATCH v6 08/17] drm/ttm: use gem vma_node

2019-08-14 Thread Gerd Hoffmann
Hi, > > Changing the order doesn't look hard. Patch attached (untested, have no > > test hardware). But maybe I missed some detail ... > > I came up with something very similar by splitting up nouveau_bo_new() > into allocation and initialization steps, so that when necessary the GEM > object

Re: [Spice-devel] [PATCH spice-common] protocol: Removed unneeded type specifications

2019-08-14 Thread Uri Lublin
On 8/14/19 11:48 AM, Frediano Ziglio wrote: Default type is already uint8_t. Signed-off-by: Frediano Ziglio Ack. Uri. --- spice.proto | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/spice.proto b/spice.proto index 3bbec0c..34ba3c8 100644 --- a/spice.proto +++ b/s

[Spice-devel] [PATCH spice-common] protocol: Removed unneeded type specifications

2019-08-14 Thread Frediano Ziglio
Default type is already uint8_t. Signed-off-by: Frediano Ziglio --- spice.proto | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/spice.proto b/spice.proto index 3bbec0c..34ba3c8 100644 --- a/spice.proto +++ b/spice.proto @@ -109,7 +109,7 @@ message Empty { } @declare;