Hi,
On 8/5/19 7:11 PM, Frediano Ziglio wrote:
Hi Snir,
there were some notes at
https://patchwork.freedesktop.org/patch/288568/?series=57199&rev=1
and
https://patchwork.freedesktop.org/patch/288569/?series=57199&rev=1
This patch [2/3] is not needed we pushed another one which
extracts the d
ping
On 2/27/19 1:26 PM, Snir Sheriber wrote:
This Makefile script is invoked by copr to build source rpm
See: https://docs.pagure.org/copr.copr/user_documentation.html#make-srpm
---
Changes from v1 are script improvements and description
---
.copr/Makefile | 21 +
1 fi
Hi Brendan,
Nicely done; this solves the problem I had with repeated test runs.
I have one trivial change to request:
On 8/5/19 2:12 PM, Brendan Shanks wrote:
The 'display->fullscreen' SHM segment was previously being used for both
x11spice's internal change scanning and as the spice primary s
On 8/5/19 1:19 PM, Brendan Shanks wrote:
Check the Debian/Ubuntu path for the non-wrapper Xorg binary
Signed-off-by: Brendan Shanks
Acked-by: Jeremy White
---
src/tests/xdummy.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/tests/xdummy.c b/src/tests/xdummy.c
index 0651dc7..
Correct a typo from the upstream atKeynames.js at the same time.
Signed-off-by: Jeremy White
---
src/atKeynames.js | 2 +-
src/utils.js | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/atKeynames.js b/src/atKeynames.js
index 110e9e9..767e78b 100644
--- a/src/atKeyn
The common scan codes were disjointed and logically belong together.
Signed-off-by: Jeremy White
---
src/utils.js | 101 +--
1 file changed, 57 insertions(+), 44 deletions(-)
diff --git a/src/utils.js b/src/utils.js
index 5059a5b..79e3e5e 100644
-
This is effectively v2 of 'Adjust the presentation of two byte scan codes.'
It breaks out a part of the patch separately. In reviewing this,
I caught a number of other issues. One warranted a patch (included).
For the rest, I chose to 'fix' it by updating the documentation,
which was a bit out o
The keypad minus key at 109 is common between at least Chrome and Firefox.
Signed-off-by: Jeremy White
---
src/utils.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/utils.js b/src/utils.js
index f12edf9..5059a5b 100644
--- a/src/utils.js
+++ b/src/utils.js
@@ -211,6 +2
The previous implementation worked strictly due to a bug which would
luckily generate roughly the right scan codes, although we would send
more codes than required.
For example, the old implementation would send 0xdf48e0 for 'up key down'
and '0xdfc8e0' for 'up key up'. The prepended 0xdf is inco
The 'display->fullscreen' SHM segment was previously being used for both
x11spice's internal change scanning and as the spice primary surface.
I don't think spice wants anything else writing to the primary surface,
and this caused sporadic test failures and graphical corruption.
Create a separate
Check the Debian/Ubuntu path for the non-wrapper Xorg binary
Signed-off-by: Brendan Shanks
---
src/tests/xdummy.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/tests/xdummy.c b/src/tests/xdummy.c
index 0651dc7..ce57b1c 100644
--- a/src/tests/xdummy.c
+++ b/src/tests/xdummy.c
@@ -157,
>
> The previous implementation worked strictly due to a bug which would
> luckily generate roughly the right scan codes, although we would send
> more codes than required.
>
> For example, the old implementation would send 0xdf48e0 for 'up key down'
> and '0xdfc8e0' for 'up key up'. Essentially
Hi Snir,
there were some notes at
https://patchwork.freedesktop.org/patch/288568/?series=57199&rev=1
and
https://patchwork.freedesktop.org/patch/288569/?series=57199&rev=1
some not addressed.
Also patch #3 was merged, maybe would be worth to send an updated
version.
(series at https://patchwork.
The previous implementation worked strictly due to a bug which would
luckily generate roughly the right scan codes, although we would send
more codes than required.
For example, the old implementation would send 0xdf48e0 for 'up key down'
and '0xdfc8e0' for 'up key up'. Essentially, it stored the
ping
On 2/25/19 4:56 PM, Snir Sheriber wrote:
---
.copr/Makefile | 21 +
1 file changed, 21 insertions(+)
create mode 100644 .copr/Makefile
diff --git a/.copr/Makefile b/.copr/Makefile
new file mode 100644
index 000..53b1b1b
--- /dev/null
+++ b/.copr/Makefile
@@ -0
Drop vma_node from ttm_buffer_object, use the gem struct
(base.vma_node) instead.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 2 +-
drivers/gpu/drm/qxl/qxl_object.h | 2 +-
drivers/gpu/drm/radeon/radeon_object.h | 2 +-
Drop drm_gem_object from qxl_bo, use the
ttm_buffer_object.base instead.
Signed-off-by: Gerd Hoffmann
Acked-by: Christian König
---
drivers/gpu/drm/qxl/qxl_drv.h | 6 +++---
drivers/gpu/drm/qxl/qxl_object.h | 4 ++--
drivers/gpu/drm/qxl/qxl_cmd.c | 4 ++--
drivers/gpu/drm/qxl/qxl_de
Signed-off-by: Gerd Hoffmann
Acked-by: Christian König
---
drivers/gpu/drm/qxl/qxl_debugfs.c | 2 +-
drivers/gpu/drm/qxl/qxl_release.c | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/qxl/qxl_debugfs.c
b/drivers/gpu/drm/qxl/qxl_debugfs.c
index bdb5ac098
ping
> ping the series
>
> >
> > Don't call close but socket_close.
> >
> > Signed-off-by: Frediano Ziglio
> > ---
> > server/tests/test-websocket.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > Currently the executable cannot run on Windows but it does not hurt
> > t
ping
>
> On LLP64 platforms (like Windows) a virtual address cannot
> be represented by a "unsigned long" type, so use uintptr_t
> which is defined as a integral type large like a pointer.
> "address_delta" is a difference of pointers so use same
> type size.
>
> Signed-off-by: Frediano Ziglio
ping the series
>
> Signed-off-by: Frediano Ziglio
> ---
> server/tests/replay.c | 18 ++
> 1 file changed, 6 insertions(+), 12 deletions(-)
>
> diff --git a/server/tests/replay.c b/server/tests/replay.c
> index e3ef7bf15..992f26d63 100644
> --- a/server/tests/replay.c
> +++ b/
ping
>
> On 32 systems pointers are 32 bit while QXLPHYSICAL is always
> 64 bit.
> Using pointer -> intptr_t -> QXLPHYSICAL conversion cause pointers
> to have higher 32 bit set to 1 if the address is >= 0x8000.
> This is possible depending on address space.
> The QXLPHYSICAL is split in 3 se
ping
>
> Signed-off-by: Frediano Ziglio
> ---
> src/usb-device-manager.c | 14 ++
> 1 file changed, 10 insertions(+), 4 deletions(-)
>
> Changes since v1:
> - conver a debug into warning to inform the user at least one time
>
> diff --git a/src/usb-device-manager.c b/src/usb-devic
Drop vma_node from ttm_buffer_object, use the gem struct
(base.vma_node) instead.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 2 +-
drivers/gpu/drm/qxl/qxl_object.h | 2 +-
drivers/gpu/drm/radeon/radeon_object.h | 2 +-
Drop drm_gem_object from qxl_bo, use the
ttm_buffer_object.base instead.
Signed-off-by: Gerd Hoffmann
Acked-by: Christian König
---
drivers/gpu/drm/qxl/qxl_drv.h | 6 +++---
drivers/gpu/drm/qxl/qxl_object.h | 4 ++--
drivers/gpu/drm/qxl/qxl_cmd.c | 4 ++--
drivers/gpu/drm/qxl/qxl_de
Signed-off-by: Gerd Hoffmann
Acked-by: Christian König
---
drivers/gpu/drm/qxl/qxl_debugfs.c | 2 +-
drivers/gpu/drm/qxl/qxl_release.c | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/qxl/qxl_debugfs.c
b/drivers/gpu/drm/qxl/qxl_debugfs.c
index bdb5ac098
On Mon, Aug 5, 2019 at 3:17 PM Frediano Ziglio wrote:
>
> >
> > On Mon, Aug 5, 2019 at 12:58 PM Frediano Ziglio wrote:
> > >
> > > >
> > > > SpiceUsbBackendDevice structure is extended to support
> > > > additional kind of device that is emulated by Spice-GTK
> > > > and not present locally (and
>
> On Mon, Aug 5, 2019 at 12:58 PM Frediano Ziglio wrote:
> >
> > >
> > > SpiceUsbBackendDevice structure is extended to support
> > > additional kind of device that is emulated by Spice-GTK
> > > and not present locally (and does not have libusb_device),
> > > such device has instead pointer to
On Mon, Aug 5, 2019 at 12:58 PM Frediano Ziglio wrote:
>
> >
> > SpiceUsbBackendDevice structure is extended to support
> > additional kind of device that is emulated by Spice-GTK
> > and not present locally (and does not have libusb_device),
> > such device has instead pointer to SpiceUsbEmulated
qxl has two modes: "native" (used by the drm driver) and "vga" (vga
compatibility mode, typically used for boot display and firmware
framebuffers).
Accessing any vga ioport will switch the qxl device into vga mode.
The qxl driver never does that, but other drivers accessing vga ports
can trigger t
Hi,
> > + ret = vga_get_interruptible(pdev, VGA_RSRC_LEGACY_IO);
> > + if (ret) {
> > + DRM_ERROR("can't get legacy vga ports\n");
> > + goto put_vga;
>
> I suppose that if this fails it's secondary so should continue.
Ah, right, there are secondary qxl cards (without t
>
> Signed-off-by: Yuri Benditovich
Acked-by: Frediano Ziglio
> ---
> src/channel-usbredir.c | 31 +++
> 1 file changed, 15 insertions(+), 16 deletions(-)
>
> diff --git a/src/channel-usbredir.c b/src/channel-usbredir.c
> index 8d4cd66..8fd6b41 100644
> --- a/src/
>
> For local USB device the USB backend returns the same device
> description as spice-usb-manager did, for emulated devices it
> uses the description provided by device's implementation.
>
> Signed-off-by: Yuri Benditovich
> ---
> src/usb-backend.c| 41
>
> SpiceUsbBackendDevice structure is extended to support
> additional kind of device that is emulated by Spice-GTK
> and not present locally (and does not have libusb_device),
> such device has instead pointer to SpiceUsbEmulatedDevice
> abstract structure. Specific implementation of such device
>
> qxl has two modes: "native" (used by the drm driver) and "vga" (vga
> compatibility mode, typically used for boot display and firmware
> framebuffers).
>
> Accessing any vga ioport will switch the qxl device into vga mode.
> The qxl driver never does that, but other drivers accessing vga port
qxl has two modes: "native" (used by the drm driver) and "vga" (vga
compatibility mode, typically used for boot display and firmware
framebuffers).
Accessing any vga ioport will switch the qxl device into vga mode.
The qxl driver never does that, but other drivers accessing vga ports
can trigger t
36 matches
Mail list logo
