Re: [Spice-devel] [spice-gtk 2/5] usb-redir: unify device hotplug/unplug for Windows and Linux

2019-07-21 Thread Yuri Benditovich
On Fri, Jul 19, 2019 at 1:14 PM Victor Toso wrote: > > Hi, > > On Sun, Jul 14, 2019 at 05:07:38PM +0300, Yuri Benditovich wrote: > > Remove Windows-specific part of hotplug detection from > > usb-device-manager and win-usb-dev and place it into > > USB backend module. Connect the hotplug/unplug de

[Spice-devel] [PATCH v3 spice-streaming-agent] gst-plugin: receive encoder properties as command parameters

2019-07-21 Thread Snir Sheriber
This allows to set plugin key=value properties on run time. To add encoder plugin property use the following syntax: -c gst.prop="property=value" -c gst.prop="property2=value2"... Make sure syntax is accurate and that the property is supported by the chosen plugin, wrong properties may ignored sile

Re: [Spice-devel] [PATCH spice-protocol] start-packet: Correct misleading comment

2019-07-21 Thread Snir Sheriber
Acked-by: Snir Sheriber Oh, got it, makes sense! Thanks On 7/18/19 6:50 PM, Frediano Ziglio wrote: Signed-off-by: Frediano Ziglio --- spice/start-packed.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/spice/start-packed.h b/spice/start-packed.h index de0c595..d1

Re: [Spice-devel] [PATCH spice-protocol 1/2 v2] qxl_dev: Fix alignment for QXLReleaseInfo

2019-07-21 Thread Snir Sheriber
On 7/18/19 6:37 PM, Frediano Ziglio wrote: On 7/18/19 5:51 PM, Frediano Ziglio wrote: Hi, IIRC this was related to some compiler warning, no? Yes, recent compilers are reporting it, see below. If it is I'd mentioning it , otherwise, ack. Just this patch or the entire series? No, actua