Re: [Spice-devel] [PATCH spice-server v2] test-codecs-parsing: On bad codec string spice_server_set_video_codecs can fail

2019-07-07 Thread Snir Sheriber
Acked-by: Snir Sheriber The 0 result means success however the function (correctly) could report a failure if the string is incorrect. This fixes the test after commit b4150de3cd0e56d4ce43a99ef5c3c5f5cbdfc4a3 ("spice_server_set_video_codecs: fail when no codec can be installed"). Signed-off-by:

[Spice-devel] [PATCH spice-server v2] red-qxl: Better encapsulation of device display information

2019-07-07 Thread Frediano Ziglio
Do not expose multiple functions to fetch different parts of internal structure. Signed-off-by: Frediano Ziglio --- server/red-qxl.c | 34 +- server/red-qxl.h | 4 +--- server/reds.c| 19 +-- 3 files changed, 23 insertions(+), 34 deletions(-)

Re: [Spice-devel] [PATCH spice-server] test-codecs-parsing: On bad codec string spice_server_set_video_codecs can fail

2019-07-07 Thread Frediano Ziglio
> > Hi, > > On 7/5/19 4:09 PM, Frediano Ziglio wrote: > > The 0 result means success however the function (correctly) could > > report a failure if the string is incorrect. > > This fixes the test after commit b4150de3cd0e56d4ce43a99ef5c3c5f5cbdfc4a3 > > ("spice_server_set_video_codecs: fail when

[Spice-devel] [PATCH spice-server v2] test-codecs-parsing: On bad codec string spice_server_set_video_codecs can fail

2019-07-07 Thread Frediano Ziglio
The 0 result means success however the function (correctly) could report a failure if the string is incorrect. This fixes the test after commit b4150de3cd0e56d4ce43a99ef5c3c5f5cbdfc4a3 ("spice_server_set_video_codecs: fail when no codec can be installed"). Signed-off-by: Frediano Ziglio --- serv

Re: [Spice-devel] [PATCH spice-server] test-codecs-parsing: On bad codec string spice_server_set_video_codecs can fail

2019-07-07 Thread Snir Sheriber
Hi, On 7/5/19 4:09 PM, Frediano Ziglio wrote: The 0 result means success however the function (correctly) could report a failure if the string is incorrect. This fixes the test after commit b4150de3cd0e56d4ce43a99ef5c3c5f5cbdfc4a3 ("spice_server_set_video_codecs: fail when no codec can be instal

Re: [Spice-devel] [PATCH spice-server] red-qxl: Better encapsulation of device display information

2019-07-07 Thread Snir Sheriber
Hi, On 7/5/19 6:47 PM, Frediano Ziglio wrote: Do not expose multiple function to fetch different part of internal structures. shouldn't be "Do not expose multiple functions to fetch different parts of internal structure." ? Signed-off-by: Frediano Ziglio --- server/red-qxl.c | 36 ++