> In red_pipe_replace_rendered_drawables_with_images, the
> value of pipe_item is re-written on the next iteration.
>
> Since a78a7d251042892182b158650291d19a85bbd6b1 pipe_item
> is no longer used to control the loop.
>
> Found by Covscan.
>
> Signed-off-by: Uri Lublin
> ---
> server/dcc-sen
In red_pipe_replace_rendered_drawables_with_images, the
value of pipe_item is re-written on the next iteration.
Since a78a7d251042892182b158650291d19a85bbd6b1 pipe_item
is no longer used to control the loop.
Found by Covscan.
Signed-off-by: Uri Lublin
---
server/dcc-send.c | 1 -
1 file change
>
> unknow-> unknown
> garanteed -> guaranteed
> preceed -> precede
>
> Uri Lublin (3):
> typo: dcc: fix the spelling of unknown
> typo: image-encoders: fix the spelling of guaranteed
> typo: fix the spelling of precede
>
> server/dcc.c | 2 +-
> server/glz-encoder-dic
---
Is "Client has sent an unknown ..." better ?
Or "Client sent an unknown ... "
---
server/dcc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/dcc.c b/server/dcc.c
index 71d09b77f..bd393e040 100644
--- a/server/dcc.c
+++ b/server/dcc.c
@@ -1177,7 +1177,7 @@ stat
unknow-> unknown
garanteed -> guaranteed
preceed -> precede
Uri Lublin (3):
typo: dcc: fix the spelling of unknown
typo: image-encoders: fix the spelling of guaranteed
typo: fix the spelling of precede
server/dcc.c | 2 +-
server/glz-encoder-dict.c | 2 +-
server/gstr
---
server/image-encoders.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/image-encoders.c b/server/image-encoders.c
index d4d486c36..81dc076a8 100644
--- a/server/image-encoders.c
+++ b/server/image-encoders.c
@@ -217,7 +217,7 @@ static void encoder_data_reset(Encoder
---
server/glz-encoder-dict.c | 2 +-
server/gstreamer-encoder.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/server/glz-encoder-dict.c b/server/glz-encoder-dict.c
index c3c4606c6..7bf16bfb2 100644
--- a/server/glz-encoder-dict.c
+++ b/server/glz-encoder-dict.c
@@ -410,7
On Wed, Jul 3, 2019 at 2:47 PM Frediano Ziglio wrote:
>
> >
> > Fedora 30 / gcc 9.1.1 20190503 (Red Hat 9.1.1-1) fails to build
> > because of this error/warning:
> >
> > > gstreamer-encoder.c: In function 'set_video_bit_rate':
> > > gstreamer-encoder.c:518:17: error: taking the absolute value of
>
> Fedora 30 / gcc 9.1.1 20190503 (Red Hat 9.1.1-1) fails to build
> because of this error/warning:
>
> > gstreamer-encoder.c: In function 'set_video_bit_rate':
> > gstreamer-encoder.c:518:17: error: taking the absolute value of
> > unsigned type 'uint64_t' {aka 'long unsigned int'} has no effec
Fedora 30 / gcc 9.1.1 20190503 (Red Hat 9.1.1-1) fails to build
because of this error/warning:
> gstreamer-encoder.c: In function 'set_video_bit_rate':
> gstreamer-encoder.c:518:17: error: taking the absolute value of
> unsigned type 'uint64_t' {aka 'long unsigned int'} has no effect
> [-Werror=ab
>
> The current approach with OutputQueue in webdav has several problems:
>
> * if the connection is slow, webdav keeps reading from phodav
> and pushing messages to the internal channel xmit_queue.
> This way, the queue can grow very quickly and the whole file
> that is being transferred using w
>
> Code dealing with nanosecond timestamps normally uses 64 bit integers
> and not long long ints. So this makes it easier to print the value of
> expressions using these constants.
>
> Signed-off-by: Francois Gouget
> ---
>
> v3: https://lists.freedesktop.org/archives/spice-devel/2019-June/04
Code dealing with nanosecond timestamps normally uses 64 bit integers
and not long long ints. So this makes it easier to print the value of
expressions using these constants.
Signed-off-by: Francois Gouget
---
v3: https://lists.freedesktop.org/archives/spice-devel/2019-June/049361.html
v4: Follo
The current approach with OutputQueue in webdav has several problems:
* if the connection is slow, webdav keeps reading from phodav
and pushing messages to the internal channel xmit_queue.
This way, the queue can grow very quickly and the whole file
that is being transferred using webdav essential
On Wed, 26 Jun 2019, Uri Lublin wrote:
[...]
> > I'd very much prefer the cast to be in the expression rather than hidden
> > in some far away macro.
>
> Is that true even if the cast is needed in all the expressions
> that use this constant ?
Yes.
That's far from being the case though.
I count
Acked-by: Jakub Janků
On Wed, Jul 3, 2019 at 11:42 AM Frediano Ziglio wrote:
>
> Reduce number of write to the channel.
> This will also help making the write to socket all asynchronous
> avoiding potential blockages.
>
> Signed-off-by: Frediano Ziglio
> ---
> Changes sinve v1:
> - make "mux" a
From: Jakub Janků
The current approach with OutputQueue in webdav has several problems:
* if the connection is slow, webdav keeps reading from phodav
and pushing messages to the internal channel xmit_queue.
This way, the queue can grow very quickly and the whole file
that is being transferred us
Reduce number of write to the channel.
This will also help making the write to socket all asynchronous
avoiding potential blockages.
Signed-off-by: Frediano Ziglio
---
Changes sinve v1:
- make "mux" a simple structure, not a pointer to a structure
---
src/channel-webdav.c | 19 +++---
On Wed, Jul 3, 2019 at 10:35 AM Frediano Ziglio wrote:
>
> Reduce number of write to the channel.
> This will also help making the write to socket all asynchronous
> avoiding potential blockages.
>
> Signed-off-by: Frediano Ziglio
> ---
> src/channel-webdav.c | 28 +---
>
>
> Hi again,
>
> On Mon, Jul 1, 2019 at 3:16 PM Jakub Janku wrote:
> >
> > Hi,
> >
> > On Mon, Jul 1, 2019 at 1:02 PM Frediano Ziglio wrote:
> > >
> > > >
> > > > The current approach with OutputQueue in webdav has several problems:
> > > >
> > > > * if the connection is slow, webdav keeps rea
From: Jakub Janků
The current approach with OutputQueue in webdav has several problems:
* if the connection is slow, webdav keeps reading from phodav
and pushing messages to the internal channel xmit_queue.
This way, the queue can grow very quickly and the whole file
that is being transferred us
Reduce number of write to the channel.
This will also help making the write to socket all asynchronous
avoiding potential blockages.
Signed-off-by: Frediano Ziglio
---
src/channel-webdav.c | 28 +---
1 file changed, 13 insertions(+), 15 deletions(-)
diff --git a/src/chan
Hi again,
On Mon, Jul 1, 2019 at 3:16 PM Jakub Janku wrote:
>
> Hi,
>
> On Mon, Jul 1, 2019 at 1:02 PM Frediano Ziglio wrote:
> >
> > >
> > > The current approach with OutputQueue in webdav has several problems:
> > >
> > > * if the connection is slow, webdav keeps reading from phodav
> > > and
23 matches
Mail list logo
