Re: [Spice-devel] [PATCH spice-server] smartcard-channel-client: Fix some typos in a comment

2019-07-02 Thread Snir Sheriber
ack Acked-by: Snir Sheriber On 6/2/19 8:53 PM, Frediano Ziglio wrote: Signed-off-by: Frediano Ziglio --- server/smartcard-channel-client.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/server/smartcard-channel-client.c b/server/smartcard-channel-client.c index

Re: [Spice-devel] [PATCH spice-server] red-parse-qxl: Reset mask attributes if brush image is missing

2019-07-02 Thread Snir Sheriber
Hi, On 6/2/19 8:53 PM, Frediano Ziglio wrote: The attributes in this case are not used to apply the mask. Doing so avoid sending garbage from the guest which usually don't initialise the memory in case the mask is missing. Guest should have cleared these bytes by its own however doing so on the

Re: [Spice-devel] [PATCH] gstreamer-encoder: fix compiler warning with Fedora 30

2019-07-02 Thread Uri Lublin
On 7/1/19 6:19 PM, Frediano Ziglio wrote: Fedora 30 / gcc 9.1.1 20190503 (Red Hat 9.1.1-1) fails to build because of this error/warning: gstreamer-encoder.c: In function 'set_video_bit_rate': gstreamer-encoder.c:518:17: error: taking the absolute value of unsigned type 'uint64_t' {aka 'long un

Re: [Spice-devel] [PATCH spice] manual: Typo at `Folder sharing` section

2019-07-02 Thread Frediano Ziglio
> > Reported here: > https://gitlab.freedesktop.org/spice/spice-space-pages/issues/1 > --- > Following to this fix website manual will be automatically generated > --- > docs/manual/manual.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/docs/manual/manual.txt b/docs/

[Spice-devel] [PATCH spice] manual: Typo at `Folder sharing` section

2019-07-02 Thread Snir Sheriber
Reported here: https://gitlab.freedesktop.org/spice/spice-space-pages/issues/1 --- Following to this fix website manual will be automatically generated --- docs/manual/manual.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/manual/manual.txt b/docs/manual/manual.txt ind