[Spice-devel] [PATCH v3 16/18] drm/qxl: switch driver from bo->resv to bo->base.resv

Signed-off-by: Gerd Hoffmann Acked-by: Christian König --- drivers/gpu/drm/qxl/qxl_debugfs.c | 2 +- drivers/gpu/drm/qxl/qxl_release.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_debugfs.c b/drivers/gpu/drm/qxl/qxl_debugfs.c index 013b93898

[Spice-devel] [PATCH v3 03/18] drm/qxl: use embedded gem object

Drop drm_gem_object from qxl_bo, use the ttm_buffer_object.base instead. Signed-off-by: Gerd Hoffmann Acked-by: Christian König --- drivers/gpu/drm/qxl/qxl_drv.h | 6 +++--- drivers/gpu/drm/qxl/qxl_object.h | 4 ++-- drivers/gpu/drm/qxl/qxl_cmd.c | 4 ++-- drivers/gpu/drm/qxl/qxl_de

[Spice-devel] [PATCH v3 08/18] drm/ttm: use gem vma_node

Drop vma_node from ttm_buffer_object, use the gem struct (base.vma_node) instead. Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 2 +- drivers/gpu/drm/qxl/qxl_object.h | 2 +- drivers/gpu/drm/radeon/radeon_object.h | 2 +-

Re: [Spice-devel] [client v3 1/6] channel-display: Minimize the stream lag by ignoring the server one

Hello, I looked at the patch series and tried to describe its modifications to better understand it; you'll find below my comments. François, in the middle of it you'll find a few nit suggestions to improve the readability. the patch for display_handle_stream_data() is obviously the most complex,

Re: [Spice-devel] [PATCH spice-server v2] char-device: Remove unused red_char_device_destroy function

ping > > ping > > > > > ping > > > > > > > > ping > > > > > > > > > > > g_object_unref is directly used. > > > > > > > > Signed-off-by: Frediano Ziglio > > > > --- > > > > server/char-device.c | 6 -- > > > > server/char-device.h | 5 ++--- > > > > 2 files changed, 2 insertions(+), 9

Re: [Spice-devel] [PATCH spice-server 13/13] red-channel-client: Add some comment on the flush code

ping > > ping > > > > > ping > > > > > > > > Signed-off-by: Frediano Ziglio > > > --- > > > server/red-channel-client.c | 6 ++ > > > 1 file changed, 6 insertions(+) > > > > > > diff --git a/server/red-channel-client.c b/server/red-channel-client.c > > > index 3fd51d78b..337733d5d 1006

Re: [Spice-devel] [PATCH spice-server 03/13] char-device: Allocate all write buffer in a single block

ping > > There are no much data other than the buffer, reduce the > allocations. > > Signed-off-by: Frediano Ziglio > --- > server/char-device.c | 27 +++ > server/char-device.h | 2 +- > 2 files changed, 16 insertions(+), 13 deletions(-) > > diff --git a/server/char-

Re: [Spice-devel] [PATCH spice-server v2] char-device: Remove unused red_char_device_destroy function

ping > > ping > > > > > ping > > > > > > > > g_object_unref is directly used. > > > > > > Signed-off-by: Frediano Ziglio > > > --- > > > server/char-device.c | 6 -- > > > server/char-device.h | 5 ++--- > > > 2 files changed, 2 insertions(+), 9 deletions(-) > > > > > > diff --git a/s

Re: [Spice-devel] [PATCH spice-protocol 3/3] qxl_dev: Move QXLReleaseInfoExt out of start/end-packed.h

ping 5 > > ping 4 > > > > > ping 3 > > > > > > > > ping > > > > > > > > > > > ping > > > > > > > > > > > > > > This structure is not declares as SPICE_ATTR_PACKED resulting it > > > > > as aligned and no packed using GCC (no MingW). > > > > > This structure is only packed under MingW or M

Re: [Spice-devel] [PATCH spice-server v2 1/2] char-device: Don't use RedClient API

ping > > ping the series > > > > > RedClient was an opaque structure for RedCharDevice. > > It started to be used when RedsState started to contain all > > the global state. > > Make it opaque again using a new RedCharDeviceClientOpaque. > > The RedCharDeviceClientOpaque define in the header al

Re: [Spice-devel] [PATCH spice-server] red-parse-qxl: Reset mask attributes if brush image is missing

ping 3 > > ping 2 > > > > > ping > > > > > > > > The attributes in this case are not used to apply the mask. > > > Doing so avoid sending garbage from the guest which usually > > > don't initialise the memory in case the mask is missing. > > > Guest should have cleared these bytes by its own

Re: [Spice-devel] [PATCH spice-server 02/13] char-device: Pull more code into red_char_device_send_to_client_tokens_absorb

ping > > ping > > > > > The 2 callers red_char_device_send_to_client_tokens_set and > > red_char_device_send_to_client_tokens_add are doing mostly > > the same thing so put common code to > > red_char_device_send_to_client_tokens_absorb. > > > > Signed-off-by: Frediano Ziglio > > --- > > ser

Re: [Spice-devel] [PATCH spice-server 12/13] red-channel-client: Reduce indentation of some code

ping > > ping > > > > > Just a style change, return earlier to avoid some indentation. > > > > Signed-off-by: Frediano Ziglio > > --- > > server/red-channel-client.c | 37 +++-- > > 1 file changed, 15 insertions(+), 22 deletions(-) > > > > diff --git a/server

Re: [Spice-devel] [PATCH spice-server 04/13] spicevmc: Remove reds parameter from spicevmc_device_disconnect

ping > > ping > > > > > ping > > > > > > > > Unused. > > > Also the devices should be able to release themselves. > > > > > > Signed-off-by: Frediano Ziglio > > > --- > > > server/char-device.h | 3 +-- > > > server/reds.c| 2 +- > > > server/spicevmc.c| 2 +- > > > 3 files cha

Re: [Spice-devel] [PATCH spice-server 05/13] red-worker: Remove warning

ping > > ping > > > > > ping > > > > > > > > In some configuration _GNU_SOURCE is defined by the compiler > > > and defining again cause a warning. > > > Do not define again to avoid the warning. > > > > > > Signed-off-by: Frediano Ziglio > > > --- > > > server/red-worker.c | 2 ++ > > > 1

Re: [Spice-devel] [PATCH spice-server v2] spice-char: Add some documentation to SpiceCharDeviceInterface

ping > Signed-off-by: Frediano Ziglio > --- > server/spice-char.h | 26 ++ > 1 file changed, 26 insertions(+) > > Changes since v1: > - updated comments > > diff --git a/server/spice-char.h b/server/spice-char.h > index 1a8a031d2..a3b9d26bf 100644 > --- a/server/spice-c

Re: [Spice-devel] [PATCH spice-gtk] channel-display: Use proper sized maximum

ping > > "audio_delay" is 32 bit as defined by protocol. > > Signed-off-by: Frediano Ziglio > --- > src/channel-display.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/channel-display.c b/src/channel-display.c > index cda0fcdd..542920bb 100644 > --- a/src/channe

Re: [Spice-devel] [PATCH spice-gtk] Replace some missing "latency" terms

ping > > This follows up commit 887aedff41bdb89845e7cb349454a8dcbb515db4 > "The video latency is in fact a margin". > > Signed-off-by: Frediano Ziglio > --- > src/channel-display-priv.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/channel-display-priv.h b/s

Re: [Spice-devel] [PATCH spice-protocol 2/3] qxl_dev: Fix alignment for QXLReleaseInfo

ping 5 > > ping 4 > > > > > ping 3 > > > > > > > > ping > > > > > > > > > > > ping > > > > > > > > > > > > > > Do not declare the structure as aligned. > > > > > The start/end-packed.h headers affects only MingW or Microsoft > > > > > compilers. To have unaligned structure with GCC compil

Re: [Spice-devel] [PATCH spice-gtk 0/4] Check distribution with CI

ping 4 > > ping 3 > > > > > ping > > > > > > > > ping the series > > > > > > > > > > > Make sure we can build distribution. > > > > Some small updates also to fix some minor issues. > > > > > > > > CI results at > > > > https://gitlab.freedesktop.org/fziglio/spice-gtk/pipelines/37744 > > >