Re: [Spice-devel] [spice v3] utils: Remove the LL suffix from NSEC_PER_SEC

2019-06-24 Thread Francois Gouget
On Mon, 17 Jun 2019, Uri Lublin wrote: > On 6/15/19 2:59 PM, Frediano Ziglio wrote: > >> > >> This constant fits in a 32 bit signed integer so it does not need the > >> suffix. However some of the derived constants don't so use an uint64_t > >> cast to avoid the long vs long long confusion (such a

[Spice-devel] [PATCH spice-gtk v2] file-transfer-task: emit signals in main context

2019-06-24 Thread Jakub Janků
Parts of the internal file transfer task API can be invoked in the coroutine context, so in these cases use g_coroutine_signal_emit and g_coroutine_object_notify. Some functions (such as spice_main_channel_clipboard_selection_grab) wake up the channel and thus can immediately switch to the corouti

Re: [Spice-devel] [PATCH 2/3] usb-redirection: isolate usage of libusb and usbredirhost

2019-06-24 Thread Yuri Benditovich
On Mon, Jun 10, 2019 at 1:48 PM Victor Toso wrote: > > Hi, > > Keeping the chat as you might enjoy then, in order to merge this > patches: > > On Wed, Apr 10, 2019 at 10:31:38PM +0300, Yuri Benditovich wrote: > > As a step toward possibility to present emulated USB devices > > to the guest, we rem

Re: [Spice-devel] [protocol v2] macros: Remove unused SPICE_GNUC_XXX macros

2019-06-24 Thread Frediano Ziglio
> > We don't want to maintain more macros than necessary and these have > been unused for over two years. > > Signed-off-by: Francois Gouget Acked for me (I'll wait) > --- > > v2: Remove unused macros altogether rather than marking them as > deprecated (no use of them has been found in sp

[Spice-devel] [protocol v2] macros: Remove unused SPICE_GNUC_XXX macros

2019-06-24 Thread Francois Gouget
We don't want to maintain more macros than necessary and these have been unused for over two years. Signed-off-by: Francois Gouget --- v2: Remove unused macros altogether rather than marking them as deprecated (no use of them has been found in spice, spice-gtk, spice-common, spice-prot

Re: [Spice-devel] [PATCH spice-gtk] file-transfer-task: emit signals in main context

2019-06-24 Thread Frediano Ziglio
> > Some parts of the internal file transfer task API I would expect "Most" of them as the agent messages are from the main channel. > can be invoked in the coroutine context, so in these cases > use g_coroutine_signal_emit and g_coroutine_object_notify. > I would add the "why", I suppose thes

[Spice-devel] [PATCH spice-gtk] file-transfer-task: emit signals in main context

2019-06-24 Thread Jakub Janků
Some parts of the internal file transfer task API can be invoked in the coroutine context, so in these cases use g_coroutine_signal_emit and g_coroutine_object_notify. Signed-off-by: Jakub Janků --- src/spice-file-transfer-task.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

Re: [Spice-devel] [PATCH spice-server] dcc-send: Check some constants at compile time

2019-06-24 Thread Uri Lublin
On 6/21/19 12:45 PM, Frediano Ziglio wrote: Signed-off-by: Frediano Ziglio Ack. Uri. --- server/dcc-send.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/dcc-send.c b/server/dcc-send.c index ea2128e27..b14619a2b 100644 --- a/server/dcc-send.c +++ b/server/dcc-