[Spice-devel] [spice v3] utils: Remove the LL suffix from NSEC_PER_SEC

This constant fits in a 32 bit signed integer so it does not need the suffix. However some of the derived constants don't so use an uint64_t cast to avoid the long vs long long confusion (such as in print statements). Also some of the expressions these constants are used in may overflow so perform

Re: [Spice-devel] [client 1/5] gstreamer: Avoid direct access to GQueue fields

On Fri, 14 Jun 2019, Frediano Ziglio wrote: > > > > Signed-off-by: Francois Gouget > > Considering that the field is public and that code will get > slower and bigger at least would be good to describe the reason > why you consider it better. Consistency mostly. This is the only place where w

[Spice-devel] [PATCH 25/59] drm/qxl: Drop drm_gem_prime_export/import

They're the default. Aside: Would be really nice to switch the others over to drm_gem_object_funcs. Signed-off-by: Daniel Vetter Cc: Dave Airlie Cc: Gerd Hoffmann Cc: virtualizat...@lists.linux-foundation.org Cc: spice-devel@lists.freedesktop.org --- drivers/gpu/drm/qxl/qxl_drv.c | 2 -- 1 fi

[Spice-devel] [PATCH x11spice v2] Changes to build on the 32 bit raspberry pi.

Signed-off-by: Jeremy White --- v2 Use (u) (u) thing instead of (u) ((u) thing) Simplify some casting where possible --- src/scan.c| 6 +++--- src/session.c | 8 src/spice.c | 18 +++--- 3 files changed, 18 insertions(+), 14 deletions(-) diff --git a/src/scan.c b

Re: [Spice-devel] [client 1/5] gstreamer: Avoid direct access to GQueue fields

> > Signed-off-by: Francois Gouget Considering that the field is public and that code will get slower and bigger at least would be good to describe the reason why you consider it better. OT: I don't understand why they didn't define g_queue_get_length as an inline or a macro... > --- > src/c

[Spice-devel] [client 4/5] gstreamer: Improve the statistics collection

By the time schedule_frame() pulls a sample off GStreamer's pipeline the frame may have been sitting in the sink's queue for hundreds of milliseconds, making the decoding time meaningless. This patch ensures the statistics are always collected by sink_event_probe() which is called as soon as the

[Spice-devel] [client 5/5] gstreamer: Add the encoded frame's rank to the statistics

The number of frames that were sitting in the decoding_queue before the current frame was added is crucial to correctly interpret the decoding time: * Less than MAX_DECODED_FRAMES means nothing blocked the decoding of that frame. * More than MAX_DECODED_FRAMES means decoding was delayed by one or

[Spice-devel] [client 2/5] gstreamer: Avoid a couple of forward function declarations

Signed-off-by: Francois Gouget --- src/channel-display-gst.c | 81 --- 1 file changed, 42 insertions(+), 39 deletions(-) diff --git a/src/channel-display-gst.c b/src/channel-display-gst.c index c756f916..50f29060 100644 --- a/src/channel-display-gst.c +++ b/sr

[Spice-devel] [client 3/5] gstreamer: Fix the spice_gst_decoder_queue_frame() documentation

Take into account changes made in 8835e757922c, 8c2101254051 and possibly other other commits. Add MAX_DECODED_FRAMES to define how many decoded frames GStreamer should queue. Signed-off-by: Francois Gouget --- src/channel-display-gst.c | 63 +++ 1 file change

[Spice-devel] [client 1/5] gstreamer: Avoid direct access to GQueue fields

Signed-off-by: Francois Gouget --- src/channel-display-gst.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/channel-display-gst.c b/src/channel-display-gst.c index 91ece0fa..c756f916 100644 --- a/src/channel-display-gst.c +++ b/src/channel-display-gst.c @@ -278,7 +278,7 @