[Spice-devel] [PATCH spice-server] Remove compile warnings on Linux 32bit system

2019-06-12 Thread Frediano Ziglio
Based on a patch from Hongzhi.Song . There are following compile errors on Linux 32bit system with -Werror for gcc. red-channel.c:207:73: error: format '%x' expects argument of type 'unsigned int', but argument 7 has type 'long unsigned int' [-Werror=format=] |207| red_channel_debug(self, "thread

[Spice-devel] [PATCH spice-server] ci: Remove dependencies from copr build

2019-06-12 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- .gitlab-ci.yml | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 91ee47edc..e21ea97de 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -79,12 +79,15 @@ distcheck: makecheck-centos: befo

Re: [Spice-devel] [PATCH spice-server] test-qxl-parsing: Fix possible integer overflow

2019-06-12 Thread Frediano Ziglio
> > This fixes https://gitlab.freedesktop.org/spice/spice-server/issues/31. > > Signed-off-by: Frediano Ziglio > --- > server/tests/test-qxl-parsing.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/server/tests/test-qxl-parsing.c > b/server/tests/test-qxl-parsing.c >

[Spice-devel] [PATCH spice-server] test-qxl-parsing: Fix possible integer overflow

2019-06-12 Thread Frediano Ziglio
This fixes https://gitlab.freedesktop.org/spice/spice-server/issues/31. Signed-off-by: Frediano Ziglio --- server/tests/test-qxl-parsing.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/tests/test-qxl-parsing.c b/server/tests/test-qxl-parsing.c index 60ca8f88c..76eab0

[Spice-devel] [PATCH spice-common] build: Disable Celt support by default

2019-06-12 Thread Frediano Ziglio
We started disabling Celt support making the option required. After 2 releases start making it disabled unless explicitly enabled. Signed-off-by: Frediano Ziglio --- m4/spice-deps.m4 | 14 ++ meson_options.txt | 1 + 2 files changed, 3 insertions(+), 12 deletions(-) diff --git a/m

[Spice-devel] [PATCH spice-server] Update spice-common submodule

2019-06-12 Thread Frediano Ziglio
This brings in the following changes: Frediano Ziglio (4): gitignore: Ignore auto generated generated_messages.h file Do not check for HAVE_CONFIG_H build: Remove unused git-version-gen file recorder: Update Uri Lublin (1): codegen Makefile: add common/ to --include

Re: [Spice-devel] [client] gstreamer: Fix the decoding time when not using GstVideoOverlay

2019-06-12 Thread Snir Sheriber
Hi, On 6/11/19 9:42 PM, Francois Gouget wrote: schedule_frame() only pulls frames out of GStreamer's pipeline once all previous decoded frames have been displayed. Thus when the video delay IIRC we used to pull when samples arrived but it was changed to this so pending frames will be queued

[Spice-devel] [PATCH spice-server] red-stream: Fix compilation on Fedora 30 for Windows using MingW

2019-06-12 Thread Frediano Ziglio
On Windows Fedora 30 reports these errors: In file included from /usr/x86_64-w64-mingw32/sys-root/mingw/include/openssl/crypto.h:29, from /usr/x86_64-w64-mingw32/sys-root/mingw/include/openssl/bio.h:20, from /usr/x86_64-w64-mingw32/sys-root/mingw/include/openss

Re: [Spice-devel] [spice 2/2] utils: Remove the LL suffix from NSEC_PER_SEC

2019-06-12 Thread Frediano Ziglio
> > This constant fits in a 32 bit signed integer so it does not need the > suffix. However some of the derived constants don't so use an uint64_t > cast to avoid the long vs long long confusion (such as in print > statements). > Also some of the expressions these constants are used in may overflo

Re: [Spice-devel] [spice] gstreamer-encoder: Document get_maximum_frame_size()

2019-06-12 Thread Frediano Ziglio
> > Signed-off-by: Francois Gouget Acked > --- > server/gstreamer-encoder.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/server/gstreamer-encoder.c b/server/gstreamer-encoder.c > index bccbe0660..110d12981 100644 > --- a/server/gstreamer-encoder.c > +++ b/server/gstreamer-e

Re: [Spice-devel] [spice 1/2] utils: Remove the LL suffix from NSEC_PER_MILLISEC

2019-06-12 Thread Frediano Ziglio
> > This constant fits in a regular 32 bit signed integer so it does not > need the suffix. > It is also not used in expressions that may overflow. > > Signed-off-by: Francois Gouget Acked > --- > server/utils.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/server/