Signed-off-by: Francois Gouget
---
server/mjpeg-encoder.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/server/mjpeg-encoder.c b/server/mjpeg-encoder.c
index 1400519bb..b03fffe14 100644
--- a/server/mjpeg-encoder.c
+++ b/server/mjpeg-encoder.c
@@ -335,13 +335,13 @@ spice
This reduces code duplication and passing the MJpegEncoder object
makes it possible to modify the playback calculation without adding
more arguments.
Signed-off-by: Francois Gouget
---
v2: Reduced the diff and constified the MJpegEncoder* parameter.
server/mjpeg-encoder.c | 20 ---
Signed-off-by: Francois Gouget
---
server/gstreamer-encoder.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/server/gstreamer-encoder.c b/server/gstreamer-encoder.c
index 110d12981..cae22c100 100644
--- a/server/gstreamer-encoder.c
+++ b/server/gstreame
Signed-off-by: Francois Gouget
---
server/gstreamer-encoder.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/server/gstreamer-encoder.c b/server/gstreamer-encoder.c
index bccbe0660..110d12981 100644
--- a/server/gstreamer-encoder.c
+++ b/server/gstreamer-encoder.c
@@ -404,6 +404,13 @@
It makes no sense to expect average frame sizes anywhere close to 2GB.
But then make sure to avoid arithmetic overflows.
Signed-off-by: Francois Gouget
---
In get_min_playback_delay() I opted for the cast approach as this makes
what happens clearer. I deemed the assignment (uint32_t) unnecessar
The source framerate is as important as the resolution when trying to
understand if the system should be fast enough to encode the video
stream in real time.
Signed-off-by: Francois Gouget
---
v2: Tweaked the message.
server/gstreamer-encoder.c | 2 +-
1 file changed, 1 insertion(+), 1 deletio
Signed-off-by: Frediano Ziglio
---
build-aux/git-version-gen | 158 --
1 file changed, 158 deletions(-)
delete mode 100755 build-aux/git-version-gen
diff --git a/build-aux/git-version-gen b/build-aux/git-version-gen
deleted file mode 100755
index 5617eb8..000
Pull version update and some features.
Version update changed copyright in files to LGPLv2, more
compatible with SPICE.
One of the feature is the support for absolute time.
Signed-off-by: Frediano Ziglio
---
common/recorder | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/comm
>
> On Thu, 16 May 2019, Frediano Ziglio wrote:
> [...]
> > > @@ -520,7 +520,7 @@ static uint32_t
> > > get_min_playback_delay(SpiceGstEncoder
> > > *encoder)
> > > * an I frame) and an average frame. This also takes into account
> > > the
> > > * frames dropped by the encoder bi
On Thu, 16 May 2019, Frediano Ziglio wrote:
[...]
> > @@ -520,7 +520,7 @@ static uint32_t get_min_playback_delay(SpiceGstEncoder
> > *encoder)
> > * an I frame) and an average frame. This also takes into account the
> > * frames dropped by the encoder bit rate control.
> > */
> >
On Thu, 16 May 2019, Frediano Ziglio wrote:
> >
> > It makes no sense to expect average frame sizes anywhere close to 2GB.
> >
> > Signed-off-by: Francois Gouget
>
> Sure but 256 kb are possible.
Even multiplied by two that fits pretty well in a 32 signed integer.
--
Francois Gouget
_
ping
>
> Do not declare the structure as aligned.
> The start/end-packed.h headers affects only MingW or Microsoft
> compilers. To have unaligned structure with GCC compiler you have
> to use SPICE_ATTR_PACKED. This way the definition are the same for
> all compiler.
> This structure is used in a
ping
>
> This structure is not declares as SPICE_ATTR_PACKED resulting it
> as aligned and no packed using GCC (no MingW).
> This structure is only packed under MingW or Microsoft compilers.
> This structure is not technically a definition for QXL device but
> is used only for spice-server QXL in
On 5/20/19 10:13 AM, Frediano Ziglio wrote:
Hi,
Maybe worth mentioning it's leftover from pygtk/python bindings
not really critical, anyway, fine with me.
Do you have the commit or some hint on what to write?
I'm not aware of this feature.
I think it should have been removed in 96ed6b7a an
Make sure we can build distribution.
Some small updates also to fix some minor issues.
CI results at https://gitlab.freedesktop.org/fziglio/spice-gtk/pipelines/37744
Frediano Ziglio (4):
ci: Test we can create a no dirty package
spice-client-gtk-module: Remove unused file
build: Do addition
- copy missing recorder files;
- generate THANKS file.
Signed-off-by: Frediano Ziglio
---
Makefile.am | 1 +
build-aux/meson-dist | 28
meson.build | 2 +-
3 files changed, 30 insertions(+), 1 deletion(-)
create mode 100755 build-aux/meson-dist
Signed-off-by: Frediano Ziglio
---
src/spice-client-gtk-module.c | 45 ---
1 file changed, 45 deletions(-)
delete mode 100644 src/spice-client-gtk-module.c
diff --git a/src/spice-client-gtk-module.c b/src/spice-client-gtk-module.c
deleted file mode 100644
index b
Make sure there's nothing left during build or that
during build files are not changed in the wrong way.
Signed-off-by: Frediano Ziglio
---
.gitlab-ci.yml | 14 ++
1 file changed, 14 insertions(+)
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 7766539e..a6cb2cda 100644
--- a/.gi
Make sure Meson is able to generate a correct tarball.
Signed-off-by: Frediano Ziglio
---
.gitlab-ci.yml | 6 ++
1 file changed, 6 insertions(+)
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index a6cb2cda..5ddb4db8 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -82,6 +82,12 @@ fedora-m
>
> Hi,
>
> Maybe worth mentioning it's leftover from pygtk/python bindings
> not really critical, anyway, fine with me.
>
Do you have the commit or some hint on what to write?
I'm not aware of this feature.
>
> Acked-by: Snir Sheriber
>
> On 5/17/19 1:41 PM, Frediano Ziglio wrote:
> > Sign
20 matches
Mail list logo
