[Spice-devel] [PATCH spice-server 2/2] dcc: Avoid usage of not aligned GlzEncDictRestoreData structure

2019-05-08 Thread Frediano Ziglio
Copy to/from unaligned field to avoid potential unaligned access. Although it adds a copy it's not in a hot path (migration) and the structure is pretty small. Signed-off-by: Frediano Ziglio --- server/dcc-send.c | 4 +++- server/dcc.c | 3 ++- 2 files changed, 5 insertions(+), 2 deletions(

[Spice-devel] [PATCH spice-server 1/2] test-display-base: Use SPICE_CONTAINEROF to avoid alignment warning

2019-05-08 Thread Frediano Ziglio
This change prevent a warning issued by GCC 9 and potentially other compilers. Signed-off-by: Frediano Ziglio --- server/tests/test-display-base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/tests/test-display-base.c b/server/tests/test-display-base.c index 31d856a

Re: [Spice-devel] [spice-gtk v1 2/2] channel-webdav: do not handle vmc_data message twice

2019-05-08 Thread Frediano Ziglio
> > From: Victor Toso > > This is a regression from commit aae07fb in 2017-03-27 by Victor Toso > . The message is handled by channel-webdav and > should not be exposed nor handled elsewhere. > > Found this while inspecting the code, there is not real side effect > as no one trying to handle po

Re: [Spice-devel] [Spice-Gtk] SpiceSession: Create webdav even with NULL shared_dir

2019-05-08 Thread Javier Celaya
Hi, El mié, 08-05-2019 a las 06:47 +, Victor Toso escribió: > Hi, > On Mon, May 06, 2019 at 04:06:45PM +0200, Javier Celaya wrote: > > HiEl lun, 06-05-2019 a las 10:37 +, Victor Toso escribió: > > > Hi,On Fri, May 03, 2019 at 06:52:00PM +0200, Javier Celaya wrote: > > > > A phodav server cr