[Spice-devel] [Spice-Gtk] SpiceSession: Create webdav even with NULL shared_dir

2019-05-03 Thread Javier Celaya
A phodav server created with a NULL shared dir is valid and results in an error answer to all requests of the webdav channel, instead of silently ignoring them. This is better than just returning NULL from spice_session_get_webdav_server because: a) it crashes channel_webdav.c:start_client. b) eve

Re: [Spice-devel] [PATCH v3 x11spice 2/5] Apply Spice style to the spice-video-dummy

2019-05-03 Thread Jeremy White
On 5/3/19 3:27 AM, Frediano Ziglio wrote: Do this using the spice_indent script which uses indent to apply current Spice styles (as per Frediano Ziglio on 2019-05-01. Do you miss a close parenthesis? Not a big issue Yep, caught it in the push, thanks. Signed-off-by: Jeremy White --- v2

Re: [Spice-devel] LGPL or GPL for recorder library

2019-05-03 Thread Frediano Ziglio
> > > On 3 May 2019, at 15:31, Daniel P. Berrangé wrote: > > > > On Fri, May 03, 2019 at 03:21:09PM +0200, Christophe de Dinechin wrote: > >> Hi Frediano, > >> > >> > >> We discussed GPL vs LGPL for the recorder library. > >> > >> I made a mistake in commit e7df1041176eda88aea6102d1c4ecd9f144

Re: [Spice-devel] LGPL or GPL for recorder library

2019-05-03 Thread Christophe de Dinechin
> On 3 May 2019, at 15:31, Daniel P. Berrangé wrote: > > On Fri, May 03, 2019 at 03:21:09PM +0200, Christophe de Dinechin wrote: >> Hi Frediano, >> >> >> We discussed GPL vs LGPL for the recorder library. >> >> I made a mistake in commit e7df1041176eda88aea6102d1c4ecd9f144321a6 of >> the rec

Re: [Spice-devel] LGPL or GPL for recorder library

2019-05-03 Thread Daniel P . Berrangé
On Fri, May 03, 2019 at 03:21:09PM +0200, Christophe de Dinechin wrote: > Hi Frediano, > > > We discussed GPL vs LGPL for the recorder library. > > I made a mistake in commit e7df1041176eda88aea6102d1c4ecd9f144321a6 of > the recorder library trying to “renormalize” the headers before submitting

[Spice-devel] LGPL or GPL for recorder library

2019-05-03 Thread Christophe de Dinechin
Hi Frediano, We discussed GPL vs LGPL for the recorder library. I made a mistake in commit e7df1041176eda88aea6102d1c4ecd9f144321a6 of the recorder library trying to “renormalize” the headers before submitting the Fedora package (the “norm” being that each file should contain the license blur

Re: [Spice-devel] [spice] Enable mm_time adjustments on startup

2019-05-03 Thread Frediano Ziglio
- Original Message - > From: "Frediano Ziglio" > To: "Francois Gouget" > Cc: "Spice devel" > Sent: Friday, 3 May, 2019 10:43:20 AM > Subject: Re: [Spice-devel] [spice] Enable mm_time adjustments on startup > > > On Wed, 17 Apr 2019, Snir Sheriber wrote: > > [...] > > > > The reason fo

Re: [Spice-devel] [spice] Enable mm_time adjustments on startup

2019-05-03 Thread Frediano Ziglio
> On Wed, 17 Apr 2019, Snir Sheriber wrote: > [...] > > > The reason for that is that while a minimum 400 ms latency is fine when > > > playing a YouTube video [1], it's very annoying when the whole desktop > > > is being streamed, either through the streaming agent or through the > > > future Virg

Re: [Spice-devel] [PATCH v3 x11spice 3/5] Initial set of revisions to the dummy driver to add DRI and Present.

2019-05-03 Thread Frediano Ziglio
> This makes the dummy driver similar to the mode setting driver. > > This work was done by Henri Verbeet, which was in turn based heavily on > the Xorg modesetting driver. > > Signed-off-by: Jeremy White > --- > v2: Apply Spice style > v3: Refine Spice style, disable console keyboard and mouse

Re: [Spice-devel] [PATCH v3 x11spice 2/5] Apply Spice style to the spice-video-dummy

2019-05-03 Thread Frediano Ziglio
> > Do this using the spice_indent script which uses indent to apply > current Spice styles (as per Frediano Ziglio on 2019-05-01. Do you miss a close parenthesis? Not a big issue > > Signed-off-by: Jeremy White > --- > v2: Original version > v3: Revised to have case indent at 0, cuddle else,

Re: [Spice-devel] [PATCH v3 x11spice 4/5] Add a --enable-dummy option to configure.

2019-05-03 Thread Frediano Ziglio
> > Provide some basic documentation as to how to use the new > spice-video-dummy driver. > > Signed-off-by: Jeremy White Acked-by: Frediano Ziglio > --- > v3: Unchanged > --- > Makefile.am | 3 +++ > README | 19 +++ > configure.

Re: [Spice-devel] [PATCH v3 x11spice 1/5] Add the upstream xf86-video-dummy as of November 25, 2018.

2019-05-03 Thread Frediano Ziglio
> > This gives x11spice access to a modern virtual/offscreen > frame buffer driver for the Xorg X server. We will then > make slight revisions to make it more suitable for use with Spice. > > The overall result should be a more functional stack, > as compared to the existing xf86-video-qxl drive

Re: [Spice-devel] [PATCH v3 x11spice 5/5] Spelling.

2019-05-03 Thread Frediano Ziglio
> > From: Henri Verbeet > > Signed-off-by: Jeremy White Acked-by: Frediano Ziglio > --- > v3: New > --- > configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac > index 0acb4d2..fa23483 100644 > --- a/configure.ac > +++ b/configure