[Spice-devel] [PATCH spice-server 2/2] Do not check for HAVE_CONFIG_H

2019-04-27 Thread Frediano Ziglio
This should always be defined and including config.h is a requirement. Signed-off-by: Frediano Ziglio --- cfg.mk| 4 docs/spice_style.txt | 2 -- server/agent-msg-filter.c | 2 -- server/cache-item.tmpl.c | 2 -- server/common-graphi

[Spice-devel] [PATCH spice-server 1/2] syntax-check: Remove exclude rules of now compliant code

2019-04-27 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- cfg.mk | 6 -- 1 file changed, 6 deletions(-) diff --git a/cfg.mk b/cfg.mk index 93d7040c..3b711c8b 100644 --- a/cfg.mk +++ b/cfg.mk @@ -132,8 +132,6 @@ sc_check_author_list: # XXX some of these tools/ programs probably ought to bindtextdomain ? exclude_f

Re: [Spice-devel] [PATCH spice-gtk v2] Unify openssl checks

2019-04-27 Thread Frediano Ziglio
> Currently, spice-gtk uses PKG_CHECK_MODULES(SSL, openssl) to detect > openssl CFLAGS and LIBS. And spice-common defines and uses > SPICE_CHECK_OPENSSL macro which calls > PKG_CHECK_MODULES(OPENSSL, openssl). > > This means that in order to override openssl CFLAGS or LIBS a user will > have to se

Re: [Spice-devel] [PATCH] Unify openssl checks

2019-04-27 Thread Roman Bogorodskiy
Frediano Ziglio wrote: > > > > Currently, spice-gtk uses PKG_CHECK_MODULES(SSL, openssl) to detect > > openssl CFLAGS and LIBS. And spice-common defines and uses > > SPICE_CHECK_OPENSSL macro which calls > > PKG_CHECK_MODULES(OPENSSL, openssl). > > > > This means that in order to override open

[Spice-devel] [PATCH spice-gtk v2] Unify openssl checks

2019-04-27 Thread Roman Bogorodskiy
Currently, spice-gtk uses PKG_CHECK_MODULES(SSL, openssl) to detect openssl CFLAGS and LIBS. And spice-common defines and uses SPICE_CHECK_OPENSSL macro which calls PKG_CHECK_MODULES(OPENSSL, openssl). This means that in order to override openssl CFLAGS or LIBS a user will have to set both OPENSSL