Re: [Spice-devel] [PATCH] Unify openssl checks

2019-04-26 Thread Frediano Ziglio
> > Currently, spice-gtk uses PKG_CHECK_MODULES(SSL, openssl) to detect > openssl CFLAGS and LIBS. And spice-common defines and uses > SPICE_CHECK_OPENSSL macro which calls > PKG_CHECK_MODULES(OPENSSL, openssl). > > This means that in order to override openssl CFLAGS or LIBS a user will > have to

Re: [Spice-devel] [PATCH] Revert "drm/qxl: drop prime import/export callbacks"

2019-04-26 Thread Thomas Hellstrom
On 4/26/19 4:21 PM, Daniel Vetter wrote: On Fri, Apr 26, 2019 at 7:33 AM Gerd Hoffmann wrote: This reverts commit f4c34b1e2a37d5676180901fa6ff188bcb6371f8. Simliar to commit a0cecc23cfcb Revert "drm/virtio: drop prime import/export callbacks". We have to do the same with qxl, for the same rea

[Spice-devel] [PATCH] Unify openssl checks

2019-04-26 Thread Roman Bogorodskiy
Currently, spice-gtk uses PKG_CHECK_MODULES(SSL, openssl) to detect openssl CFLAGS and LIBS. And spice-common defines and uses SPICE_CHECK_OPENSSL macro which calls PKG_CHECK_MODULES(OPENSSL, openssl). This means that in order to override openssl CFLAGS or LIBS a user will have to set both OPENSSL

[Spice-devel] [PATCH spice-streaming-agent] spec: Add missing dependency

2019-04-26 Thread Frediano Ziglio
Some include file now require some X11 library include so add the dependency. Signed-off-by: Frediano Ziglio --- spice-streaming-agent.spec.in | 1 + 1 file changed, 1 insertion(+) diff --git a/spice-streaming-agent.spec.in b/spice-streaming-agent.spec.in index 3874c2e..299ea02 100644 --- a/spi

Re: [Spice-devel] [PATCH] Revert "drm/qxl: drop prime import/export callbacks"

2019-04-26 Thread Daniel Vetter
On Fri, Apr 26, 2019 at 7:33 AM Gerd Hoffmann wrote: > > This reverts commit f4c34b1e2a37d5676180901fa6ff188bcb6371f8. > > Simliar to commit a0cecc23cfcb Revert "drm/virtio: drop prime > import/export callbacks". We have to do the same with qxl, > for the same reasons (it breaks DRI3). > > Drop t

Re: [Spice-devel] [PATCH spice-streaming-agent] Add support log logging statistics from plugins

2019-04-26 Thread Frediano Ziglio
> > On 26 Apr 2019, at 09:13, Frediano Ziglio wrote: > > > >>> > >>> On 25 Apr 2019, at 11:42, Frediano Ziglio wrote: > >>> > >>> ping 2 > >>> > > ping > > > > > Allows the plugins to add information to the log. > > > > Signed-off-by: Frediano Ziglio >

Re: [Spice-devel] [PATCH spice-server] inputs-channel: Attempt to have a reliable led state

2019-04-26 Thread Frediano Ziglio
> > > > From: Benjamin Tissoires > > > > We can not consider the qemu led state to be reliable. It by default has > > 50ms of delay, so if we want to achieve something reliable, this won't do. > > > > We need to keep our own internal state, and consider it as reliable. > > We update it immediat

[Spice-devel] [PATCH spice-server] syntax-check: Remove exclude rules of now compliant code

2019-04-26 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- cfg.mk | 6 -- 1 file changed, 6 deletions(-) diff --git a/cfg.mk b/cfg.mk index 93d7040c5..3b711c8bd 100644 --- a/cfg.mk +++ b/cfg.mk @@ -132,8 +132,6 @@ sc_check_author_list: # XXX some of these tools/ programs probably ought to bindtextdomain ? exclude

[Spice-devel] [PATCH spice-server v2 0/3] Release preparation

2019-04-26 Thread Frediano Ziglio
Changes since v1: - commit messages for libcacard and protocol version updated; - add README bump for libcacard; - change NEWS file a bit (Victor suggestions). Frediano Ziglio (3): meson: Bump libcacard requirement to 2.5.1 Update spice-protocol version build: Prepare for 0.14.2 release NE

[Spice-devel] [PATCH spice-server v2 1/3] meson: Bump libcacard requirement to 2.5.1

2019-04-26 Thread Frediano Ziglio
This had already been done for Meson in commit afb2ec312bde342b8538451c6ae15a7f3bdd494f. Signed-off-by: Frediano Ziglio Acked-by: Victor Toso --- README | 2 +- configure.ac | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/README b/README index 0905fe5b4..8ce949a28 1

[Spice-devel] [PATCH spice-server v2 3/3] build: Prepare for 0.14.2 release

2019-04-26 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- NEWS | 20 configure.ac | 6 +++--- meson.build | 6 +++--- 3 files changed, 26 insertions(+), 6 deletions(-) diff --git a/NEWS b/NEWS index 403df63cd..cbf126006 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,23 @@ +Major Changes in 0.1

[Spice-devel] [PATCH spice-server v2 2/3] Update spice-protocol version

2019-04-26 Thread Frediano Ziglio
We require version after 0.12.15 which was released as 0.14.0. Check against a valid released instead of checking for a non existing one. Signed-off-by: Frediano Ziglio Acked-by: Victor Toso --- README | 2 +- configure.ac | 2 +- meson.build | 2 +- 3 files changed, 3 insertions(+), 3 d

Re: [Spice-devel] [PATCH spice-server 3/3] build: Prepare for 0.14.2 release

2019-04-26 Thread Victor Toso
On Fri, Apr 26, 2019 at 11:22:30AM +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > NEWS | 20 > configure.ac | 6 +++--- > meson.build | 6 +++--- > 3 files changed, 26 insertions(+), 6 deletions(-) > > diff --git a/NEWS b/NEWS > index 403df

Re: [Spice-devel] [PATCH spice-server 2/3] Update spice-protocol version

2019-04-26 Thread Victor Toso
Hi, On Fri, Apr 26, 2019 at 11:22:29AM +0100, Frediano Ziglio wrote: > We require version after 0.12.15 which will be released as 0.14.0. * was released. What I said in linux/vd-agent was 'to check against a valid released instead of checking with a non existing one', that is, 0.12.16 http

Re: [Spice-devel] [PATCH spice-server 1/3] meson: Bump libcacard requirement to 2.5.1

2019-04-26 Thread Victor Toso
On Fri, Apr 26, 2019 at 11:22:28AM +0100, Frediano Ziglio wrote: > This had already been done for autotools in commit > afb2ec312bde342b8538451c6ae15a7f3bdd494f. > > Signed-off-by: Frediano Ziglio Acked-by: Victor Toso > --- > configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

[Spice-devel] [PATCH spice-server 2/3] Update spice-protocol version

2019-04-26 Thread Frediano Ziglio
We require version after 0.12.15 which will be released as 0.14.0. Signed-off-by: Frediano Ziglio --- README | 2 +- configure.ac | 2 +- meson.build | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/README b/README index 0905fe5b4..73286a537 100644 --- a/README +++ b

[Spice-devel] [PATCH spice-server 3/3] build: Prepare for 0.14.2 release

2019-04-26 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- NEWS | 20 configure.ac | 6 +++--- meson.build | 6 +++--- 3 files changed, 26 insertions(+), 6 deletions(-) diff --git a/NEWS b/NEWS index 403df63cd..10441c586 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,23 @@ +Major Changes in 0.1

[Spice-devel] [PATCH spice-server 1/3] meson: Bump libcacard requirement to 2.5.1

2019-04-26 Thread Frediano Ziglio
This had already been done for autotools in commit afb2ec312bde342b8538451c6ae15a7f3bdd494f. Signed-off-by: Frediano Ziglio --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 604a41b21..9a8f4504c 100644 --- a/configure.ac +++ b/

Re: [Spice-devel] [PATCH spice-streaming-agent] Add support log logging statistics from plugins

2019-04-26 Thread Christophe de Dinechin
> On 26 Apr 2019, at 09:13, Frediano Ziglio wrote: > >>> >>> On 25 Apr 2019, at 11:42, Frediano Ziglio wrote: >>> >>> ping 2 >>> ping > > Allows the plugins to add information to the log. > > Signed-off-by: Frediano Ziglio > --- > Not entirely hap

Re: [Spice-devel] [spice] Enable mm_time adjustments on startup

2019-04-26 Thread Frediano Ziglio
> > On Thu, 11 Apr 2019, Victor Toso wrote: > > > Hi, > > > > On Wed, Apr 10, 2019 at 11:25:17AM +0200, Francois Gouget wrote: > > > We send mm_time adjustments to the client whenever there is no audio > > > playback. There is no audio playback on startup. Therefore > > > mm_time_enabled must be

Re: [Spice-devel] [spice] Enable mm_time adjustments on startup

2019-04-26 Thread Frediano Ziglio
> > We send mm_time adjustments to the client whenever there is no audio > playback. There is no audio playback on startup. Therefore > mm_time_enabled must be true on startup. QED. > How did you demonstrated it ? > Signed-off-by: Francois Gouget > --- > server/reds.c | 1 + > 1 file changed,

[Spice-devel] [vdagent-win PATCH] Remove some unused definitions

2019-04-26 Thread Frediano Ziglio
_ftime_s, vdagent_strcat_s and vdagent_strcpy_s are not used. Code is using different string functions. Signed-off-by: Frediano Ziglio --- common/vdcommon.cpp | 42 -- common/vdcommon.h | 24 2 files changed, 66 deletions(-) dif

Re: [Spice-devel] [PATCH spice-streaming-agent] Add support log logging statistics from plugins

2019-04-26 Thread Frediano Ziglio
> > > On 25 Apr 2019, at 11:42, Frediano Ziglio wrote: > > > > ping 2 > > > >> > >> ping > >> > >>> > >>> Allows the plugins to add information to the log. > >>> > >>> Signed-off-by: Frediano Ziglio > >>> --- > >>> Not entirely happy to export a kind of C function, any suggestion > >>> wel