Hi,
On Sun, Mar 24, 2019 at 7:26 PM Marc-André Lureau
wrote:
>
> Hi
>
> On Sun, Mar 24, 2019 at 6:50 PM Jakub Janku wrote:
> >
> > Hi,
> >
> > On Thu, Mar 21, 2019 at 1:21 PM wrote:
> > >
> > > From: Marc-André Lureau
> > >
> > > On the client side, whenever the grab owner changes (and the cli
Yes, it looks like this finally does the same thing.
From my personal point of view, this is less obvious than previous
code, so I would add 2 comments:
that we unreference the device from the new list
that we add reference to the device from the old list, it will be
dereferenced on next line when
On Thu, Mar 21, 2019 at 05:16:03PM +0200, Yuri Benditovich wrote:
> > > @@ -412,10 +428,17 @@ static void notify_dev_state_change(GUdevClient
> > > *self,
> > > GList *dev;
> > >
> > > for (dev = g_list_first(old_list); dev != NULL; dev =
> > > g_list_next(dev)) {
> > > -if (g_l
When getting a new list of USB devices after a WM_DEVICECHANGE event,
libusb_device which were already present before the event may be
represented by a different instance than the one we got in the new list.
Since other layers of spice-gtk may be using that older instance of
libusb_device, this co
From: Yuri Benditovich
Change internal device list to maintain libusb devices
instead of GUdevDevice objects. Create temporary
GUdevDevice object only for indication to usb-dev-manager.
Signed-off-by: Yuri Benditovich
Acked-by: Christophe Fergeau
---
Changes since version on the list:
- notify
Hi Snir,
Looks good to me.
Some suggestions at the bottom (inlined).
Feel free to fix/ignore and push with Frediano's ack.
On 3/24/19 6:04 PM, Snir Sheriber wrote:
---
Due to outdated links reported Daniel P. Berrangé in
"[Spice-devel] Bug tracker links outdated"
In addition i did changes i
Hi,
On Mon, Mar 25, 2019, 11:34 AM Marc-André Lureau
wrote:
> Hi
>
> On Mon, Mar 25, 2019 at 10:26 AM Frediano Ziglio
> wrote:
> >
> > >
> > > From: Marc-André Lureau
> > >
> > > This will allow easier lifecycle management,
> > > and usage of gtk_clipboard_set_with_owner()
> > >
> > > Signed-o
Hi
On Mon, Mar 25, 2019 at 10:26 AM Frediano Ziglio wrote:
>
> >
> > From: Marc-André Lureau
> >
> > This will allow easier lifecycle management,
> > and usage of gtk_clipboard_set_with_owner()
> >
> > Signed-off-by: Marc-André Lureau
> > ---
> > src/vdagent/clipboard.c | 67 ++
> ---
>
> Due to outdated links reported Daniel P. Berrangé in
> "[Spice-devel] Bug tracker links outdated"
>
Maybe adding a "Reported-by" in the commit log?
> In addition i did changes in the text so i sent it for review
>
>
> ---
> support.rst | 20
> 1 file changed,
>
> From: Marc-André Lureau
>
> This will allow easier lifecycle management,
> and usage of gtk_clipboard_set_with_owner()
>
> Signed-off-by: Marc-André Lureau
> ---
> src/vdagent/clipboard.c | 67 +++--
> src/vdagent/clipboard.h | 12 +---
> src/vdagen
10 matches
Mail list logo
