Re: [Spice-devel] [PATCH spice-gtk 3/3] clipboard: invalidate targets request when needed

2019-03-06 Thread Marc-André Lureau
Hi On Thu, Feb 28, 2019 at 8:12 PM Jakub Janků wrote: > > Targets request is no longer relevant when > clipboard owner changes since the retrieved targets > will be outdated. > > When the request is no longer relevant, > invalidate it by pointing its weak ref to NULL. > As a consequence, free_wea

Re: [Spice-devel] [PATCH spice-gtk 1/3] clipboard: accept grab only from the side with keyboard focus

2019-03-06 Thread Marc-André Lureau
Hi On Thu, Feb 28, 2019 at 8:12 PM Jakub Janků wrote: > > If two grab messages in opposite directions "meet" on their way > to their destinations, we end up in a state when both spice-gtk > and spice-vdagent think that the other component can provide > clipboard data. As a consequence of this, ne

[Spice-devel] [win32/vd_agent 2/4] add to CCD object reference to parent WDDM object

2019-03-06 Thread Yuri Benditovich
Adding to CCD object reference to WDDM interface that includes it. This allows to use WDDM methods from CCD methods. Signed-off-by: Yuri Benditovich --- vdagent/display_configuration.cpp | 4 +++- vdagent/display_configuration.h | 5 - 2 files changed, 7 insertions(+), 2 deletions(-) diff

[Spice-devel] [win32/vd_agent 0/4] Fix for BZ#1477191

2019-03-06 Thread Yuri Benditovich
https://bugzilla.redhat.com/show_bug.cgi?id=1477191 When one of multiple qxl-wddm-dod displays is turned off by the client, on Windows 10 the display driver does not receive any update, so on next connection the adapter is recognized as active. This series fixes the problem by sending QXL_ESCAPE_MO

[Spice-devel] [win32/vd_agent 1/4] construct WDDMMonitorConfigEscape also with NULL DisplayMode

2019-03-06 Thread Yuri Benditovich
Adding possibility to construct WDDMMonitorConfigEscape object with NULL parameter of DisplayMode. In this case all the fields depending on DisplayMode are set to zero. Signed-off-by: Yuri Benditovich --- vdagent/display_configuration.cpp | 8 1 file changed, 4 insertions(+), 4 deletion

[Spice-devel] [win32/vd_agent 4/4] make display disconnection persistent

2019-03-06 Thread Yuri Benditovich
https://bugzilla.redhat.com/show_bug.cgi?id=1477191 Currently on Win10 when one of multiple displays is disconnected by the client, the qxl-wddm-dod driver does not receive any update, the system just stops using this adapter for rendering. As a result, the 'disconnected' state of the adapter is no

[Spice-devel] [win32/vd_agent 3/4] introduce turn_monitor_off method of WDDM interface

2019-03-06 Thread Yuri Benditovich
Adding method 'turn_monitor_off' to WDDM interface. It sends QXL_ESCAPE_MONITOR_CONFIG escape with zeroed display size to qxl-wddm-dod driver. Signed-off-by: Yuri Benditovich --- vdagent/display_configuration.cpp | 18 ++ vdagent/display_configuration.h | 2 +- 2 files changed

Re: [Spice-devel] [vdagent-win PATCH] build: Check we can link libpng statically

2019-03-06 Thread Christophe Fergeau
On Wed, Feb 27, 2019 at 10:52:05AM +, Frediano Ziglio wrote: > Catch the problem during configure instead of having to wait the > build to fail. > On Fedora try for instance to remove mingw64-zlib-static package, > the missing dependency won't be detected during configure. > > Signed-off-by: F

Re: [Spice-devel] [PATCH spice-server v2 1/3] Refactor agent_adjust_capabilities() function

2019-03-06 Thread Christophe Fergeau
Series looks good to me, Acked-by: Christophe Fergeau On Mon, Mar 04, 2019 at 01:50:43PM -0600, Jonathon Jongsma wrote: > Make this a RedsState member function rather than a standalone function. > This means that we simply pass RedsState* as an argument rather than the > internal member variable

[Spice-devel] [PATCH spice-server 0/1] prevent crash on video stream reattach

2019-03-06 Thread Douglas Paul
I experienced some crashes with qemu 3.1.0 compiled with libspice-server 0.14.0 on Gentoo. The problem reproduced reliably with a guest running Ubuntu 18.04.2 LTS. If I connect a viewer at system startup, I would get a crash just after the fade-in of the login prompt in GDM. Interestingly, I us

[Spice-devel] [PATCH spice-server 1/1] video-stream: prevent crash on stream reattach

2019-03-06 Thread Douglas Paul
--- server/video-stream.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/server/video-stream.c b/server/video-stream.c index b624093e..19795098 100644 --- a/server/video-stream.c +++ b/server/video-stream.c @@ -369,7 +369,9 @@ static void before_reattach_stream(DisplayChann

Re: [Spice-devel] [spice-gtk v2 1/2] Deprecate “color-depth” properties

2019-03-06 Thread Victor Toso
Hi, On Tue, Jan 08, 2019 at 04:22:55PM +0100, Victor Toso wrote: > Hi, > > On Tue, Jan 08, 2019 at 04:09:54PM +0100, Christophe Fergeau wrote: > > On Fri, Dec 14, 2018 at 04:29:46PM +0100, Victor Toso wrote: > > > From: Victor Toso > > > > > > With commit 1a980f3712 we deprecated some command l

Re: [Spice-devel] [PATCH spice-gtk] egl: Adjust to window scaling

2019-03-06 Thread Christophe Fergeau
On Sun, Mar 03, 2019 at 10:11:08AM +0200, Snir Sheriber wrote: > When GDK_SCALE is != 1 and egl is used, the presented image does not > fit to the window (scale of 2 is often used with hidpi monitors). > Usually this is not a problem since all components are adjusted by > gdk/gtk but with egl, pixe