Re: [Spice-devel] [PATCH spice-common 8/9] protocol: Add a dummy TunnelChannel

2019-03-05 Thread Uri Lublin
On 3/5/19 3:52 PM, Frediano Ziglio wrote: On 3/3/19 9:10 PM, Frediano Ziglio wrote: The removal of the channel definition will cause the enumeration to miss this old channel. Add a dummy channel (empty) to avoid having to update spice-gtk and spice-server and possibly breaking other software.

Re: [Spice-devel] [PATCH spice-server v4 06/20] test-stat: Adjust delay checks

2019-03-05 Thread Marc-André Lureau
On Wed, Feb 6, 2019 at 2:59 PM Frediano Ziglio wrote: > > usleep under Windows does not seem to have the required precision. > Use milliseconds and adjust check times according. > > Signed-off-by: Frediano Ziglio Reviewed-by: Marc-André Lureau > --- > server/tests/stat-test.c | 12 ++-

Re: [Spice-devel] [PATCH spice-server v4 08/20] sys-socket: Add socket_newpair utility

2019-03-05 Thread Marc-André Lureau
Hi On Tue, Mar 5, 2019 at 3:07 PM Frediano Ziglio wrote: > > > Hi > > > > On Wed, Feb 6, 2019 at 2:59 PM Frediano Ziglio wrote: > > > > > > Allows to easier port socketpair. > > > Windows does not have this function, we need to create a pair > > > using 2 internet sockets and connecting one to t

Re: [Spice-devel] [PATCH spice-server v4 08/20] sys-socket: Add socket_newpair utility

2019-03-05 Thread Frediano Ziglio
> Hi > > On Wed, Feb 6, 2019 at 2:59 PM Frediano Ziglio wrote: > > > > Allows to easier port socketpair. > > Windows does not have this function, we need to create a pair > > using 2 internet sockets and connecting one to the other. > > > > Signed-off-by: Frediano Ziglio > > --- > > server/sys-

Re: [Spice-devel] [PATCH spice-server v4 03/20] Avoids %m in formatting for Windows

2019-03-05 Thread Marc-André Lureau
Hi On Tue, Mar 5, 2019 at 3:02 PM Frediano Ziglio wrote: > > > Hi > > > > On Wed, Feb 6, 2019 at 2:59 PM Frediano Ziglio wrote: > > > > > > Not supported, %m is a GNU extension of sscanf. > > > > > > Signed-off-by: Frediano Ziglio > > > --- > > > server/reds.c | 25 - >

Re: [Spice-devel] [PATCH spice-server v4 06/20] test-stat: Adjust delay checks

2019-03-05 Thread Frediano Ziglio
> > Hi > > On Wed, Feb 6, 2019 at 2:59 PM Frediano Ziglio wrote: > > > > usleep under Windows does not seem to have the required precision. > > Use milliseconds and adjust check times according. > > > > Signed-off-by: Frediano Ziglio > > As discussed previously, g_usleep() would also be a good

Re: [Spice-devel] [PATCH spice-server v4 03/20] Avoids %m in formatting for Windows

2019-03-05 Thread Frediano Ziglio
> Hi > > On Wed, Feb 6, 2019 at 2:59 PM Frediano Ziglio wrote: > > > > Not supported, %m is a GNU extension of sscanf. > > > > Signed-off-by: Frediano Ziglio > > --- > > server/reds.c | 25 - > > 1 file changed, 12 insertions(+), 13 deletions(-) > > > > diff --git a/serv

Re: [Spice-devel] [PATCH spice-common 8/9] protocol: Add a dummy TunnelChannel

2019-03-05 Thread Frediano Ziglio
> > On 3/3/19 9:10 PM, Frediano Ziglio wrote: > > The removal of the channel definition will cause the enumeration > > to miss this old channel. > > Add a dummy channel (empty) to avoid having to update spice-gtk > > and spice-server and possibly breaking other software. > > Hi Freidano, > > Thi

Re: [Spice-devel] [PATCH win-vdagent v2] Don't exit when receiving unknown messages

2019-03-05 Thread Frediano Ziglio
> > In 8251fa25, a check on the minimum size of a message was introduced. > For unsupported messages, the vdagent simply exited. This makes it > inconsistent with previous behavior and inconsistent with the behavior > of the linux vdagent. Instead, just print a warning indicating that an > unsupp

Re: [Spice-devel] [PATCH spice-server v4 10/20] reds: Use socket compatibility layer

2019-03-05 Thread Uri Lublin
Hi, All this patch does is replacing close(sock) with socket_close(sock), which is defined a couple of patches earlier. I'd change the subject to reflect that. On 2/6/19 3:58 PM, Frediano Ziglio wrote: Signed-off-by: Frediano Ziglio --- server/red-common.h | 1 + server/reds.c | 11