In 8251fa25, a check on the minimum size of a message was introduced.
For unsupported messages, the vdagent simply exited. This makes it
inconsistent with previous behavior and inconsistent with the behavior
of the linux vdagent. Instead, just print a warning indicating that an
unsupported message
For coding style consistency, use 'bool' when we want to represent a
boolean value.
Signed-off-by: Jonathon Jongsma
---
Changes in v2:
- new patch
server/reds.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/server/reds.c b/server/reds.c
index 07562b555..db93ac
Make this a RedsState member function rather than a standalone function.
This means that we simply pass RedsState* as an argument rather than the
internal member variables of RedsState. This enables the following
commit which handles the VD_AGENT_CAP_GRAPHICS_DEVICE_INFO capability to
avoid sending
Only send the graphics device display info to agents that advertise the
VD_AGENT_CAP_GRAPHICS_DEVICE_INFO capability
Signed-off-by: Jonathon Jongsma
---
Changes in v2:
- renamed member variable
- moved variable to RedCharDeviceVDIPortPrivate
- reset variable when agent disconnects
- make sure
On Wed, Feb 6, 2019 at 2:59 PM Frediano Ziglio wrote:
>
> Formatting string should be compatible with GLib.
> GLib uses formatting types compatible with GNU.
> For Linux this is not an issue as both systems (like a printf) and
> GLib one uses the same formatting type. However on Windows they
> di
On Wed, Feb 6, 2019 at 2:59 PM Frediano Ziglio wrote:
>
> Windows needs some specific setting to use network.
>
> Signed-off-by: Frediano Ziglio
autotools only?
Reviewed-by: Marc-André Lureau
> ---
> configure.ac | 20 +++-
> 1 file changed, 19 insertions(+), 1 deletion(-)
>
On Wed, Feb 6, 2019 at 2:59 PM Frediano Ziglio wrote:
>
> Signed-off-by: Frediano Ziglio
You could easily improve the commit message, as it doesn't seem to do
what it says.
> ---
> server/net-utils.c | 11 +++
> 1 file changed, 11 insertions(+)
>
> diff --git a/server/net-utils.c b/ser
Hi
On Wed, Feb 6, 2019 at 2:59 PM Frediano Ziglio wrote:
>
> Allows to easier port socketpair.
> Windows does not have this function, we need to create a pair
> using 2 internet sockets and connecting one to the other.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/sys-socket.c | 75
Hi
On Wed, Feb 6, 2019 at 2:59 PM Frediano Ziglio wrote:
>
> Between Unix and Windows socket are quite different:
> - on Windows sockets have a different namespace from C file
> descriptors so you can't use read/write/close or similar functions;
> - errors are not stored in errno but you must be
Hi
On Wed, Feb 6, 2019 at 2:59 PM Frediano Ziglio wrote:
>
> usleep under Windows does not seem to have the required precision.
> Use milliseconds and adjust check times according.
>
> Signed-off-by: Frediano Ziglio
As discussed previously, g_usleep() would also be a good fit. I would
rather us
Hi
On Wed, Feb 6, 2019 at 2:59 PM Frediano Ziglio wrote:
>
> "interface" and "MAX_MONITORS" are defined in some Windows system
> headers causing garbage code to be fed to the compiler.
>
> Signed-off-by: Frediano Ziglio
To avoid the conflict, I suggest renaming those instead.
> ---
> server/r
Hi
On Wed, Feb 6, 2019 at 2:59 PM Frediano Ziglio wrote:
>
> Not supported, %m is a GNU extension of sscanf.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/reds.c | 25 -
> 1 file changed, 12 insertions(+), 13 deletions(-)
>
> diff --git a/server/reds.c b/server/reds.
On 3/3/19 9:10 PM, Frediano Ziglio wrote:
The removal of the channel definition will cause the enumeration
to miss this old channel.
Add a dummy channel (empty) to avoid having to update spice-gtk
and spice-server and possibly breaking other software.
Hi Freidano,
This patch should be applied
On Mon, Feb 25, 2019 at 04:07:03PM +0200, Yuri Benditovich wrote:
> On Fri, Feb 22, 2019 at 2:06 PM Christophe Fergeau
> wrote:
> > I don't think we should have a hard limit on the number of lines in a
> > patch, however there should be a maximum of 1 logical change per commit,
> > see
> > https
Hi Jakub,
On Thu, Feb 28, 2019 at 08:12:41PM +0100, Jakub Janků wrote:
> Hi,
>
> this is another try to solve the grab race.
> Intention of these patches is to make spice-gtk
> behave reasonably well with older agents.
>
> The next step would be to fix the protocol itself.
> But that will requir
15 matches
Mail list logo
