[Spice-devel] [linux/vd-agent v2 2/5] Make README a markdown file

2019-02-25 Thread Victor Toso
From: Victor Toso This commit only renames it to have .md suffix as that is recognized by Gitlab. Signed-off-by: Victor Toso --- README => README.md | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename README => README.md (100%) diff --git a/README b/README.md similarity index 100% re

[Spice-devel] [linux/vd-agent v2 5/5] CHANGELOG: Move content from NEWS and delete it

2019-02-25 Thread Victor Toso
From: Victor Toso And add some Markdown style. v1 -> v2: * Fix NEWS -> CHANGELOG.md in Makefile.am (Jakub) Signed-off-by: Victor Toso --- CHANGELOG.md | 47 +++ Makefile.am | 2 +- NEWS | 46 --

[Spice-devel] [linux/vd-agent v2 1/5] Remove TODO

2019-02-25 Thread Victor Toso
From: Victor Toso Not something we really use nor we keep it up to date. One should check/update issues at https://gitlab.freedesktop.org/spice/linux/vd_agent/issues Signed-off-by: Victor Toso --- TODO | 3 --- 1 file changed, 3 deletions(-) delete mode 100644 TODO diff --git a/TODO b/T

[Spice-devel] [linux/vd-agent v2 3/5] README: Remove non relevant features information

2019-02-25 Thread Victor Toso
From: Victor Toso It is not relevant nowadays that *spicec* client was removed and even monitors_config does not reach spice-vdagent in modern Guests. Also add block quote for qemu cmdline and system's paths to make it easier to copy-and-paste. Signed-off-by: Victor Toso --- README.md | 34 ++

[Spice-devel] [linux/vd-agent v2 4/5] CHANGELOG: To use markdown

2019-02-25 Thread Victor Toso
From: Victor Toso We will prefer CHANGELOG over NEWS just as matter of Gitlab's. Followup patch will move NEWS content to CHANGELOG. This patch renames ChangeLog -> CHANGELOG.md and changes some style to follow Markdown. Also adds 'News in' string to the title of each section. Signed-off-by: Vi

Re: [Spice-devel] [linux/vd-agent 3/3] README: Use block quotes for code or paths

2019-02-25 Thread Victor Toso
On Sat, Feb 23, 2019 at 03:49:47PM +0100, Jakub Janku wrote: > Hi, > > in the README file, there are some formatting errors that I think > could be fixed in this patch as well, namely: > > * Sentence starting with "Then connect" should be in a new paragraph, > not in the nested list Sure > * t

Re: [Spice-devel] [linux/vd-agent 5/5] CHANGELOG: Move NEWS' content

2019-02-25 Thread Victor Toso
Hi, On Sat, Feb 23, 2019 at 04:27:24PM +0100, Jakub Janku wrote: > Hi, > > NEWS is appended to EXTRA_DIST var in Makefile.am, so we should change > that to CHANGELOG.md, if I'm not mistaken. Yes sir! Thanks! > > Jakub > > On Fri, Feb 22, 2019 at 6:23 PM Victor Toso wrote: > > > > From: Victo

Re: [Spice-devel] [RFC spice-streaming-agent 0/3] Integration with copr build system

2019-02-25 Thread Victor Toso
Hi, On Mon, Feb 25, 2019 at 04:56:44PM +0200, Snir Sheriber wrote: > This is an example for integration of copr and gitlab so that > any git update will generate a copr build automatically. > Doing that for whole our repos will allow to get an updated > upstream repo without maintaining a running

[Spice-devel] [PATCH 2/3] Update .gitlab-ci.yml

2019-02-25 Thread Snir Sheriber
--- .gitlab-ci.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index ab1b2a3..57d3dd9 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -3,7 +3,6 @@ image: fedora:latest before_script: - > dnf install -y 'dnf-command(copr)' make automake autoco

[Spice-devel] [PATCH 1/3] Add copr Makefile

2019-02-25 Thread Snir Sheriber
--- .copr/Makefile | 21 + 1 file changed, 21 insertions(+) create mode 100644 .copr/Makefile diff --git a/.copr/Makefile b/.copr/Makefile new file mode 100644 index 000..53b1b1b --- /dev/null +++ b/.copr/Makefile @@ -0,0 +1,21 @@ +PROTOCOL_GIT_REPO = https://gitlab.freed

[Spice-devel] [RFC spice-streaming-agent 0/3] Integration with copr build system

2019-02-25 Thread Snir Sheriber
This is an example for integration of copr and gitlab so that any git update will generate a copr build automatically. Doing that for whole our repos will allow to get an updated upstream repo without maintaining a running vm somewhere. (although i'm still not sure what to do with the mingw builds

[Spice-devel] [PATCH 3/3] Update spec.in

2019-02-25 Thread Snir Sheriber
gcc-c++ is not being installed on fedora 29 builds --- spice-streaming-agent.spec.in | 1 + 1 file changed, 1 insertion(+) diff --git a/spice-streaming-agent.spec.in b/spice-streaming-agent.spec.in index 6206cdc..3874c2e 100644 --- a/spice-streaming-agent.spec.in +++ b/spice-streaming-agent.spec.

Re: [Spice-devel] [vdagent-win PATCH] file-xfer: handle_start: use snprintf instead of sprintf_s

2019-02-25 Thread Frediano Ziglio
> > When building with older mingw, sprintf_s does not > always work as expected, but snprintf does. > > Also it's more consistent in the file. > > Note that when building with VS, snprintf becomes sprintf_s > I think this could be a bug, from documentation: "If the buffer is too small for th

Re: [Spice-devel] [spice-gtk] usb-redir: use persistent libusb device on Windows

2019-02-25 Thread Yuri Benditovich
On Fri, Feb 22, 2019 at 2:06 PM Christophe Fergeau wrote: > > Hi, > > On Thu, Feb 21, 2019 at 09:37:06AM +0200, Yuri Benditovich wrote: > > On Wed, Feb 20, 2019 at 6:03 PM Christophe Fergeau > > wrote: > > > > static SpiceUsbDevice* > > > > spice_usb_device_manager_find_device(SpiceUsbDeviceMa

Re: [Spice-devel] [PATCH spice-streaming-agent] Update spec file BuildRequires

2019-02-25 Thread Frediano Ziglio
> > --- > CI related fixes will follow later > --- > spice-streaming-agent.spec.in | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/spice-streaming-agent.spec.in b/spice-streaming-agent.spec.in > index 5a06e89..6206cdc 100644 > --- a/spice-streaming-agent.spec.in > +++ b/spice-streamin

Re: [Spice-devel] [PATCH spice-server] Do not use possibly undefined SPICE_CHANNEL_TUNNEL

2019-02-25 Thread Frediano Ziglio
> > Hi, > > On Mon, Feb 25, 2019 at 08:37:23AM +, Frediano Ziglio wrote: > > The channel was removed from the protocol and marked as > > obsolete. Potentially will be removed from spice/enums.h > > when regenerated. > > Should it really be removed? > I had the same question. Could be an op

Re: [Spice-devel] [PATCH spice-server] Do not use possibly undefined SPICE_CHANNEL_TUNNEL

2019-02-25 Thread Victor Toso
Hi, On Mon, Feb 25, 2019 at 08:37:23AM +, Frediano Ziglio wrote: > The channel was removed from the protocol and marked as > obsolete. Potentially will be removed from spice/enums.h > when regenerated. Should it really be removed? > Signed-off-by: Frediano Ziglio > --- > server/utils.c | 2

Re: [Spice-devel] [vdagent-win PATCH] file-xfer: handle_start: use snprintf instead of sprintf_s

2019-02-25 Thread Victor Toso
On Mon, Feb 25, 2019 at 12:20:06PM +0200, Uri Lublin wrote: > When building with older mingw, sprintf_s does not > always work as expected, but snprintf does. > > Also it's more consistent in the file. > > Note that when building with VS, snprintf becomes sprintf_s I really don't mind to have th

Re: [Spice-devel] [PATCH spice-streaming-agent] Update spec file BuildRequires

2019-02-25 Thread Snir Sheriber
On 2/25/19 1:12 PM, Frediano Ziglio wrote: --- CI related fixes will follow later Patch seems fine, I still have to test it but looking at previous patch something like this is needed. But looking at https://gitlab.freedesktop.org/spice/spice-streaming-agent/pipelines it seems this is not tes

Re: [Spice-devel] [vdagent-win PATCH] file-xfer: handle_start: use snprintf instead of sprintf_s

2019-02-25 Thread Frediano Ziglio
> > When building with older mingw, sprintf_s does not > always work as expected, but snprintf does. > > Also it's more consistent in the file. > > Note that when building with VS, snprintf becomes sprintf_s > > Related: rhbz#1410181 > > Signed-off-by: Uri Lublin Yes, you are right. I think

Re: [Spice-devel] [PATCH spice-streaming-agent] Update spec file BuildRequires

2019-02-25 Thread Frediano Ziglio
> > --- > CI related fixes will follow later Patch seems fine, I still have to test it but looking at previous patch something like this is needed. But looking at https://gitlab.freedesktop.org/spice/spice-streaming-agent/pipelines it seems this is not tested, which CI are you referring to? Sho

[Spice-devel] [PATCH spice-streaming-agent] Update spec file BuildRequires

2019-02-25 Thread Snir Sheriber
--- CI related fixes will follow later --- spice-streaming-agent.spec.in | 2 ++ 1 file changed, 2 insertions(+) diff --git a/spice-streaming-agent.spec.in b/spice-streaming-agent.spec.in index 5a06e89..6206cdc 100644 --- a/spice-streaming-agent.spec.in +++ b/spice-streaming-agent.spec.in @@ -11,

[Spice-devel] [vdagent-win PATCH] file-xfer: handle_start: use snprintf instead of sprintf_s

2019-02-25 Thread Uri Lublin
When building with older mingw, sprintf_s does not always work as expected, but snprintf does. Also it's more consistent in the file. Note that when building with VS, snprintf becomes sprintf_s Related: rhbz#1410181 Signed-off-by: Uri Lublin --- vdagent/file_xfer.cpp | 2 +- 1 file changed, 1

Re: [Spice-devel] Video stream low performance on raspberry pi while using h264

2019-02-25 Thread Snir Sheriber
Hi, On 2/22/19 4:14 PM, 陈炤 wrote: Hi, I am testing video stream on raspberry pi. My spice-gtk version is 0.34 and spice server is 0.14, video encode type is h264. On raspberry pi I use omxh264dec as hardware accelerated decoder. Can you shed more light on the server side configuration & en

[Spice-devel] [PATCH spice-server] Do not use possibly undefined SPICE_CHANNEL_TUNNEL

2019-02-25 Thread Frediano Ziglio
The channel was removed from the protocol and marked as obsolete. Potentially will be removed from spice/enums.h when regenerated. Signed-off-by: Frediano Ziglio --- server/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/utils.c b/server/utils.c index b440c0648

[Spice-devel] [PATCH v6 3/3] drm/qxl: remove conflicting framebuffers earlier

2019-02-25 Thread Gerd Hoffmann
Add error checking while being at it. Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel Vetter --- drivers/gpu/drm/qxl/qxl_drv.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/qxl/qxl_drv.c b/drivers/gpu/drm/qxl/qxl_drv.c index bb81e310eb6d..578d867a81d5