Re: [Spice-devel] [PATCH spice-common 6/6] Generate automatically most C message declarations

2019-02-23 Thread Frediano Ziglio
> > So, I applied these patches, and generated the messages with the new > code and compared it to the old hand-coded message.h file. I had to re- > arrange a bunch of the newly-generated code to get a readable diff, but > I end up with the attached output. A few notable changes: > > - Quite a fe

Re: [Spice-devel] [PATCH spice-common 1/6] messages: Remove fields not used by the protocol

2019-02-23 Thread Frediano Ziglio
> On Thu, 2019-02-21 at 10:38 +, Frediano Ziglio wrote: > > These fields are not used by the protocol. > > Avoid spice-gtk and spice-server to use them by mistake. > > This can cause memory errors (data_size is not used or > > is not set correctly) and useless code (spice-gtk uses > > the pub_k

Re: [Spice-devel] [linux/vd-agent 5/5] CHANGELOG: Move NEWS' content

2019-02-23 Thread Jakub Janku
Hi, NEWS is appended to EXTRA_DIST var in Makefile.am, so we should change that to CHANGELOG.md, if I'm not mistaken. Jakub On Fri, Feb 22, 2019 at 6:23 PM Victor Toso wrote: > > From: Victor Toso > > And add some Markdown style. > > Signed-off-by: Victor Toso > --- > CHANGELOG.md | 47 +

Re: [Spice-devel] [linux/vd-agent 3/3] README: Use block quotes for code or paths

2019-02-23 Thread Jakub Janku
Hi, in the README file, there are some formatting errors that I think could be fixed in this patch as well, namely: * Sentence starting with "Then connect" should be in a new paragraph, not in the nested list * the command "spicec --full-screen=auto-config" could be enclosed in backquotes rather