On Wed, Feb 20, 2019 at 6:03 PM Christophe Fergeau wrote:
>
> Hey,
>
> Sorry, it took a bit of time to review, but this patch is sticking a lot
> of changes together, splitting such patches in multiple smaller ones
> really help to get speedier reviews (and actually, probably improves
> these revi
On Wed, 2019-02-20 at 07:08 -0500, Frediano Ziglio wrote:
> >
> > For the Display Channel and the Cursor channel, move the call to
> > reds_register_channel() to the _constructed() vfunc rather than
> > calling
> > it explicitly from RedWorker. This matches what other channels do.
>
> I think thi
>
> On Thu, 2019-02-14 at 12:56 +, Frediano Ziglio wrote:
> > Allows to catch some errors which the compiler is not able to
> > detect in debug mode (the default).
>
> Seems fine, but what kind of errors are you talking about?
> Reviewed-by: Jonathon Jongsma
>
Like "this variable is not us
On Thu, 2019-02-14 at 12:56 +, Frediano Ziglio wrote:
> Allows to catch some errors which the compiler is not able to
> detect in debug mode (the default).
Seems fine, but what kind of errors are you talking about?
Reviewed-by: Jonathon Jongsma
>
> Signed-off-by: Frediano Ziglio
> ---
>
On Wed, 2019-02-20 at 07:08 -0500, Frediano Ziglio wrote:
> >
> > For the Display Channel and the Cursor channel, move the call to
> > reds_register_channel() to the _constructed() vfunc rather than
> > calling
> > it explicitly from RedWorker. This matches what other channels do.
>
> I think thi
Commit 9cf6d39b369f9c22615fc329e307126721125ecd ("server,proto:
tell the clients to connect to the migration target before migraton
starts", dated 18th September 2011) removed these fields.
Avoid to use them. If nobody complained in more than 7 years
it means this path of the code is not used.
Sig
> On Mon, Feb 18, 2019 at 04:01:24PM +, Frediano Ziglio wrote:
> > Does not make sense to specify the same field to have 2
> > different C implementation at the same time.
> >
> > Signed-off-by: Frediano Ziglio
> > ---
> > python_modules/ptypes.py | 7 +++
> > 1 file changed, 7 insertion
> On Mon, Feb 18, 2019 at 04:01:29PM +, Frediano Ziglio wrote:
> > c_type() method is supposed to return the type to use for
> > C structure field. But the name is not a C type but a
> > protocol name.
> > Return the type name of the aliased type (for instance
> > uint32_t for a uint32 type).
>
On Mon, Feb 18, 2019 at 04:01:29PM +, Frediano Ziglio wrote:
> c_type() method is supposed to return the type to use for
> C structure field. But the name is not a C type but a
> protocol name.
> Return the type name of the aliased type (for instance
> uint32_t for a uint32 type).
> This does n
On Mon, Feb 18, 2019 at 04:01:28PM +, Frediano Ziglio wrote:
> @ptr_array is supposed to change the destination to an array
> of pointer to items. This for a raw buffer does not make sense
> but check if user specifies this combination.
>
> Signed-off-by: Frediano Ziglio
> ---
> python_modul
Acked-by: Christophe Fergeau
On Mon, Feb 18, 2019 at 04:01:27PM +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> python_modules/ptypes.py | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/python_modules/ptypes.py b/python_modules/ptypes.py
> inde
On Mon, Feb 18, 2019 at 04:01:26PM +, Frediano Ziglio wrote:
> These fields are not used by the protocol.
> Avoid spice-gtk and spice-server to use them by mistake.
> This can cause memory errors (data_size is not used or
> is not set correctly) and useless code (spice-gtk uses
> the pub_key* f
On Mon, Feb 18, 2019 at 04:01:25PM +, Frediano Ziglio wrote:
> Although on the platform we support size_t and uintptr_t are
> the same on some platform the size_t can (in theory) be smaller
"the same, on some platforms size_t can ..." (took me a while to parse
the sentence without the comma)
On Mon, Feb 18, 2019 at 04:01:24PM +, Frediano Ziglio wrote:
> Does not make sense to specify the same field to have 2
> different C implementation at the same time.
>
> Signed-off-by: Frediano Ziglio
> ---
> python_modules/ptypes.py | 7 +++
> 1 file changed, 7 insertions(+)
>
> diff -
Acked-by: Christophe Fergeau
On Mon, Feb 18, 2019 at 04:01:23PM +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> python_modules/ptypes.py | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/python_modules/ptypes.py b/python_modules/ptypes.py
> index c548a28..38759
On Wed, Feb 20, 2019 at 08:43:22AM +, Victor Toso wrote:
> On Tue, Feb 19, 2019 at 05:37:38PM +0100, Marc-André Lureau wrote:
> > You can filter it out with grep, fairly easily.
> >
> > I proposed a series using structured logging and categories for
> > SPICE_DEBUG= in the past iirc. I guess I
spice-server does not deal properly with multiple smartcard readers,
only the first one will be working. Add a warning when this happens to
make it easier to diagnose such issues.
Signed-off-by: Christophe Fergeau
---
src/smartcard-manager.c | 20
1 file changed, 20 insertio
Hey,
Sorry, it took a bit of time to review, but this patch is sticking a lot
of changes together, splitting such patches in multiple smaller ones
really help to get speedier reviews (and actually, probably improves
these reviews, there are some things I would have missed if I did not
split this l
Problem: qxl switches from native mode back into vga compatibility mode
when it notices someone is accessing vga registers. And vgacon does
exactly that before fbcon takes over.
Before qxl switched to the generic fbdev emulation that didn't cause any
problems. With the generic fbdev emulation t
> Hi together,
> has anyone compiled / used spice-vdagent under FreeBSD?
> Kind regards
> Margit
Hi,
not as far as I know but we are mostly depending on
GLib2 and X11, I think the systemd part is conditional.
Frediano
___
Spice-devel mailing list
S
>
> Also define TESTS once
>
> autoreconf complains when there are multiple definitions of
> a variable. In this case (partial error message follows):
> warning: check_PROGRAMS multiply defined
>
> Signed-off-by: Uri Lublin
Acked-by: Frediano Ziglio
now both tests are executed!
> ---
>
Also define TESTS once
autoreconf complains when there are multiple definitions of
a variable. In this case (partial error message follows):
warning: check_PROGRAMS multiply defined
Signed-off-by: Uri Lublin
---
changes since v1:
- Instead of having a single check_PROGRAMS at the top,
>
> For the Display Channel and the Cursor channel, move the call to
> reds_register_channel() to the _constructed() vfunc rather than calling
> it explicitly from RedWorker. This matches what other channels do.
I think this was different for these channels as they where created
in a different th
Hi,
On Tue, Feb 19, 2019 at 06:12:45PM +0100, Marc-André Lureau wrote:
> Hi
>
> On Tue, Feb 19, 2019 at 6:02 PM Victor Toso wrote:
> >
> > Hi,
> >
> > On Tue, Feb 19, 2019 at 05:37:38PM +0100, Marc-André Lureau wrote:
> > > > > > -SPICE_DEBUG("frame mm_time %u size %u creation time %"
>
24 matches
Mail list logo
