[Spice-devel] [spice-gtk v1 06/10] gitlab-ci: move windows dependencies to a variable

2019-02-08 Thread Victor Toso
From: Victor Toso To keep all dependencies together. Some (small) effort was made to distinguish what is necessary for Fedora and what is necessary for Windows builds in order to install only required packages when job is executing. Note that we are adding gettext, gettext-devel and glib2-devel

[Spice-devel] [spice-gtk v1 03/10] flatpak: update python-six from 1.10.0 -> 1.11.0

2019-02-08 Thread Victor Toso
From: Victor Toso Same rationale as previous commit. 1.11.0 was released in 17.09.2017 while 1.10.0 is from 7.10.2015. Signed-off-by: Victor Toso --- data/org.spicespace.spicy.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/data/org.spicespace.spicy.json b/data

[Spice-devel] [spice-gtk v1 09/10] gitlab-ci: add mingw meson build

2019-02-08 Thread Victor Toso
From: Victor Toso To keep track of meson builds for windows too. Note that mingw64-meson requires to be ran inside the folder, different from common meson. So, some extra steps were done due that. Signed-off-by: Victor Toso --- .gitlab-ci.yml | 21 + 1 file changed, 21 inse

[Spice-devel] [spice-gtk v1 04/10] flatpak: add .desktop for spicy

2019-02-08 Thread Victor Toso
From: Victor Toso Spicy is just a testing tool but together with flatpak, it is nicer to have a desktop entry shipped with it. I don't see an issue in shipping this as long as we always keep in mind that it is a testing too, not a fully supported Spice client such as remote-viewer. Signed-off-by

[Spice-devel] [spice-gtk v1 08/10] gitlab-ci: add artifacts for logs and tests

2019-02-08 Thread Victor Toso
From: Victor Toso Much better than playing around with shell. Logs should live for week since the build and CI will try to always upload them. This patch also adds the logs for tests from builds with autotools Signed-off-by: Victor Toso --- .gitlab-ci.yml | 20 1 file cha

[Spice-devel] [spice-gtk v1 02/10] flatpak: update pyparsing 2.0.3 -> 2.2.0

2019-02-08 Thread Victor Toso
From: Victor Toso For flatpak, is better to keep dependencies somewhat close to what latest stable releases are shipping. Fedora 29 ships 2.2.0, so that's why I picked this release. Note that by following [0], latest release is from 13.01.2019, 2.3.1 while 2.2.0 is from 06.03.2017 and previous 2

[Spice-devel] [spice-gtk v1 07/10] gitlab-ci: create before_script per job

2019-02-08 Thread Victor Toso
From: Victor Toso * On a windows job-build, we don't need to install Fedora dependencies. This change makes only one dnf install be ran per job. * On a meson build, we should build spice-protocol with meson too. Moving this before_script rule to each job makes all of this clear. So, this pat

[Spice-devel] [spice-gtk v1 01/10] flatpak: Use 'master' runtime

2019-02-08 Thread Victor Toso
From: Victor Toso The spicy tool is a development tool and its flatpak should be targeting the master runtime. Current master runtime includes Opus, which is nice :) Also changes some style, to keep one argument/setting per line. Signed-off-by: Victor Toso --- data/org.spicespace.spicy.json |

[Spice-devel] [spice-gtk v1 05/10] gitlab-ci: group and rename jobs

2019-02-08 Thread Victor Toso
From: Victor Toso Group by target build instead of command. The focus of each job is to check any regression for given platform, using 'fedora'/'windows' and 'autotools'/'meson' seems more intuitive. By doing that we are grouping similar jobs together, this is intentional as we are reducing the

[Spice-devel] [spice-gtk v1 00/10] Flatpak + CI

2019-02-08 Thread Victor Toso
From: Victor Toso Hi, Trying to improve and integrate flatpak for spicy together with gitlab-ci. I hope the changes here makes sense to you. You can see the end result at: https://gitlab.freedesktop.org/victortoso/spice-gtk/pipelines/18268 Victor Toso (10): flatpak: Use 'master' runtime

[Spice-devel] [spice-gtk v1 10/10] gitlab-ci: add stages and manual flatpak generation

2019-02-08 Thread Victor Toso
From: Victor Toso This should make much easier to test spice-gtk changes, one must have to activate the flatpak stage manually if seems necessary. Note that the spicy.flatkpak bundle is around 1.1M Signed-off-by: Victor Toso --- .gitlab-ci.yml | 33 + 1 file ch

[Spice-devel] [spice-server v2 4/4] smartcard: Improve on_message_from_device readability

2019-02-08 Thread Christophe Fergeau
This removes a not really useful switch/case, and changes the function to exit early on error cases, rather than exiting early in the nominal case. Signed-off-by: Christophe Fergeau --- server/smartcard.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/server/sm

[Spice-devel] [spice-server v2 3/4] smartcard: Rework smartcard_get_vsc_msg_item a bit

2019-02-08 Thread Christophe Fergeau
This renames the method to smartcard_new_vsc_msg_item as this creates a new object. This also removes the creation of a temporary VHeader which is then going to be duplicated. Signed-off-by: Christophe Fergeau --- server/smartcard.c | 17 +++-- 1 file changed, 7 insertions(+), 10 del

[Spice-devel] [spice-server v2 1/4] smartcard: Remove unused smartcard_get_vsc_msg_item argument

2019-02-08 Thread Christophe Fergeau
Signed-off-by: Christophe Fergeau --- server/smartcard.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/server/smartcard.c b/server/smartcard.c index ff680d8a5..21dc8de5a 100644 --- a/server/smartcard.c +++ b/server/smartcard.c @@ -103,7 +103,7 @@ typedef struct RedMs

[Spice-devel] [spice-server v2 2/4] smartcard: Remove redundant test in smartcard_char_device_on_message_from_device()

2019-02-08 Thread Christophe Fergeau
The function returns NULL if vheader->type is VSC_Init so no need to check it a second time. Signed-off-by: Christophe Fergeau --- server/smartcard.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/smartcard.c b/server/smartcard.c index 21dc8de5a..39ada9c28 100644 ---

Re: [Spice-devel] [PATCH spice-server v3] Update usage of GObject private structures

2019-02-08 Thread Victor Toso
On Fri, Feb 08, 2019 at 06:11:29AM -0500, Frediano Ziglio wrote: > > > > New functions and macros have been added in glib 2.38 to better handle > > this case. > > > > https://gitlab.gnome.org/GNOME/glib/blob/c8de2b11bbbf5705ee20bf68d0c11e455b441312/NEWS > > > > G_TYPE_INSTANCE_GET_PRIVATE will b

Re: [Spice-devel] [PATCH spice-server v3] Update usage of GObject private structures

2019-02-08 Thread Frediano Ziglio
> > New functions and macros have been added in glib 2.38 to better handle > this case. > > https://gitlab.gnome.org/GNOME/glib/blob/c8de2b11bbbf5705ee20bf68d0c11e455b441312/NEWS > > G_TYPE_INSTANCE_GET_PRIVATE will be deprecated in GLib 2.58. > > https://gitlab.gnome.org/GNOME/glib/merge_reque