Hi Yuri,
Did you check how BasicDisplay.sys driver is getting default (initial) display
mode information on UEFI systems?
I did a check on both configurations: bare metal UEFI machine and VM (Windows
10 1803 x86 with OVMF).
BasicDisplay!BASIC_DISPLAY_DRIVER::StartDevice is the method that is p
New functions and macros have been added in glib 2.38 to better handle
this case.
https://gitlab.gnome.org/GNOME/glib/blob/c8de2b11bbbf5705ee20bf68d0c11e455b441312/NEWS
G_TYPE_INSTANCE_GET_PRIVATE will be deprecated in GLib 2.58.
https://gitlab.gnome.org/GNOME/glib/merge_requests/7/commits
Sign
On 2/7/19 2:42 PM, Frediano Ziglio wrote:
> Split long lines.
Sorry, I forgot to break the lines, my bad. I will squash this one as
well...
Small tip, next time you could use the --in-reply-to="" option
for git-send-email to keep the context, especially, with fixup patches
like this one.
Thank y
Split long lines.
---
server/common-graphics-channel.c | 6 --
server/cursor-channel-client.c | 3 ++-
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/server/common-graphics-channel.c b/server/common-graphics-channel.c
index 1bf44fee..b70fa3a4 100644
--- a/server/common-graph
> On 2/7/19 4:55 PM, Frediano Ziglio wrote:
> >>
> >> Just fixing the subject (spice-streaming-agent patch v4)
> >> Uri
> >>
> >> On 2/7/19 2:02 PM, Uri Lublin wrote:
> >>> Catch2 is now in upstream (github) and Fedora (since Fedora 27)
> >>>
> >>> Signed-off-by: Uri Lublin
> >>> ---
> >>>
> >>> S
On 2/7/19 4:55 PM, Frediano Ziglio wrote:
Just fixing the subject (spice-streaming-agent patch v4)
Uri
On 2/7/19 2:02 PM, Uri Lublin wrote:
Catch2 is now in upstream (github) and Fedora (since Fedora 27)
Signed-off-by: Uri Lublin
---
Since v3 (local only):
- Use AC_CHECK_HEADERS instead
The parameter file_page_offset is a constant shared by all drivers. Just
replace it with the constant itself.
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 1 -
drivers/gpu/drm/ast/ast_ttm.c | 1 -
drivers/gpu/drm/bochs/bochs_mm.c| 1
A BO's address has to be at least the minimum offset. Sharing this
test in ttm_bo_mmap() removes code from drivers. A full buffer-address
validation is still done within drm_vma_offset_lockup_locked().
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 9 ++--
Am 07.02.19 um 10:36 schrieb Koenig, Christian:
> Am 07.02.19 um 09:59 schrieb Thomas Zimmermann:
>> Almost all TTM-based drivers use the same values for the mmap-able
>> range of BO addresses. Each driver therefore duplicates the
>> DRM_FILE_PAGE_OFFSET constant. OTOH, the mmap range's size is not
Most TTM drivers define the constant DRM_FILE_PAGE_OFFSET of the same
value. The only exception is vboxvideo, which is being converted to the
new offset by this patch. Unifying the constants in a single place
simplifies the driver code.
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/amd/am
Hi
Am 07.02.19 um 09:59 schrieb Thomas Zimmermann:
> Most TTM drivers define the constant DRM_FILE_PAGE_OFFSET of the same
> value. The only exception is vboxvideo, which is being converted to the
> new offset by this patch. Unifying the constants in a single place
> simplifies the driver code.
J
The vboxvideo driver mmaps BOs at 0x1000 or higher. Changing the
offset to 0x1 aligns the driver with all other DRM drivers.
Signed-off-by: Thomas Zimmermann
---
drivers/staging/vboxvideo/vbox_drv.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/v
GEM defines DRM_FILE_PAGE_OFFSET_{START,SIZE} constants for the
mmap-able range of addresses. TTM can use them as well.
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/drm_gem.c | 17 -
drivers/gpu/drm/ttm/ttm_bo.c| 4 ++--
drivers/gpu/drm/ttm/ttm_bo_vm.c | 2 +-
Am 07.02.19 um 09:59 schrieb Thomas Zimmermann:
> Almost all TTM-based drivers use the same values for the mmap-able
> range of BO addresses. Each driver therefore duplicates the
> DRM_FILE_PAGE_OFFSET constant. OTOH, the mmap range's size is not
> configurable by drivers.
>
> This patch set replac
Almost all TTM-based drivers use the same values for the mmap-able
range of BO addresses. Each driver therefore duplicates the
DRM_FILE_PAGE_OFFSET constant. OTOH, the mmap range's size is not
configurable by drivers.
This patch set replaces driver-specific configuration with a single
setup. All
On 2/7/19 3:02 PM, Christophe Fergeau wrote:
Only RedCharDeviceVDIPortClass implements this vfunc, rather than
forcing every classes deriving from RedCharDeviceClass to implement it,
red_char_device_send_tokens_to_client() can deal with it.
Ack.
This is related to dev_client->do_flow_control a
>
> ---
> server/smartcard.c | 8 +++-
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/server/smartcard.c b/server/smartcard.c
> index 4c8494500..95dd90108 100644
> --- a/server/smartcard.c
> +++ b/server/smartcard.c
> @@ -108,7 +108,7 @@ typedef struct RedMsgItem {
>
On Thu, Feb 7, 2019 at 4:01 PM Eduardo Lima (Etrunko)
wrote:
>
> Since version 0.48, the python3 module has been deprecated:
>
> https://mesonbuild.com/Release-notes-for-0-48-0.html#python3-module-is-deprecated
>
> Signed-off-by: Eduardo Lima (Etrunko)
ack
> ---
> src/meson.build | 2 +-
> 1 f
ack
On Thu, Feb 7, 2019 at 4:01 PM Eduardo Lima (Etrunko)
wrote:
>
> Signed-off-by: Eduardo Lima (Etrunko)
> ---
> meson.build | 5 -
> 1 file changed, 5 deletions(-)
>
> diff --git a/meson.build b/meson.build
> index 8e540c9..1276fb9 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -299
>
> RedCharDevice subclasses are always implementing it by calling
> red_channel_client_shutdown().
>
> The only exception is RedStreamDevice. The various codepaths leading
> to a ::remove_client() call are not going to be hit as it does not have
> an associated channel client (it does not call r
>
> Explain how to get more verbose logs out of spice-server
>
> Signed-off-by: Christophe Fergeau
> ---
> docs/manual/manual.txt | 10 ++
> 1 file changed, 10 insertions(+)
>
> diff --git a/docs/manual/manual.txt b/docs/manual/manual.txt
> index 99f6a5c84..9de3c4701 100644
> --- a/doc
Since version 0.48, the python3 module has been deprecated:
https://mesonbuild.com/Release-notes-for-0-48-0.html#python3-module-is-deprecated
Signed-off-by: Eduardo Lima (Etrunko)
---
src/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/meson.build b/src/meson
Signed-off-by: Eduardo Lima (Etrunko)
---
meson.build | 5 -
1 file changed, 5 deletions(-)
diff --git a/meson.build b/meson.build
index 8e540c9..1276fb9 100644
--- a/meson.build
+++ b/meson.build
@@ -299,25 +299,20 @@ if d.found()
endif
# lz4
-spice_gtk_has_lz4 = false
d = dependency('
>
> Just fixing the subject (spice-streaming-agent patch v4)
> Uri
>
> On 2/7/19 2:02 PM, Uri Lublin wrote:
> > Catch2 is now in upstream (github) and Fedora (since Fedora 27)
> >
> > Signed-off-by: Uri Lublin
> > ---
> >
> > Since v3 (local only):
> >- Use AC_CHECK_HEADERS instead of AC_C
Just fixing the subject (spice-streaming-agent patch v4)
Uri
On 2/7/19 2:02 PM, Uri Lublin wrote:
Catch2 is now in upstream (github) and Fedora (since Fedora 27)
Signed-off-by: Uri Lublin
---
Since v3 (local only):
- Use AC_CHECK_HEADERS instead of AC_CHECK_HEADER
Since v2:
- Do not ass
Explain how to get more verbose logs out of spice-server
Signed-off-by: Christophe Fergeau
---
docs/manual/manual.txt | 10 ++
1 file changed, 10 insertions(+)
diff --git a/docs/manual/manual.txt b/docs/manual/manual.txt
index 99f6a5c84..9de3c4701 100644
--- a/docs/manual/manual.txt
+++
---
server/smartcard.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/server/smartcard.c b/server/smartcard.c
index 4c8494500..95dd90108 100644
--- a/server/smartcard.c
+++ b/server/smartcard.c
@@ -108,7 +108,7 @@ typedef struct RedMsgItem {
VSCMsgHeader* vheader;
RedCharDevice subclasses are always implementing it by calling
red_channel_client_shutdown().
The only exception is RedStreamDevice. The various codepaths leading
to a ::remove_client() call are not going to be hit as it does not have
an associated channel client (it does not call red_char_device_
Only RedCharDeviceVDIPortClass implements this vfunc, rather than
forcing every classes deriving from RedCharDeviceClass to implement it,
red_char_device_send_tokens_to_client() can deal with it.
---
server/char-device.c | 3 +++
server/red-stream-device.c | 7 ---
server/smartcard.c
New functions and macros have been added in glib 2.38 to better handle
this case.
https://gitlab.gnome.org/GNOME/glib/blob/c8de2b11bbbf5705ee20bf68d0c11e455b441312/NEWS
G_TYPE_INSTANCE_GET_PRIVATE will be deprecated in GLib 2.58.
https://gitlab.gnome.org/GNOME/glib/merge_requests/7/commits
Sign
On 2/7/19 6:50 AM, Frediano Ziglio wrote:
> Use TYPE_get_instance_private instead which was introduced in GLib
> 2.38.
> G_TYPE_INSTANCE_GET_PRIVATE will be deprecated in GLib 2.58.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/char-device.c | 4 +---
> server/common-graphics-c
Catch2 is now in upstream (github) and Fedora (since Fedora 27)
Signed-off-by: Uri Lublin
---
Since v3 (local only):
- Use AC_CHECK_HEADERS instead of AC_CHECK_HEADER
Since v2:
- Do not assume the .h files are under /usr/include
Since v1:
- Check both Catch2 and Catch
---
configure.ac
>
> G_ADD_PRIVATE was added in 2.38 and older functions are getting deprecated:
> https://gitlab.gnome.org/GNOME/glib/merge_requests/7/commits
>
> Signed-off-by: Eduardo Lima (Etrunko)
Looks good and works.
Can you split long lines?
I also sent a follow up to this, feel free to squash into thi
Use TYPE_get_instance_private instead which was introduced in GLib
2.38.
G_TYPE_INSTANCE_GET_PRIVATE will be deprecated in GLib 2.58.
Signed-off-by: Frediano Ziglio
---
server/char-device.c | 4 +---
server/common-graphics-channel.c | 11 ++-
server/cursor-channel-client.c
34 matches
Mail list logo
