Re: [Spice-devel] [PATCH] spec: call semanage in posttrans not in post

2019-02-05 Thread Frediano Ziglio
> On Tue, Feb 05, 2019 at 09:30:39AM -0500, Frediano Ziglio wrote: > > > > > > It can happen that selinux-policy (targeted) is installed only after > > > spice-streaming-agent (upon system installation). In that case > > > running semanage in post scriptlet will fail. > > > > > > In posttrans all

Re: [Spice-devel] [PATCH] spec: call semanage in posttrans not in post

2019-02-05 Thread Christophe Fergeau
On Tue, Feb 05, 2019 at 09:30:39AM -0500, Frediano Ziglio wrote: > > > > It can happen that selinux-policy (targeted) is installed only after > > spice-streaming-agent (upon system installation). In that case > > running semanage in post scriptlet will fail. > > > > In posttrans all packages are

Re: [Spice-devel] [PATCH] spec: call semanage in posttrans not in post

2019-02-05 Thread Frediano Ziglio
> > It can happen that selinux-policy (targeted) is installed only after > spice-streaming-agent (upon system installation). In that case > running semanage in post scriptlet will fail. > > In posttrans all packages are already installed, so it should be > safe to call semanage at that point. >

Re: [Spice-devel] [spice-server v2 1/2] build-sys: Raise glib requirement to 2.38

2019-02-05 Thread Christophe Fergeau
On Tue, Feb 05, 2019 at 06:27:11AM -0500, Frediano Ziglio wrote: > > > > meson is already using 2.38, and most distros have a newer version: > > - Fedora 28 has 2.56 > > - CentOS 7 has 2.46 > > - Debian 9 has 2.50 > > I would add the spice-common, a strong dependency of spice-server a

Re: [Spice-devel] [spice-server v2 1/2] build-sys: Raise glib requirement to 2.38

2019-02-05 Thread Eduardo Lima (Etrunko)
On 2/5/19 9:24 AM, Christophe Fergeau wrote: > meson is already using 2.38, and most distros have a newer version: > - Fedora 28 has 2.56 > - CentOS 7 has 2.46 > - Debian 9 has 2.50 > --- > configure.ac | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/confi

Re: [Spice-devel] [spice-server v2 1/2] build-sys: Raise glib requirement to 2.38

2019-02-05 Thread Frediano Ziglio
> > meson is already using 2.38, and most distros have a newer version: > - Fedora 28 has 2.56 > - CentOS 7 has 2.46 > - Debian 9 has 2.50 I would add the spice-common, a strong dependency of spice-server already needs 2.38. Beside that, Acked-by: Frediano Ziglio > --- > configur

[Spice-devel] [spice-server v2 2/2] memslot: Fix off-by-one error in group/slot boundary check

2019-02-05 Thread Christophe Fergeau
RedMemSlotInfo keeps an array of groups, and each group contains an array of slots. Unfortunately, these checks are off by 1, they check that the index is greater or equal to the number of elements in the array, while these arrays are 0 based. The check should only check for strictly greater than t

[Spice-devel] [spice-server v2 1/2] build-sys: Raise glib requirement to 2.38

2019-02-05 Thread Christophe Fergeau
meson is already using 2.38, and most distros have a newer version: - Fedora 28 has 2.56 - CentOS 7 has 2.46 - Debian 9 has 2.50 --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index fa79af7f1..604a41b21 100644 --- a/

Re: [Spice-devel] [spice-server] memslot: Fix off-by-one error in group/slot boundary check

2019-02-05 Thread Frediano Ziglio
> > RedMemSlotInfo keeps an array of groups, and each group contains an > array of slots. Unfortunately, these checks are off by 1, they check > that the index is greater or equal to the number of elements in the > array, while these arrays are 0 based. The check should only check for > strictly g

Re: [Spice-devel] [spice-server] memslot: Fix off-by-one error in group/slot boundary check

2019-02-05 Thread Frediano Ziglio
> > RedMemSlotInfo keeps an array of groups, and each group contains an > array of slots. Unfortunately, these checks are off by 1, they check > that the index is greater or equal to the number of elements in the > array, while these arrays are 0 based. The check should only check for > strictly g

Re: [Spice-devel] [PATCH spice-common 1/2] log: remove deprecated SPICE_ABORT_LEVEL support

2019-02-05 Thread Frediano Ziglio
ping the series > > This feature was marked obsolete by efd1d3cb4d8eee more than > three years ago. > > Signed-off-by: Frediano Ziglio > --- > common/log.c | 30 +- > tests/test-logging.c | 39 +-- > 2 files changed, 2 ins

Re: [Spice-devel] [vdagent-linux 1/2] README: Drop obsolete information

2019-02-05 Thread Victor Toso
On Tue, 2019-02-05 at 10:03 +0100, Christophe Fergeau wrote: > Ping? > > On Mon, Jan 14, 2019 at 12:16:48PM +0100, Christophe Fergeau wrote: > > The README still references QEMU < 0.14, and mentions Gerd and Hans > > which have not been active on spice-vdagent for a few years. > > > > Signed-off-

Re: [Spice-devel] [Qemu-devel] [PATCH v2] spice: set device address and device display ID in QXL interface

2019-02-05 Thread Gerd Hoffmann
On Tue, Feb 05, 2019 at 10:13:28AM +0100, Gerd Hoffmann wrote: > On Mon, Feb 04, 2019 at 11:08:10AM +0100, Lukáš Hrázký wrote: > > Calls the new SPICE QXL interface function spice_qxl_set_device_info to > > set the hardware address of the graphics device represented by the QXL > > interface (e.g. a

[Spice-devel] [spice-server] memslot: Fix off-by-one error in group/slot boundary check

2019-02-05 Thread Christophe Fergeau
RedMemSlotInfo keeps an array of groups, and each group contains an array of slots. Unfortunately, these checks are off by 1, they check that the index is greater or equal to the number of elements in the array, while these arrays are 0 based. The check should only check for strictly greater than t

Re: [Spice-devel] [PATCH v2] spice: set device address and device display ID in QXL interface

2019-02-05 Thread Gerd Hoffmann
On Mon, Feb 04, 2019 at 11:08:10AM +0100, Lukáš Hrázký wrote: > Calls the new SPICE QXL interface function spice_qxl_set_device_info to > set the hardware address of the graphics device represented by the QXL > interface (e.g. a PCI path) and the device display IDs (the IDs of the > device's monito

Re: [Spice-devel] [spice-server v2] ssl: Dump OpenSSL error stack on errors

2019-02-05 Thread Christophe Fergeau
Ping? On Mon, Jan 14, 2019 at 11:59:17AM +0100, Christophe Fergeau wrote: > Bugs such as https://bugzilla.redhat.com/show_bug.cgi?id=1651882 can be > quite tricky to figure out without the detailed OpenSSL error. This > commit adds a detailed dump of the OpenSSL error stack when an OpenSSL > failu

Re: [Spice-devel] [vdagent-linux 1/2] README: Drop obsolete information

2019-02-05 Thread Christophe Fergeau
Ping? On Mon, Jan 14, 2019 at 12:16:48PM +0100, Christophe Fergeau wrote: > The README still references QEMU < 0.14, and mentions Gerd and Hans > which have not been active on spice-vdagent for a few years. > > Signed-off-by: Christophe Fergeau > --- > README | 11 --- > 1 file changed,