Re: [Spice-devel] [PATCH spice-common 2/4] meson: Bump requirement to 0.48

2019-02-04 Thread Eduardo Lima (Etrunko)
On 2/4/19 10:47 AM, Frediano Ziglio wrote: >> >> This version is already required by both spice-server and spice-gtk, so >> there is no much sense in keeping it for spice-protocol as well. >> > > spice-server currently requires 0.47.2. Message is wrong, I thought spice-server would get 0.48 befo

Re: [Spice-devel] [PATCH spice-server 2/3] reds: Factor out a function to build VDAgentGraphicsDeviceInfo message

2019-02-04 Thread Christophe Fergeau
Hey, On Mon, Feb 04, 2019 at 02:27:52PM +, Frediano Ziglio wrote: > Instead of scanning the monitor twice (one to compute the size > and another to build the message) use a single function. I'm not sure I'm sold on this approach as this makes everything more complex ;) If you want to split re

Re: [Spice-devel] [PATCH spice-server 1/3] red-stream-device: Constify stream_device_get_device_display_info result

2019-02-04 Thread Christophe Fergeau
Acked-by: Christophe Fergeau On Mon, Feb 04, 2019 at 02:27:51PM +, Frediano Ziglio wrote: > There should be no reason for the caller to modify the internal > structure. > > Signed-off-by: Frediano Ziglio > --- > server/red-stream-device.c | 2 +- > server/red-stream-device.h | 2 +- > ser

Re: [Spice-devel] [PATCH spice-jhbuild] Build spice modules with meson

2019-02-04 Thread Christophe Fergeau
Dunno how much people are using this moduleset, but Acked-by: Christophe Fergeau On Mon, Feb 04, 2019 at 11:30:44AM -0200, Eduardo Lima (Etrunko) wrote: > Signed-off-by: Eduardo Lima (Etrunko) > --- > jhbuildrc| 2 ++ > modulesets/spice.xml | 35 ++-

Re: [Spice-devel] [Qemu-devel] [PATCH v2] spice: set device address and device display ID in QXL interface

2019-02-04 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190204100810.14800-1-lhra...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #

Re: [Spice-devel] [spice-html5]Converting to NodeJS

2019-02-04 Thread Cedric Bosdonnat
On Mon, 2019-02-04 at 08:30 -0600, Jeremy White wrote: > > > I'd be delighted if spice-html5 had a proper name space! > > > > How should we proceed? I could implement this using ES6 exports, > > but > > that rules out really old browsers. Not sure if CommonJS exports > > would > > cover a broader

Re: [Spice-devel] [spice-html5]Converting to NodeJS

2019-02-04 Thread Jeremy White
I'd be delighted if spice-html5 had a proper name space! How should we proceed? I could implement this using ES6 exports, but that rules out really old browsers. Not sure if CommonJS exports would cover a broader audience thought. To some extent, spice-html5 does not support truly old browser

[Spice-devel] [PATCH spice-server 3/3] test-stream-device: Check monitor ID messages

2019-02-04 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/tests/test-stream-device.c | 53 +++ 1 file changed, 53 insertions(+) diff --git a/server/tests/test-stream-device.c b/server/tests/test-stream-device.c index f1707d2f..b0448cf8 100644 --- a/server/tests/test-stream-device.c

[Spice-devel] [PATCH spice-server 1/3] red-stream-device: Constify stream_device_get_device_display_info result

2019-02-04 Thread Frediano Ziglio
There should be no reason for the caller to modify the internal structure. Signed-off-by: Frediano Ziglio --- server/red-stream-device.c | 2 +- server/red-stream-device.h | 2 +- server/reds.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/server/red-stream-

[Spice-devel] [PATCH spice-server 2/3] reds: Factor out a function to build VDAgentGraphicsDeviceInfo message

2019-02-04 Thread Frediano Ziglio
Instead of scanning the monitor twice (one to compute the size and another to build the message) use a single function. Signed-off-by: Frediano Ziglio --- server/reds.c | 137 -- 1 file changed, 65 insertions(+), 72 deletions(-) diff --git a/serve

Re: [Spice-devel] [PATCH spice-server 1/3] meson: Use underscorify() instead of split()

2019-02-04 Thread Frediano Ziglio
> > Signed-off-by: Eduardo Lima (Etrunko) > --- > meson.build | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/meson.build b/meson.build > index 5f402a5f..811099c6 100644 > --- a/meson.build > +++ b/meson.build > @@ -192,8 +192,7 @@ endif > # > # global C defines >

Re: [Spice-devel] [PATCH spice-common 1/4] meson: Use underscorify() instead of split()

2019-02-04 Thread Eduardo Lima (Etrunko)
On 2/4/19 10:45 AM, Frediano Ziglio wrote: >> >> Signed-off-by: Eduardo Lima (Etrunko) >> --- >> meson.build | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/meson.build b/meson.build >> index 80e4b1c..e26d817 100644 >> --- a/meson.build >> +++ b/meson.build >> @@ -16

[Spice-devel] [PATCH spice-jhbuild] Build spice modules with meson

2019-02-04 Thread Eduardo Lima (Etrunko)
Signed-off-by: Eduardo Lima (Etrunko) --- jhbuildrc| 2 ++ modulesets/spice.xml | 35 ++- 2 files changed, 20 insertions(+), 17 deletions(-) diff --git a/jhbuildrc b/jhbuildrc index 8b15ef6..1fb1c0e 100644 --- a/jhbuildrc +++ b/jhbuildrc @@ -11,6 +11,

Re: [Spice-devel] [PATCH spice-server 1/2] meson: Bump libcacard requirement to 2.5.1

2019-02-04 Thread Frediano Ziglio
> > This had already been done for autotools in spice-common commit > 924f47a653bd87fbd50229ee34b58d7b9a3f1ec8. > > Signed-off-by: Eduardo Lima (Etrunko) > --- > meson.build| 15 ++- > server/smartcard.c | 4 > 2 files changed, 2 insertions(+), 17 deletions(-) > > dif

Re: [Spice-devel] [spice-html5]Converting to NodeJS

2019-02-04 Thread Cedric Bosdonnat
On Fri, 2019-02-01 at 13:07 -0600, Jeremy White wrote: > On 2/1/19 11:55 AM, Cedric Bosdonnat wrote: > > I'm pondering converting spice-html5 before submitting it to > > npmjs.org. > > In the move I'ld move everythin into a SpiceHtml5 namespace. > > > > How does that sound? I'm ready to invest som

Re: [Spice-devel] [PATCH spice-common 3/4] meson: Bump libcacard requirement to 2.5.1

2019-02-04 Thread Frediano Ziglio
> > Commit 924f47 did this for autotools, do the same for meson. > > Signed-off-by: Eduardo Lima (Etrunko) Acked-by: Frediano Ziglio > --- > common/messages.h | 4 > meson.build | 6 -- > 2 files changed, 10 deletions(-) > > diff --git a/common/messages.h b/common/messages.h

Re: [Spice-devel] [PATCH spice-common 2/4] meson: Bump requirement to 0.48

2019-02-04 Thread Frediano Ziglio
> > This version is already required by both spice-server and spice-gtk, so > there is no much sense in keeping it for spice-protocol as well. > spice-server currently requires 0.47.2. > It is necessary to update the usage of the python module as described in > the documentation: > > https://m

Re: [Spice-devel] [PATCH spice-common 1/4] meson: Use underscorify() instead of split()

2019-02-04 Thread Frediano Ziglio
> > Signed-off-by: Eduardo Lima (Etrunko) > --- > meson.build | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/meson.build b/meson.build > index 80e4b1c..e26d817 100644 > --- a/meson.build > +++ b/meson.build > @@ -164,8 +164,7 @@ endif > # > # global C defines > #

[Spice-devel] [PATCH spice-server 1/2] meson: Bump libcacard requirement to 2.5.1

2019-02-04 Thread Eduardo Lima (Etrunko)
This had already been done for autotools in spice-common commit 924f47a653bd87fbd50229ee34b58d7b9a3f1ec8. Signed-off-by: Eduardo Lima (Etrunko) --- meson.build| 15 ++- server/smartcard.c | 4 2 files changed, 2 insertions(+), 17 deletions(-) diff --git a/meson.build b

[Spice-devel] [PATCH spice-common 4/4] meson: switch smartcard option to auto feature

2019-02-04 Thread Eduardo Lima (Etrunko)
In spice-gtk commit dbdf692909f7a2b272b06a674a38a1aeb4303032, the smartcard option has been changed from boolean to feature, which actually broke the option yeld, because the option type is incompatible between superproject and subproject. Signed-off-by: Eduardo Lima (Etrunko) --- meson.build

[Spice-devel] [PATCH spice-server 2/2] meson: switch smartcard option to auto feature

2019-02-04 Thread Eduardo Lima (Etrunko)
Make it compatible with spice-common. Signed-off-by: Eduardo Lima (Etrunko) --- meson.build | 14 ++ meson_options.txt | 3 +-- 2 files changed, 7 insertions(+), 10 deletions(-) diff --git a/meson.build b/meson.build index f6580fc2..ec1518ec 100644 --- a/meson.build +++ b/mes

[Spice-devel] [PATCH spice-common 3/4] meson: Bump libcacard requirement to 2.5.1

2019-02-04 Thread Eduardo Lima (Etrunko)
Commit 924f47 did this for autotools, do the same for meson. Signed-off-by: Eduardo Lima (Etrunko) --- common/messages.h | 4 meson.build | 6 -- 2 files changed, 10 deletions(-) diff --git a/common/messages.h b/common/messages.h index 2399b08..3e37235 100644 --- a/common/message

[Spice-devel] [PATCH spice-common 2/4] meson: Bump requirement to 0.48

2019-02-04 Thread Eduardo Lima (Etrunko)
This version is already required by both spice-server and spice-gtk, so there is no much sense in keeping it for spice-protocol as well. It is necessary to update the usage of the python module as described in the documentation: https://mesonbuild.com/Release-notes-for-0-48-0.html#python3-module-

[Spice-devel] [PATCH spice-common 1/4] meson: Use underscorify() instead of split()

2019-02-04 Thread Eduardo Lima (Etrunko)
Signed-off-by: Eduardo Lima (Etrunko) --- meson.build | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 80e4b1c..e26d817 100644 --- a/meson.build +++ b/meson.build @@ -164,8 +164,7 @@ endif # # global C defines # -glib_major_minor = glib_vers

Re: [Spice-devel] [PATCH spice-gtk] channel-display-gst.c: Update the described codeflow comment

2019-02-04 Thread Frediano Ziglio
> --- > > Please notice also to the readability and understandability :p > > --- > src/channel-display-gst.c | 37 + > 1 file changed, 21 insertions(+), 16 deletions(-) > > diff --git a/src/channel-display-gst.c b/src/channel-display-gst.c > index 4272ade..bc

[Spice-devel] [PATCH v2] spice: set device address and device display ID in QXL interface

2019-02-04 Thread Lukáš Hrázký
Calls the new SPICE QXL interface function spice_qxl_set_device_info to set the hardware address of the graphics device represented by the QXL interface (e.g. a PCI path) and the device display IDs (the IDs of the device's monitors that belong to this QXL interface). Also stops using the deprecate

[Spice-devel] [PATCH spice-gtk] channel-display-gst.c: Update the described codeflow comment

2019-02-04 Thread Snir Sheriber
--- Please notice also to the readability and understandability :p --- src/channel-display-gst.c | 37 + 1 file changed, 21 insertions(+), 16 deletions(-) diff --git a/src/channel-display-gst.c b/src/channel-display-gst.c index 4272ade..bc9f3f2 100644 --- a/s