Re: [Spice-devel] [PATCH] spec: call semanage in posttrans not in post

2019-01-29 Thread Daniel P . Berrangé
On Tue, Jan 29, 2019 at 06:40:32PM +0200, Uri Lublin wrote: > It can happen that selinux-policy (targeted) is installed only after > spice-streaming-agent (upon system installation). In that case > running semanage in post scriptlet will fail. > > In posttrans all packages are already installed, s

[Spice-devel] [PATCH] spec: call semanage in posttrans not in post

2019-01-29 Thread Uri Lublin
It can happen that selinux-policy (targeted) is installed only after spice-streaming-agent (upon system installation). In that case running semanage in post scriptlet will fail. In posttrans all packages are already installed, so it should be safe to call semanage at that point. rhbz#1647789 Sig

[Spice-devel] [PATCH linux vdagent] Fix coding style

2019-01-29 Thread Jonathon Jongsma
Use brackets everywhere. --- src/vdagent/device-info.c | 28 +++- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/src/vdagent/device-info.c b/src/vdagent/device-info.c index 7c0f615..4983543 100644 --- a/src/vdagent/device-info.c +++ b/src/vdagent/device-info

Re: [Spice-devel] [PATCH linux vdagent v5 1/7] Add lookup_xrand_output_for_device_info()

2019-01-29 Thread Jonathon Jongsma
On Tue, 2019-01-29 at 10:17 -0500, Frediano Ziglio wrote: > Can you use the coding style at least for new code? > In particular always use brackets, code is half with and half without Oh, I already pushed after Lukas's ACK. I'll send a follow-up patch fixing some bracket usage. Not sure how I miss

Re: [Spice-devel] [PATCH] catch: directory is now catch2

2019-01-29 Thread Frediano Ziglio
> Upstream and since Fedora 27 > > Signed-off-by: Uri Lublin Does it work on RHEL7 ? > --- > > Another option is to check both catch/ and catch2/ > and pick the one that is installed on the system, if any > > --- > configure.ac | 4 ++-- > src/unittests/test-mjpeg-fa

[Spice-devel] [PATCH] catch: directory is now catch2

2019-01-29 Thread Uri Lublin
Upstream and since Fedora 27 Signed-off-by: Uri Lublin --- Another option is to check both catch/ and catch2/ and pick the one that is installed on the system, if any --- configure.ac | 4 ++-- src/unittests/test-mjpeg-fallback.cpp | 2 +- src/unittests/test-stream-por

Re: [Spice-devel] [PATCH linux vdagent v5 1/7] Add lookup_xrand_output_for_device_info()

2019-01-29 Thread Frediano Ziglio
Can you use the coding style at least for new code? In particular always use brackets, code is half with and half without > > Add a function to look up an xrandr output for a given device display > id. This uses sysfs and the drm subsystem to lookup information about a > graphics device output. I

Re: [Spice-devel] [PATCH linux vdagent v5 0/7] Use the PCI addr and display ID

2019-01-29 Thread Lukáš Hrázký
For the series: Acked-by: Lukáš Hrázký On Wed, 2019-01-23 at 16:18 -0600, Jonathon Jongsma wrote: > This is a patch set that handles the PCI address and device dispay ID > sent down to the agent by the server, and uses that to maintain a map > for looking up a particular xrandr output for a giv

[Spice-devel] [PATCH spice-streaming-agent v5 5/6] Send the GraphicsDeviceInfo to the server

2019-01-29 Thread Lukáš Hrázký
Adds serialization of the GraphicsDeviceInfo message and sends it to the server when it starts to stream. Signed-off-by: Lukáš Hrázký Acked-by: Jonathon Jongsma --- configure.ac | 2 +- src/spice-streaming-agent.cpp | 65 ++- 2 files changed, 57

Re: [Spice-devel] [PATCH] smartcard: do not keep weak ref when device is NULL

2019-01-29 Thread Frediano Ziglio
> > When a client disconnects, smartcard_channel_client_set_char_device > is called with a NULL "device" argument. In that case there is > no need to take a weak reference to the device. > > Without this patch the server complains: > g_object_add_weak_pointer: assertion 'G_IS_OBJECT (object)' f

[Spice-devel] [PATCH 1/3] drm/irq: Don't check for DRIVER_HAVE_IRQ in drm_irq_(un)install

2019-01-29 Thread Daniel Vetter
If a non-legacy driver calls these it's valid to assume there is interrupt support. The flag is really only needed for legacy drivers, which control IRQ enabling/disabling through the DRM_IOCTL_CONTROL legacy IOCTL. Also remove all the flag usage from non-legacy drivers. v2: Review from Emil: - i

Re: [Spice-devel] [vdagent-linux] vdagent: Silently ignore missing spicevmc device

2019-01-29 Thread Christophe Fergeau
On Tue, Jan 29, 2019 at 06:05:35AM -0500, Frediano Ziglio wrote: > > > > On most distros, spice-vdagent will be autostarted as part of the > > startup of the desktop environment session. This is done by > > spice-vdagent.desktop, which has no way of checking if we are in a virt > > environment wit

Re: [Spice-devel] [vdagent-linux] vdagent: Silently ignore missing spicevmc device

2019-01-29 Thread Frediano Ziglio
> > On most distros, spice-vdagent will be autostarted as part of the > startup of the desktop environment session. This is done by > spice-vdagent.desktop, which has no way of checking if we are in a virt > environment with the needed devices present. > > Currently, if /dev/virtio-ports/com.redh

[Spice-devel] [PATCH] smartcard: do not keep weak ref when device is NULL

2019-01-29 Thread Uri Lublin
When a client disconnects, smartcard_channel_client_set_char_device is called with a NULL "device" argument. In that case there is no need to take a weak reference to the device. Without this patch the server complains: g_object_add_weak_pointer: assertion 'G_IS_OBJECT (object)' failed and abor

[Spice-devel] [PATCH spice-common 2/2] log: remove deprecated SPICE_DEBUG_LEVEL support

2019-01-29 Thread Frediano Ziglio
This feature was marked obsolete by efd1d3cb4d8eee more than three years ago. Signed-off-by: Frediano Ziglio --- common/log.c | 86 tests/test-logging.c | 67 -- 2 files changed, 153 deletions(-) diff --git a/c

[Spice-devel] [PATCH spice-common 1/2] log: remove deprecated SPICE_ABORT_LEVEL support

2019-01-29 Thread Frediano Ziglio
This feature was marked obsolete by efd1d3cb4d8eee more than three years ago. Signed-off-by: Frediano Ziglio --- common/log.c | 30 +- tests/test-logging.c | 39 +-- 2 files changed, 2 insertions(+), 67 deletions(-) diff --

[Spice-devel] Compression efficiency (was: image-encoders: Initialize Zlib lazily)

2019-01-29 Thread Frediano Ziglio
About these compression and encodings. How is ZLib compared to Glz. Glz is really demanding in terms of memory resources (keep drawable to be freed and the hash table is really huge too). Is it worth having it? Is also quite tricky/complicated as is shared amongst different DisplayChannel connecti

Re: [Spice-devel] [PATCH] usbredirserver: Make compile under MacOS

2019-01-29 Thread Christophe Fergeau
On Mon, Jan 28, 2019 at 02:28:36PM -0500, Frediano Ziglio wrote: > > On Wed, Jan 23, 2019 at 10:09:25AM +, Frediano Ziglio wrote: > > > This fixes Gitlab issue #9 > > > (cfr https://gitlab.freedesktop.org/spice/usbredir/issues/9). > > > > > > Signed-off-by: Frediano Ziglio > > > --- > > > us

Re: [Spice-devel] [PATCH v2] drm/qxl: use ttm_tt

2019-01-29 Thread Noralf Trønnes
Den 29.01.2019 09.25, skrev Gerd Hoffmann: > qxl device will not dma, so we don't need ttm_dma_tt. Go use ttm_tt > instead, to avoid wasting resources (swiotlb bounce buffers for > example). > > Signed-off-by: Gerd Hoffmann > --- Acked-by: Noralf Trønnes _

[Spice-devel] [PATCH v2] drm/qxl: use ttm_tt

2019-01-29 Thread Gerd Hoffmann
qxl device will not dma, so we don't need ttm_dma_tt. Go use ttm_tt instead, to avoid wasting resources (swiotlb bounce buffers for example). Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/qxl/qxl_ttm.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu