From: Victor Toso
Similar to 172c521271a3d - if we don't, the agent might be waiting for
data till some timeout happens in the system, blocking copy-paste
feature and possibly freezing applications.
A way to reproduce is copy-paste big clipboard data between two spice
clients.
Also add some doc
From: Victor Toso
Should first check selection value before accessing those arrays.
The get_clipboard_from_selection() function does that for us.
Signed-off-by: Victor Toso
---
src/spice-gtk-session.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/src/spice-gtk-sessio
Hi,
On Wed, Jan 16, 2019 at 12:08:31AM +0400, Marc-André Lureau wrote:
> On Tue, Jan 15, 2019 at 8:11 PM Victor Toso wrote:
> >
> > From: Victor Toso
> >
> > Hi,
> >
> > Several iteractions trying to avoid some bug in X11 but in the end I
> > found the iteraction with Clibpoard managers (or any
Hi Christophe,
Thank you for your answer！
BR,
Don
At 2019-01-15 21:54:36, "Christophe Fergeau" wrote:
>Hey,
>
>On Thu, Jan 10, 2019 at 03:03:05PM +0800, 陈炤 wrote:
>> Hi,
>>
>>
>>
>> I read the spice server code, and find that the video stream detection
>> code is in server/spice-bit
Hi,
On Tue, Jan 15, 2019 at 11:22 AM Victor Toso wrote:
>
> From: Victor Toso
>
> * Set -> Sets (Jakub)
> * Clarify when onwer-changed event is called with
> owner == self (Jakub)
>
> Signed-off-by: Victor Toso
> ---
> src/spice-gtk-session.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 d
On Tue, Jan 15, 2019 at 8:11 PM Victor Toso wrote:
>
> From: Victor Toso
>
> Hi,
>
> Several iteractions trying to avoid some bug in X11 but in the end I
> found the iteraction with Clibpoard managers (or any other application
> that request/set clipboard data) a bit more urgent.
>
> Simple try h
Signed-off-by: Frediano Ziglio
---
src/vdagent/file-xfers.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/vdagent/file-xfers.c b/src/vdagent/file-xfers.c
index 78d5db3..67bad9e 100644
--- a/src/vdagent/file-xfers.c
+++ b/src/vdagent/file-xfers.c
@@ -220,10 +220,7 @
Variable is not used. Keep code to create file together.
Signed-off-by: Frediano Ziglio
---
src/vdagent/file-xfers.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/vdagent/file-xfers.c b/src/vdagent/file-xfers.c
index 67bad9e..77029e7 100644
--- a/src/vdagent/file-xfer
Avoid race condition creating file between checking file existence
with stat() and opening with open().
Directly create the file passing the O_EXCL flag.
Signed-off-by: Frediano Ziglio
---
src/vdagent/file-xfers.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(
Correct invalid value for a file descriptor is -1, not 0.
Signed-off-by: Frediano Ziglio
---
src/vdagent/file-xfers.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/vdagent/file-xfers.c b/src/vdagent/file-xfers.c
index b5aedd0..78d5db3 100644
--- a/src/vdagent/file-xfers.c
+++ b/src/vda
Make easier to test file creation
Signed-off-by: Frediano Ziglio
---
src/vdagent/file-xfers.c | 88
src/vdagent/file-xfers.h | 1 +
2 files changed, 53 insertions(+), 36 deletions(-)
diff --git a/src/vdagent/file-xfers.c b/src/vdagent/file-xfers.c
index
Signed-off-by: Frediano Ziglio
---
src/tests/test-file-xfers.c | 6 ++
src/vdagent/file-xfers.c| 3 ++-
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/src/tests/test-file-xfers.c b/src/tests/test-file-xfers.c
index 494adc9..e87efac 100644
--- a/src/tests/test-file-xfers.c
+
Signed-off-by: Frediano Ziglio
---
Makefile.am | 22 +++
src/tests/test-file-xfers.c | 73 +
2 files changed, 95 insertions(+)
create mode 100644 src/tests/test-file-xfers.c
diff --git a/Makefile.am b/Makefile.am
index 3e405bc..2aee440
Hi,
On Tue, Jan 15, 2019 at 05:11:36PM +0100, Victor Toso wrote:
> From: Victor Toso
>
> Hi,
>
> Several iteractions trying to avoid some bug in X11 but in the end I
> found the iteraction with Clibpoard managers (or any other application
> that request/set clipboard data) a bit more urgent.
>
From: Victor Toso
If SpiceGtkSession::allow-clipboard-managers is disabled, while the
spice client does not hold the keyboard-grab, every owner-change event
to clipboard change will be delayed and requested later when
keyboard-grab is received.
Signed-off-by: Victor Toso
---
src/spice-gtk-sess
From: Victor Toso
SpiceGtkSession::allow-clipboard-managers property is introduced to
enable other applications in the Client OS to set or fetch clipboard
data from a spice-gtk-session that is under keyboard-grab, which is
expected to be in use by the user.
This option is disabled by default as
From: Victor Toso
Hi,
Several iteractions trying to avoid some bug in X11 but in the end I
found the iteraction with Clibpoard managers (or any other application
that request/set clipboard data) a bit more urgent.
Simple try here, to not allow another application to request clipboard
data from
>
> Hi,
>
> On 1/15/19 3:42 PM, Frediano Ziglio wrote:
> >> Currently we set timestamps as buffer's PTS, this value may be changed by
> >> the pipeline in some cases and cause an unexpected buffer warnings (when
> >> GstVideoOverlay is not used). Use GstReferenceTimestampMeta when
> >> synchroniz
Hi,
On 1/15/19 3:42 PM, Frediano Ziglio wrote:
Currently we set timestamps as buffer's PTS, this value may be changed by
the pipeline in some cases and cause an unexpected buffer warnings (when
GstVideoOverlay is not used). Use GstReferenceTimestampMeta when
synchronization is made by spice.
Be
>
> From: Christian Hesse
>
> When loading the unit file, systemd 240 logs:
>
> systemd[1]: /usr/lib/systemd/system/spice-vdagentd.service:9: PIDFile=
> references path below legacy directory /var/run/, updating
> /var/run/spice-vdagentd/spice-vdagentd.pid →
> /run/spice-vdagentd/spice-vdagentd
On Tue, Jan 15, 2019 at 06:00:09PM +0400, Marc-André Lureau wrote:
> Hi
>
> On Tue, Jan 15, 2019 at 4:53 PM Christophe Fergeau
> wrote:
> >
> > Hey,
> >
> > On Fri, Jan 11, 2019 at 11:07:14PM +0400, marcandre.lur...@redhat.com wrote:
> > > @@ -0,0 +1,131 @@
> > > +The "spice" URI scheme
> > > +=
Hey,
On Mon, Jan 07, 2019 at 03:50:12PM +0200, Yuri Benditovich wrote:
> >
> > > if (!priv->host)
> > > -g_error("Out of memory allocating usbredirhost");
> > > +g_error("Out of memory initializing redirection support");
> > >
> > > -#if USBREDIR_VERSION >= 0x000701
> > > -
Hi,
I've just noticed I've somehow messed up my commits right before
sending the v2, disregard this one and 7/8 is two commits squashed
together it seems. I'll resend.
Cheers,
Lukas
On Mon, 2019-01-14 at 17:38 +0100, Lukáš Hrázký wrote:
> This commits adds the -export-dynamic linker flag to expo
Hi,
On 1/15/19 3:03 PM, Frediano Ziglio wrote:
The vaapisink plugin to support overlay requires the application
to provide the proper context. If you don't do so the plugin will
cause a crash of the application.
To avoid possible thread errors from X11 create a new Display
connection to pass to
Hi
On Tue, Jan 15, 2019 at 4:53 PM Christophe Fergeau wrote:
>
> Hey,
>
> On Fri, Jan 11, 2019 at 11:07:14PM +0400, marcandre.lur...@redhat.com wrote:
> > @@ -0,0 +1,131 @@
> > +The "spice" URI scheme
> > +==
> > +
> > +This document is inspired by 'The "vnc" URI Scheme' (rfc7
Hey,
On Thu, Jan 10, 2019 at 03:03:05PM +0800, 陈炤 wrote:
> Hi,
>
>
>
> I read the spice server code, and find that the video stream detection
> code is in server/spice-bitmap-utils.c. func
> bitmap_get_graduality_level will calculate a score, and the GRADUALITY
> is set based on the score.
>
>
>
> Currently we set timestamps as buffer's PTS, this value may be changed by
> the pipeline in some cases and cause an unexpected buffer warnings (when
> GstVideoOverlay is not used). Use GstReferenceTimestampMeta when
> synchronization is made by spice.
>
> Before applying this patch you can re
>
> Receives the GraphicsDeviceInfo message from the streaming agent and
> stores the data in a list on the streaming device.
>
> Signed-off-by: Lukáš Hrázký
> ---
> server/display-limits.h| 3 ++
> server/red-qxl.c | 2 +-
> server/red-stream-device.c | 67 +
The vaapisink plugin to support overlay requires the application
to provide the proper context. If you don't do so the plugin will
cause a crash of the application.
To avoid possible thread errors from X11 create a new Display
connection to pass to vaapisink.
Signed-off-by: Frediano Ziglio
---
To
On 15/01/2019 11:41, Daniel Vetter wrote:
> Having the probe helper stuff (which pretty much everyone needs) in
> the drm_crtc_helper.h file (which atomic drivers should never need) is
> confusing. Split them out.
>
> To make sure I actually achieved the goal here I went through all
> drivers. And
Currently we set timestamps as buffer's PTS, this value may be changed by
the pipeline in some cases and cause an unexpected buffer warnings (when
GstVideoOverlay is not used). Use GstReferenceTimestampMeta when
synchronization is made by spice.
Before applying this patch you can reproduce the war
Hey,
On Fri, Jan 11, 2019 at 11:07:14PM +0400, marcandre.lur...@redhat.com wrote:
> @@ -0,0 +1,131 @@
> +The "spice" URI scheme
> +==
> +
> +This document is inspired by 'The "vnc" URI Scheme' (rfc7869) and
> +attempts to document a standard Spice URI scheme.
> +
> +The normati
The vaapisink plugin to support overlay requires the application
to provide the proper context. If you don't do so the plugin will
cause a crash of the application.
To avoid possible thread errors from X11 create a new Display
connection to pass to vaapisink.
Signed-off-by: Frediano Ziglio
---
To
Acked-by: Snir Sheriber
On 1/9/19 12:09 PM, Frediano Ziglio wrote:
From: Marc-André Lureau
GStreamer is being increasingly used by spice-gtk. Let's make it a
core requirement.
Signed-off-by: Marc-André Lureau
---
.gitlab-ci.yml | 2 --
configure.ac | 41 +++
The vaapisink plugin to support overlay requires the application
to provide the proper context. If you don't do so the plugin will
cause a crash of the application.
To avoid possible thread errors from X11 create a new Display
connection to pass to vaapisink.
Signed-off-by: Frediano Ziglio
---
To
>
> On 1/15/19 12:22 PM, Frediano Ziglio wrote:
> > The vaapisink plugin to support overlay requires the application
> > to provide the proper context. If you don't do so the plugin will
> > cause a crash of the application.
> > To avoid possible thread errors from X11 create a new Display
> > con
>
> On Mon, Jan 14, 2019 at 8:36 PM Frediano Ziglio wrote:
> >
> > >
> > > From: Marc-André Lureau
> > >
> > > Signed-off-by: Marc-André Lureau
> > > ---
> > > docs/Makefile.am | 1 +
> > > docs/meson.build | 2 +-
> > > docs/spice_uri_scheme.txt | 131 +++
>
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
Acked-by: Frediano Ziglio
> ---
> docs/Makefile.am | 22 +++---
> docs/meson.build | 12 +++-
> 2 files changed, 22 insertions(+), 12 deletions(-)
>
> diff --git a/docs/Makefile.am b/docs/Makefile.am
>
On Tue, 15 Jan 2019, Daniel Vetter wrote:
> Having the probe helper stuff (which pretty much everyone needs) in
> the drm_crtc_helper.h file (which atomic drivers should never need) is
> confusing. Split them out.
>
> To make sure I actually achieved the goal here I went through all
> drivers. And
On Mon, Jan 14, 2019 at 8:36 PM Frediano Ziglio wrote:
>
> >
> > From: Marc-André Lureau
> >
> > Signed-off-by: Marc-André Lureau
> > ---
> > docs/Makefile.am | 1 +
> > docs/meson.build | 2 +-
> > docs/spice_uri_scheme.txt | 131 ++
> >
This patch fixes the issues I've experienced before
Ack
On 1/15/19 12:22 PM, Frediano Ziglio wrote:
Calling gst_video_overlay_handle_events after
gst_video_overlay_set_window_handle causes often a deadlock in
gstreamer-vaapi.
Reverting the calls fix this issue.
Signed-off-by: Frediano Ziglio
On 1/15/19 12:22 PM, Frediano Ziglio wrote:
The vaapisink plugin to support overlay requires the application
to provide the proper context. If you don't do so the plugin will
cause a crash of the application.
To avoid possible thread errors from X11 create a new Display
connection to pass to vaap
>
> The message contains information about the graphics device and monitor
> belonging to a particular video stream (which maps to a channel) from
> the streaming agent.
>
> Signed-off-by: Lukáš Hrázký
Acked-by: Frediano Ziglio
> ---
> spice/stream-device.h | 31 +
> The message serves for passing the device address and device display ID
> information for all display channels from SPICE server to the vd_agent.
>
> Signed-off-by: Lukáš Hrázký
Acked-by: Frediano Ziglio
> ---
> spice/vd_agent.h | 23 +++
> 1 file changed, 23 insertions
The vaapisink plugin to support overlay requires the application
to provide the proper context. If you don't do so the plugin will
cause a crash of the application.
To avoid possible thread errors from X11 create a new Display
connection to pass to vaapisink.
Signed-off-by: Frediano Ziglio
---
To
Calling gst_video_overlay_handle_events after
gst_video_overlay_set_window_handle causes often a deadlock in
gstreamer-vaapi.
Reverting the calls fix this issue.
Signed-off-by: Frediano Ziglio
---
src/spice-widget.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/spice-wi
From: Victor Toso
* Set -> Sets (Jakub)
* Clarify when onwer-changed event is called with
owner == self (Jakub)
Signed-off-by: Victor Toso
---
src/spice-gtk-session.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/src/spice-gtk-session.c b/src/spice-gtk-session.c
in
Hi,
On Mon, Jan 14, 2019 at 10:15:04PM +0100, Jakub Janku wrote:
> > The comment refers to the gtk_clipboard_clear() not
> > owner-changed event so you are right, of course. This comment
> > was probably a left over from different interactions that I
> > did in this code :(
> >
> > I'll send a fix
Hi,
On Mon, Jan 14, 2019 at 08:49:52PM +0100, Jakub Janku wrote:
> Hi,
>
> On Mon, Jan 14, 2019 at 1:34 PM Victor Toso wrote:
> >
> > From: Victor Toso
> >
> > * Sets -> Set (Jakub)
> > * Clarify when onwer-changed event is called with
> > owner == self (Jakub)
> >
> > Signed-off-by: Victor T
Hi,
On Tue, Jan 15, 2019 at 01:40:48AM +0400, Marc-André Lureau wrote:
> Hi
>
> On Tue, Jan 15, 2019 at 12:40 AM Jakub Janku wrote:
> >
> > Hi,
> >
> > On Mon, Jan 14, 2019 at 1:41 PM Marc-André Lureau
> > wrote:
> > >
> > > Hi
> > >
> > > On Mon, Jan 14, 2019 at 4:34 PM Victor Toso wrote:
> >
50 matches
Mail list logo
