On Mon, Jan 14, 2019 at 3:40 PM Jakub Janku wrote:
> > >
> > > Related: https://gitlab.freedesktop.org/spice/win32/vd_agent/issues/6
> > > Related: https://gitlab.freedesktop.org/spice/linux/vd_agent/issues/9
> > > Related: https://bugzilla.redhat.com/show_bug.cgi?id=1594876
> > >
> > > Changed in
On Fri, 2019-01-11 at 10:07 +0100, Lukáš Hrázký wrote:
> Hi,
>
> On Thu, 2019-01-10 at 15:27 -0600, Jonathon Jongsma wrote:
> > On Tue, 2019-01-08 at 16:28 +0100, Lukáš Hrázký wrote:
> > > Receives the GraphicsDeviceInfo message from the streaming agent
> > > and
> > > stores the data in a list on
On Fri, 2019-01-11 at 11:15 +0100, Lukáš Hrázký wrote:
> On Wed, 2019-01-09 at 11:36 -0600, Jonathon Jongsma wrote:
> > On Tue, 2019-01-08 at 16:26 +0100, Lukáš Hrázký wrote:
> > > Adds a function to let QEMU provide information to identify
> > > graphics
> > > devices and their monitors in the gue
Hi
On Tue, Jan 15, 2019 at 12:40 AM Jakub Janku wrote:
>
> Hi,
>
> On Mon, Jan 14, 2019 at 1:41 PM Marc-André Lureau
> wrote:
> >
> > Hi
> >
> > On Mon, Jan 14, 2019 at 4:34 PM Victor Toso wrote:
> > >
> > > From: Victor Toso
> > >
> > > On X11, the release-grab message might end up clearing t
Hi,
On Mon, Jan 14, 2019 at 10:34 AM Victor Toso wrote:
>
> Hi,
>
> On Sun, Jan 13, 2019 at 09:59:11PM +0100, Jakub Janku wrote:
> > Hi,
> >
> > I see that I'm being late to the party as this has already been
> > pushed upstream, but I'd like to comment anyway:
> >
> > On Thu, Jan 10, 2019 at 1:4
Hi,
On Mon, Jan 14, 2019 at 1:41 PM Marc-André Lureau
wrote:
>
> Hi
>
> On Mon, Jan 14, 2019 at 4:34 PM Victor Toso wrote:
> >
> > From: Victor Toso
> >
> > On X11, the release-grab message might end up clearing the
> > GtkClipboard which triggers the owner-changed callback having the
> > event
Hi,
On Mon, Jan 14, 2019 at 1:34 PM Victor Toso wrote:
>
> From: Victor Toso
>
> * Sets -> Set (Jakub)
> * Clarify when onwer-changed event is called with
> owner == self (Jakub)
>
> Signed-off-by: Victor Toso
> ---
> src/spice-gtk-session.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 d
The graphics_device_info message contains the device display ID
information (device address and device display ID). Stores the data in a
hash table in vdagent.
Signed-off-by: Lukáš Hrázký
---
src/vdagent/vdagent.c| 3 ++
src/vdagent/x11-priv.h | 1 +
src/vdagent/x11-randr.c
The message serves for passing the device address and device display ID
information for all display channels from SPICE server to the vd_agent.
Signed-off-by: Lukáš Hrázký
---
spice/vd_agent.h | 23 +++
1 file changed, 23 insertions(+)
diff --git a/spice/vd_agent.h b/spice/v
Sends the device address and device display IDs to the vdagent. The
message is sent either in reaction to the SPICE_MSGC_MAIN_AGENT_START
message or when the graphics device info changes.
Signed-off-by: Lukáš Hrázký
---
server/red-qxl.c | 20 +
server/red-qxl.h | 3 ++
ser
Receives the GraphicsDeviceInfo message from the streaming agent and
stores the data in a list on the streaming device.
Signed-off-by: Lukáš Hrázký
---
server/display-limits.h| 3 ++
server/red-qxl.c | 2 +-
server/red-stream-device.c | 67 --
Adds the graphics device info from the streaming device(s) to the
VDAgentGraphicsDeviceInfo message sent to the vd_agent.
Signed-off-by: Lukáš Hrázký
---
server/red-stream-device.c | 18 +++
server/red-stream-device.h | 7 +
server/reds.c | 63 ++
Adds an interface method to the FrameCapture class to get the device
display info (device address and device display id) for each display of
the graphics device that is captured.
Also adds functions to the API implementing this functionality for X11
in variants with and without DRM (the non-DRM ve
Hello,
this series introduces a new mechanism to identify monitors across the
host and guest boundary, using the pair (device_address and
device_display_id). device_address is a HW address of a graphics device
(a PCI address to be specific, though other address domains can be
used as well), device
The message contains information about the graphics device and monitor
belonging to a particular video stream (which maps to a channel) from
the streaming agent.
Signed-off-by: Lukáš Hrázký
---
spice/stream-device.h | 31 +++
1 file changed, 31 insertions(+)
diff --g
This commits adds the -export-dynamic linker flag to export dynamic
symbols to be used by the streaming agent's plugins. It also adds the
-fvisibility=hidden compiler flag to hide all symbols by default (along
with -fvisibility-inline-hidden for C++ inline functions).
Then it adds the visibility("
>
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
> ---
> docs/Makefile.am | 1 +
> docs/meson.build | 2 +-
> docs/spice_uri_scheme.txt | 131 ++
> 3 files changed, 133 insertions(+), 1 deletion(-)
> create mode 100644
>
> From: Marc-André Lureau
>
> That makes it easier to send patch series for spice-common.
>
> Signed-off-by: Marc-André Lureau
> ---
> .gitpublish | 3 +++
> 1 file changed, 3 insertions(+)
> create mode 100644 .gitpublish
>
> diff --git a/.gitpublish b/.gitpublish
> new file mode 100644
ping
>
> Signed-off-by: Frediano Ziglio
> ---
> server/inputs-channel.c | 8
> server/reds.c | 36 +++-
> server/reds.h | 2 +-
> 3 files changed, 24 insertions(+), 22 deletions(-)
>
> diff --git a/server/inputs-channel.c b/server/
The SpiceStat structure can be 20 or 24 bytes depending on alignment.
Being a memory mapped structure potentially used with lockless access,
it is not good to have it unaligned.
The only tool that we know of that reads this memory mapped file
(reds_stats) is able to detect if the structure is eithe
Trace when data is received from the guest and when is sent
to the client.
Signed-off-by: Frediano Ziglio
Acked-by: Victor Toso
---
server/red-stream-device.c | 6 ++
server/stream-channel.c| 5 +
2 files changed, 11 insertions(+)
diff --git a/server/red-stream-device.c b/server/re
Allow to use recorder library. See https://github.com/c3d/recorder for
details.
The main usage will be to collect statistics while the programs will run.
By default the recorder will be disabled at compile time. The idea of the
usage in SPICE is to collect data while the program run. Using current
recorder library will be used to collect some statistics during
development.
Signed-off-by: Frediano Ziglio
Acked-by: Victor Toso
---
configure.ac | 1 +
meson_options.txt| 5 +
subprojects/spice-common | 2 +-
3 files changed, 7 insertions(+), 1 deletion(-)
diff --git
This brings in the following changes:
Frediano Ziglio (11):
Update --enable-celt051 help string
test-marshaller: Make test_overflow static
test-marshaller: Make main declaration easier
test-region: Add missing dependencies
ci: Run tests on Windows using wine
Use
Changes since v3:
- split spice-common update;
- update recorder commit to remove Meson error.
Changes since v2:
- rebased
Frediano Ziglio (4):
Integrate recorder library
Update spice-common submodule
Allows to enable recorder integration
Trace streaming device data using recorder
confi
Hi,
On Mon, Jan 14, 2019 at 07:49:37AM -0500, Frediano Ziglio wrote:
> >
> > Hi,
> >
> > On Mon, Jan 14, 2019 at 12:16:24PM +, Frediano Ziglio wrote:
> > > This brings in the following changes:
> > >
> > > Frediano Ziglio (11):
> > > Update --enable-celt051 help string
> > > tes
Hi,
On Mon, Jan 14, 2019 at 04:40:35PM +0400, Marc-André Lureau wrote:
> Hi
>
> On Mon, Jan 14, 2019 at 4:34 PM Victor Toso wrote:
> >
> > From: Victor Toso
> >
> > On X11, the release-grab message might end up clearing the
> > GtkClipboard which triggers the owner-changed callback having the
>
On 1/10/19 7:08 PM, Victor Toso wrote:
Hi,
On Thu, Jan 10, 2019 at 12:51:04PM +0200, Yuri Benditovich wrote:
On Wed, Jan 9, 2019 at 3:35 PM Uri Lublin wrote:
On 1/9/19 3:30 PM, Yuri Benditovich wrote:
On Tue, Jan 8, 2019 at 3:09 PM Uri Lublin mailto:u...@redhat.com>> wrote:
On 1/8/1
Hi,
On 1/14/19 11:48 AM, Frediano Ziglio wrote:
Hi,
On 1/11/19 6:36 PM, Frediano Ziglio wrote:
The vaapisink plugin to support overlay requires the application
to provide the proper context. If you don't do so the plugin will
cause a crash of the application.
To avoid possible thread errors f
>
> Hi,
>
> On Mon, Jan 14, 2019 at 12:16:24PM +, Frediano Ziglio wrote:
> > This brings in the following changes:
> >
> > Frediano Ziglio (11):
> > Update --enable-celt051 help string
> > test-marshaller: Make test_overflow static
> > test-marshaller: Make main declaration
Hi
On Mon, Jan 14, 2019 at 4:34 PM Victor Toso wrote:
>
> From: Victor Toso
>
> On X11, the release-grab message might end up clearing the
> GtkClipboard which triggers the owner-changed callback having the
> event owner as NULL.
>
> We should not be calling gtk_clipboard_request_targets() in th
Hi,
On Mon, Jan 14, 2019 at 12:16:24PM +, Frediano Ziglio wrote:
> This brings in the following changes:
>
> Frediano Ziglio (11):
> Update --enable-celt051 help string
> test-marshaller: Make test_overflow static
> test-marshaller: Make main declaration easier
> test-
From: Victor Toso
* Sets -> Set (Jakub)
* Clarify when onwer-changed event is called with
owner == self (Jakub)
Signed-off-by: Victor Toso
---
src/spice-gtk-session.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/spice-gtk-session.c b/src/spice-gtk-session.c
i
From: Victor Toso
On X11, the release-grab message might end up clearing the
GtkClipboard which triggers the owner-changed callback having the
event owner as NULL.
We should not be calling gtk_clipboard_request_targets() in this
situation as is prone to errors as the intention here is request
cl
Hi
On Mon, Jan 14, 2019 at 3:26 PM Snir Sheriber wrote:
>
> Hi,
>
>
> On 1/13/19 6:31 PM, Marc-André Lureau wrote:
> > Hi
> >
> > On Sun, Jan 13, 2019 at 1:13 PM Snir Sheriber wrote:
> >>
> >> On 1/11/19 1:03 PM, marcandre.lur...@redhat.com wrote:
> >>> From: Marc-André Lureau
> >>>
> >>> There
>
> Hi,
>
> On Mon, Jan 14, 2019 at 10:03:03AM +, Frediano Ziglio wrote:
> > recorder library will be used to collect some statistics during
> > development.
> >
> > Signed-off-by: Frediano Ziglio
> > ---
> > configure.ac | 1 +
> > meson_options.txt| 5 +
> > subpr
This brings in the following changes:
Frediano Ziglio (11):
Update --enable-celt051 help string
test-marshaller: Make test_overflow static
test-marshaller: Make main declaration easier
test-region: Add missing dependencies
ci: Run tests on Windows using wine
Use
Hi
On Mon, Jan 14, 2019 at 4:00 PM Frediano Ziglio wrote:
>
> >
> > Hi
> >
> > On Sat, Jan 12, 2019 at 1:41 PM Frediano Ziglio wrote:
> > >
> > > >
> > > > From: Marc-André Lureau
> > > >
> > > > Signed-off-by: Marc-André Lureau
> > > > ---
> > > > NEWS | 26 ++
> > > >
Hey,
On Mon, Jan 14, 2019 at 06:28:28AM -0500, Frediano Ziglio wrote:
> >
> > From: Christian Hesse
> >
> > When loading the unit file, systemd 240 logs:
> >
> > systemd[1]: /usr/lib/systemd/system/spice-vdagentd.service:9: PIDFile=
> > references path below legacy directory /var/run/, updatin
>
> Hi
>
> On Sat, Jan 12, 2019 at 1:41 PM Frediano Ziglio wrote:
> >
> > >
> > > From: Marc-André Lureau
> > >
> > > Signed-off-by: Marc-André Lureau
> > > ---
> > > NEWS | 26 ++
> > > 1 file changed, 26 insertions(+)
> > >
> > > This is a preliminary patch for the v
On Mon, Jan 14, 2019 at 3:25 PM Snir Sheriber wrote:
>
> If GstStreamVolume is not implemented (e.g. in alsasrc) element value is
> set to NULL, this is causing some g_object assertions to fail.
>
> Signed-off-by: Snir Sheriber
ack,
thanks
> ---
> src/spice-gstaudio.c | 24 ---
>
> From: Christian Hesse
>
> When loading the unit file, systemd 240 logs:
>
> systemd[1]: /usr/lib/systemd/system/spice-vdagentd.service:9: PIDFile=
> references path below legacy directory /var/run/, updating
> /var/run/spice-vdagentd/spice-vdagentd.pid →
> /run/spice-vdagentd/spice-vdagentd
Hi,
On 1/13/19 6:31 PM, Marc-André Lureau wrote:
Hi
On Sun, Jan 13, 2019 at 1:13 PM Snir Sheriber wrote:
On 1/11/19 1:03 PM, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
There is a racy bug in pulsesrc that we can't easily workaround:
https://gitlab.freedesktop.org/gstreame
If GstStreamVolume is not implemented (e.g. in alsasrc) element value is
set to NULL, this is causing some g_object assertions to fail.
Signed-off-by: Snir Sheriber
---
src/spice-gstaudio.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/src/spice-g
On Mon, Jan 14, 2019 at 2:56 PM Victor Toso wrote:
>
> Hi,
>
> On Sun, Jan 13, 2019 at 08:31:43PM +0400, Marc-André Lureau wrote:
> > Hi
> >
> > On Sun, Jan 13, 2019 at 1:13 PM Snir Sheriber wrote:
> > >
> > >
> > > On 1/11/19 1:03 PM, marcandre.lur...@redhat.com wrote:
> > > > From: Marc-André L
Hi
On Mon, Jan 14, 2019 at 3:09 PM Victor Toso wrote:
>
> Hi,
>
> On Fri, Jan 11, 2019 at 01:39:22PM +0400, Marc-André Lureau wrote:
> > Hi
> >
> > On Thu, Jan 10, 2019 at 5:40 PM Victor Toso wrote:
> > >
> > > Hi,
> > >
> > > On Thu, Jan 10, 2019 at 05:18:48PM +0400, Marc-André Lureau wrote:
>
The README still references QEMU < 0.14, and mentions Gerd and Hans
which have not been active on spice-vdagent for a few years.
Signed-off-by: Christophe Fergeau
---
README | 11 ---
1 file changed, 11 deletions(-)
diff --git a/README b/README
index 2eefbc4..9d9360c 100644
--- a/README
Signed-off-by: Christophe Fergeau
---
README | 13 +
1 file changed, 13 insertions(+)
diff --git a/README b/README
index 9d9360c..b445243 100644
--- a/README
+++ b/README
@@ -56,3 +56,16 @@ the qemu cmdline:
-chardev spicevmc,name=vdagent,id=vdagent \
-device \
virtserialport,nr=
From: Christian Hesse
When loading the unit file, systemd 240 logs:
systemd[1]: /usr/lib/systemd/system/spice-vdagentd.service:9: PIDFile=
references path below legacy directory /var/run/, updating
/var/run/spice-vdagentd/spice-vdagentd.pid →
/run/spice-vdagentd/spice-vdagentd.pid; please update
>
> Instead of
> if (serveroutlen) {
> ...
> } else {
> red_stream_write_u32_le(stream, serveroutlen);
> }
>
> use 'red_stream_write_u32_le(stream, 0);' in the else block as it's
> slightly more obvious.
>
> Signed-off-by: Christophe Fergeau
Acked-by: Frediano Ziglio
> ---
> server/red-
Hi,
On Fri, Jan 11, 2019 at 01:39:22PM +0400, Marc-André Lureau wrote:
> Hi
>
> On Thu, Jan 10, 2019 at 5:40 PM Victor Toso wrote:
> >
> > Hi,
> >
> > On Thu, Jan 10, 2019 at 05:18:48PM +0400, Marc-André Lureau wrote:
> > > On Thu, Jan 10, 2019 at 4:47 PM Victor Toso wrote:
> > > >
> > > > From
Bugs such as https://bugzilla.redhat.com/show_bug.cgi?id=1651882 can be
quite tricky to figure out without the detailed OpenSSL error. This
commit adds a detailed dump of the OpenSSL error stack when an OpenSSL
failure happens.
In the bug above, this would have displayed:
(process:13154): Spice-WA
Hi,
On Mon, Jan 14, 2019 at 11:56:06AM +0100, Victor Toso wrote:
> Hi,
>
> On Sun, Jan 13, 2019 at 08:31:43PM +0400, Marc-André Lureau wrote:
> > Hi
> >
> > On Sun, Jan 13, 2019 at 1:13 PM Snir Sheriber wrote:
> > >
> > >
> > > On 1/11/19 1:03 PM, marcandre.lur...@redhat.com wrote:
> > > > From
Bugs such as https://bugzilla.redhat.com/show_bug.cgi?id=1651882 can be
quite tricky to figure out without the detailed OpenSSL error. This
commit adds a detailed dump of the OpenSSL error stack when an OpenSSL
failure happens.
In the bug above, this would have displayed:
(process:13154): Spice-WA
Instead of
if (serveroutlen) {
...
} else {
red_stream_write_u32_le(stream, serveroutlen);
}
use 'red_stream_write_u32_le(stream, 0);' in the else block as it's
slightly more obvious.
Signed-off-by: Christophe Fergeau
---
server/red-stream.c | 2 +-
1 file changed, 1 insertion(+), 1 deletio
Hi,
On Sun, Jan 13, 2019 at 08:31:43PM +0400, Marc-André Lureau wrote:
> Hi
>
> On Sun, Jan 13, 2019 at 1:13 PM Snir Sheriber wrote:
> >
> >
> > On 1/11/19 1:03 PM, marcandre.lur...@redhat.com wrote:
> > > From: Marc-André Lureau
> > >
> > > There is a racy bug in pulsesrc that we can't easily
Hi
On Sat, Jan 12, 2019 at 1:41 PM Frediano Ziglio wrote:
>
> >
> > From: Marc-André Lureau
> >
> > Signed-off-by: Marc-André Lureau
> > ---
> > NEWS | 26 ++
> > 1 file changed, 26 insertions(+)
> >
> > This is a preliminary patch for the v0.36 release notes, which sho
Hi,
On Mon, Jan 14, 2019 at 10:03:04AM +, Frediano Ziglio wrote:
> Trace when data is received from the guest and when is sent
> to the client.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/red-stream-device.c | 6 ++
> server/stream-channel.c| 5 +
> 2 files changed, 11 ins
Hi,
On Mon, Jan 14, 2019 at 10:03:03AM +, Frediano Ziglio wrote:
> recorder library will be used to collect some statistics during
> development.
>
> Signed-off-by: Frediano Ziglio
> ---
> configure.ac | 1 +
> meson_options.txt| 5 +
> subprojects/spice-common | 2 +
Hi,
On Mon, Jan 14, 2019 at 10:03:02AM +, Frediano Ziglio wrote:
> Allow to use recorder library. See https://github.com/c3d/recorder for
> details.
> The main usage will be to collect statistics while the programs will run.
> By default the recorder will be disabled at compile time. The idea
Trace when data is received from the guest and when is sent
to the client.
Signed-off-by: Frediano Ziglio
---
server/red-stream-device.c | 6 ++
server/stream-channel.c| 5 +
2 files changed, 11 insertions(+)
diff --git a/server/red-stream-device.c b/server/red-stream-device.c
index
Allow to use recorder library. See https://github.com/c3d/recorder for
details.
The main usage will be to collect statistics while the programs will run.
By default the recorder will be disabled at compile time. The idea of the
usage in SPICE is to collect data while the program run. Using current
recorder library will be used to collect some statistics during
development.
Signed-off-by: Frediano Ziglio
---
configure.ac | 1 +
meson_options.txt| 5 +
subprojects/spice-common | 2 +-
3 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/configure.ac b/config
Changes since v2:
- rebased
Frediano Ziglio (3):
Integrate recorder library
Allows to enable recorder integration
Trace streaming device data using recorder
configure.ac | 1 +
meson_options.txt | 5 +
server/red-stream-device.c | 6 ++
server/stream-channel.
>
> Hi,
>
>
> On 1/11/19 6:36 PM, Frediano Ziglio wrote:
> > The vaapisink plugin to support overlay requires the application
> > to provide the proper context. If you don't do so the plugin will
> > cause a crash of the application.
> > To avoid possible thread errors from X11 create a new Disp
Hi,
On Sat, Jan 12, 2019 at 02:48:11PM -0500, Frediano Ziglio wrote:
> >
> > Hi,
> >
> > On Wed, Dec 12, 2018 at 10:13:27AM +, Frediano Ziglio wrote:
> > > recorder library will be used to collect some statistics during
> > > development.
> >
> > If we use RECORDER() like in the following c
Hi,
On Sun, Jan 13, 2019 at 09:59:11PM +0100, Jakub Janku wrote:
> Hi,
>
> I see that I'm being late to the party as this has already been
> pushed upstream, but I'd like to comment anyway:
>
> On Thu, Jan 10, 2019 at 1:47 PM Victor Toso wrote:
> >
> > From: Victor Toso
> >
> > This patch impr
On Mon, Jan 14, 2019 at 12:59 PM Victor Toso wrote:
>
> From: Victor Toso
>
> Otherwise it breaks client to guest clipboard copy&paste.
>
> This reverts commit 84ea62de2e53b149f65e4d071fb5d70e121f6307.
> Signed-off-by: Victor Toso
ack
> ---
> src/spice-gtk-session.c | 3 +--
> 1 file changed,
From: Victor Toso
Otherwise it breaks client to guest clipboard copy&paste.
This reverts commit 84ea62de2e53b149f65e4d071fb5d70e121f6307.
Signed-off-by: Victor Toso
---
src/spice-gtk-session.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/spice-gtk-session.c b/src/s
Hi,
On Sat, Jan 12, 2019 at 06:29:00PM +0100, Jakub Janku wrote:
> Hi,
>
> On Fri, Jan 11, 2019 at 11:40 AM wrote:
> >
> > From: Marc-André Lureau
> >
> > After a clipboard-clear, the owner-changed signal is triggered, with
> > no owner. Let's avoid requesting for targets, that would lead to a
Hi
spice-protocol 0.12.15 can be found in
https://www.spice-space.org/download/releases/spice-protocol/spice-protocol-0.12.15.tar.bz2
Major changes in 0.12.15
* Add support for h265 video codec
* qxl_dev: Align QXLRam to 4 bytes
* meson: fix spice-protocol as subproject
71 matches
Mail list logo
