Re: [Spice-devel] [PATCH spice 3/8] Send the graphics device info to the vd_agent

2019-01-08 Thread Frediano Ziglio
> > Sends the device address and device display IDs to the vdagent. The > message is sent either in reaction to the SPICE_MSGC_MAIN_AGENT_START > message or when the graphics device info changes. > > TODO: doesn't resend the message on agent reconnect, FIXIT. Why is this a problem? What if the a

Re: [Spice-devel] [PATCH spice-protocol 1/8] Add the VDAgentGraphicsDeviceInfo message

2019-01-08 Thread Frediano Ziglio
> > The message serves for passing the device address and device display ID > information for all display channels from SPICE server to the vd_agent. > > Signed-off-by: Lukáš Hrázký > --- > spice/vd_agent.h | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/spice/vd_agen

Re: [Spice-devel] [PATCH spice-protocol 2/8] Add the StreamMsgGraphicsDeviceInfo message

2019-01-08 Thread Frediano Ziglio
> > The message contains information about the graphics device and monitor > belonging to a particular video stream (which maps to a channel) from > the streaming agent. > > Signed-off-by: Lukáš Hrázký > --- > spice/stream-device.h | 9 + > 1 file changed, 9 insertions(+) > > diff --gi

Re: [Spice-devel] [spice-gtk v2] gtk-session: do not request guest's clipboard data unnecessarily

2019-01-08 Thread james harvey
On Mon, Jan 7, 2019 at 7:41 AM Victor Toso wrote: > > From: Victor Toso > > If SpiceGtkSession is holding the keyboard, that's huge indication > that the client should not be requesting guest's clipboard data yet. > > This patch adds a check in clipboard_get() callback, to avoid such > requests.

Re: [Spice-devel] [PATCH spice-gtk 28/34] meson: switch vapi to auto feature

2019-01-08 Thread Marc-André Lureau
Hi On Tue, Jan 8, 2019 at 12:30 PM Christophe Fergeau wrote: > > On Mon, Jan 07, 2019 at 11:15:55PM +0400, Marc-André Lureau wrote: > > On Mon, Jan 7, 2019 at 8:21 PM Christophe Fergeau > > wrote: > > > > > > On Mon, Jan 07, 2019 at 12:00:57PM +0400, marcandre.lur...@redhat.com > > > wrote: >

Re: [Spice-devel] [PATCH spice-protocol] Add Spice URI Scheme document

2019-01-08 Thread Marc-André Lureau
Hi On Tue, Jan 8, 2019 at 5:52 PM Christophe Fergeau wrote: > > On Tue, Jan 08, 2019 at 04:40:47PM +0400, Marc-André Lureau wrote: > > Hi > > > > On Tue, Jan 8, 2019 at 4:24 PM Christophe Fergeau > > wrote: > > > > > > On Wed, Dec 19, 2018 at 06:33:59PM +0400, marcandre.lur...@redhat.com > > >

Re: [Spice-devel] [spice-gtk v1] option: Remove spice-usbredir-filter option

2019-01-08 Thread Marc-André Lureau
On Tue, Jan 8, 2019 at 7:43 PM Victor Toso wrote: > > From: Victor Toso > > Deprecated since v0.15 with: > > commit 0af80691680be769f3e9d1047ed27a0245cddab3 > Author: Hans de Goede > Date: Thu Oct 11 10:00:02 2012 +0200 > > Signed-off-by: Victor Toso ack! > --- > src/spice-opti

Re: [Spice-devel] Upstream UsbDk?

2019-01-08 Thread Marc-André Lureau
Hi On Tue, Jan 8, 2019 at 10:38 PM Yuri Benditovich wrote: > > > > On Tue, Jan 8, 2019 at 2:44 PM Marc-André Lureau > wrote: >> >> Hi >> >> On Tue, Jan 8, 2019 at 4:39 PM Yuri Benditovich >> wrote: >> > >> > Hi >> > >> > Due to some historical reasons the UsbDk is maintained at >> > https://g

Re: [Spice-devel] Upstream UsbDk?

2019-01-08 Thread Yuri Benditovich
On Tue, Jan 8, 2019 at 2:44 PM Marc-André Lureau wrote: > Hi > > On Tue, Jan 8, 2019 at 4:39 PM Yuri Benditovich > wrote: > > > > Hi > > > > Due to some historical reasons the UsbDk is maintained at > https://github.com/daynix/UsbDk and issues there are under monitoring > (according to rumors th

Re: [Spice-devel] Upstream UsbDk?

2019-01-08 Thread Yuri Benditovich
On Tue, Jan 8, 2019 at 4:11 PM Christophe Fergeau wrote: > On Tue, Jan 08, 2019 at 02:39:35PM +0200, Yuri Benditovich wrote: > > Hi > > > > Due to some historical reasons the UsbDk is maintained at > > https://github.com/daynix/UsbDk and issues there are under monitoring > > (according to rumors

Re: [Spice-devel] [spice-gtk v2] gtk-session: do not request guest's clipboard data unnecessarily

2019-01-08 Thread Jakub Janku
On Tue, Jan 8, 2019 at 10:06 AM Victor Toso wrote: > > Hi, > > Thanks for review! > > On Mon, Jan 07, 2019 at 09:28:04PM +0100, Jakub Janku wrote: > > Hi, > > > > On Mon, Jan 7, 2019 at 1:41 PM Victor Toso wrote: > > > > > > From: Victor Toso > > > > > > If SpiceGtkSession is holding the keyboar

[Spice-devel] [spice-gtk v1] option: Remove spice-usbredir-filter option

2019-01-08 Thread Victor Toso
From: Victor Toso Deprecated since v0.15 with: commit 0af80691680be769f3e9d1047ed27a0245cddab3 Author: Hans de Goede Date: Thu Oct 11 10:00:02 2012 +0200 Signed-off-by: Victor Toso --- src/spice-option.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/src/sp

[Spice-devel] [PATCH v3] option: Hide --spice-color-depth and warn on usage

2019-01-08 Thread Victor Toso
From: Victor Toso As this is NOP from previous patch and has been deprecated since v0.34 Signed-off-by: Victor Toso Acked-by: Christophe Fergeau --- src/spice-option.c | 28 +++- 1 file changed, 3 insertions(+), 25 deletions(-) diff --git a/src/spice-option.c b/src/sp

[Spice-devel] [PATCH spice-streaming-agent 6/8] Interface + implementation of getting device display info

2019-01-08 Thread Lukáš Hrázký
Adds an interface method to the FrameCapture class to get the device display info (device address and device display id) for each display of the graphics device that is captured. Also adds functions to the API implementing this functionality for X11 in variants with and without DRM (the non-DRM ve

[Spice-devel] [PATCH vd_agent 8/8] Receive the graphics_device_info message

2019-01-08 Thread Lukáš Hrázký
The graphics_device_info message contains the device display ID information (device address and device display ID). Stores the data in a hash table in vdagent. Signed-off-by: Lukáš Hrázký --- src/vdagent/vdagent.c| 3 ++ src/vdagent/x11-priv.h | 1 + src/vdagent/x11-randr.c

[Spice-devel] [PATCH spice-streaming-agent 7/8] Send the GraphicsDeviceInfo to the server

2019-01-08 Thread Lukáš Hrázký
Adds serialization of the GraphicsDeviceInfo message and sends it to the server when it starts to stream. Signed-off-by: Lukáš Hrázký --- src/spice-streaming-agent.cpp | 54 +-- 1 file changed, 45 insertions(+), 9 deletions(-) diff --git a/src/spice-streaming-age

[Spice-devel] [PATCH spice 4/8] Receive the GraphicsDeviceInfo message from the streaming agent

2019-01-08 Thread Lukáš Hrázký
Receives the GraphicsDeviceInfo message from the streaming agent and stores the data in a list on the streaming device. Signed-off-by: Lukáš Hrázký --- server/red-qxl.c | 1 - server/red-stream-device.c | 66 -- server/red-stream-device.h | 8 +

[Spice-devel] [PATCH spice 3/8] Send the graphics device info to the vd_agent

2019-01-08 Thread Lukáš Hrázký
Sends the device address and device display IDs to the vdagent. The message is sent either in reaction to the SPICE_MSGC_MAIN_AGENT_START message or when the graphics device info changes. TODO: doesn't resend the message on agent reconnect, FIXIT. Signed-off-by: Lukáš Hrázký --- server/red-qxl.

[Spice-devel] [PATCH spice-protocol 2/8] Add the StreamMsgGraphicsDeviceInfo message

2019-01-08 Thread Lukáš Hrázký
The message contains information about the graphics device and monitor belonging to a particular video stream (which maps to a channel) from the streaming agent. Signed-off-by: Lukáš Hrázký --- spice/stream-device.h | 9 + 1 file changed, 9 insertions(+) diff --git a/spice/stream-device

[Spice-devel] [PATCH spice 5/8] Send the graphics device info from streaming agent to the vd_agent

2019-01-08 Thread Lukáš Hrázký
Adds the graphics device info from the streaming device(s) to the VDAgentGraphicsDeviceInfo message sent to the vd_agent. Signed-off-by: Lukáš Hrázký --- server/red-stream-device.c | 14 ++ server/red-stream-device.h | 4 +++ server/reds.c | 56 +

[Spice-devel] [PATCH 0/8] Monitor ID between host and guest

2019-01-08 Thread Lukáš Hrázký
Hello, this series introduces a new mechanism to identify monitors across the host and guest boundary, using the pair (device_address and device_display_id). device_address is a HW address of a graphics device (a PCI address to be specific, though other address domains can be used as well), device

[Spice-devel] [PATCH spice-protocol 1/8] Add the VDAgentGraphicsDeviceInfo message

2019-01-08 Thread Lukáš Hrázký
The message serves for passing the device address and device display ID information for all display channels from SPICE server to the vd_agent. Signed-off-by: Lukáš Hrázký --- spice/vd_agent.h | 15 +++ 1 file changed, 15 insertions(+) diff --git a/spice/vd_agent.h b/spice/vd_agent.

[Spice-devel] [PATCH qemu 3/3] spice: set device address and device display ID in QXL interface

2019-01-08 Thread Lukáš Hrázký
Calls the new SPICE QXL interface function spice_qxl_set_device_info to set the hardware address of the graphics device represented by the QXL interface (e.g. a PCI path) and the device display IDs (the IDs of the device's monitors that belong to this QXL interface). Also stops using the deprecate

[Spice-devel] [PATCH spice/qemu 0/3] QXL interface to set monitor ID

2019-01-08 Thread Lukáš Hrázký
Hello, this is the final version of the new QXL interface to identify the graphics device monitors in the guest. This interface adds a function that allows to set the device path (e.g. a PCI path) and the IDs of the device's displays from QEMU to SPICE server. The server will forward this informat

[Spice-devel] [PATCH spice 2/3] QXL interface: deprecate spice_qxl_set_max_monitors

2019-01-08 Thread Lukáš Hrázký
Replace it by spice_qxl_set_device_info. Note we can't use monitors_count for what's stored in max_monitors, because monitors_count denotes the length of the device_display_ids array, which spice_qxl_set_max_monitors doesn't touch. Signed-off-by: Lukáš Hrázký --- server/red-qxl.c | 1 + server

[Spice-devel] [PATCH spice 1/3] QXL interface: add a function to identify monitors in the guest

2019-01-08 Thread Lukáš Hrázký
Adds a function to let QEMU provide information to identify graphics devices and their monitors in the guest. The function (spice_qxl_set_device_info) sets the device address (e.g. a PCI path) and monitor ID -> device display ID mapping of displays exposed by given QXL interface. Signed-off-by: Lu

Re: [Spice-devel] [spice-gtk v2 1/2] Deprecate “color-depth” properties

2019-01-08 Thread Victor Toso
Hi, On Tue, Jan 08, 2019 at 04:09:54PM +0100, Christophe Fergeau wrote: > On Fri, Dec 14, 2018 at 04:29:46PM +0100, Victor Toso wrote: > > From: Victor Toso > > > > With commit 1a980f3712 we deprecated some command line options. The > > color-depth one is the only one which is not used for testi

Re: [Spice-devel] Upstream UsbDk?

2019-01-08 Thread Snir Sheriber
Hi, On 1/8/19 4:11 PM, Christophe Fergeau wrote: On Tue, Jan 08, 2019 at 02:39:35PM +0200, Yuri Benditovich wrote: Hi Due to some historical reasons the UsbDk is maintained at https://github.com/daynix/UsbDk and issues there are under monitoring (according to rumors there were some problem wit

Re: [Spice-devel] [spice-gtk v2 1/2] Deprecate “color-depth” properties

2019-01-08 Thread Christophe Fergeau
On Fri, Dec 14, 2018 at 04:29:46PM +0100, Victor Toso wrote: > From: Victor Toso > > With commit 1a980f3712 we deprecated some command line options. The > color-depth one is the only one which is not used for testing/debug > purposes. > > The intention of this option is to set guest's video driv

Re: [Spice-devel] [spice-gtk v2 2/2] option: Hide --spice-color-depth and warn on usage

2019-01-08 Thread Christophe Fergeau
On Fri, Dec 14, 2018 at 04:29:47PM +0100, Victor Toso wrote: > From: Victor Toso > > As this is NOP from previous patch and has been deprecated since v0.34 > > Signed-off-by: Victor Toso > --- > src/spice-option.c | 28 +++- > 1 file changed, 3 insertions(+), 25 deletio

Re: [Spice-devel] Upstream UsbDk?

2019-01-08 Thread Christophe Fergeau
On Tue, Jan 08, 2019 at 02:39:35PM +0200, Yuri Benditovich wrote: > Hi > > Due to some historical reasons the UsbDk is maintained at > https://github.com/daynix/UsbDk and issues there are under monitoring > (according to rumors there were some problem with accounts/rights/etc on > the freedesktop)

Re: [Spice-devel] [PATCH spice-common v2] test: Add a test for subject_to_x509_name function

2019-01-08 Thread Christophe Fergeau
On Tue, Jan 08, 2019 at 12:47:05PM +, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > tests/Makefile.am | 20 +- > tests/meson.build | 2 +- > tests/test-ssl-verify.c | 134 > 3 files changed, 154 insertions(+), 2 del

Re: [Spice-devel] [PATCH spice-gtk 20/34] meson: switch lz4 option to auto feature

2019-01-08 Thread Christophe Fergeau
On Tue, Jan 08, 2019 at 05:30:46PM +0400, Marc-André Lureau wrote: > On Tue, Jan 8, 2019 at 12:58 PM Christophe Fergeau > wrote: > > > > On Mon, Jan 07, 2019 at 11:19:11PM +0400, Marc-André Lureau wrote: > > > Hi > > > > > > On Mon, Jan 7, 2019 at 7:58 PM Christophe Fergeau > > > wrote: > > > >

Re: [Spice-devel] [PATCH spice-common] Bump libcacard requirement to 2.5.1

2019-01-08 Thread Frediano Ziglio
> > Hi > > On Tue, Jan 8, 2019 at 3:38 PM Frediano Ziglio wrote: > > > > > > > > > > From: Marc-André Lureau > > > > > > > > v2.5.1 was released the 2015-11-24. > > > > > > > > According to repology, from the distro we care about, CentOS 6, > > > > openSUSE Leap 42.3 have too old version (0.1.2

Re: [Spice-devel] [PATCH spice-protocol] Add Spice URI Scheme document

2019-01-08 Thread Christophe Fergeau
On Tue, Jan 08, 2019 at 04:40:47PM +0400, Marc-André Lureau wrote: > Hi > > On Tue, Jan 8, 2019 at 4:24 PM Christophe Fergeau wrote: > > > > On Wed, Dec 19, 2018 at 06:33:59PM +0400, marcandre.lur...@redhat.com wrote: > > > +URI Parameters > > > +-- > > > + > > > +A description of hos

Re: [Spice-devel] [PATCH spice-gtk 0/5] Require GStreamer, fix build warnings

2019-01-08 Thread Frediano Ziglio
> > Hi, > > On Tue, Jan 08, 2019 at 08:25:09AM -0500, Frediano Ziglio wrote: > > > We have only GStreamer support for video, so let's make it > > > required. > > > > There's also mjpeg for video. > > I've tested mjpeg from GStreamer and works well too 0:-) > > > > There is no modularity needed

Re: [Spice-devel] How to use spice floder sharing

2019-01-08 Thread Christophe Fergeau
On Wed, Dec 19, 2018 at 11:49:26AM +0100, Victor Toso wrote: > Hi, > > On Wed, Dec 19, 2018 at 10:06:53AM +0800, wangjiedong wrote: > > Actually there are 2 questions. > > > Firstly , on Windows 7 vm i can install > > spice-webdavd-x64-2.2.msi and no error , but the service > > spice-webdavd in T

Re: [Spice-devel] [PATCH spice-gtk 0/5] Require GStreamer, fix build warnings

2019-01-08 Thread Victor Toso
Hi, On Tue, Jan 08, 2019 at 08:25:09AM -0500, Frediano Ziglio wrote: > > We have only GStreamer support for video, so let's make it > > required. > > There's also mjpeg for video. I've tested mjpeg from GStreamer and works well too 0:-) > > There is no modularity needed at this point, it can be

Re: [Spice-devel] [PATCH spice-gtk 20/34] meson: switch lz4 option to auto feature

2019-01-08 Thread Marc-André Lureau
On Tue, Jan 8, 2019 at 12:58 PM Christophe Fergeau wrote: > > On Mon, Jan 07, 2019 at 11:19:11PM +0400, Marc-André Lureau wrote: > > Hi > > > > On Mon, Jan 7, 2019 at 7:58 PM Christophe Fergeau > > wrote: > > > > > > On Mon, Jan 07, 2019 at 12:00:49PM +0400, marcandre.lur...@redhat.com > > > wr

Re: [Spice-devel] [PATCH spice-gtk 0/5] Require GStreamer, fix build warnings

2019-01-08 Thread Frediano Ziglio
> > Hi > > On Mon, Jan 7, 2019 at 5:46 PM Frediano Ziglio wrote: > > > > > Hi > > > > > > On Mon, Jan 7, 2019 at 3:44 PM Frediano Ziglio > > > wrote: > > > > > > > > > Hi > > > > > > > > > > On Sat, Jan 5, 2019 at 9:00 PM Frediano Ziglio > > > > > wrote: > > > > > > > > > > > > > > > > > > > >

Re: [Spice-devel] [PATCH spice-common v2 1/2] test-region: Add missing dependencies

2019-01-08 Thread Frediano Ziglio
> On Mon, Dec 17, 2018 at 06:56:19AM -0500, Frediano Ziglio wrote: > > > > > > The test uses both GLib and pixman libraries. > > > This does not seem to affect Linux but make the test fails under Windows. > > > > > > Signed-off-by: Frediano Ziglio > > > --- > > > tests/Makefile.am | 1 + > > >

Re: [Spice-devel] [spice-gtk PATCH v1] win-usb-dev: Set UsbDk backend on libusb 1.0.22

2019-01-08 Thread Uri Lublin
On 1/8/19 1:35 PM, Christophe Fergeau wrote: On Tue, Jan 08, 2019 at 11:02:04AM +0200, Uri Lublin wrote: win-usb-dev also uses libusb. Similar to commit 3e23fff9, set libusb backend to UsbDk. Without this patch usb devices are not seen by win-usb-dev (windows clients), when UsbDk driver is insta

Re: [Spice-devel] [RFC PATCH spice-common] marshaller: Provide spice_marshaller_fill_iovec for Windows

2019-01-08 Thread Christophe Fergeau
Acked-by: Christophe Fergeau On Mon, Dec 17, 2018 at 10:26:57AM +, Frediano Ziglio wrote: > An array of WSABUF can be used with WSASend. > > Signed-off-by: Frediano Ziglio > --- > common/marshaller.c | 10 -- > common/marshaller.h | 4 ++-- > 2 files changed, 10 insertions(+), 4

Re: [Spice-devel] [PATCH spice-common v2 1/2] test-region: Add missing dependencies

2019-01-08 Thread Christophe Fergeau
On Mon, Dec 17, 2018 at 06:56:19AM -0500, Frediano Ziglio wrote: > > > > The test uses both GLib and pixman libraries. > > This does not seem to affect Linux but make the test fails under Windows. > > > > Signed-off-by: Frediano Ziglio > > --- > > tests/Makefile.am | 1 + > > 1 file changed, 1

Re: [Spice-devel] [PATCH spice-common] Bump libcacard requirement to 2.5.1

2019-01-08 Thread Frediano Ziglio
> > Hi > > On Tue, Jan 8, 2019 at 3:35 PM Frediano Ziglio wrote: > > > > > > > > From: Marc-André Lureau > > > > > > v2.5.1 was released the 2015-11-24. > > > > > > According to repology, from the distro we care about, CentOS 6, > > > openSUSE Leap 42.3 have too old version (0.1.2). > > > > > >

[Spice-devel] [PATCH spice-common v2] test: Add a test for subject_to_x509_name function

2019-01-08 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- tests/Makefile.am | 20 +- tests/meson.build | 2 +- tests/test-ssl-verify.c | 134 3 files changed, 154 insertions(+), 2 deletions(-) create mode 100644 tests/test-ssl-verify.c Changes since v1: - do

Re: [Spice-devel] Upstream UsbDk?

2019-01-08 Thread Marc-André Lureau
Hi On Tue, Jan 8, 2019 at 4:39 PM Yuri Benditovich wrote: > > Hi > > Due to some historical reasons the UsbDk is maintained at > https://github.com/daynix/UsbDk and issues there are under monitoring > (according to rumors there were some problem with accounts/rights/etc on the > freedesktop).

Re: [Spice-devel] [PATCH spice-protocol] Add Spice URI Scheme document

2019-01-08 Thread Marc-André Lureau
Hi On Tue, Jan 8, 2019 at 4:24 PM Christophe Fergeau wrote: > > On Wed, Dec 19, 2018 at 06:33:59PM +0400, marcandre.lur...@redhat.com wrote: > > +URI Parameters > > +-- > > + > > +A description of host information and URI parameters is provided in > > +this section. Information on th

Re: [Spice-devel] Upstream UsbDk?

2019-01-08 Thread Yuri Benditovich
Hi Due to some historical reasons the UsbDk is maintained at https://github.com/daynix/UsbDk and issues there are under monitoring (according to rumors there were some problem with accounts/rights/etc on the freedesktop). It looks like there was working mirror at freedesktop but some time ago it s

Re: [Spice-devel] [PATCH spice-protocol] Add Spice URI Scheme document

2019-01-08 Thread Christophe Fergeau
On Wed, Dec 19, 2018 at 06:33:59PM +0400, marcandre.lur...@redhat.com wrote: > +URI Parameters > +-- > + > +A description of host information and URI parameters is provided in > +this section. Information on the constraints of various data types is > +provided in Section "Data Types".

Re: [Spice-devel] [PATCH spice-protocol] Add Spice URI Scheme document

2019-01-08 Thread Hoffmann, Gerd
On Tue, Jan 08, 2019 at 03:54:26PM +0400, Marc-André Lureau wrote: > Hi > > On Wed, Dec 19, 2018 at 6:56 PM Marc-André Lureau > wrote: > > > > Hi > > > > On Wed, Dec 19, 2018 at 6:43 PM Frediano Ziglio wrote: > > > > > > > > > > > From: Marc-André Lureau > > > > > > > > A recent discussion abou

Re: [Spice-devel] [PATCH spice-common 2/2] test: Add a test for subject_to_x509_name function

2019-01-08 Thread Christophe Fergeau
On Tue, Dec 18, 2018 at 12:19:28PM -0500, Frediano Ziglio wrote: > > On Thu, Dec 13, 2018 at 02:20:25PM +, Frediano Ziglio wrote: > > > Signed-off-by: Frediano Ziglio > > > --- > > > common/ssl_verify.c | 5 +- > > > common/ssl_verify.h | 4 ++ > > > tests/Makefile.am | 20

Re: [Spice-devel] [PATCH spice-protocol] Add Spice URI Scheme document

2019-01-08 Thread Marc-André Lureau
Hi On Wed, Dec 19, 2018 at 6:56 PM Marc-André Lureau wrote: > > Hi > > On Wed, Dec 19, 2018 at 6:43 PM Frediano Ziglio wrote: > > > > > > > > From: Marc-André Lureau > > > > > > A recent discussion about Spice URI scheme on the QEMU mailing list > > > with Gerd prompted me to make an effort to

Re: [Spice-devel] Spice Protocol changes

2019-01-08 Thread Christophe Fergeau
Hey, On Sun, Jan 06, 2019 at 02:12:55PM +0100, ucontacti ss wrote: > Dear developers, > > While I was looking in the packets using Wireshark I saw that the Major and > Minor version is 2 and not 1 anymore. And there are some discrepancies in > the Spice protocol v1.0 and the actual value of field

Re: [Spice-devel] [PATCH spice-common] Bump libcacard requirement to 2.5.1

2019-01-08 Thread Marc-André Lureau
Hi On Tue, Jan 8, 2019 at 3:38 PM Frediano Ziglio wrote: > > > > > > > From: Marc-André Lureau > > > > > > v2.5.1 was released the 2015-11-24. > > > > > > According to repology, from the distro we care about, CentOS 6, > > > openSUSE Leap 42.3 have too old version (0.1.2). > > > > > > > This pat

Re: [Spice-devel] [PATCH spice-server v3 02/32] red-replay-qxl: Use PRIxPTR constant for string formatting

2019-01-08 Thread Christophe Fergeau
Acked-by: Christophe Fergeau On Mon, Jan 07, 2019 at 06:01:45PM +, Frediano Ziglio wrote: > These constants are meant to be used in format string for pointers > types. Use them for portability. > > Signed-off-by: Frediano Ziglio > --- > server/red-replay-qxl.c | 2 +- > 1 file changed, 1

Re: [Spice-devel] [PATCH spice-common] Bump libcacard requirement to 2.5.1

2019-01-08 Thread Marc-André Lureau
Hi On Tue, Jan 8, 2019 at 3:35 PM Frediano Ziglio wrote: > > > > > From: Marc-André Lureau > > > > v2.5.1 was released the 2015-11-24. > > > > According to repology, from the distro we care about, CentOS 6, > > openSUSE Leap 42.3 have too old version (0.1.2). > > > > This patch tell me that now

Re: [Spice-devel] [PATCH spice-common] Bump libcacard requirement to 2.5.1

2019-01-08 Thread Frediano Ziglio
> > > > From: Marc-André Lureau > > > > v2.5.1 was released the 2015-11-24. > > > > According to repology, from the distro we care about, CentOS 6, > > openSUSE Leap 42.3 have too old version (0.1.2). > > > > This patch tell me that now we DON'T care about them. > Honestly I don't care any mo

Re: [Spice-devel] [spice-gtk PATCH v1] win-usb-dev: Set UsbDk backend on libusb 1.0.22

2019-01-08 Thread Christophe Fergeau
On Tue, Jan 08, 2019 at 11:02:04AM +0200, Uri Lublin wrote: > win-usb-dev also uses libusb. > Similar to commit 3e23fff9, set libusb backend to UsbDk. > Without this patch usb devices are not seen by win-usb-dev > (windows clients), when UsbDk driver is installed. > > Signed-off-by: Uri Lublin >

Re: [Spice-devel] [PATCH spice-common] Bump libcacard requirement to 2.5.1

2019-01-08 Thread Frediano Ziglio
> > From: Marc-André Lureau > > v2.5.1 was released the 2015-11-24. > > According to repology, from the distro we care about, CentOS 6, > openSUSE Leap 42.3 have too old version (0.1.2). > This patch tell me that now we DON'T care about them. Honestly I don't care any more about CentOS 6. Can

Re: [Spice-devel] [PATCH spice-gtk 0/5] Require GStreamer, fix build warnings

2019-01-08 Thread Christophe Fergeau
On Mon, Jan 07, 2019 at 11:30:55PM +0400, Marc-André Lureau wrote: > Since we would like to release v0.36 soonish, and there are valid > concerns that such a change now is a bit too risky, I propose to: > > - make GStreamer a blessed dependency in 0.36 for audio & video (since > it is required for

Re: [Spice-devel] [PATCH spice-gtk] build-sys: drop support for libcacard < 2.5.1

2019-01-08 Thread Christophe Fergeau
Acked-by: Christophe Fergeau On Tue, Jan 08, 2019 at 01:48:45PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > v2.5.1 was released the 2015-11-24. > > According to repology, from the distro we care about, CentOS 6, > openSUSE Leap 42.3 have too old version (0.1.2). >

Re: [Spice-devel] [PATCH spice-gtk 0/5] Require GStreamer, fix build warnings

2019-01-08 Thread Victor Toso
On Tue, Jan 08, 2019 at 02:41:22PM +0400, Marc-André Lureau wrote: > Hi > > On Tue, Jan 8, 2019 at 1:15 PM Victor Toso wrote: > > > > Hi, > > > > On Mon, Jan 07, 2019 at 11:30:55PM +0400, Marc-André Lureau wrote: > > > > > In the future, yes! For now, use GStreamer by default if possible, and > >

[Spice-devel] Upstream UsbDk?

2019-01-08 Thread Marc-André Lureau
Hi, Where is UsbDk officially maintained? What is the homepage? Where should I file bugs? Apparently, https://gitlab.freedesktop.org/spice/win32/usbdk should be the upstream. But Daynix maintains its own on github https://github.com/daynix/UsbDk, which is more recent, and more active, looking at

Re: [Spice-devel] [PATCH spice-gtk 0/5] Require GStreamer, fix build warnings

2019-01-08 Thread Marc-André Lureau
Hi On Tue, Jan 8, 2019 at 1:15 PM Victor Toso wrote: > > Hi, > > On Mon, Jan 07, 2019 at 11:30:55PM +0400, Marc-André Lureau wrote: > > > > In the future, yes! For now, use GStreamer by default if possible, and > > > > fallback on pulse. > > > > > > > > See also proposed implementation: > > > > "

[Spice-devel] [PATCH spice-gtk] build-sys: drop support for libcacard < 2.5.1

2019-01-08 Thread marcandre . lureau
From: Marc-André Lureau v2.5.1 was released the 2015-11-24. According to repology, from the distro we care about, CentOS 6, openSUSE Leap 42.3 have too old version (0.1.2). SPICE_CHECK_SMARTCARD is updated with spice-common. Signed-off-by: Marc-André Lureau --- meson.build | 18

Re: [Spice-devel] [PATCH spice-gtk 0/5] Require GStreamer, fix build warnings

2019-01-08 Thread Victor Toso
Hi, On Mon, Jan 07, 2019 at 11:30:55PM +0400, Marc-André Lureau wrote: > > > In the future, yes! For now, use GStreamer by default if possible, and > > > fallback on pulse. > > > > > > See also proposed implementation: > > > "[PATCH spice-gtk 32/34] gst: check pulseaudio plugin version >= 1.15" >

Re: [Spice-devel] [spice-gtk v2] gtk-session: do not request guest's clipboard data unnecessarily

2019-01-08 Thread Victor Toso
Hi, Thanks for review! On Mon, Jan 07, 2019 at 09:28:04PM +0100, Jakub Janku wrote: > Hi, > > On Mon, Jan 7, 2019 at 1:41 PM Victor Toso wrote: > > > > From: Victor Toso > > > > If SpiceGtkSession is holding the keyboard, that's huge indication > > that the client should not be requesting gues

[Spice-devel] [spice-gtk PATCH v1] win-usb-dev: Set UsbDk backend on libusb 1.0.22

2019-01-08 Thread Uri Lublin
win-usb-dev also uses libusb. Similar to commit 3e23fff9, set libusb backend to UsbDk. Without this patch usb devices are not seen by win-usb-dev (windows clients), when UsbDk driver is installed. Signed-off-by: Uri Lublin --- Additionally I think the code need to check that usbdk driver is inde

Re: [Spice-devel] [PATCH spice-gtk 20/34] meson: switch lz4 option to auto feature

2019-01-08 Thread Christophe Fergeau
On Mon, Jan 07, 2019 at 11:19:11PM +0400, Marc-André Lureau wrote: > Hi > > On Mon, Jan 7, 2019 at 7:58 PM Christophe Fergeau wrote: > > > > On Mon, Jan 07, 2019 at 12:00:49PM +0400, marcandre.lur...@redhat.com wrote: > > > From: Marc-André Lureau > > > > > > Contrary to spice server dependency,

Re: [Spice-devel] [PATCH spice-common] Bump libcacard requirement to 2.5.1

2019-01-08 Thread Christophe Fergeau
On Tue, Jan 08, 2019 at 11:41:23AM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > v2.5.1 was released the 2015-11-24. s/the/on/ > > According to repology, from the distro we care about, CentOS 6, > openSUSE Leap 42.3 have too old version (0.1.2). > > spice-gtk & spice

Re: [Spice-devel] [PATCH spice-gtk 16/34] meson: switch pulse option to auto feature

2019-01-08 Thread Christophe Fergeau
On Mon, Jan 07, 2019 at 11:02:04PM +0400, Marc-André Lureau wrote: > Hi > > On Mon, Jan 7, 2019 at 6:15 PM Christophe Fergeau wrote: > > > > On Mon, Jan 07, 2019 at 12:00:45PM +0400, marcandre.lur...@redhat.com wrote: > > > From: Marc-André Lureau > > > > > > Signed-off-by: Marc-André Lureau >

Re: [Spice-devel] [PATCH spice-gtk 28/34] meson: switch vapi to auto feature

2019-01-08 Thread Christophe Fergeau
On Mon, Jan 07, 2019 at 11:15:55PM +0400, Marc-André Lureau wrote: > On Mon, Jan 7, 2019 at 8:21 PM Christophe Fergeau wrote: > > > > On Mon, Jan 07, 2019 at 12:00:57PM +0400, marcandre.lur...@redhat.com wrote: > > > From: Marc-André Lureau > > > > > > Removed unused vapigen/vapidir variables as