From: Marc-André Lureau
v2.5.1 was released the 2015-11-24.
According to repology, from the distro we care about, CentOS 6,
openSUSE Leap 42.3 have too old version (0.1.2).
spice-gtk & spice-server will have to be updated to drop
USE_SMARTCARD_012.
Signed-off-by: Marc-André Lureau
---
m4/spi
There are basically three ways to refer to an output within vdagent:
- The index of the array of MonitorConfig message. This is essentially
a "spice display id"
- the index of the array of xrandr outputs. This is the "output index"
- the xrandr output id. This is the "output ID"
Previous
When the agent gets a new device info message (from the daemon), we need
to re-calculate the guest output map and send that information back down
to the daemon so that it can handle mouse input events correctly.
---
src/vdagent/x11-randr.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src
Rather than getting the current guest resolution in a
VDAgentMonitorsConfig struct and then translating it to a new struct
type for sending down to the daemon, simply use the new function that
was factored out in a previous commit and populate the message struct
directly.
---
src/vdagent/x11-randr
When sending the guest xorg resolution to the vdagentd daemon, we get
the current resolution with this function, which returns a
VDAgentMonitorsConfig structure that must then be converted to the
structure that we send to the daemon. Rather than re-using this function
that returns the wrong type, f
Add a display_id field to the structure that we use to send down the
list of guest display resolutions to the vdagentd daemon. This allows us
to map the spice display id to the proper X display for determining
mouse locations, etc.
---
src/vdagent/x11-randr.c | 35 -
Instead of storing each device address and device display ID in the hash
table, simply use the lookup_xrandr_output_for_device_info() function to
look up the ID of the xrandr output and store that in the hash table.
---
src/vdagent/x11-priv.h | 2 +-
src/vdagent/x11-randr.c | 47
This is a patch set that handles the PCI address and device dispay ID
sent down to the agent by the server, and uses that to maintain a map
for looking up a particular xrandr output for a given spice display id.
This patch series builds on the patch from Lukas titled "Receive the
graphics_device_i
---
src/vdagent/vdagent.c | 68 +
src/vdagent/x11-priv.h | 1 +
src/vdagent/x11-randr.c | 58 +++
src/vdagent/x11.c | 13
src/vdagent/x11.h | 1 +
5 files changed, 74 insertions(+), 67 deletions(-)
d
Add a function to look up an xrandr output for a given device display
id. This uses sysfs and the drm subsystem to lookup information about a
graphics device output. It then compares the drm output name to xrandr
output names to try to match that device output to an xrandr output.
This is necesary
instead of using the spice display id directly as the xrandr output,
look it up using our new guest output map
---
src/vdagent/x11-randr.c | 78 -
1 file changed, 69 insertions(+), 9 deletions(-)
diff --git a/src/vdagent/x11-randr.c b/src/vdagent/x11-randr.
Hi,
On Mon, Jan 7, 2019 at 1:41 PM Victor Toso wrote:
>
> From: Victor Toso
>
> If SpiceGtkSession is holding the keyboard, that's huge indication
> that the client should not be requesting guest's clipboard data yet.
>
> This patch adds a check in clipboard_get() callback, to avoid such
> reque
Hi
On Mon, Jan 7, 2019 at 5:46 PM Frediano Ziglio wrote:
>
> > Hi
> >
> > On Mon, Jan 7, 2019 at 3:44 PM Frediano Ziglio wrote:
> > >
> > > > Hi
> > > >
> > > > On Sat, Jan 5, 2019 at 9:00 PM Frediano Ziglio
> > > > wrote:
> > > > >
> > > > > >
> > > > > > Hi
> > > > > >
> > > > > > On Sat, Jan
Hi
On Mon, Jan 7, 2019 at 7:58 PM Christophe Fergeau wrote:
>
> On Mon, Jan 07, 2019 at 12:00:49PM +0400, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > Contrary to spice server dependency, spice-gtk doesn't have a known
> > minimum version requirement.
>
> Ideally, we'd
Hi
On Mon, Jan 7, 2019 at 8:06 PM Christophe Fergeau wrote:
>
> On Mon, Jan 07, 2019 at 12:00:52PM +0400, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > The desktop-integration code works by attempting to connect to GNOME
> > Session Manager. If it is absent, it will prin
On Mon, Jan 7, 2019 at 8:21 PM Christophe Fergeau wrote:
>
> On Mon, Jan 07, 2019 at 12:00:57PM +0400, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > Removed unused vapigen/vapidir variables as well.
> >
> > Signed-off-by: Marc-André Lureau
> > ---
> > meson.build
On Mon, Jan 7, 2019 at 6:24 PM Christophe Fergeau wrote:
>
> On Mon, Jan 07, 2019 at 12:00:47PM +0400, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > Signed-off-by: Marc-André Lureau
> > ---
> > meson.build | 32 +++-
> > meson_options.t
Hi
On Mon, Jan 7, 2019 at 6:22 PM Christophe Fergeau wrote:
>
> On Mon, Jan 07, 2019 at 12:00:46PM +0400, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > Signed-off-by: Marc-André Lureau
> > ---
> > .gitlab-ci.yml| 1 -
> > meson.build | 15 +--
> >
Hi
On Mon, Jan 7, 2019 at 6:15 PM Christophe Fergeau wrote:
>
> On Mon, Jan 07, 2019 at 12:00:45PM +0400, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > Signed-off-by: Marc-André Lureau
> > ---
> > .gitlab-ci.yml| 1 -
> > meson.build | 8 +++-
> > meson_o
On Mon, Jan 7, 2019 at 6:06 PM Christophe Fergeau wrote:
>
> On Mon, Jan 07, 2019 at 12:00:42PM +0400, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > Let's turn explicit true/false option into features which can be
> > autodetected and turned all enabled/disabled at once.
Hi
On Mon, Jan 7, 2019 at 8:22 PM Christophe Fergeau wrote:
>
> On Mon, Jan 07, 2019 at 12:01:02PM +0400, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > The pulse backend is getting deprecated.
>
> Not sure this is something we should do right before a release rather
> th
The definitions in the header are not used.
Also this fixes porting SPICE to Windows where the header is not
available.
Signed-off-by: Frediano Ziglio
---
ui/spice-core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/ui/spice-core.c b/ui/spice-core.c
index 525e0929b9..fb87944a24 100644
---
Although this feature can be ported to Windows doing so would
require the usage of g_spawn_async_with_fds, which is only available
in GLib 2.58 or some specific Win32 code.
Signed-off-by: Frediano Ziglio
---
server/red-record-qxl.c| 7 +++
server/tests/test-record.c | 7 +--
2 files
Allows the compiler to catch errors mixing int and sockets.
Make easier to keep Windows port working.
This technique was used to port SPICE server to Windows.
Signed-off-by: Frediano Ziglio
---
server/sys-socket.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/sys-soc
Signed-off-by: Frediano Ziglio
---
README.Windows | 18 ++
1 file changed, 18 insertions(+)
create mode 100644 README.Windows
diff --git a/README.Windows b/README.Windows
new file mode 100644
index ..a953813d
--- /dev/null
+++ b/README.Windows
@@ -0,0 +1,18 @@
+SPICE ser
Client process termination did not work for Windows, used Win32
APIs.
Signed-off-by: Frediano Ziglio
Reviewed-by: Marc-André Lureau
---
server/tests/replay.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/server/tests/replay.c b/server/tests/replay.c
index b88c0
MingW does not include this header while including stdint.h so
on Windows you need to include it.
Signed-off-by: Frediano Ziglio
Reviewed-by: Marc-André Lureau
---
server/reds.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/server/reds.h b/server/reds.h
index 8481d7c6..f192b563 100644
---
Set correctly errno to make callers handle correctly encrypted
traffic.
Signed-off-by: Frediano Ziglio
---
server/red-stream.c | 29 +
1 file changed, 25 insertions(+), 4 deletions(-)
diff --git a/server/red-stream.c b/server/red-stream.c
index a6da8385..687d6ca2 100
usleep under Windows does not seem to have the required precision.
Use milliseconds and adjust check times according.
Signed-off-by: Frediano Ziglio
---
server/tests/stat-test.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/server/tests/stat-test.c b/server/tes
test-stream test is passing file descriptor using Unix socket.
test-stat-file needs some porting work of mmap feature.
Signed-off-by: Frediano Ziglio
Reviewed-by: Marc-André Lureau
---
server/tests/Makefile.am | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/server/t
- global signals;
- CLOEXEC flag;
- mmap and statistics;
- IPTOS_LOWDELAY flag;
- Unix sockets;
- sharing file descriptors through Unix sockets;
- TCP_CORK flag.
Signed-off-by: Frediano Ziglio
Reviewed-by: Marc-André Lureau
---
server/red-channel-client.c | 2 ++
server/red-stream.c
Use g_io_channel_win32_new_socket instead of g_io_channel_unix_new
Signed-off-by: Frediano Ziglio
Reviewed-by: Marc-André Lureau
---
server/event-loop.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/server/event-loop.c b/server/event-loop.c
index 56200ce5..72af9ab9 100644
--- a/serve
Windows does not support Unix sockets.
Signed-off-by: Frediano Ziglio
Reviewed-by: Marc-André Lureau
---
server/tests/test-listen.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/server/tests/test-listen.c b/server/tests/test-listen.c
index 640e8f12..2fd4b5a3 100644
--- a/serve
Signed-off-by: Frediano Ziglio
---
server/tests/test-stream.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/server/tests/test-stream.c b/server/tests/test-stream.c
index d56109d1..54fbf259 100644
--- a/server/tests/test-stream.c
+++ b/server/tests/test-stream.c
@@ -113,9
Signed-off-by: Frediano Ziglio
Reviewed-by: Marc-André Lureau
---
server/tests/Makefile.am | 2 +
server/tests/test-channel.c | 1 +
server/tests/test-loop.c | 1 +
server/tests/test-stream-device.c | 1 +
server/tests/win-alarm.c | 65 +++
Replace poll call with select.
As socket is set to non-blocking we must support it so if
we detect an EAGAIN error wait for data.
Signed-off-by: Frediano Ziglio
---
server/dispatcher.c | 20
1 file changed, 20 insertions(+)
diff --git a/server/dispatcher.c b/server/dispatch
Signed-off-by: Frediano Ziglio
---
server/tests/test-channel.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/server/tests/test-channel.c b/server/tests/test-channel.c
index 1c9148df..fef295a3 100644
--- a/server/tests/test-channel.c
+++ b/server/test
"interface" and "MAX_MONITORS" are defined in some Windows system
headers causing garbage code to be fed to the compiler.
Signed-off-by: Frediano Ziglio
---
server/red-qxl.c | 4
server/reds.c| 6 ++
2 files changed, 10 insertions(+)
diff --git a/server/red-qxl.c b/server/red-qxl.c
These constants are meant to be used in format string for pointers
types. Use them for portability.
Signed-off-by: Frediano Ziglio
---
server/red-replay-qxl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/red-replay-qxl.c b/server/red-replay-qxl.c
index 9b63d237..488
Between Unix and Windows socket are quite different:
- on Windows sockets have a different namespace from C file
descriptors so you can't use read/write/close or similar functions;
- errors are not stored in errno but you must be read/write the
errors with specific function;
- sometimes sockets
Not supported, %m is a GNU extension of sscanf.
Signed-off-by: Frediano Ziglio
---
server/reds.c | 25 -
1 file changed, 12 insertions(+), 13 deletions(-)
diff --git a/server/reds.c b/server/reds.c
index 84e4bb8c..ec7fbc38 100644
--- a/server/reds.c
+++ b/server/reds.c
@
Allows to easier port socketpair.
Windows does not have this function, we need to create a pair
using 2 internet sockets and connecting one to the other.
Signed-off-by: Frediano Ziglio
---
server/sys-socket.c | 75 +
server/sys-socket.h | 7 +
2 f
Signed-off-by: Frediano Ziglio
---
server/tests/basic-event-loop.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/server/tests/basic-event-loop.c b/server/tests/basic-event-loop.c
index 607a5a5e..76b0580e 100644
--- a/server/tests/basic-event-loop.c
+++ b/server/tests/basic
Signed-off-by: Frediano Ziglio
---
server/net-utils.c | 33 +
server/net-utils.h | 10 ++
2 files changed, 27 insertions(+), 16 deletions(-)
diff --git a/server/net-utils.c b/server/net-utils.c
index 802509a4..8a5b62cb 100644
--- a/server/net-utils.c
+++ b
Windows needs some specific setting to use network.
Signed-off-by: Frediano Ziglio
---
configure.ac | 20 +++-
1 file changed, 19 insertions(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 96e4e66c..43224f8b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -68,6
Signed-off-by: Frediano Ziglio
---
server/tests/test-leaks.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/server/tests/test-leaks.c b/server/tests/test-leaks.c
index 64130c22..98f9cb67 100644
--- a/server/tests/test-leaks.c
+++ b/server/tests/test-leaks.c
@@ -35
Signed-off-by: Frediano Ziglio
---
server/red-common.h | 4 +-
server/reds-private.h | 4 +-
server/reds.c | 94 +++
server/reds.h | 2 +-
4 files changed, 56 insertions(+), 48 deletions(-)
diff --git a/server/red-common.h b/server/red
Signed-off-by: Frediano Ziglio
---
server/event-loop.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/server/event-loop.c b/server/event-loop.c
index 413102e8..56200ce5 100644
--- a/server/event-loop.c
+++ b/server/event-loop.c
@@ -153,16 +153,16 @@ static void watch_up
Signed-off-by: Frediano Ziglio
---
server/dispatcher.c | 26 +-
server/dispatcher.h | 2 +-
2 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/server/dispatcher.c b/server/dispatcher.c
index 3e27f2c2..4cd91f11 100644
--- a/server/dispatcher.c
+++ b/server/di
Signed-off-by: Frediano Ziglio
---
server/sound.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/server/sound.c b/server/sound.c
index 44b27dec..00b473a8 100644
--- a/server/sound.c
+++ b/server/sound.c
@@ -775,14 +775,13 @@ static void record_channel_send_item(RedChan
Signed-off-by: Frediano Ziglio
---
server/red-stream.c | 32 +---
server/red-stream.h | 4 ++--
2 files changed, 19 insertions(+), 17 deletions(-)
diff --git a/server/red-stream.c b/server/red-stream.c
index 57034a64..33086d99 100644
--- a/server/red-stream.c
+++ b/s
Signed-off-by: Frediano Ziglio
---
server/red-channel-client.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/server/red-channel-client.c b/server/red-channel-client.c
index 375a60b3..07f1988d 100644
--- a/server/red-channel-client.c
+++ b/server/red-channel-client.c
@@ -
This is a preparatory patch for next portability patches
Signed-off-by: Frediano Ziglio
Reviewed-by: Marc-André Lureau
---
server/dispatcher.c | 2 ++
server/net-utils.c | 2 ++
server/red-channel-client.c | 6 --
server/red-qxl.c | 1 -
s
Formatting string should be compatible with GLib.
GLib uses formatting types compatible with GNU.
For Linux this is not an issue as both systems (like a printf) and
GLib one uses the same formatting type. However on Windows they
differs potentially causing issues.
This is also make worse as GLib 2
Windows support is useful to use with Qemu under Windows as host or
to implement servers like Xspice.
Mainly SPICE server uses lot of libraries to expose a TCP protocol.
As TCP is implemented with socket library which is quite portable was
not that hard to port.
Beside some minor feature (see REAME
Acked-by: Christophe Fergeau
On Fri, Jan 04, 2019 at 10:56:24AM +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> src/vdagent/vdagent.c | 16
> src/vdagentd/vdagentd.c | 16
> 2 files changed, 24 insertions(+), 8 deletions(-)
>
> Change
>
> On Wed, Jan 02, 2019 at 02:56:43PM +, Frediano Ziglio wrote:
> > Formatting string should be compatible with GLib.
> > GLib uses formatting types compatible with GNU.
> > For Linux this is not an issue as both systems (like a printf) and
> > GLib one uses the same formatting type. However
On Fri, Jan 04, 2019 at 10:56:23AM +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> src/udscs.c| 2 ++
> src/vdagent/x11.c | 2 ++
> src/vdagentd/virtio-port.c | 1 +
> 3 files changed, 5 insertions(+)
>
> diff --git a/src/udscs.c b/src/udscs.c
> in
On Mon, Jan 07, 2019 at 12:01:02PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> The pulse backend is getting deprecated.
Not sure this is something we should do right before a release rather
than right after the release so that the gstreamer backend on linux gets
a bit
On Mon, Jan 07, 2019 at 12:00:57PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Removed unused vapigen/vapidir variables as well.
>
> Signed-off-by: Marc-André Lureau
> ---
> meson.build | 9 +
> meson_options.txt | 3 +--
> 2 files changed, 6 insertion
Reviewed-by: Christophe Fergeau
On Mon, Jan 07, 2019 at 12:00:58PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
> ---
> src/spice-gstaudio.c | 6 --
> 1 file changed, 6 deletions(-)
>
> diff --git a/src/spice-gstaudio.c b/src/s
On Mon, Jan 07, 2019 at 12:00:55PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> It makes it non-obvious what that variable actually is.
Reviewed-by: Christophe Fergeau
>
> Signed-off-by: Marc-André Lureau
> ---
> meson.build | 9 -
> src/meson.build |
On Mon, Jan 07, 2019 at 12:00:54PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> This is based on similar meson code in GStreamer.
> (one of the core meson developer, Nirbheek, is also doing the GStreamer
> meson build support)
>
> This allows me to install a meson-ming
Reviewed-by: Christophe Fergeau
On Mon, Jan 07, 2019 at 12:00:53PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> ../src/./spice-audio.h:22:2: warning: #warning "Only can be
> included directly" [-Wcpp]
> #warning "Only can be included directly"
> ^~~
> ...
>
On Mon, Jan 07, 2019 at 12:00:52PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> The desktop-integration code works by attempting to connect to GNOME
> Session Manager. If it is absent, it will print a "Warning no
> automount-inhibiting implementation available" message.
Reviewed-by: Christophe Fergeau
On Mon, Jan 07, 2019 at 12:00:51PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
> ---
> .gitlab-ci.yml| 1 -
> meson.build | 5 +++--
> meson_options.txt | 3 +--
> 3 files changed, 4 insert
Reviewed-by: Christophe Fergeau
On Mon, Jan 07, 2019 at 12:00:50PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
> ---
> .gitlab-ci.yml| 1 -
> meson.build | 5 +++--
> meson_options.txt | 3 +--
> 3 files changed, 4 insert
On Mon, Jan 07, 2019 at 12:00:49PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Contrary to spice server dependency, spice-gtk doesn't have a known
> minimum version requirement.
Ideally, we'd still check for some not very old liblz4 to avoid compile
time failures, but
Missed that one, but
Reviewed-by: Christophe Fergeau
On Mon, Jan 07, 2019 at 12:00:36PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> libusb 1.0.16 was released on 11 Jul 2013, that should be long enough.
>
> From the distro we care about, according to repology, Cent
>
> Reviewed-by: Christophe Fergeau
>
Is it an ack or a nack?
> On Mon, Jan 07, 2019 at 12:00:43PM +0400, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > Signed-off-by: Marc-André Lureau
> > ---
> > meson.build | 6 --
> > meson_options.txt | 3 +--
> > 2 f
Acked-by: Christophe Fergeau
On Mon, Jan 07, 2019 at 12:00:48PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
> ---
> meson.build | 5 +++--
> meson_options.txt | 3 +--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> d
On Mon, Jan 07, 2019 at 12:00:47PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
> ---
> meson.build | 32 +++-
> meson_options.txt | 3 +--
> 2 files changed, 16 insertions(+), 19 deletions(-)
>
> di
On Mon, Jan 07, 2019 at 12:00:46PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
> ---
> .gitlab-ci.yml| 1 -
> meson.build | 15 +--
> meson_options.txt | 3 +--
> 3 files changed, 6 insertions(+), 13 deletions(
On Mon, Jan 07, 2019 at 12:00:45PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
> ---
> .gitlab-ci.yml| 1 -
> meson.build | 8 +++-
> meson_options.txt | 3 +--
> 3 files changed, 4 insertions(+), 8 deletions(-)
>
> dif
Reviewed-by: Christophe Fergeau
On Mon, Jan 07, 2019 at 12:00:43PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
> ---
> meson.build | 6 --
> meson_options.txt | 3 +--
> 2 files changed, 5 insertions(+), 4 deletions(-)
>
Reviewed-by: Christophe Fergeau
On Mon, Jan 07, 2019 at 12:00:44PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
> ---
> .gitlab-ci.yml| 1 -
> meson.build | 14 +-
> meson_options.txt | 3 +--
> 3 files chang
On Mon, Jan 07, 2019 at 12:00:42PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Let's turn explicit true/false option into features which can be
> autodetected and turned all enabled/disabled at once.
Is this saying that after the following commits which will turn most
Hi
On Mon, Jan 7, 2019 at 5:37 PM Christophe Fergeau wrote:
>
> On Mon, Jan 07, 2019 at 12:00:39PM +0400, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > [1/14] Compiling C object
> > 'src/25a6634@@spice-client-glib-2.0@sha/win-usb-dev.c.obj'.
> > ../src/win-usb-dev.c: In
> Hi
>
> On Mon, Jan 7, 2019 at 3:44 PM Frediano Ziglio wrote:
> >
> > > Hi
> > >
> > > On Sat, Jan 5, 2019 at 9:00 PM Frediano Ziglio
> > > wrote:
> > > >
> > > > >
> > > > > Hi
> > > > >
> > > > > On Sat, Jan 5, 2019 at 1:59 PM Victor Toso
> > > > > wrote:
> > > > > >
> > > > > > Hi,
> > > >
Hi
On Mon, Jan 7, 2019 at 5:22 PM Christophe Fergeau wrote:
>
> On Mon, Jan 07, 2019 at 12:00:37PM +0400, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > v2.5.1 was released the 2015-11-24.
> >
> > According to repology, from the distro we care about, CentOS 6,
> > openSUS
On Mon, Jan 07, 2019 at 12:00:41PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Remove rt/x11/m dependencies from Windows build.
librt/libm dependencies are even removed from all builds as far as I can
tell? This does not seem to make a difference on the build though.
On Mon, Jan 07, 2019 at 12:00:39PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> [1/14] Compiling C object
> 'src/25a6634@@spice-client-glib-2.0@sha/win-usb-dev.c.obj'.
> ../src/win-usb-dev.c: In function 'get_usb_dev_info':
> ../src/win-usb-dev.c:376:5: warning: implic
On Mon, Jan 07, 2019 at 12:00:38PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Gtk+ shouldn't be used by spice-client-glib. GIO is enough.
>
> Signed-off-by: Marc-André Lureau
> ---
> src/win-usb-dev.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> dif
Hi,
On Thu, Jan 03, 2019 at 09:57:40AM +0100, Jakub Janku wrote: > Hi,
>
>
> On Wed, Jan 2, 2019, 5:31 PM Victor Toso
> > Hi,
> >
> > Thanks for taking a look!
> >
> > On Sun, Dec 30, 2018 at 10:23:02PM +0100, Jakub Janku wrote:
> > > Hi,
> > >
> > > On Wed, Dec 19, 2018 at 3:30 PM Victor Toso
On Mon, Jan 07, 2019 at 12:00:37PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> v2.5.1 was released the 2015-11-24.
>
> According to repology, from the distro we care about, CentOS 6,
> openSUSE Leap 42.3 have too old version (0.1.2).
>
> I didn't bother updating SPIC
On Mon, Jan 07, 2019 at 12:00:35PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> It was release the 2012-09-07, should be enough time.
>
> According to repology, all tracked distros have 0.5:
> https://repology.org/metapackage/usbredir/versions
>
> Signed-off-by: Marc-
Reviewed-by: Christophe Fergeau
though they depend on the patches making gstreamer a hard dep which are
still under discussion.
Christophe
On Mon, Jan 07, 2019 at 12:00:34PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Add required dependency on gstreamer to fix un
On Mon, Jan 07, 2019 at 12:00:30PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Deprecated for several releases now (v0.31).
Ok, though it does not hurt either as it's going to be dropped when
autotools is dropped.
Reviewed-by: Christophe Fergeau
>
> Signed-off-by:
Hi
On Mon, Jan 7, 2019 at 1:11 PM Snir Sheriber wrote:
>
> Hi,
>
>
> On 1/7/19 10:01 AM, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > There is a racy bug in pulsesrc that we can't easily workaround:
> > https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/merge_req
On Mon, Jan 7, 2019 at 1:06 PM Snir Sheriber wrote:
>
> Hi,
>
> On 1/7/19 10:00 AM, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > (lt-spicy:13097): GStreamer-CRITICAL **: 18:01:13.698:
> > Trying to dispose element pipeline1, but it is in READY instead of the NULL
> > st
Hi
On Mon, Jan 7, 2019 at 3:44 PM Frediano Ziglio wrote:
>
> > Hi
> >
> > On Sat, Jan 5, 2019 at 9:00 PM Frediano Ziglio wrote:
> > >
> > > >
> > > > Hi
> > > >
> > > > On Sat, Jan 5, 2019 at 1:59 PM Victor Toso
> > > > wrote:
> > > > >
> > > > > Hi,
> > > > >
> > > > > On Fri, Jan 04, 2019 at
From: Victor Toso
If SpiceGtkSession is holding the keyboard, that's huge indication
that the client should not be requesting guest's clipboard data yet.
This patch adds a check in clipboard_get() callback, to avoid such
requests. In Linux, this only happens with X11 backend.
This patch helps t
On Mon, Jan 07, 2019 at 03:12:45PM +0400, Marc-André Lureau wrote:
> g_warning or g_debug, not a big difference to me here.
>
> But g_debug() is likely to be missed, since it is silent by default.
Yes, and being silent for now is the goal since the vast majority of
systems will be hitting that fa
Can be used with Qemu on Windows or to implement software like Xspice on
Windows.
Requires a really small path for Qemu (just remove a "#include "
line).
Frediano
>
> Can you explain the end goal here?
>
> On Fri, 2018-12-21 at 12:02 +, Frediano Ziglio wrote:
> > Mainly SPICE server uses lo
> Hi
>
> On Sat, Jan 5, 2019 at 9:00 PM Frediano Ziglio wrote:
> >
> > >
> > > Hi
> > >
> > > On Sat, Jan 5, 2019 at 1:59 PM Victor Toso wrote:
> > > >
> > > > Hi,
> > > >
> > > > On Fri, Jan 04, 2019 at 04:48:21PM +0400, marcandre.lur...@redhat.com
> > > > wrote:
> > > > > From: Marc-André Lure
Dear developers,
While I was looking in the packets using Wireshark I saw that the Major and
Minor version is 2 and not 1 anymore. And there are some discrepancies in
the Spice protocol v1.0 and the actual value of fields. Has the protocol
been updated in any way? If yes, where can I find the chan
Hi
On Mon, Jan 7, 2019 at 2:50 PM Christophe Fergeau wrote:
>
> On Mon, Jan 07, 2019 at 02:12:34PM +0400, Marc-André Lureau wrote:
> > Hi
> >
> > On Mon, Jan 7, 2019 at 2:03 PM Christophe Fergeau
> > wrote:
> > >
> > > On Sun, Jan 06, 2019 at 12:24:33AM +0400, Marc-André Lureau wrote:
> > > > >
On Mon, Jan 07, 2019 at 02:12:34PM +0400, Marc-André Lureau wrote:
> Hi
>
> On Mon, Jan 7, 2019 at 2:03 PM Christophe Fergeau wrote:
> >
> > On Sun, Jan 06, 2019 at 12:24:33AM +0400, Marc-André Lureau wrote:
> > > >
> > > > > I'll work on a patch to remove pulse.
> > > > >
> > > >
> > > > It seem
Hi
On Mon, Jan 7, 2019 at 2:03 PM Christophe Fergeau wrote:
>
> On Sun, Jan 06, 2019 at 12:24:33AM +0400, Marc-André Lureau wrote:
> > >
> > > > I'll work on a patch to remove pulse.
> > > >
> > >
> > > It seems too soon.
> >
> > yes, we haven't done enough testing of the gstreamer backend on Lin
On Sun, Jan 06, 2019 at 12:24:33AM +0400, Marc-André Lureau wrote:
> >
> > > I'll work on a patch to remove pulse.
> > >
> >
> > It seems too soon.
>
> yes, we haven't done enough testing of the gstreamer backend on Linux.
> The recording path at least fails very often for me due to a race:
> http
1 - 100 of 138 matches
Mail list logo
