Hi,
On Wed, Dec 19, 2018 at 03:29:44PM +0100, Victor Toso wrote:
> From: Victor Toso
>
> If SpiceGtkSession is holding the keyboard, that's huge indication
> that we should not be requesting clipboard data yet. The proper time
> to request it is when another application in the client machine is
On Wed, Dec 19, 2018 at 09:55:52AM -0500, Frediano Ziglio wrote:
> Out of this patch but related. What will happen to systems during upgrade?
> Will the dependency (sockets.target wants spice-vdagentd.socket) removed?
> I suppose for RPM the script will do it, not sure about a possible
> "make inst
On Wed, Dec 19, 2018 at 09:52:57AM -0500, Frediano Ziglio wrote:
> The "Requisite" still prevents the socket to be activated with a
> "systemctl enable spice-vdagentd.socket" launched manually.
> You can obviously complaint that users should not do that but
> I don't think that if the system says "
Hi,
On Wed, Dec 19, 2018 at 09:47:14AM -0500, Frediano Ziglio wrote:
> >
> > From: Victor Toso
> >
> > In the current code, output should never be negative but the check
> > exists after we use the variable as index. Make the check earlier.
> >
> > This patch also breaks the check in two in or
Hi
On Wed, Dec 19, 2018 at 6:43 PM Frediano Ziglio wrote:
>
> >
> > From: Marc-André Lureau
> >
> > A recent discussion about Spice URI scheme on the QEMU mailing list
> > with Gerd prompted me to make an effort to standardize the Spice URIs
> > usage. So far, it is mostly used and desribed in s
>
> .socket systemd units already automatically get a
> Before=sockets.service, and the udev rule we have will ensure that when
> the appropriate virtio device is there, the socket unit will be started,
> so this WantedBy dependency is not needed, and is in part responsible
> for these warnings:
>
> On Wed, Dec 19, 2018 at 04:11:09AM -0500, Frediano Ziglio wrote:
> > >
> > > On Tue, Dec 18, 2018 at 12:15:09PM -0500, Frediano Ziglio wrote:
> > > > >
> > > > > The udev rule already adds SYSTEMD_WANTS=spice-vdagentd.socket
> > > > > to the relevant virtio devices, which automatically adds
> >
>
> From: Victor Toso
>
> In the current code, output should never be negative but the check
> exists after we use the variable as index. Make the check earlier.
>
> This patch also breaks the check in two in order to provide more
> accurate error log.
>
> Found by coverity:
> | check_after_
>
> From: Marc-André Lureau
>
> A recent discussion about Spice URI scheme on the QEMU mailing list
> with Gerd prompted me to make an effort to standardize the Spice URIs
> usage. So far, it is mostly used and desribed in spice-gtk (see URI in
> man/spice-client.pod). But it would be more appro
From: Marc-André Lureau
A recent discussion about Spice URI scheme on the QEMU mailing list
with Gerd prompted me to make an effort to standardize the Spice URIs
usage. So far, it is mostly used and desribed in spice-gtk (see URI in
man/spice-client.pod). But it would be more appropriate as part
.socket systemd units already automatically get a
Before=sockets.service, and the udev rule we have will ensure that when
the appropriate virtio device is there, the socket unit will be started,
so this WantedBy dependency is not needed, and is in part responsible
for these warnings:
[ INFO ] dev-
The udev rule already adds SYSTEMD_WANTS=spice-vdagentd.socket
to the relevant virtio devices, which automatically adds Wants=${device}
to spice-vdagentd.socket (see 'systemctl show spice-vdagentd.socket').
Adding a Requisite/After for these ports is at best redundant, and most
likely wrong as this
From: Victor Toso
If SpiceGtkSession is holding the keyboard, that's huge indication
that we should not be requesting clipboard data yet. The proper time
to request it is when another application in the client machine is
asking for it, which means the user would switch to another
application to p
From: Victor Toso
In the current code, output should never be negative but the check
exists after we use the variable as index. Make the check earlier.
This patch also breaks the check in two in order to provide more
accurate error log.
Found by coverity:
| check_after_sink: You might be usin
On Wed, Dec 19, 2018 at 04:11:09AM -0500, Frediano Ziglio wrote:
> >
> > On Tue, Dec 18, 2018 at 12:15:09PM -0500, Frediano Ziglio wrote:
> > > >
> > > > The udev rule already adds SYSTEMD_WANTS=spice-vdagentd.socket
> > > > to the relevant virtio devices, which automatically adds Wants=${device}
Hi,
On Wed, Dec 19, 2018 at 03:19:37PM +0100, Victor Toso wrote:
> From: Victor Toso
>
> In the current code, output should never be negative but the check
> exists after we use the variable as index. Make the check earlier.
>
> Found by coverity:
> | check_after_sink: You might be using vari
From: Victor Toso
In the current code, output should never be negative but the check
exists after we use the variable as index. Make the check earlier.
Found by coverity:
| check_after_sink: You might be using variable "output" before
| verifying that it is >= 0.
Changes in v2:
- Move overf
Signed-off-by: Frediano Ziglio
---
tools/spicy-screenshot.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/tools/spicy-screenshot.c b/tools/spicy-screenshot.c
index 0bfd3ca2..13b319d2 100644
--- a/tools/spicy-screenshot.c
+++ b/tools/spicy-screenshot.c
@@ -33,6 +33,8
On Windows this prevents LFs to be written as CR+LF.
Signed-off-by: Frediano Ziglio
---
tools/spicy-screenshot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/spicy-screenshot.c b/tools/spicy-screenshot.c
index 9d7aa34b..0bfd3ca2 100644
--- a/tools/spicy-screenshot.c
Not used outside this module.
Also update indentation.
Signed-off-by: Frediano Ziglio
---
tools/spicy-screenshot.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/spicy-screenshot.c b/tools/spicy-screenshot.c
index 13b319d2..97bd4da9 100644
--- a/tools/spicy-scree
Replace tabs with spaces
Signed-off-by: Frediano Ziglio
---
tools/spicy-screenshot.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/spicy-screenshot.c b/tools/spicy-screenshot.c
index 68f93350..9d7aa34b 100644
--- a/tools/spicy-screenshot.c
+++ b/tools/spicy-screen
Modify directly the new_wbuf->buf buffer instead of writing into
a temporary buffer and then copy in the final one.
This also fixes Coverity warning:
| uninit_use_in_call: Using uninitialized value "message_header". Field
| "message_header.data" is uninitialized when calling "memcpy".
Signed-of
OK , i'll try another Win7 vm ; about linux i used one desktop version of
UbuntuKylin https://www.ubuntukylin.com, maybe it related to OS , it used MATE
rather than GNONE
-- Original --
From: "Victor Toso";
Date: Wed, Dec 19, 2018 06:49 PM
To: "wangjiedong";
On Tue, Dec 18, 2018 at 12:22:31PM -0500, Frediano Ziglio wrote:
> > On Thu, Dec 13, 2018 at 02:20:24PM +, Frediano Ziglio wrote:
> > > A full copy can keep both the key and the value instead of
> > > allocating twice the memory.
> > > Also this remove a warning produced by Coverity that is ass
Hi,
On Wed, Dec 19, 2018 at 10:06:53AM +0800, wangjiedong wrote:
> Actually there are 2 questions.
> Firstly , on Windows 7 vm i can install
> spice-webdavd-x64-2.2.msi and no error , but the service
> spice-webdavd in TASK MANAGER allways stop although rebooting
> vm.
So, you are able to instal
Hi,
On Tue, Dec 18, 2018 at 12:06:01PM -0500, Frediano Ziglio wrote:
>
> >
> > From: Victor Toso
> >
> > Found by coverity:
> >
> > | uninit_use_in_call: Using uninitialized value "message_header". Field
> > | "message_header.data" is uninitialized when calling "memcpy".
> >
> > Signed-off
Hi,
On Tue, Dec 18, 2018 at 12:25:27PM -0500, Frediano Ziglio wrote:
> >
> > From: Victor Toso
> >
> > In the current code, output should never be negative but the check
> > exists after we use the variable as index. Make the check earlier.
> >
> > Found by coverity:
> > | check_after_sink:
Hi,
On Tue, Dec 18, 2018 at 12:33:20PM -0500, Frediano Ziglio wrote:
> >
> > From: Victor Toso
> >
> > And use well defined macros for standard file descriptors.
> >
> > Signed-off-by: Victor Toso
> > ---
> > src/vdagent/vdagent.c | 8 ++--
> > src/vdagentd/vdagentd.c | 8 ++--
> >
Hi,
On Tue, Dec 18, 2018 at 12:43:13PM -0500, Frediano Ziglio wrote:
> >
> > From: Victor Toso
> >
> > Found by coverity:
> > | warning: Access to field 'next' results in a dereference of a
> > | null pointer (loaded from variable 'prev_sel')
> >
> > Signed-off-by: Victor Toso
> > ---
> >
>
> On Tue, Dec 18, 2018 at 12:15:09PM -0500, Frediano Ziglio wrote:
> > >
> > > The udev rule already adds SYSTEMD_WANTS=spice-vdagentd.socket
> > > to the relevant virtio devices, which automatically adds Wants=${device}
> > > to spice-vdagentd.socket (see 'systemctl show spice-vdagentd.socket'
30 matches
Mail list logo
